<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[203784] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/203784">203784</a></dd>
<dt>Author</dt> <dd>cdumez@apple.com</dd>
<dt>Date</dt> <dd>2016-07-27 11:27:22 -0700 (Wed, 27 Jul 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>First parameter to Document.execCommand() / queryCommand*() should be mandatory
https://bugs.webkit.org/show_bug.cgi?id=160258
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
Rebaseline W3C test now that more checks are passing.
* web-platform-tests/html/dom/interfaces-expected.txt:
Source/WebCore:
First parameter to Document.execCommand() / queryCommand*() should be mandatory:
- https://w3c.github.io/editing/execCommand.html
Firefox and Chrome agree with the specification.
Test: fast/dom/Document/editing-parameters.html
* dom/Document.idl:
LayoutTests:
Add layout test coverage.
* fast/dom/Document/editing-parameters-expected.txt: Added.
* fast/dom/Document/editing-parameters.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsimportedw3cChangeLog">trunk/LayoutTests/imported/w3c/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestshtmldominterfacesexpectedtxt">trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoredomDocumentidl">trunk/Source/WebCore/dom/Document.idl</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsfastdomDocumenteditingparametersexpectedtxt">trunk/LayoutTests/fast/dom/Document/editing-parameters-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastdomDocumenteditingparametershtml">trunk/LayoutTests/fast/dom/Document/editing-parameters.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (203783 => 203784)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2016-07-27 18:04:58 UTC (rev 203783)
+++ trunk/LayoutTests/ChangeLog 2016-07-27 18:27:22 UTC (rev 203784)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2016-07-27 Chris Dumez <cdumez@apple.com>
+
+ First parameter to Document.execCommand() / queryCommand*() should be mandatory
+ https://bugs.webkit.org/show_bug.cgi?id=160258
+
+ Reviewed by Darin Adler.
+
+ Add layout test coverage.
+
+ * fast/dom/Document/editing-parameters-expected.txt: Added.
+ * fast/dom/Document/editing-parameters.html: Added.
+
</ins><span class="cx"> 2016-07-27 Ryan Haddad <ryanhaddad@apple.com>
</span><span class="cx">
</span><span class="cx"> Fix a typo in TestExpectations.
</span></span></pre></div>
<a id="trunkLayoutTestsfastdomDocumenteditingparametersexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/dom/Document/editing-parameters-expected.txt (0 => 203784)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/dom/Document/editing-parameters-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/dom/Document/editing-parameters-expected.txt 2016-07-27 18:27:22 UTC (rev 203784)
</span><span class="lines">@@ -0,0 +1,15 @@
</span><ins>+Test that the parameters of the editing API on Document are mandatory.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS document.execCommand() threw exception TypeError: Not enough arguments.
+PASS document.queryCommandEnabled() threw exception TypeError: Not enough arguments.
+PASS document.queryCommandIndeterm() threw exception TypeError: Not enough arguments.
+PASS document.queryCommandState() threw exception TypeError: Not enough arguments.
+PASS document.queryCommandSupported() threw exception TypeError: Not enough arguments.
+PASS document.queryCommandValue() threw exception TypeError: Not enough arguments.
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
</ins></span></pre></div>
<a id="trunkLayoutTestsfastdomDocumenteditingparametershtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/dom/Document/editing-parameters.html (0 => 203784)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/dom/Document/editing-parameters.html (rev 0)
+++ trunk/LayoutTests/fast/dom/Document/editing-parameters.html 2016-07-27 18:27:22 UTC (rev 203784)
</span><span class="lines">@@ -0,0 +1,17 @@
</span><ins>+<!DOCTYPE html>
+<html>
+<body>
+<script src="../../../resources/js-test-pre.js"></script>
+<script>
+description("Test that the parameters of the editing API on Document are mandatory.");
+
+shouldThrow("document.execCommand()", "'TypeError: Not enough arguments'");
+shouldThrow("document.queryCommandEnabled()", "'TypeError: Not enough arguments'");
+shouldThrow("document.queryCommandIndeterm()", "'TypeError: Not enough arguments'");
+shouldThrow("document.queryCommandState()", "'TypeError: Not enough arguments'");
+shouldThrow("document.queryCommandSupported()", "'TypeError: Not enough arguments'");
+shouldThrow("document.queryCommandValue()", "'TypeError: Not enough arguments'");
+</script>
+<script src="../../../resources/js-test-post.js"></script>
+</body>
+</html>
</ins></span></pre></div>
<a id="trunkLayoutTestsimportedw3cChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/ChangeLog (203783 => 203784)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/ChangeLog 2016-07-27 18:04:58 UTC (rev 203783)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2016-07-27 18:27:22 UTC (rev 203784)
</span><span class="lines">@@ -1,3 +1,14 @@
</span><ins>+2016-07-27 Chris Dumez <cdumez@apple.com>
+
+ First parameter to Document.execCommand() / queryCommand*() should be mandatory
+ https://bugs.webkit.org/show_bug.cgi?id=160258
+
+ Reviewed by Darin Adler.
+
+ Rebaseline W3C test now that more checks are passing.
+
+ * web-platform-tests/html/dom/interfaces-expected.txt:
+
</ins><span class="cx"> 2016-07-26 Youenn Fablet <youenn@apple.com>
</span><span class="cx">
</span><span class="cx"> [Fetch API] Response constructor should be able to take a ReadableStream as body
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestshtmldominterfacesexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt (203783 => 203784)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt 2016-07-27 18:04:58 UTC (rev 203783)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt 2016-07-27 18:27:22 UTC (rev 203784)
</span><span class="lines">@@ -40,12 +40,12 @@
</span><span class="cx"> PASS Document interface: attribute activeElement
</span><span class="cx"> PASS Document interface: operation hasFocus()
</span><span class="cx"> FAIL Document interface: attribute designMode assert_true: The prototype object must have a property "designMode" expected true got false
</span><del>-FAIL Document interface: operation execCommand(DOMString,boolean,DOMString) assert_equals: property has wrong .length expected 1 but got 0
-FAIL Document interface: operation queryCommandEnabled(DOMString) assert_equals: property has wrong .length expected 1 but got 0
-FAIL Document interface: operation queryCommandIndeterm(DOMString) assert_equals: property has wrong .length expected 1 but got 0
-FAIL Document interface: operation queryCommandState(DOMString) assert_equals: property has wrong .length expected 1 but got 0
-FAIL Document interface: operation queryCommandSupported(DOMString) assert_equals: property has wrong .length expected 1 but got 0
-FAIL Document interface: operation queryCommandValue(DOMString) assert_equals: property has wrong .length expected 1 but got 0
</del><ins>+PASS Document interface: operation execCommand(DOMString,boolean,DOMString)
+PASS Document interface: operation queryCommandEnabled(DOMString)
+PASS Document interface: operation queryCommandIndeterm(DOMString)
+PASS Document interface: operation queryCommandState(DOMString)
+PASS Document interface: operation queryCommandSupported(DOMString)
+PASS Document interface: operation queryCommandValue(DOMString)
</ins><span class="cx"> FAIL Document interface: attribute commands assert_true: The prototype object must have a property "commands" expected true got false
</span><span class="cx"> PASS Document interface: attribute onreadystatechange
</span><span class="cx"> FAIL Document interface: attribute fgColor assert_true: The prototype object must have a property "fgColor" expected true got false
</span><span class="lines">@@ -207,29 +207,17 @@
</span><span class="cx"> PASS Document interface: iframe.contentDocument must inherit property "hasFocus" with the proper type (61)
</span><span class="cx"> PASS Document interface: iframe.contentDocument must inherit property "designMode" with the proper type (62)
</span><span class="cx"> PASS Document interface: iframe.contentDocument must inherit property "execCommand" with the proper type (63)
</span><del>-FAIL Document interface: calling execCommand(DOMString,boolean,DOMString) on iframe.contentDocument with too few arguments must throw TypeError assert_throws: Called with 0 arguments function "function () {
- fn.apply(obj, args);
- }" did not throw
</del><ins>+PASS Document interface: calling execCommand(DOMString,boolean,DOMString) on iframe.contentDocument with too few arguments must throw TypeError
</ins><span class="cx"> PASS Document interface: iframe.contentDocument must inherit property "queryCommandEnabled" with the proper type (64)
</span><del>-FAIL Document interface: calling queryCommandEnabled(DOMString) on iframe.contentDocument with too few arguments must throw TypeError assert_throws: Called with 0 arguments function "function () {
- fn.apply(obj, args);
- }" did not throw
</del><ins>+PASS Document interface: calling queryCommandEnabled(DOMString) on iframe.contentDocument with too few arguments must throw TypeError
</ins><span class="cx"> PASS Document interface: iframe.contentDocument must inherit property "queryCommandIndeterm" with the proper type (65)
</span><del>-FAIL Document interface: calling queryCommandIndeterm(DOMString) on iframe.contentDocument with too few arguments must throw TypeError assert_throws: Called with 0 arguments function "function () {
- fn.apply(obj, args);
- }" did not throw
</del><ins>+PASS Document interface: calling queryCommandIndeterm(DOMString) on iframe.contentDocument with too few arguments must throw TypeError
</ins><span class="cx"> PASS Document interface: iframe.contentDocument must inherit property "queryCommandState" with the proper type (66)
</span><del>-FAIL Document interface: calling queryCommandState(DOMString) on iframe.contentDocument with too few arguments must throw TypeError assert_throws: Called with 0 arguments function "function () {
- fn.apply(obj, args);
- }" did not throw
</del><ins>+PASS Document interface: calling queryCommandState(DOMString) on iframe.contentDocument with too few arguments must throw TypeError
</ins><span class="cx"> PASS Document interface: iframe.contentDocument must inherit property "queryCommandSupported" with the proper type (67)
</span><del>-FAIL Document interface: calling queryCommandSupported(DOMString) on iframe.contentDocument with too few arguments must throw TypeError assert_throws: Called with 0 arguments function "function () {
- fn.apply(obj, args);
- }" did not throw
</del><ins>+PASS Document interface: calling queryCommandSupported(DOMString) on iframe.contentDocument with too few arguments must throw TypeError
</ins><span class="cx"> PASS Document interface: iframe.contentDocument must inherit property "queryCommandValue" with the proper type (68)
</span><del>-FAIL Document interface: calling queryCommandValue(DOMString) on iframe.contentDocument with too few arguments must throw TypeError assert_throws: Called with 0 arguments function "function () {
- fn.apply(obj, args);
- }" did not throw
</del><ins>+PASS Document interface: calling queryCommandValue(DOMString) on iframe.contentDocument with too few arguments must throw TypeError
</ins><span class="cx"> FAIL Document interface: iframe.contentDocument must inherit property "commands" with the proper type (69) assert_inherits: property "commands" not found in prototype chain
</span><span class="cx"> PASS Document interface: iframe.contentDocument must inherit property "onreadystatechange" with the proper type (70)
</span><span class="cx"> PASS Document interface: iframe.contentDocument must inherit property "fgColor" with the proper type (71)
</span><span class="lines">@@ -471,29 +459,17 @@
</span><span class="cx"> PASS Document interface: new Document() must inherit property "hasFocus" with the proper type (61)
</span><span class="cx"> FAIL Document interface: new Document() must inherit property "designMode" with the proper type (62) assert_inherits: property "designMode" not found in prototype chain
</span><span class="cx"> PASS Document interface: new Document() must inherit property "execCommand" with the proper type (63)
</span><del>-FAIL Document interface: calling execCommand(DOMString,boolean,DOMString) on new Document() with too few arguments must throw TypeError assert_throws: Called with 0 arguments function "function () {
- fn.apply(obj, args);
- }" did not throw
</del><ins>+PASS Document interface: calling execCommand(DOMString,boolean,DOMString) on new Document() with too few arguments must throw TypeError
</ins><span class="cx"> PASS Document interface: new Document() must inherit property "queryCommandEnabled" with the proper type (64)
</span><del>-FAIL Document interface: calling queryCommandEnabled(DOMString) on new Document() with too few arguments must throw TypeError assert_throws: Called with 0 arguments function "function () {
- fn.apply(obj, args);
- }" did not throw
</del><ins>+PASS Document interface: calling queryCommandEnabled(DOMString) on new Document() with too few arguments must throw TypeError
</ins><span class="cx"> PASS Document interface: new Document() must inherit property "queryCommandIndeterm" with the proper type (65)
</span><del>-FAIL Document interface: calling queryCommandIndeterm(DOMString) on new Document() with too few arguments must throw TypeError assert_throws: Called with 0 arguments function "function () {
- fn.apply(obj, args);
- }" did not throw
</del><ins>+PASS Document interface: calling queryCommandIndeterm(DOMString) on new Document() with too few arguments must throw TypeError
</ins><span class="cx"> PASS Document interface: new Document() must inherit property "queryCommandState" with the proper type (66)
</span><del>-FAIL Document interface: calling queryCommandState(DOMString) on new Document() with too few arguments must throw TypeError assert_throws: Called with 0 arguments function "function () {
- fn.apply(obj, args);
- }" did not throw
</del><ins>+PASS Document interface: calling queryCommandState(DOMString) on new Document() with too few arguments must throw TypeError
</ins><span class="cx"> PASS Document interface: new Document() must inherit property "queryCommandSupported" with the proper type (67)
</span><del>-FAIL Document interface: calling queryCommandSupported(DOMString) on new Document() with too few arguments must throw TypeError assert_throws: Called with 0 arguments function "function () {
- fn.apply(obj, args);
- }" did not throw
</del><ins>+PASS Document interface: calling queryCommandSupported(DOMString) on new Document() with too few arguments must throw TypeError
</ins><span class="cx"> PASS Document interface: new Document() must inherit property "queryCommandValue" with the proper type (68)
</span><del>-FAIL Document interface: calling queryCommandValue(DOMString) on new Document() with too few arguments must throw TypeError assert_throws: Called with 0 arguments function "function () {
- fn.apply(obj, args);
- }" did not throw
</del><ins>+PASS Document interface: calling queryCommandValue(DOMString) on new Document() with too few arguments must throw TypeError
</ins><span class="cx"> FAIL Document interface: new Document() must inherit property "commands" with the proper type (69) assert_inherits: property "commands" not found in prototype chain
</span><span class="cx"> PASS Document interface: new Document() must inherit property "onreadystatechange" with the proper type (70)
</span><span class="cx"> FAIL Document interface: new Document() must inherit property "fgColor" with the proper type (71) assert_inherits: property "fgColor" not found in prototype chain
</span><span class="lines">@@ -738,29 +714,17 @@
</span><span class="cx"> PASS Document interface: document.implementation.createDocument(null, "", null) must inherit property "hasFocus" with the proper type (61)
</span><span class="cx"> FAIL Document interface: document.implementation.createDocument(null, "", null) must inherit property "designMode" with the proper type (62) assert_inherits: property "designMode" not found in prototype chain
</span><span class="cx"> PASS Document interface: document.implementation.createDocument(null, "", null) must inherit property "execCommand" with the proper type (63)
</span><del>-FAIL Document interface: calling execCommand(DOMString,boolean,DOMString) on document.implementation.createDocument(null, "", null) with too few arguments must throw TypeError assert_throws: Called with 0 arguments function "function () {
- fn.apply(obj, args);
- }" did not throw
</del><ins>+PASS Document interface: calling execCommand(DOMString,boolean,DOMString) on document.implementation.createDocument(null, "", null) with too few arguments must throw TypeError
</ins><span class="cx"> PASS Document interface: document.implementation.createDocument(null, "", null) must inherit property "queryCommandEnabled" with the proper type (64)
</span><del>-FAIL Document interface: calling queryCommandEnabled(DOMString) on document.implementation.createDocument(null, "", null) with too few arguments must throw TypeError assert_throws: Called with 0 arguments function "function () {
- fn.apply(obj, args);
- }" did not throw
</del><ins>+PASS Document interface: calling queryCommandEnabled(DOMString) on document.implementation.createDocument(null, "", null) with too few arguments must throw TypeError
</ins><span class="cx"> PASS Document interface: document.implementation.createDocument(null, "", null) must inherit property "queryCommandIndeterm" with the proper type (65)
</span><del>-FAIL Document interface: calling queryCommandIndeterm(DOMString) on document.implementation.createDocument(null, "", null) with too few arguments must throw TypeError assert_throws: Called with 0 arguments function "function () {
- fn.apply(obj, args);
- }" did not throw
</del><ins>+PASS Document interface: calling queryCommandIndeterm(DOMString) on document.implementation.createDocument(null, "", null) with too few arguments must throw TypeError
</ins><span class="cx"> PASS Document interface: document.implementation.createDocument(null, "", null) must inherit property "queryCommandState" with the proper type (66)
</span><del>-FAIL Document interface: calling queryCommandState(DOMString) on document.implementation.createDocument(null, "", null) with too few arguments must throw TypeError assert_throws: Called with 0 arguments function "function () {
- fn.apply(obj, args);
- }" did not throw
</del><ins>+PASS Document interface: calling queryCommandState(DOMString) on document.implementation.createDocument(null, "", null) with too few arguments must throw TypeError
</ins><span class="cx"> PASS Document interface: document.implementation.createDocument(null, "", null) must inherit property "queryCommandSupported" with the proper type (67)
</span><del>-FAIL Document interface: calling queryCommandSupported(DOMString) on document.implementation.createDocument(null, "", null) with too few arguments must throw TypeError assert_throws: Called with 0 arguments function "function () {
- fn.apply(obj, args);
- }" did not throw
</del><ins>+PASS Document interface: calling queryCommandSupported(DOMString) on document.implementation.createDocument(null, "", null) with too few arguments must throw TypeError
</ins><span class="cx"> PASS Document interface: document.implementation.createDocument(null, "", null) must inherit property "queryCommandValue" with the proper type (68)
</span><del>-FAIL Document interface: calling queryCommandValue(DOMString) on document.implementation.createDocument(null, "", null) with too few arguments must throw TypeError assert_throws: Called with 0 arguments function "function () {
- fn.apply(obj, args);
- }" did not throw
</del><ins>+PASS Document interface: calling queryCommandValue(DOMString) on document.implementation.createDocument(null, "", null) with too few arguments must throw TypeError
</ins><span class="cx"> FAIL Document interface: document.implementation.createDocument(null, "", null) must inherit property "commands" with the proper type (69) assert_inherits: property "commands" not found in prototype chain
</span><span class="cx"> PASS Document interface: document.implementation.createDocument(null, "", null) must inherit property "onreadystatechange" with the proper type (70)
</span><span class="cx"> FAIL Document interface: document.implementation.createDocument(null, "", null) must inherit property "fgColor" with the proper type (71) assert_inherits: property "fgColor" not found in prototype chain
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (203783 => 203784)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-07-27 18:04:58 UTC (rev 203783)
+++ trunk/Source/WebCore/ChangeLog 2016-07-27 18:27:22 UTC (rev 203784)
</span><span class="lines">@@ -1,5 +1,21 @@
</span><span class="cx"> 2016-07-27 Chris Dumez <cdumez@apple.com>
</span><span class="cx">
</span><ins>+ First parameter to Document.execCommand() / queryCommand*() should be mandatory
+ https://bugs.webkit.org/show_bug.cgi?id=160258
+
+ Reviewed by Darin Adler.
+
+ First parameter to Document.execCommand() / queryCommand*() should be mandatory:
+ - https://w3c.github.io/editing/execCommand.html
+
+ Firefox and Chrome agree with the specification.
+
+ Test: fast/dom/Document/editing-parameters.html
+
+ * dom/Document.idl:
+
+2016-07-27 Chris Dumez <cdumez@apple.com>
+
</ins><span class="cx"> Align CSSSupportsRule with the specification
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=160256
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoredomDocumentidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Document.idl (203783 => 203784)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Document.idl 2016-07-27 18:04:58 UTC (rev 203783)
+++ trunk/Source/WebCore/dom/Document.idl 2016-07-27 18:27:22 UTC (rev 203784)
</span><span class="lines">@@ -140,24 +140,20 @@
</span><span class="cx"> optional XPathResult? inResult);
</span><span class="cx">
</span><span class="cx"> // Common extensions
</span><del>- // FIXME: Using "undefined" as default parameter value is wrong.
- boolean execCommand(optional DOMString command = "undefined",
- optional boolean userInterface = false,
- optional DOMString? value = null);
</del><ins>+ // FIXME: The default value for the last parameter should be the empty string.
+ boolean execCommand(DOMString command, optional boolean userInterface = false, optional DOMString? value = null);
</ins><span class="cx">
</span><span class="cx"> #if defined(LANGUAGE_OBJECTIVE_C) && LANGUAGE_OBJECTIVE_C
</span><span class="cx"> // FIXME: remove the these two versions once optional is implemented for Objective-C.
</span><del>- boolean execCommand(DOMString command,
- boolean userInterface);
- boolean execCommand(DOMString command);
</del><ins>+ boolean execCommand(DOMString command, boolean userInterface);
+ boolean execCommand(DOMString command);
</ins><span class="cx"> #endif
</span><span class="cx">
</span><del>- // FIXME: Using "undefined" as default parameter value is wrong.
- boolean queryCommandEnabled(optional DOMString command = "undefined");
- boolean queryCommandIndeterm(optional DOMString command = "undefined");
- boolean queryCommandState(optional DOMString command = "undefined");
- boolean queryCommandSupported(optional DOMString command = "undefined");
- DOMString queryCommandValue(optional DOMString command = "undefined");
</del><ins>+ boolean queryCommandEnabled(DOMString command);
+ boolean queryCommandIndeterm(DOMString command);
+ boolean queryCommandState(DOMString command);
+ boolean queryCommandSupported(DOMString command);
+ DOMString queryCommandValue(DOMString command);
</ins><span class="cx">
</span><span class="cx"> // Moved down from HTMLDocument
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>