<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[203795] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/203795">203795</a></dd>
<dt>Author</dt> <dd>cdumez@apple.com</dd>
<dt>Date</dt> <dd>2016-07-27 14:33:57 -0700 (Wed, 27 Jul 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Align MediaList with the CSSOM specification
https://bugs.webkit.org/show_bug.cgi?id=160257
Reviewed by Ryosuke Niwa.
Source/WebCore:
Align MediaList with the CSSOM specification:
- https://www.w3.org/TR/cssom-1/#the-medialist-interface
In particular, the parameter to item() / deleteMedium() and
appendMedium() is now mandatory.
Firefox and Chrome agree with the specification.
Test: fast/css/MediaList-mediaText-null.html
fast/css/MediaList-parameters.html
* css/MediaList.idl:
LayoutTests:
* fast/css/MediaList-mediaText-null-expected.txt: Added.
* fast/css/MediaList-mediaText-null.html: Added.
Add test coverage for MediaList.mediaText to make sure it is not nullable
and treats null as the empty string. Our IDL did not match the
specification here but our behavior was correct. Therefore, this test is
passing with and without my change. I just wanted to make sure we had
good coverage since I updated our IDL to match the specification.
* fast/css/MediaList-parameters-expected.txt: Added.
* fast/css/MediaList-parameters.html: Added.
Add test coverage for mandatory parameters.
* fast/dom/non-numeric-values-numeric-parameters-expected.txt:
* fast/dom/script-tests/non-numeric-values-numeric-parameters.js:
Update existing test to reflect behavior change.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsfastdomnonnumericvaluesnumericparametersexpectedtxt">trunk/LayoutTests/fast/dom/non-numeric-values-numeric-parameters-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastdomscripttestsnonnumericvaluesnumericparametersjs">trunk/LayoutTests/fast/dom/script-tests/non-numeric-values-numeric-parameters.js</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorecssMediaListidl">trunk/Source/WebCore/css/MediaList.idl</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsfastcssMediaListmediaTextnullexpectedtxt">trunk/LayoutTests/fast/css/MediaList-mediaText-null-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastcssMediaListmediaTextnullhtml">trunk/LayoutTests/fast/css/MediaList-mediaText-null.html</a></li>
<li><a href="#trunkLayoutTestsfastcssMediaListparametersexpectedtxt">trunk/LayoutTests/fast/css/MediaList-parameters-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastcssMediaListparametershtml">trunk/LayoutTests/fast/css/MediaList-parameters.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (203794 => 203795)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2016-07-27 21:18:50 UTC (rev 203794)
+++ trunk/LayoutTests/ChangeLog 2016-07-27 21:33:57 UTC (rev 203795)
</span><span class="lines">@@ -1,3 +1,26 @@
</span><ins>+2016-07-27 Chris Dumez <cdumez@apple.com>
+
+ Align MediaList with the CSSOM specification
+ https://bugs.webkit.org/show_bug.cgi?id=160257
+
+ Reviewed by Ryosuke Niwa.
+
+ * fast/css/MediaList-mediaText-null-expected.txt: Added.
+ * fast/css/MediaList-mediaText-null.html: Added.
+ Add test coverage for MediaList.mediaText to make sure it is not nullable
+ and treats null as the empty string. Our IDL did not match the
+ specification here but our behavior was correct. Therefore, this test is
+ passing with and without my change. I just wanted to make sure we had
+ good coverage since I updated our IDL to match the specification.
+
+ * fast/css/MediaList-parameters-expected.txt: Added.
+ * fast/css/MediaList-parameters.html: Added.
+ Add test coverage for mandatory parameters.
+
+ * fast/dom/non-numeric-values-numeric-parameters-expected.txt:
+ * fast/dom/script-tests/non-numeric-values-numeric-parameters.js:
+ Update existing test to reflect behavior change.
+
</ins><span class="cx"> 2016-07-27 Ryan Haddad <ryanhaddad@apple.com>
</span><span class="cx">
</span><span class="cx"> Correct the syntax used to skip js/regress/script-tests/bigswitch-indirect-symbol.js
</span></span></pre></div>
<a id="trunkLayoutTestsfastcssMediaListmediaTextnullexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/css/MediaList-mediaText-null-expected.txt (0 => 203795)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/css/MediaList-mediaText-null-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/css/MediaList-mediaText-null-expected.txt 2016-07-27 21:33:57 UTC (rev 203795)
</span><span class="lines">@@ -0,0 +1,18 @@
</span><ins>+Tests that MediaList.mediaText is not nullable and treats null as the empty string.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS mediaList.__proto__ is MediaList.prototype
+PASS mediaList.length is 1
+PASS mediaList.mediaText is "screen and (min-width: 480px)"
+PASS mediaList.mediaText = null did not throw exception.
+PASS mediaList.mediaText is ""
+PASS mediaList.mediaText = 'screen and (min-width: 480px)' did not throw exception.
+PASS mediaList.mediaText is "screen and (min-width: 480px)"
+PASS style.removeAttribute('media') did not throw exception.
+PASS mediaList.mediaText is ""
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
</ins></span></pre></div>
<a id="trunkLayoutTestsfastcssMediaListmediaTextnullhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/css/MediaList-mediaText-null.html (0 => 203795)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/css/MediaList-mediaText-null.html (rev 0)
+++ trunk/LayoutTests/fast/css/MediaList-mediaText-null.html 2016-07-27 21:33:57 UTC (rev 203795)
</span><span class="lines">@@ -0,0 +1,27 @@
</span><ins>+<!DOCTYPE html>
+<html>
+<head>
+<style media="screen and (min-width: 480px)">
+</style>
+</head>
+<body>
+<script src="../../resources/js-test-pre.js"></script>
+<script>
+description("Tests that MediaList.mediaText is not nullable and treats null as the empty string.");
+
+var style = document.getElementsByTagName("style")[0];
+var mediaList = style.sheet.media;
+shouldBe("mediaList.__proto__", "MediaList.prototype");
+shouldBe("mediaList.length", "1");
+
+shouldBeEqualToString("mediaList.mediaText", "screen and (min-width: 480px)");
+shouldNotThrow("mediaList.mediaText = null");
+shouldBeEqualToString("mediaList.mediaText", "");
+shouldNotThrow("mediaList.mediaText = 'screen and (min-width: 480px)'");
+shouldBeEqualToString("mediaList.mediaText", "screen and (min-width: 480px)");
+shouldNotThrow("style.removeAttribute('media')");
+shouldBeEqualToString("mediaList.mediaText", "");
+</script>
+<script src="../../resources/js-test-post.js"></script>
+</body>
+</html>
</ins></span></pre></div>
<a id="trunkLayoutTestsfastcssMediaListparametersexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/css/MediaList-parameters-expected.txt (0 => 203795)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/css/MediaList-parameters-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/css/MediaList-parameters-expected.txt 2016-07-27 21:33:57 UTC (rev 203795)
</span><span class="lines">@@ -0,0 +1,13 @@
</span><ins>+Tests that the parameters to MediaList.item() / deleteMedium() / appendMedium() are mandatory.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS mediaList.__proto__ is MediaList.prototype
+PASS mediaList.item() threw exception TypeError: Not enough arguments.
+PASS mediaList.deleteMedium() threw exception TypeError: Not enough arguments.
+PASS mediaList.appendMedium() threw exception TypeError: Not enough arguments.
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
</ins></span></pre></div>
<a id="trunkLayoutTestsfastcssMediaListparametershtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/css/MediaList-parameters.html (0 => 203795)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/css/MediaList-parameters.html (rev 0)
+++ trunk/LayoutTests/fast/css/MediaList-parameters.html 2016-07-27 21:33:57 UTC (rev 203795)
</span><span class="lines">@@ -0,0 +1,22 @@
</span><ins>+<!DOCTYPE html>
+<html>
+<head>
+<style>
+@media screen { a { text-weight: bold } }
+</style>
+</head>
+<body>
+<script src="../../resources/js-test-pre.js"></script>
+<script>
+description("Tests that the parameters to MediaList.item() / deleteMedium() / appendMedium() are mandatory.");
+
+var mediaList = document.getElementsByTagName("style")[0].sheet.media;
+shouldBe("mediaList.__proto__", "MediaList.prototype");
+
+shouldThrow("mediaList.item()", "'TypeError: Not enough arguments'");
+shouldThrow("mediaList.deleteMedium()", "'TypeError: Not enough arguments'");
+shouldThrow("mediaList.appendMedium()", "'TypeError: Not enough arguments'");
+</script>
+<script src="../../resources/js-test-post.js"></script>
+</body>
+</html>
</ins></span></pre></div>
<a id="trunkLayoutTestsfastdomnonnumericvaluesnumericparametersexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/dom/non-numeric-values-numeric-parameters-expected.txt (203794 => 203795)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/dom/non-numeric-values-numeric-parameters-expected.txt 2016-07-27 21:18:50 UTC (rev 203794)
+++ trunk/LayoutTests/fast/dom/non-numeric-values-numeric-parameters-expected.txt 2016-07-27 21:33:57 UTC (rev 203795)
</span><span class="lines">@@ -42,7 +42,7 @@
</span><span class="cx"> PASS nonNumericPolicy('document.createElement("textarea").setSelectionRange(x, 0)') is 'any type allowed'
</span><span class="cx"> PASS nonNumericPolicy('document.createElement("textarea").setSelectionRange(0, x)') is 'any type allowed'
</span><span class="cx"> PASS nonNumericPolicy('document.createEvent("KeyboardEvent").initKeyboardEvent("a", false, false, null, "b", x, false, false, false, false, false)') is 'any type allowed'
</span><del>-PASS nonNumericPolicy('createMediaList().item(x)') is 'any type allowed'
</del><ins>+PASS nonNumericPolicy('createMediaList().item(x)') is 'any type allowed (but not omitted)'
</ins><span class="cx"> PASS nonNumericPolicy('document.createEvent("MouseEvent").initMouseEvent("a", false, false, null, x, 0, 0, 0, 0, false, false, false, false, 0, null)') is 'any type allowed'
</span><span class="cx"> PASS nonNumericPolicy('document.createEvent("MouseEvent").initMouseEvent("a", false, false, null, 0, x, 0, 0, 0, false, false, false, false, 0, null)') is 'any type allowed'
</span><span class="cx"> PASS nonNumericPolicy('document.createEvent("MouseEvent").initMouseEvent("a", false, false, null, 0, 0, x, 0, 0, false, false, false, false, 0, null)') is 'any type allowed'
</span></span></pre></div>
<a id="trunkLayoutTestsfastdomscripttestsnonnumericvaluesnumericparametersjs"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/dom/script-tests/non-numeric-values-numeric-parameters.js (203794 => 203795)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/dom/script-tests/non-numeric-values-numeric-parameters.js 2016-07-27 21:18:50 UTC (rev 203794)
+++ trunk/LayoutTests/fast/dom/script-tests/non-numeric-values-numeric-parameters.js 2016-07-27 21:33:57 UTC (rev 203795)
</span><span class="lines">@@ -278,7 +278,7 @@
</span><span class="cx">
</span><span class="cx"> // MediaList
</span><span class="cx">
</span><del>-shouldBe("nonNumericPolicy('createMediaList().item(x)')", "'any type allowed'");
</del><ins>+shouldBe("nonNumericPolicy('createMediaList().item(x)')", "'any type allowed (but not omitted)'");
</ins><span class="cx">
</span><span class="cx"> // MouseEvent
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (203794 => 203795)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-07-27 21:18:50 UTC (rev 203794)
+++ trunk/Source/WebCore/ChangeLog 2016-07-27 21:33:57 UTC (rev 203795)
</span><span class="lines">@@ -1,3 +1,23 @@
</span><ins>+2016-07-27 Chris Dumez <cdumez@apple.com>
+
+ Align MediaList with the CSSOM specification
+ https://bugs.webkit.org/show_bug.cgi?id=160257
+
+ Reviewed by Ryosuke Niwa.
+
+ Align MediaList with the CSSOM specification:
+ - https://www.w3.org/TR/cssom-1/#the-medialist-interface
+
+ In particular, the parameter to item() / deleteMedium() and
+ appendMedium() is now mandatory.
+
+ Firefox and Chrome agree with the specification.
+
+ Test: fast/css/MediaList-mediaText-null.html
+ fast/css/MediaList-parameters.html
+
+ * css/MediaList.idl:
+
</ins><span class="cx"> 2016-07-27 Jeremy Jones <jeremyj@apple.com>
</span><span class="cx">
</span><span class="cx"> Fullscreen video zoom button does not work after rotating when aspect ratio matches display.
</span></span></pre></div>
<a id="trunkSourceWebCorecssMediaListidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/MediaList.idl (203794 => 203795)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/MediaList.idl 2016-07-27 21:18:50 UTC (rev 203794)
+++ trunk/Source/WebCore/css/MediaList.idl 2016-07-27 21:33:57 UTC (rev 203795)
</span><span class="lines">@@ -30,14 +30,13 @@
</span><span class="cx"> ImplementationLacksVTable,
</span><span class="cx"> ] interface MediaList {
</span><span class="cx">
</span><del>- [SetterRaisesException] attribute DOMString? mediaText;
</del><ins>+ [SetterRaisesException, TreatNullAs=EmptyString] attribute DOMString mediaText;
</ins><span class="cx"> readonly attribute unsigned long length;
</span><span class="cx">
</span><del>- getter DOMString? item(optional unsigned long index = 0);
</del><ins>+ getter DOMString? item(unsigned long index);
</ins><span class="cx">
</span><del>- // FIXME: Using "undefined" as default parameter value is wrong.
- [RaisesException] void deleteMedium(optional DOMString oldMedium = "undefined");
- [RaisesException] void appendMedium(optional DOMString newMedium = "undefined");
</del><ins>+ [RaisesException] void deleteMedium(DOMString oldMedium);
+ [RaisesException] void appendMedium(DOMString newMedium);
</ins><span class="cx">
</span><span class="cx"> };
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>