<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[203788] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/203788">203788</a></dd>
<dt>Author</dt> <dd>cdumez@apple.com</dd>
<dt>Date</dt> <dd>2016-07-27 13:51:41 -0700 (Wed, 27 Jul 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>First parameter to indexed property getters should be mandatory
https://bugs.webkit.org/show_bug.cgi?id=160259
Reviewed by Ryosuke Niwa.
LayoutTests/imported/w3c:
Rebaseline W3C test now that more checks are passing.
* web-platform-tests/html/dom/interfaces-expected.txt:
Source/WebCore:
First parameter to indexed property getters should be mandatory:
- https://heycam.github.io/webidl/#idl-indexed-properties
No new tests, rebaselined existing tests.
* Modules/gamepad/deprecated/GamepadList.idl:
* bindings/js/JSHTMLAllCollectionCustom.cpp:
(WebCore::JSHTMLAllCollection::item):
* css/CSSRuleList.idl:
* css/CSSValueList.idl:
* css/StyleSheetList.idl:
* css/WebKitCSSFilterValue.idl:
* css/WebKitCSSTransformValue.idl:
* dom/ClientRectList.idl:
* dom/DOMStringList.idl:
* dom/DataTransferItemList.idl:
* html/HTMLAllCollection.idl:
* plugins/DOMMimeTypeArray.idl:
* plugins/DOMPlugin.idl:
* plugins/DOMPluginArray.idl:
LayoutTests:
Update existing tests to reflect behavior change.
* fast/css/webkit-keyframes-crash.html:
* fast/dom/non-numeric-values-numeric-parameters-expected.txt:
* fast/dom/script-tests/non-numeric-values-numeric-parameters.js:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsfastcsswebkitkeyframescrashhtml">trunk/LayoutTests/fast/css/webkit-keyframes-crash.html</a></li>
<li><a href="#trunkLayoutTestsfastdomnonnumericvaluesnumericparametersexpectedtxt">trunk/LayoutTests/fast/dom/non-numeric-values-numeric-parameters-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastdomscripttestsnonnumericvaluesnumericparametersjs">trunk/LayoutTests/fast/dom/script-tests/non-numeric-values-numeric-parameters.js</a></li>
<li><a href="#trunkLayoutTestsimportedw3cChangeLog">trunk/LayoutTests/imported/w3c/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestshtmldominterfacesexpectedtxt">trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreModulesgamepaddeprecatedGamepadListidl">trunk/Source/WebCore/Modules/gamepad/deprecated/GamepadList.idl</a></li>
<li><a href="#trunkSourceWebCorebindingsjsJSHTMLAllCollectionCustomcpp">trunk/Source/WebCore/bindings/js/JSHTMLAllCollectionCustom.cpp</a></li>
<li><a href="#trunkSourceWebCorecssCSSRuleListidl">trunk/Source/WebCore/css/CSSRuleList.idl</a></li>
<li><a href="#trunkSourceWebCorecssCSSValueListidl">trunk/Source/WebCore/css/CSSValueList.idl</a></li>
<li><a href="#trunkSourceWebCorecssStyleSheetListidl">trunk/Source/WebCore/css/StyleSheetList.idl</a></li>
<li><a href="#trunkSourceWebCorecssWebKitCSSFilterValueidl">trunk/Source/WebCore/css/WebKitCSSFilterValue.idl</a></li>
<li><a href="#trunkSourceWebCorecssWebKitCSSTransformValueidl">trunk/Source/WebCore/css/WebKitCSSTransformValue.idl</a></li>
<li><a href="#trunkSourceWebCoredomClientRectListidl">trunk/Source/WebCore/dom/ClientRectList.idl</a></li>
<li><a href="#trunkSourceWebCoredomDOMStringListidl">trunk/Source/WebCore/dom/DOMStringList.idl</a></li>
<li><a href="#trunkSourceWebCoredomDataTransferItemListidl">trunk/Source/WebCore/dom/DataTransferItemList.idl</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLAllCollectionidl">trunk/Source/WebCore/html/HTMLAllCollection.idl</a></li>
<li><a href="#trunkSourceWebCorepluginsDOMMimeTypeArrayidl">trunk/Source/WebCore/plugins/DOMMimeTypeArray.idl</a></li>
<li><a href="#trunkSourceWebCorepluginsDOMPluginidl">trunk/Source/WebCore/plugins/DOMPlugin.idl</a></li>
<li><a href="#trunkSourceWebCorepluginsDOMPluginArrayidl">trunk/Source/WebCore/plugins/DOMPluginArray.idl</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (203787 => 203788)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2016-07-27 20:05:43 UTC (rev 203787)
+++ trunk/LayoutTests/ChangeLog 2016-07-27 20:51:41 UTC (rev 203788)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2016-07-27 Chris Dumez <cdumez@apple.com>
+
+ First parameter to indexed property getters should be mandatory
+ https://bugs.webkit.org/show_bug.cgi?id=160259
+
+ Reviewed by Ryosuke Niwa.
+
+ Update existing tests to reflect behavior change.
+
+ * fast/css/webkit-keyframes-crash.html:
+ * fast/dom/non-numeric-values-numeric-parameters-expected.txt:
+ * fast/dom/script-tests/non-numeric-values-numeric-parameters.js:
+
</ins><span class="cx"> 2016-07-27 Ryan Haddad <ryanhaddad@apple.com>
</span><span class="cx">
</span><span class="cx"> Land test expectations for rdar://problem/27574303.
</span></span></pre></div>
<a id="trunkLayoutTestsfastcsswebkitkeyframescrashhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/css/webkit-keyframes-crash.html (203787 => 203788)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/css/webkit-keyframes-crash.html 2016-07-27 20:05:43 UTC (rev 203787)
+++ trunk/LayoutTests/fast/css/webkit-keyframes-crash.html 2016-07-27 20:51:41 UTC (rev 203788)
</span><span class="lines">@@ -9,7 +9,7 @@
</span><span class="cx">
</span><span class="cx"> function main(){
</span><span class="cx"> var e = window.document.styleSheets[0].cssRules[0];
</span><del>- e.cssRules.item().parentStyleSheet.removeRule();
</del><ins>+ e.cssRules.item(0).parentStyleSheet.removeRule();
</ins><span class="cx"> e.name = 'bar';
</span><span class="cx"> document.getElementById('console').innerHTML = "PASSED";
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkLayoutTestsfastdomnonnumericvaluesnumericparametersexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/dom/non-numeric-values-numeric-parameters-expected.txt (203787 => 203788)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/dom/non-numeric-values-numeric-parameters-expected.txt 2016-07-27 20:05:43 UTC (rev 203787)
+++ trunk/LayoutTests/fast/dom/non-numeric-values-numeric-parameters-expected.txt 2016-07-27 20:51:41 UTC (rev 203788)
</span><span class="lines">@@ -13,13 +13,13 @@
</span><span class="cx"> PASS nonNumericPolicy('document.createTextNode("a").replaceData(0, x, "b")') is 'any type allowed'
</span><span class="cx"> PASS nonNumericPolicy('createCSSMediaRule().insertRule(ruleText, x)') is 'any type allowed'
</span><span class="cx"> PASS nonNumericPolicy('createCSSMediaRule().deleteRule(x)') is 'any type allowed'
</span><del>-PASS nonNumericPolicy('createCSSRuleList().item(x)') is 'any type allowed'
</del><ins>+PASS nonNumericPolicy('createCSSRuleList().item(x)') is 'any type allowed (but not omitted)'
</ins><span class="cx"> PASS nonNumericPolicy('createCSSStyleDeclaration().item(x)') is 'any type allowed (but not omitted)'
</span><span class="cx"> PASS nonNumericPolicy('createCSSStyleSheet().insertRule(ruleText, x)') is 'any type allowed'
</span><span class="cx"> PASS nonNumericPolicy('createCSSStyleSheet().deleteRule(x)') is 'any type allowed (but not omitted)'
</span><span class="cx"> PASS nonNumericPolicy('createCSSStyleSheet().addRule(selector, styleText, x)') is 'any type allowed'
</span><span class="cx"> PASS nonNumericPolicy('createCSSStyleSheet().removeRule(x)') is 'any type allowed'
</span><del>-PASS nonNumericPolicy('createCSSValueList().item(x)') is 'any type allowed'
</del><ins>+PASS nonNumericPolicy('createCSSValueList().item(x)') is 'any type allowed (but not omitted)'
</ins><span class="cx"> PASS nonNumericPolicy('document.elementFromPoint(x, 0)') is 'any type allowed'
</span><span class="cx"> PASS nonNumericPolicy('document.elementFromPoint(0, x)') is 'any type allowed'
</span><span class="cx"> PASS nonNumericPolicy('document.body.scrollByLines(x)') is 'any type allowed'
</span><span class="lines">@@ -62,7 +62,7 @@
</span><span class="cx"> PASS nonNumericPolicy('getSelection().setPosition(document, x)') is 'any type allowed'
</span><span class="cx"> PASS nonNumericPolicy('getSelection().extend(document, x)') is 'any type allowed'
</span><span class="cx"> PASS nonNumericPolicy('getSelection().getRangeAt(x)') is 'any type allowed'
</span><del>-PASS nonNumericPolicy('document.styleSheets.item(x)') is 'any type allowed'
</del><ins>+PASS nonNumericPolicy('document.styleSheets.item(x)') is 'any type allowed (but not omitted)'
</ins><span class="cx"> PASS nonNumericPolicy('document.createTextNode("a").splitText(x)') is 'any type allowed (but not omitted)'
</span><span class="cx"> PASS nonNumericPolicy('document.createTreeWalker(document, x, null, false)') is 'any type allowed'
</span><span class="cx"> PASS nonNumericPolicy('document.createEvent("UIEvent").initUIEvent("a", false, false, null, x)') is 'any type allowed'
</span></span></pre></div>
<a id="trunkLayoutTestsfastdomscripttestsnonnumericvaluesnumericparametersjs"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/dom/script-tests/non-numeric-values-numeric-parameters.js (203787 => 203788)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/dom/script-tests/non-numeric-values-numeric-parameters.js 2016-07-27 20:05:43 UTC (rev 203787)
+++ trunk/LayoutTests/fast/dom/script-tests/non-numeric-values-numeric-parameters.js 2016-07-27 20:51:41 UTC (rev 203788)
</span><span class="lines">@@ -200,7 +200,7 @@
</span><span class="cx">
</span><span class="cx"> // CSSRuleList
</span><span class="cx">
</span><del>-shouldBe("nonNumericPolicy('createCSSRuleList().item(x)')", "'any type allowed'");
</del><ins>+shouldBe("nonNumericPolicy('createCSSRuleList().item(x)')", "'any type allowed (but not omitted)'");
</ins><span class="cx">
</span><span class="cx"> // CSSStyleDeclaration
</span><span class="cx">
</span><span class="lines">@@ -215,7 +215,7 @@
</span><span class="cx">
</span><span class="cx"> // CSSValueList
</span><span class="cx">
</span><del>-shouldBe("nonNumericPolicy('createCSSValueList().item(x)')", "'any type allowed'");
</del><ins>+shouldBe("nonNumericPolicy('createCSSValueList().item(x)')", "'any type allowed (but not omitted)'");
</ins><span class="cx">
</span><span class="cx"> // Document
</span><span class="cx">
</span><span class="lines">@@ -323,7 +323,7 @@
</span><span class="cx">
</span><span class="cx"> // StyleSheetList
</span><span class="cx">
</span><del>-shouldBe("nonNumericPolicy('document.styleSheets.item(x)')", "'any type allowed'");
</del><ins>+shouldBe("nonNumericPolicy('document.styleSheets.item(x)')", "'any type allowed (but not omitted)'");
</ins><span class="cx">
</span><span class="cx"> // Text
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/ChangeLog (203787 => 203788)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/ChangeLog 2016-07-27 20:05:43 UTC (rev 203787)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2016-07-27 20:51:41 UTC (rev 203788)
</span><span class="lines">@@ -1,5 +1,16 @@
</span><span class="cx"> 2016-07-27 Chris Dumez <cdumez@apple.com>
</span><span class="cx">
</span><ins>+ First parameter to indexed property getters should be mandatory
+ https://bugs.webkit.org/show_bug.cgi?id=160259
+
+ Reviewed by Ryosuke Niwa.
+
+ Rebaseline W3C test now that more checks are passing.
+
+ * web-platform-tests/html/dom/interfaces-expected.txt:
+
+2016-07-27 Chris Dumez <cdumez@apple.com>
+
</ins><span class="cx"> First parameter to Document.execCommand() / queryCommand*() should be mandatory
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=160258
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestshtmldominterfacesexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt (203787 => 203788)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt 2016-07-27 20:05:43 UTC (rev 203787)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt 2016-07-27 20:51:41 UTC (rev 203788)
</span><span class="lines">@@ -888,8 +888,8 @@
</span><span class="cx"> PASS HTMLAllCollection interface: existence and properties of interface prototype object
</span><span class="cx"> PASS HTMLAllCollection interface: existence and properties of interface prototype object's "constructor" property
</span><span class="cx"> PASS HTMLAllCollection interface: attribute length
</span><del>-FAIL HTMLAllCollection interface: operation item(unsigned long) assert_equals: property has wrong .length expected 1 but got 0
-FAIL HTMLAllCollection interface: operation item(DOMString) assert_equals: property has wrong .length expected 1 but got 0
</del><ins>+PASS HTMLAllCollection interface: operation item(unsigned long)
+PASS HTMLAllCollection interface: operation item(DOMString)
</ins><span class="cx"> PASS HTMLAllCollection interface: operation namedItem(DOMString)
</span><span class="cx"> FAIL HTMLAllCollection must be primary interface of document.all assert_equals: wrong typeof object expected "function" but got "undefined"
</span><span class="cx"> FAIL Stringification of document.all assert_equals: wrong typeof object expected "function" but got "undefined"
</span><span class="lines">@@ -5716,7 +5716,7 @@
</span><span class="cx"> PASS PluginArray interface: existence and properties of interface prototype object's "constructor" property
</span><span class="cx"> PASS PluginArray interface: operation refresh(boolean)
</span><span class="cx"> PASS PluginArray interface: attribute length
</span><del>-FAIL PluginArray interface: operation item(unsigned long) assert_equals: property has wrong .length expected 1 but got 0
</del><ins>+PASS PluginArray interface: operation item(unsigned long)
</ins><span class="cx"> FAIL PluginArray interface: operation namedItem(DOMString) assert_equals: property has wrong .length expected 1 but got 0
</span><span class="cx"> PASS MimeTypeArray interface: existence and properties of interface object
</span><span class="cx"> PASS MimeTypeArray interface object length
</span><span class="lines">@@ -5724,7 +5724,7 @@
</span><span class="cx"> PASS MimeTypeArray interface: existence and properties of interface prototype object
</span><span class="cx"> PASS MimeTypeArray interface: existence and properties of interface prototype object's "constructor" property
</span><span class="cx"> PASS MimeTypeArray interface: attribute length
</span><del>-FAIL MimeTypeArray interface: operation item(unsigned long) assert_equals: property has wrong .length expected 1 but got 0
</del><ins>+PASS MimeTypeArray interface: operation item(unsigned long)
</ins><span class="cx"> FAIL MimeTypeArray interface: operation namedItem(DOMString) assert_equals: property has wrong .length expected 1 but got 0
</span><span class="cx"> PASS Plugin interface: existence and properties of interface object
</span><span class="cx"> PASS Plugin interface object length
</span><span class="lines">@@ -5735,7 +5735,7 @@
</span><span class="cx"> PASS Plugin interface: attribute description
</span><span class="cx"> PASS Plugin interface: attribute filename
</span><span class="cx"> PASS Plugin interface: attribute length
</span><del>-FAIL Plugin interface: operation item(unsigned long) assert_equals: property has wrong .length expected 1 but got 0
</del><ins>+PASS Plugin interface: operation item(unsigned long)
</ins><span class="cx"> FAIL Plugin interface: operation namedItem(DOMString) assert_equals: property has wrong .length expected 1 but got 0
</span><span class="cx"> PASS MimeType interface: existence and properties of interface object
</span><span class="cx"> PASS MimeType interface object length
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (203787 => 203788)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-07-27 20:05:43 UTC (rev 203787)
+++ trunk/Source/WebCore/ChangeLog 2016-07-27 20:51:41 UTC (rev 203788)
</span><span class="lines">@@ -1,3 +1,31 @@
</span><ins>+2016-07-27 Chris Dumez <cdumez@apple.com>
+
+ First parameter to indexed property getters should be mandatory
+ https://bugs.webkit.org/show_bug.cgi?id=160259
+
+ Reviewed by Ryosuke Niwa.
+
+ First parameter to indexed property getters should be mandatory:
+ - https://heycam.github.io/webidl/#idl-indexed-properties
+
+ No new tests, rebaselined existing tests.
+
+ * Modules/gamepad/deprecated/GamepadList.idl:
+ * bindings/js/JSHTMLAllCollectionCustom.cpp:
+ (WebCore::JSHTMLAllCollection::item):
+ * css/CSSRuleList.idl:
+ * css/CSSValueList.idl:
+ * css/StyleSheetList.idl:
+ * css/WebKitCSSFilterValue.idl:
+ * css/WebKitCSSTransformValue.idl:
+ * dom/ClientRectList.idl:
+ * dom/DOMStringList.idl:
+ * dom/DataTransferItemList.idl:
+ * html/HTMLAllCollection.idl:
+ * plugins/DOMMimeTypeArray.idl:
+ * plugins/DOMPlugin.idl:
+ * plugins/DOMPluginArray.idl:
+
</ins><span class="cx"> 2016-07-27 Javier Fernandez <jfernandez@igalia.com>
</span><span class="cx">
</span><span class="cx"> [css-grid] The isValidTransition function must not alter the GridSizingData object
</span></span></pre></div>
<a id="trunkSourceWebCoreModulesgamepaddeprecatedGamepadListidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/gamepad/deprecated/GamepadList.idl (203787 => 203788)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/gamepad/deprecated/GamepadList.idl 2016-07-27 20:05:43 UTC (rev 203787)
+++ trunk/Source/WebCore/Modules/gamepad/deprecated/GamepadList.idl 2016-07-27 20:51:41 UTC (rev 203788)
</span><span class="lines">@@ -29,6 +29,6 @@
</span><span class="cx"> ImplementationLacksVTable,
</span><span class="cx"> ] interface GamepadList {
</span><span class="cx"> readonly attribute unsigned long length;
</span><del>- getter Gamepad item(optional unsigned long index = 0);
</del><ins>+ getter Gamepad item(unsigned long index);
</ins><span class="cx"> };
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsjsJSHTMLAllCollectionCustomcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/js/JSHTMLAllCollectionCustom.cpp (203787 => 203788)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/js/JSHTMLAllCollectionCustom.cpp 2016-07-27 20:05:43 UTC (rev 203787)
+++ trunk/Source/WebCore/bindings/js/JSHTMLAllCollectionCustom.cpp 2016-07-27 20:51:41 UTC (rev 203788)
</span><span class="lines">@@ -104,9 +104,13 @@
</span><span class="cx">
</span><span class="cx"> JSValue JSHTMLAllCollection::item(ExecState& state)
</span><span class="cx"> {
</span><del>- if (Optional<uint32_t> index = parseIndex(*state.argument(0).toString(&state)->value(&state).impl()))
</del><ins>+ if (UNLIKELY(state.argumentCount() < 1))
+ return state.vm().throwException(&state, createNotEnoughArgumentsError(&state));
+
+ String argument = state.uncheckedArgument(0).toWTFString(&state);
+ if (Optional<uint32_t> index = parseIndex(*argument.impl()))
</ins><span class="cx"> return toJS(&state, globalObject(), wrapped().item(index.value()));
</span><del>- return namedItems(state, this, Identifier::fromString(&state, state.argument(0).toString(&state)->value(&state)));
</del><ins>+ return namedItems(state, this, Identifier::fromString(&state, argument));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> JSValue JSHTMLAllCollection::namedItem(ExecState& state)
</span></span></pre></div>
<a id="trunkSourceWebCorecssCSSRuleListidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/CSSRuleList.idl (203787 => 203788)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/CSSRuleList.idl 2016-07-27 20:05:43 UTC (rev 203787)
+++ trunk/Source/WebCore/css/CSSRuleList.idl 2016-07-27 20:51:41 UTC (rev 203788)
</span><span class="lines">@@ -28,7 +28,7 @@
</span><span class="cx"> CustomIsReachable,
</span><span class="cx"> SkipVTableValidation,
</span><span class="cx"> ] interface CSSRuleList {
</span><del>- readonly attribute unsigned long length;
- getter CSSRule item(optional unsigned long index = 0);
</del><ins>+ readonly attribute unsigned long length;
+ getter CSSRule item(unsigned long index);
</ins><span class="cx"> };
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorecssCSSValueListidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/CSSValueList.idl (203787 => 203788)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/CSSValueList.idl 2016-07-27 20:05:43 UTC (rev 203787)
+++ trunk/Source/WebCore/css/CSSValueList.idl 2016-07-27 20:51:41 UTC (rev 203788)
</span><span class="lines">@@ -27,7 +27,7 @@
</span><span class="cx"> [
</span><span class="cx"> ImplementationLacksVTable,
</span><span class="cx"> ] interface CSSValueList : CSSValue {
</span><del>- readonly attribute unsigned long length;
- getter CSSValue item(optional unsigned long index = 0);
</del><ins>+ readonly attribute unsigned long length;
+ getter CSSValue item(unsigned long index);
</ins><span class="cx"> };
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorecssStyleSheetListidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/StyleSheetList.idl (203787 => 203788)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/StyleSheetList.idl 2016-07-27 20:05:43 UTC (rev 203787)
+++ trunk/Source/WebCore/css/StyleSheetList.idl 2016-07-27 20:51:41 UTC (rev 203788)
</span><span class="lines">@@ -23,8 +23,8 @@
</span><span class="cx"> GenerateIsReachable=ImplDocument,
</span><span class="cx"> ImplementationLacksVTable,
</span><span class="cx"> ] interface StyleSheetList {
</span><del>- readonly attribute unsigned long length;
- getter StyleSheet item(optional unsigned long index = 0);
</del><ins>+ readonly attribute unsigned long length;
+ getter StyleSheet item(unsigned long index);
</ins><span class="cx"> getter CSSStyleSheet (DOMString name);
</span><span class="cx"> };
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorecssWebKitCSSFilterValueidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/WebKitCSSFilterValue.idl (203787 => 203788)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/WebKitCSSFilterValue.idl 2016-07-27 20:05:43 UTC (rev 203787)
+++ trunk/Source/WebCore/css/WebKitCSSFilterValue.idl 2016-07-27 20:51:41 UTC (rev 203788)
</span><span class="lines">@@ -44,5 +44,5 @@
</span><span class="cx">
</span><span class="cx"> readonly attribute unsigned short operationType;
</span><span class="cx">
</span><del>- getter CSSValue (optional unsigned long index = 0);
</del><ins>+ getter CSSValue (unsigned long index);
</ins><span class="cx"> };
</span></span></pre></div>
<a id="trunkSourceWebCorecssWebKitCSSTransformValueidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/WebKitCSSTransformValue.idl (203787 => 203788)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/WebKitCSSTransformValue.idl 2016-07-27 20:05:43 UTC (rev 203787)
+++ trunk/Source/WebCore/css/WebKitCSSTransformValue.idl 2016-07-27 20:51:41 UTC (rev 203788)
</span><span class="lines">@@ -57,6 +57,6 @@
</span><span class="cx">
</span><span class="cx"> readonly attribute unsigned short operationType;
</span><span class="cx">
</span><del>- getter CSSValue (optional unsigned long index = 0);
</del><ins>+ getter CSSValue (unsigned long index);
</ins><span class="cx"> };
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoredomClientRectListidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/ClientRectList.idl (203787 => 203788)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/ClientRectList.idl 2016-07-27 20:05:43 UTC (rev 203787)
+++ trunk/Source/WebCore/dom/ClientRectList.idl 2016-07-27 20:51:41 UTC (rev 203788)
</span><span class="lines">@@ -29,7 +29,7 @@
</span><span class="cx"> ExportMacro=WEBCORE_EXPORT,
</span><span class="cx"> ] interface ClientRectList {
</span><span class="cx"> readonly attribute unsigned long length;
</span><del>- getter ClientRect item(optional unsigned long index = 0);
</del><ins>+ getter ClientRect item(unsigned long index);
</ins><span class="cx"> // FIXME: Fix list behavior to allow custom exceptions to be thrown.
</span><span class="cx"> };
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoredomDOMStringListidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/DOMStringList.idl (203787 => 203788)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/DOMStringList.idl 2016-07-27 20:05:43 UTC (rev 203787)
+++ trunk/Source/WebCore/dom/DOMStringList.idl 2016-07-27 20:51:41 UTC (rev 203788)
</span><span class="lines">@@ -28,7 +28,7 @@
</span><span class="cx"> ImplementationLacksVTable,
</span><span class="cx"> ] interface DOMStringList {
</span><span class="cx"> readonly attribute unsigned long length;
</span><del>- getter DOMString? item(optional unsigned long index = 0);
</del><ins>+ getter DOMString? item(unsigned long index);
</ins><span class="cx">
</span><span class="cx"> // FIXME: Using "undefined" as default parameter value is wrong.
</span><span class="cx"> boolean contains(optional DOMString string = "undefined");
</span></span></pre></div>
<a id="trunkSourceWebCoredomDataTransferItemListidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/DataTransferItemList.idl (203787 => 203788)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/DataTransferItemList.idl 2016-07-27 20:05:43 UTC (rev 203787)
+++ trunk/Source/WebCore/dom/DataTransferItemList.idl 2016-07-27 20:51:41 UTC (rev 203788)
</span><span class="lines">@@ -35,7 +35,7 @@
</span><span class="cx"> ImplementationLacksVTable,
</span><span class="cx"> ] interface DataTransferItemList {
</span><span class="cx"> readonly attribute long length;
</span><del>- getter DataTransferItem item(optional unsigned long index = 0);
</del><ins>+ getter DataTransferItem item(unsigned long index);
</ins><span class="cx">
</span><span class="cx"> void clear();
</span><span class="cx"> void add(File? file);
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLAllCollectionidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLAllCollection.idl (203787 => 203788)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLAllCollection.idl 2016-07-27 20:05:43 UTC (rev 203787)
+++ trunk/Source/WebCore/html/HTMLAllCollection.idl 2016-07-27 20:51:41 UTC (rev 203788)
</span><span class="lines">@@ -29,7 +29,7 @@
</span><span class="cx"> GenerateIsReachable=ImplOwnerNodeRoot,
</span><span class="cx"> ] interface HTMLAllCollection {
</span><span class="cx"> readonly attribute unsigned long length;
</span><del>- [Custom] getter Element item(optional unsigned long index);
</del><ins>+ [Custom] getter Element item(unsigned long index);
</ins><span class="cx"> [Custom] getter Element namedItem(DOMString name);
</span><span class="cx"> // FIXME: This should return an HTMLAllCollection.
</span><span class="cx"> NodeList tags(DOMString name);
</span></span></pre></div>
<a id="trunkSourceWebCorepluginsDOMMimeTypeArrayidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/plugins/DOMMimeTypeArray.idl (203787 => 203788)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/plugins/DOMMimeTypeArray.idl 2016-07-27 20:05:43 UTC (rev 203787)
+++ trunk/Source/WebCore/plugins/DOMMimeTypeArray.idl 2016-07-27 20:51:41 UTC (rev 203788)
</span><span class="lines">@@ -23,7 +23,7 @@
</span><span class="cx"> InterfaceName=MimeTypeArray,
</span><span class="cx"> ] interface DOMMimeTypeArray {
</span><span class="cx"> readonly attribute unsigned long length;
</span><del>- getter DOMMimeType item(optional unsigned long index = 0);
</del><ins>+ getter DOMMimeType item(unsigned long index);
</ins><span class="cx">
</span><span class="cx"> // FIXME: Using "undefined" as default parameter value is wrong.
</span><span class="cx"> getter DOMMimeType namedItem(optional DOMString name = "undefined");
</span></span></pre></div>
<a id="trunkSourceWebCorepluginsDOMPluginidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/plugins/DOMPlugin.idl (203787 => 203788)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/plugins/DOMPlugin.idl 2016-07-27 20:05:43 UTC (rev 203787)
+++ trunk/Source/WebCore/plugins/DOMPlugin.idl 2016-07-27 20:51:41 UTC (rev 203788)
</span><span class="lines">@@ -25,7 +25,7 @@
</span><span class="cx"> readonly attribute DOMString filename;
</span><span class="cx"> readonly attribute DOMString description;
</span><span class="cx"> readonly attribute unsigned long length;
</span><del>- getter DOMMimeType item(optional unsigned long index = 0);
</del><ins>+ getter DOMMimeType item(unsigned long index);
</ins><span class="cx">
</span><span class="cx"> // FIXME: Using "undefined" as default parameter value is wrong.
</span><span class="cx"> getter DOMMimeType namedItem(optional DOMString name = "undefined");
</span></span></pre></div>
<a id="trunkSourceWebCorepluginsDOMPluginArrayidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/plugins/DOMPluginArray.idl (203787 => 203788)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/plugins/DOMPluginArray.idl 2016-07-27 20:05:43 UTC (rev 203787)
+++ trunk/Source/WebCore/plugins/DOMPluginArray.idl 2016-07-27 20:51:41 UTC (rev 203788)
</span><span class="lines">@@ -23,7 +23,7 @@
</span><span class="cx"> InterfaceName=PluginArray,
</span><span class="cx"> ] interface DOMPluginArray {
</span><span class="cx"> readonly attribute unsigned long length;
</span><del>- getter DOMPlugin item(optional unsigned long index = 0);
</del><ins>+ getter DOMPlugin item(unsigned long index);
</ins><span class="cx">
</span><span class="cx"> // FIXME: Using "undefined" as default parameter value is wrong.
</span><span class="cx"> getter DOMPlugin namedItem(optional DOMString name = "undefined");
</span></span></pre>
</div>
</div>
</body>
</html>