<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[203748] trunk/Websites/perf.webkit.org</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/203748">203748</a></dd>
<dt>Author</dt> <dd>rniwa@webkit.org</dd>
<dt>Date</dt> <dd>2016-07-26 16:15:14 -0700 (Tue, 26 Jul 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>REGRESSION: Tooltip for analysis tasks doesn't show up on charts
https://bugs.webkit.org/show_bug.cgi?id=160221
Rubber-stamped by Chris Dumez.
The bug was caused by ChartPaneBase resetting annotation bars every time the current point has moved.
Avoid doing this in ChartPaneBase's _renderAnnotations().
* public/v3/components/chart-pane-base.js:
(ChartPaneBase):
(ChartPaneBase.prototype.fetchAnalysisTasks):
(ChartPaneBase.prototype._renderAnnotations):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkWebsitesperfwebkitorgChangeLog">trunk/Websites/perf.webkit.org/ChangeLog</a></li>
<li><a href="#trunkWebsitesperfwebkitorgpublicv3componentschartpanebasejs">trunk/Websites/perf.webkit.org/public/v3/components/chart-pane-base.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkWebsitesperfwebkitorgChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/ChangeLog (203747 => 203748)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/ChangeLog 2016-07-26 23:06:34 UTC (rev 203747)
+++ trunk/Websites/perf.webkit.org/ChangeLog 2016-07-26 23:15:14 UTC (rev 203748)
</span><span class="lines">@@ -1,5 +1,20 @@
</span><span class="cx"> 2016-07-26 Ryosuke Niwa <rniwa@webkit.org>
</span><span class="cx">
</span><ins>+ REGRESSION: Tooltip for analysis tasks doesn't show up on charts
+ https://bugs.webkit.org/show_bug.cgi?id=160221
+
+ Rubber-stamped by Chris Dumez.
+
+ The bug was caused by ChartPaneBase resetting annotation bars every time the current point has moved.
+ Avoid doing this in ChartPaneBase's _renderAnnotations().
+
+ * public/v3/components/chart-pane-base.js:
+ (ChartPaneBase):
+ (ChartPaneBase.prototype.fetchAnalysisTasks):
+ (ChartPaneBase.prototype._renderAnnotations):
+
+2016-07-26 Ryosuke Niwa <rniwa@webkit.org>
+
</ins><span class="cx"> REGRESSION: The arrow indicating the current page doesn't get updated
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=160185
</span><span class="cx">
</span></span></pre></div>
<a id="trunkWebsitesperfwebkitorgpublicv3componentschartpanebasejs"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/public/v3/components/chart-pane-base.js (203747 => 203748)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/public/v3/components/chart-pane-base.js 2016-07-26 23:06:34 UTC (rev 203747)
+++ trunk/Websites/perf.webkit.org/public/v3/components/chart-pane-base.js 2016-07-26 23:15:14 UTC (rev 203748)
</span><span class="lines">@@ -18,6 +18,7 @@
</span><span class="cx"> this._mainChartStatus = null;
</span><span class="cx"> this._commitLogViewer = null;
</span><span class="cx"> this._tasksForAnnotations = null;
</span><ins>+ this._renderedAnnotations = false;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> configure(platformId, metricId)
</span><span class="lines">@@ -92,6 +93,7 @@
</span><span class="cx"> var self = this;
</span><span class="cx"> AnalysisTask.fetchByPlatformAndMetric(this._platformId, this._metricId, noCache).then(function (tasks) {
</span><span class="cx"> self._tasksForAnnotations = tasks;
</span><ins>+ self._renderedAnnotations = false;
</ins><span class="cx"> self.render();
</span><span class="cx"> });
</span><span class="cx"> }
</span><span class="lines">@@ -225,8 +227,9 @@
</span><span class="cx">
</span><span class="cx"> _renderAnnotations()
</span><span class="cx"> {
</span><del>- if (!this._tasksForAnnotations)
</del><ins>+ if (!this._tasksForAnnotations || this._renderedAnnotations)
</ins><span class="cx"> return;
</span><ins>+ this._renderedAnnotations = true;
</ins><span class="cx">
</span><span class="cx"> var annotations = this._tasksForAnnotations.map(function (task) {
</span><span class="cx"> var fillStyle = '#fc6';
</span></span></pre>
</div>
</div>
</body>
</html>