<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[203667] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/203667">203667</a></dd>
<dt>Author</dt> <dd>ddkilzer@apple.com</dd>
<dt>Date</dt> <dd>2016-07-24 10:47:39 -0700 (Sun, 24 Jul 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>REGRESSION (<a href="http://trac.webkit.org/projects/webkit/changeset/203106">r203106</a>): Crash in WebCore::MathMLElement::parseMathMLLength()
<https://webkit.org/b/160111>
<rdar://problem/27506489>
Reviewed by Chris Dumez.
Source/WebCore:
Test: mathml/mpadded-crash.html
* mathml/MathMLElement.cpp:
(WebCore::skipLeadingAndTrailingWhitespace): Change to take
StringView parameter instead of String to avoid creating a
temporary String that's released on return.
LayoutTests:
* mathml/mpadded-crash-expected.txt: Added.
* mathml/mpadded-crash.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoremathmlMathMLElementcpp">trunk/Source/WebCore/mathml/MathMLElement.cpp</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsmathmlmpaddedcrashexpectedtxt">trunk/LayoutTests/mathml/mpadded-crash-expected.txt</a></li>
<li><a href="#trunkLayoutTestsmathmlmpaddedcrashhtml">trunk/LayoutTests/mathml/mpadded-crash.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (203666 => 203667)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2016-07-24 17:36:43 UTC (rev 203666)
+++ trunk/LayoutTests/ChangeLog 2016-07-24 17:47:39 UTC (rev 203667)
</span><span class="lines">@@ -1,3 +1,14 @@
</span><ins>+2016-07-24 David Kilzer <ddkilzer@apple.com>
+
+ REGRESSION (r203106): Crash in WebCore::MathMLElement::parseMathMLLength()
+ <https://webkit.org/b/160111>
+ <rdar://problem/27506489>
+
+ Reviewed by Chris Dumez.
+
+ * mathml/mpadded-crash-expected.txt: Added.
+ * mathml/mpadded-crash.html: Added.
+
</ins><span class="cx"> 2016-07-24 Myles C. Maxfield <mmaxfield@apple.com>
</span><span class="cx">
</span><span class="cx"> Test gardening after r203626.
</span></span></pre></div>
<a id="trunkLayoutTestsmathmlmpaddedcrashexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/mathml/mpadded-crash-expected.txt (0 => 203667)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/mathml/mpadded-crash-expected.txt (rev 0)
+++ trunk/LayoutTests/mathml/mpadded-crash-expected.txt 2016-07-24 17:47:39 UTC (rev 203667)
</span><span class="lines">@@ -0,0 +1,9 @@
</span><ins>+Test passes if it does not crash with GuardMalloc or ASan.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
</ins></span></pre></div>
<a id="trunkLayoutTestsmathmlmpaddedcrashhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/mathml/mpadded-crash.html (0 => 203667)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/mathml/mpadded-crash.html (rev 0)
+++ trunk/LayoutTests/mathml/mpadded-crash.html 2016-07-24 17:47:39 UTC (rev 203667)
</span><span class="lines">@@ -0,0 +1,16 @@
</span><ins>+<!DOCTYPE html>
+<html>
+ <head>
+ <title>Test mpadded attribute with space</title>
+ <script src="../resources/js-test.js"></script>
+ </head>
+ <body>
+ <math>
+ <mpadded width=" 20px ">
+ </mpadded>
+ </math>
+ <script>
+ description("Test passes if it does not crash with GuardMalloc or ASan.");
+ </script>
+ </body>
+</html>
</ins></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (203666 => 203667)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-07-24 17:36:43 UTC (rev 203666)
+++ trunk/Source/WebCore/ChangeLog 2016-07-24 17:47:39 UTC (rev 203667)
</span><span class="lines">@@ -1,3 +1,18 @@
</span><ins>+2016-07-24 David Kilzer <ddkilzer@apple.com>
+
+ REGRESSION (r203106): Crash in WebCore::MathMLElement::parseMathMLLength()
+ <https://webkit.org/b/160111>
+ <rdar://problem/27506489>
+
+ Reviewed by Chris Dumez.
+
+ Test: mathml/mpadded-crash.html
+
+ * mathml/MathMLElement.cpp:
+ (WebCore::skipLeadingAndTrailingWhitespace): Change to take
+ StringView parameter instead of String to avoid creating a
+ temporary String that's released on return.
+
</ins><span class="cx"> 2016-07-24 Carlos Garcia Campos <cgarcia@igalia.com>
</span><span class="cx">
</span><span class="cx"> [Coordinated Graphics] ASSERTION FAILED: !m_flushingLayers in fast/repaint/animation-after-layer-scroll.html
</span></span></pre></div>
<a id="trunkSourceWebCoremathmlMathMLElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/mathml/MathMLElement.cpp (203666 => 203667)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/mathml/MathMLElement.cpp 2016-07-24 17:36:43 UTC (rev 203666)
+++ trunk/Source/WebCore/mathml/MathMLElement.cpp 2016-07-24 17:47:39 UTC (rev 203667)
</span><span class="lines">@@ -397,16 +397,16 @@
</span><span class="cx"> return Element::tabIndex();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-static inline StringView skipLeadingAndTrailingWhitespace(const String& string)
</del><ins>+static inline StringView skipLeadingAndTrailingWhitespace(const StringView& stringView)
</ins><span class="cx"> {
</span><del>- unsigned start = 0, stringLength = string.length();
- while (stringLength > 0 && isHTMLSpace(string[start])) {
</del><ins>+ unsigned start = 0, stringLength = stringView.length();
+ while (stringLength > 0 && isHTMLSpace(stringView[start])) {
</ins><span class="cx"> start++;
</span><span class="cx"> stringLength--;
</span><span class="cx"> }
</span><del>- while (stringLength > 0 && isHTMLSpace(string[start + stringLength - 1]))
</del><ins>+ while (stringLength > 0 && isHTMLSpace(stringView[start + stringLength - 1]))
</ins><span class="cx"> stringLength--;
</span><del>- return string.substring(start, stringLength);
</del><ins>+ return stringView.substring(start, stringLength);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> MathMLElement::Length MathMLElement::parseNumberAndUnit(const StringView& string)
</span></span></pre>
</div>
</div>
</body>
</html>