<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[203605] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/203605">203605</a></dd>
<dt>Author</dt> <dd>cdumez@apple.com</dd>
<dt>Date</dt> <dd>2016-07-22 11:39:47 -0700 (Fri, 22 Jul 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>First parameter to getElementById() should be mandatory
https://bugs.webkit.org/show_bug.cgi?id=160087
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
Rebaseline several W3C tests now that more checks are passing.
* web-platform-tests/dom/interfaces-expected.txt:
* web-platform-tests/html/dom/interfaces-expected.txt:
Source/WebCore:
First parameter to getElementById() should be mandatory:
- https://dom.spec.whatwg.org/#nonelementparentnode
- https://www.w3.org/TR/SVG/struct.html#InterfaceSVGSVGElement
Both Firefox and Chrome agree with the specification.
Test: svg/dom/SVGSVGElement-getElementById.html
* dom/NonElementParentNode.idl:
* svg/SVGSVGElement.idl:
LayoutTests:
Add layout test coverage for SVGSVGElement.getElementById().
* svg/dom/SVGSVGElement-getElementById-expected.txt: Added.
* svg/dom/SVGSVGElement-getElementById.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsimportedw3cChangeLog">trunk/LayoutTests/imported/w3c/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestsdominterfacesexpectedtxt">trunk/LayoutTests/imported/w3c/web-platform-tests/dom/interfaces-expected.txt</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestshtmldominterfacesexpectedtxt">trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoredomNonElementParentNodeidl">trunk/Source/WebCore/dom/NonElementParentNode.idl</a></li>
<li><a href="#trunkSourceWebCoresvgSVGSVGElementidl">trunk/Source/WebCore/svg/SVGSVGElement.idl</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestssvgdomSVGSVGElementgetElementByIdexpectedtxt">trunk/LayoutTests/svg/dom/SVGSVGElement-getElementById-expected.txt</a></li>
<li><a href="#trunkLayoutTestssvgdomSVGSVGElementgetElementByIdhtml">trunk/LayoutTests/svg/dom/SVGSVGElement-getElementById.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (203604 => 203605)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2016-07-22 18:34:56 UTC (rev 203604)
+++ trunk/LayoutTests/ChangeLog 2016-07-22 18:39:47 UTC (rev 203605)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2016-07-22 Chris Dumez <cdumez@apple.com>
+
+ First parameter to getElementById() should be mandatory
+ https://bugs.webkit.org/show_bug.cgi?id=160087
+
+ Reviewed by Darin Adler.
+
+ Add layout test coverage for SVGSVGElement.getElementById().
+
+ * svg/dom/SVGSVGElement-getElementById-expected.txt: Added.
+ * svg/dom/SVGSVGElement-getElementById.html: Added.
+
</ins><span class="cx"> 2016-07-22 Ryan Haddad <ryanhaddad@apple.com>
</span><span class="cx">
</span><span class="cx"> Correct a TestExpectation by changing it from Failure to ImageOnlyFailure
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/ChangeLog (203604 => 203605)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/ChangeLog 2016-07-22 18:34:56 UTC (rev 203604)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2016-07-22 18:39:47 UTC (rev 203605)
</span><span class="lines">@@ -1,5 +1,17 @@
</span><span class="cx"> 2016-07-22 Chris Dumez <cdumez@apple.com>
</span><span class="cx">
</span><ins>+ First parameter to getElementById() should be mandatory
+ https://bugs.webkit.org/show_bug.cgi?id=160087
+
+ Reviewed by Darin Adler.
+
+ Rebaseline several W3C tests now that more checks are passing.
+
+ * web-platform-tests/dom/interfaces-expected.txt:
+ * web-platform-tests/html/dom/interfaces-expected.txt:
+
+2016-07-22 Chris Dumez <cdumez@apple.com>
+
</ins><span class="cx"> Parameter to Node.lookupPrefix() / lookupNamespaceURI() / isDefaultNamespace() should be mandatory
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=160086
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestsdominterfacesexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/dom/interfaces-expected.txt (203604 => 203605)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/dom/interfaces-expected.txt 2016-07-22 18:34:56 UTC (rev 203604)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/dom/interfaces-expected.txt 2016-07-22 18:39:47 UTC (rev 203605)
</span><span class="lines">@@ -272,7 +272,7 @@
</span><span class="cx"> PASS Document interface: operation createRange()
</span><span class="cx"> PASS Document interface: operation createNodeIterator(Node,unsigned long,NodeFilter)
</span><span class="cx"> PASS Document interface: operation createTreeWalker(Node,unsigned long,NodeFilter)
</span><del>-FAIL Document interface: operation getElementById(DOMString) assert_equals: property has wrong .length expected 1 but got 0
</del><ins>+PASS Document interface: operation getElementById(DOMString)
</ins><span class="cx"> PASS Document interface: attribute children
</span><span class="cx"> PASS Document interface: attribute firstElementChild
</span><span class="cx"> PASS Document interface: attribute lastElementChild
</span><span class="lines">@@ -327,9 +327,7 @@
</span><span class="cx"> PASS Document interface: new Document() must inherit property "createTreeWalker" with the proper type (27)
</span><span class="cx"> PASS Document interface: calling createTreeWalker(Node,unsigned long,NodeFilter) on new Document() with too few arguments must throw TypeError
</span><span class="cx"> PASS Document interface: new Document() must inherit property "getElementById" with the proper type (28)
</span><del>-FAIL Document interface: calling getElementById(DOMString) on new Document() with too few arguments must throw TypeError assert_throws: Called with 0 arguments function "function () {
- fn.apply(obj, args);
- }" did not throw
</del><ins>+PASS Document interface: calling getElementById(DOMString) on new Document() with too few arguments must throw TypeError
</ins><span class="cx"> PASS Document interface: new Document() must inherit property "children" with the proper type (29)
</span><span class="cx"> PASS Document interface: new Document() must inherit property "firstElementChild" with the proper type (30)
</span><span class="cx"> PASS Document interface: new Document() must inherit property "lastElementChild" with the proper type (31)
</span><span class="lines">@@ -461,9 +459,7 @@
</span><span class="cx"> PASS Document interface: xmlDoc must inherit property "createTreeWalker" with the proper type (27)
</span><span class="cx"> PASS Document interface: calling createTreeWalker(Node,unsigned long,NodeFilter) on xmlDoc with too few arguments must throw TypeError
</span><span class="cx"> PASS Document interface: xmlDoc must inherit property "getElementById" with the proper type (28)
</span><del>-FAIL Document interface: calling getElementById(DOMString) on xmlDoc with too few arguments must throw TypeError assert_throws: Called with 0 arguments function "function () {
- fn.apply(obj, args);
- }" did not throw
</del><ins>+PASS Document interface: calling getElementById(DOMString) on xmlDoc with too few arguments must throw TypeError
</ins><span class="cx"> PASS Document interface: xmlDoc must inherit property "children" with the proper type (29)
</span><span class="cx"> PASS Document interface: xmlDoc must inherit property "firstElementChild" with the proper type (30)
</span><span class="cx"> PASS Document interface: xmlDoc must inherit property "lastElementChild" with the proper type (31)
</span><span class="lines">@@ -661,7 +657,7 @@
</span><span class="cx"> PASS DocumentFragment interface object name
</span><span class="cx"> PASS DocumentFragment interface: existence and properties of interface prototype object
</span><span class="cx"> PASS DocumentFragment interface: existence and properties of interface prototype object's "constructor" property
</span><del>-FAIL DocumentFragment interface: operation getElementById(DOMString) assert_equals: property has wrong .length expected 1 but got 0
</del><ins>+PASS DocumentFragment interface: operation getElementById(DOMString)
</ins><span class="cx"> PASS DocumentFragment interface: attribute children
</span><span class="cx"> PASS DocumentFragment interface: attribute firstElementChild
</span><span class="cx"> PASS DocumentFragment interface: attribute lastElementChild
</span><span class="lines">@@ -673,9 +669,7 @@
</span><span class="cx"> PASS DocumentFragment must be primary interface of document.createDocumentFragment()
</span><span class="cx"> PASS Stringification of document.createDocumentFragment()
</span><span class="cx"> PASS DocumentFragment interface: document.createDocumentFragment() must inherit property "getElementById" with the proper type (0)
</span><del>-FAIL DocumentFragment interface: calling getElementById(DOMString) on document.createDocumentFragment() with too few arguments must throw TypeError assert_throws: Called with 0 arguments function "function () {
- fn.apply(obj, args);
- }" did not throw
</del><ins>+PASS DocumentFragment interface: calling getElementById(DOMString) on document.createDocumentFragment() with too few arguments must throw TypeError
</ins><span class="cx"> PASS DocumentFragment interface: document.createDocumentFragment() must inherit property "children" with the proper type (1)
</span><span class="cx"> PASS DocumentFragment interface: document.createDocumentFragment() must inherit property "firstElementChild" with the proper type (2)
</span><span class="cx"> PASS DocumentFragment interface: document.createDocumentFragment() must inherit property "lastElementChild" with the proper type (3)
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestshtmldominterfacesexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt (203604 => 203605)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt 2016-07-22 18:34:56 UTC (rev 203604)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt 2016-07-22 18:39:47 UTC (rev 203605)
</span><span class="lines">@@ -244,9 +244,7 @@
</span><span class="cx"> PASS Document interface: iframe.contentDocument must inherit property "releaseEvents" with the proper type (80)
</span><span class="cx"> PASS Document interface: iframe.contentDocument must inherit property "all" with the proper type (81)
</span><span class="cx"> PASS Document interface: iframe.contentDocument must inherit property "getElementById" with the proper type (82)
</span><del>-FAIL Document interface: calling getElementById(DOMString) on iframe.contentDocument with too few arguments must throw TypeError assert_throws: Called with 0 arguments function "function () {
- fn.apply(obj, args);
- }" did not throw
</del><ins>+PASS Document interface: calling getElementById(DOMString) on iframe.contentDocument with too few arguments must throw TypeError
</ins><span class="cx"> PASS Document interface: iframe.contentDocument must inherit property "children" with the proper type (83)
</span><span class="cx"> PASS Document interface: iframe.contentDocument must inherit property "firstElementChild" with the proper type (84)
</span><span class="cx"> PASS Document interface: iframe.contentDocument must inherit property "lastElementChild" with the proper type (85)
</span><span class="lines">@@ -514,9 +512,7 @@
</span><span class="cx"> FAIL Document interface: new Document() must inherit property "releaseEvents" with the proper type (80) assert_inherits: property "releaseEvents" not found in prototype chain
</span><span class="cx"> FAIL Document interface: new Document() must inherit property "all" with the proper type (81) assert_inherits: property "all" not found in prototype chain
</span><span class="cx"> PASS Document interface: new Document() must inherit property "getElementById" with the proper type (82)
</span><del>-FAIL Document interface: calling getElementById(DOMString) on new Document() with too few arguments must throw TypeError assert_throws: Called with 0 arguments function "function () {
- fn.apply(obj, args);
- }" did not throw
</del><ins>+PASS Document interface: calling getElementById(DOMString) on new Document() with too few arguments must throw TypeError
</ins><span class="cx"> PASS Document interface: new Document() must inherit property "children" with the proper type (83)
</span><span class="cx"> PASS Document interface: new Document() must inherit property "firstElementChild" with the proper type (84)
</span><span class="cx"> PASS Document interface: new Document() must inherit property "lastElementChild" with the proper type (85)
</span><span class="lines">@@ -787,9 +783,7 @@
</span><span class="cx"> FAIL Document interface: document.implementation.createDocument(null, "", null) must inherit property "releaseEvents" with the proper type (80) assert_inherits: property "releaseEvents" not found in prototype chain
</span><span class="cx"> FAIL Document interface: document.implementation.createDocument(null, "", null) must inherit property "all" with the proper type (81) assert_inherits: property "all" not found in prototype chain
</span><span class="cx"> PASS Document interface: document.implementation.createDocument(null, "", null) must inherit property "getElementById" with the proper type (82)
</span><del>-FAIL Document interface: calling getElementById(DOMString) on document.implementation.createDocument(null, "", null) with too few arguments must throw TypeError assert_throws: Called with 0 arguments function "function () {
- fn.apply(obj, args);
- }" did not throw
</del><ins>+PASS Document interface: calling getElementById(DOMString) on document.implementation.createDocument(null, "", null) with too few arguments must throw TypeError
</ins><span class="cx"> PASS Document interface: document.implementation.createDocument(null, "", null) must inherit property "children" with the proper type (83)
</span><span class="cx"> PASS Document interface: document.implementation.createDocument(null, "", null) must inherit property "firstElementChild" with the proper type (84)
</span><span class="cx"> PASS Document interface: document.implementation.createDocument(null, "", null) must inherit property "lastElementChild" with the proper type (85)
</span></span></pre></div>
<a id="trunkLayoutTestssvgdomSVGSVGElementgetElementByIdexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/svg/dom/SVGSVGElement-getElementById-expected.txt (0 => 203605)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/svg/dom/SVGSVGElement-getElementById-expected.txt (rev 0)
+++ trunk/LayoutTests/svg/dom/SVGSVGElement-getElementById-expected.txt 2016-07-22 18:39:47 UTC (rev 203605)
</span><span class="lines">@@ -0,0 +1,10 @@
</span><ins>+Tests that calling SVGSVGElement.getElementById() without parameter throws an exception.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS svg.getElementById() threw exception TypeError: Not enough arguments.
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
</ins></span></pre></div>
<a id="trunkLayoutTestssvgdomSVGSVGElementgetElementByIdhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/svg/dom/SVGSVGElement-getElementById.html (0 => 203605)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/svg/dom/SVGSVGElement-getElementById.html (rev 0)
+++ trunk/LayoutTests/svg/dom/SVGSVGElement-getElementById.html 2016-07-22 18:39:47 UTC (rev 203605)
</span><span class="lines">@@ -0,0 +1,13 @@
</span><ins>+<!DOCTYPE html>
+<html>
+<body>
+<script src="../../resources/js-test-pre.js"></script>
+<script>
+description("Tests that calling SVGSVGElement.getElementById() without parameter throws an exception.");
+
+var svg = document.createElementNS("http://www.w3.org/2000/svg", "svg");
+shouldThrow("svg.getElementById()", "'TypeError: Not enough arguments'");
+</script>
+<script src="../../resources/js-test-post.js"></script>
+</body>
+</html>
</ins></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (203604 => 203605)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-07-22 18:34:56 UTC (rev 203604)
+++ trunk/Source/WebCore/ChangeLog 2016-07-22 18:39:47 UTC (rev 203605)
</span><span class="lines">@@ -1,5 +1,23 @@
</span><span class="cx"> 2016-07-22 Chris Dumez <cdumez@apple.com>
</span><span class="cx">
</span><ins>+ First parameter to getElementById() should be mandatory
+ https://bugs.webkit.org/show_bug.cgi?id=160087
+
+ Reviewed by Darin Adler.
+
+ First parameter to getElementById() should be mandatory:
+ - https://dom.spec.whatwg.org/#nonelementparentnode
+ - https://www.w3.org/TR/SVG/struct.html#InterfaceSVGSVGElement
+
+ Both Firefox and Chrome agree with the specification.
+
+ Test: svg/dom/SVGSVGElement-getElementById.html
+
+ * dom/NonElementParentNode.idl:
+ * svg/SVGSVGElement.idl:
+
+2016-07-22 Chris Dumez <cdumez@apple.com>
+
</ins><span class="cx"> Parameter to Node.lookupPrefix() / lookupNamespaceURI() / isDefaultNamespace() should be mandatory
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=160086
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoredomNonElementParentNodeidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/NonElementParentNode.idl (203604 => 203605)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/NonElementParentNode.idl 2016-07-22 18:34:56 UTC (rev 203604)
+++ trunk/Source/WebCore/dom/NonElementParentNode.idl 2016-07-22 18:39:47 UTC (rev 203605)
</span><span class="lines">@@ -28,6 +28,5 @@
</span><span class="cx"> [
</span><span class="cx"> NoInterfaceObject,
</span><span class="cx"> ] interface NonElementParentNode {
</span><del>- // FIXME: Using "undefined" as default parameter value is wrong.
- Element getElementById([ObjCExplicitAtomicString,RequiresExistingAtomicString] optional DOMString elementId = "undefined");
</del><ins>+ Element getElementById([ObjCExplicitAtomicString,RequiresExistingAtomicString] DOMString elementId);
</ins><span class="cx"> };
</span></span></pre></div>
<a id="trunkSourceWebCoresvgSVGSVGElementidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/svg/SVGSVGElement.idl (203604 => 203605)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/svg/SVGSVGElement.idl 2016-07-22 18:34:56 UTC (rev 203604)
+++ trunk/Source/WebCore/svg/SVGSVGElement.idl 2016-07-22 18:39:47 UTC (rev 203605)
</span><span class="lines">@@ -71,8 +71,7 @@
</span><span class="cx"> SVGTransform createSVGTransform();
</span><span class="cx"> SVGTransform createSVGTransformFromMatrix(SVGMatrix matrix);
</span><span class="cx">
</span><del>- // FIXME: Using "undefined" as default parameter value is wrong.
- Element getElementById([RequiresExistingAtomicString] optional DOMString elementId = "undefined");
</del><ins>+ Element getElementById([RequiresExistingAtomicString] DOMString elementId);
</ins><span class="cx"> };
</span><span class="cx">
</span><span class="cx"> SVGSVGElement implements SVGExternalResourcesRequired;
</span></span></pre>
</div>
</div>
</body>
</html>