<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[203614] trunk/LayoutTests</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/203614">203614</a></dd>
<dt>Author</dt> <dd>mattbaker@apple.com</dd>
<dt>Date</dt> <dd>2016-07-22 13:36:31 -0700 (Fri, 22 Jul 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Web Inspector: Remove unused code from Debounce layout test
https://bugs.webkit.org/show_bug.cgi?id=160049
<rdar://problem/27479713>
Reviewed by Joseph Pecoraro.
* inspector/unit-tests/debounce-expected.txt:
Updated with new delay times.
* inspector/unit-tests/debounce.html:
Remove unused code that was copy-pasted from other tests, and reduced
delay times from 100ms to 10ms to speed up test.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsinspectorunittestsdebounceexpectedtxt">trunk/LayoutTests/inspector/unit-tests/debounce-expected.txt</a></li>
<li><a href="#trunkLayoutTestsinspectorunittestsdebouncehtml">trunk/LayoutTests/inspector/unit-tests/debounce.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (203613 => 203614)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2016-07-22 20:35:07 UTC (rev 203613)
+++ trunk/LayoutTests/ChangeLog 2016-07-22 20:36:31 UTC (rev 203614)
</span><span class="lines">@@ -1,3 +1,18 @@
</span><ins>+2016-07-22 Matt Baker <mattbaker@apple.com>
+
+ Web Inspector: Remove unused code from Debounce layout test
+ https://bugs.webkit.org/show_bug.cgi?id=160049
+ <rdar://problem/27479713>
+
+ Reviewed by Joseph Pecoraro.
+
+ * inspector/unit-tests/debounce-expected.txt:
+ Updated with new delay times.
+
+ * inspector/unit-tests/debounce.html:
+ Remove unused code that was copy-pasted from other tests, and reduced
+ delay times from 100ms to 10ms to speed up test.
+
</ins><span class="cx"> 2016-07-22 Chris Dumez <cdumez@apple.com>
</span><span class="cx">
</span><span class="cx"> Fix default parameter values for window.alert() / prompt() / confirm()
</span></span></pre></div>
<a id="trunkLayoutTestsinspectorunittestsdebounceexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/inspector/unit-tests/debounce-expected.txt (203613 => 203614)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/inspector/unit-tests/debounce-expected.txt 2016-07-22 20:35:07 UTC (rev 203613)
+++ trunk/LayoutTests/inspector/unit-tests/debounce-expected.txt 2016-07-22 20:36:31 UTC (rev 203614)
</span><span class="lines">@@ -4,7 +4,7 @@
</span><span class="cx"> == Running test suite: Debouce
</span><span class="cx"> -- Running test case: Basic Debounce
</span><span class="cx"> PASS: Debounced successfully.
</span><del>-PASS: Call delayed at least 100ms.
</del><ins>+PASS: Call delayed at least 10ms.
</ins><span class="cx"> PASS: `this` is the right object.
</span><span class="cx"> PASS: Arguments length is 2.
</span><span class="cx"> PASS: First argument is 4.
</span><span class="lines">@@ -12,7 +12,7 @@
</span><span class="cx">
</span><span class="cx"> -- Running test case: Multiple Debounce Delays
</span><span class="cx"> PASS: Debounced successfully.
</span><del>-PASS: Call delayed at least 400ms.
</del><ins>+PASS: Call delayed at least 40ms.
</ins><span class="cx"> PASS: `this` is the right object.
</span><span class="cx"> PASS: Arguments length is 2.
</span><span class="cx"> PASS: First argument is 4.
</span></span></pre></div>
<a id="trunkLayoutTestsinspectorunittestsdebouncehtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/inspector/unit-tests/debounce.html (203613 => 203614)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/inspector/unit-tests/debounce.html 2016-07-22 20:35:07 UTC (rev 203613)
+++ trunk/LayoutTests/inspector/unit-tests/debounce.html 2016-07-22 20:36:31 UTC (rev 203614)
</span><span class="lines">@@ -20,7 +20,7 @@
</span><span class="cx"> else
</span><span class="cx"> InspectorTest.fail("Debounced function called multiple times.");
</span><span class="cx">
</span><del>- InspectorTest.expectThat(performance.now() - startTime >= 100, "Call delayed at least 100ms.");
</del><ins>+ InspectorTest.expectThat(performance.now() - startTime >= 10, "Call delayed at least 10ms.");
</ins><span class="cx">
</span><span class="cx"> InspectorTest.expectThat(this === object, "`this` is the right object.");
</span><span class="cx"> InspectorTest.expectThat(arguments.length === 2, "Arguments length is 2.");
</span><span class="lines">@@ -31,7 +31,7 @@
</span><span class="cx"> }
</span><span class="cx"> };
</span><span class="cx">
</span><del>- let debounceProxy = object.debounce(100);
</del><ins>+ let debounceProxy = object.debounce(10);
</ins><span class="cx"> debounceProxy.test(1, 'xyz');
</span><span class="cx"> debounceProxy.test(2, 'fgh');
</span><span class="cx"> debounceProxy.test(3, 'ert');
</span><span class="lines">@@ -58,7 +58,7 @@
</span><span class="cx"> else
</span><span class="cx"> InspectorTest.fail("Debounced function called multiple times.");
</span><span class="cx">
</span><del>- InspectorTest.expectThat(performance.now() - startTime >= 400, "Call delayed at least 400ms.");
</del><ins>+ InspectorTest.expectThat(performance.now() - startTime >= 40, "Call delayed at least 40ms.");
</ins><span class="cx">
</span><span class="cx"> InspectorTest.expectThat(this === object, "`this` is the right object.");
</span><span class="cx"> InspectorTest.expectThat(arguments.length === 2, "Arguments length is 2.");
</span><span class="lines">@@ -69,10 +69,10 @@
</span><span class="cx"> }
</span><span class="cx"> };
</span><span class="cx">
</span><del>- object.debounce(100).test(1, 'xyz');
- object.debounce(200).test(2, 'fgh');
- object.debounce(300).test(3, 'ert');
- object.debounce(400).test(4, 'abc');
</del><ins>+ object.debounce(10).test(1, 'xyz');
+ object.debounce(20).test(2, 'fgh');
+ object.debounce(30).test(3, 'ert');
+ object.debounce(40).test(4, 'abc');
</ins><span class="cx">
</span><span class="cx"> if (!callCount)
</span><span class="cx"> return;
</span><span class="lines">@@ -119,26 +119,17 @@
</span><span class="cx"> suite.addTestCase({
</span><span class="cx"> name: "Cancel Debounce",
</span><span class="cx"> test: function(resolve, reject) {
</span><del>- let callCount = 0;
- let startTime = performance.now();
-
</del><span class="cx"> let object = {
</span><del>- test(foo, bar) {
</del><ins>+ test() {
</ins><span class="cx"> InspectorTest.fail("Debounced function call should have been canceled.");
</span><span class="cx"> resolve();
</span><span class="cx"> }
</span><span class="cx"> };
</span><span class="cx">
</span><del>- object.debounce(100).test(1, 'xyz');
</del><ins>+ object.debounce(10).test();
</ins><span class="cx"> object.test.cancelDebounce();
</span><span class="cx">
</span><del>- setTimeout(() => { InspectorTest.pass("Debounced function canceled."); resolve(); }, 200);
-
- if (!callCount)
- return;
-
- InspectorTest.fail("Debounced function called immediately.");
- resolve();
</del><ins>+ setTimeout(() => { InspectorTest.pass("Debounced function canceled."); resolve(); }, 20);
</ins><span class="cx"> }
</span><span class="cx"> });
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>