<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[203624] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/203624">203624</a></dd>
<dt>Author</dt> <dd>cdumez@apple.com</dd>
<dt>Date</dt> <dd>2016-07-22 16:13:40 -0700 (Fri, 22 Jul 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Parameter to HTMLCollection.item() / namedItem() should be mandatory
https://bugs.webkit.org/show_bug.cgi?id=160099
Reviewed by Sam Weinig.
LayoutTests/imported/w3c:
Rebaseline several W3C tests now that more checks are passing.
* web-platform-tests/dom/interfaces-expected.txt:
* web-platform-tests/html/dom/interfaces-expected.txt:
Source/WebCore:
Parameter to HTMLCollection.item() / namedItem() should be mandatory:
- https://dom.spec.whatwg.org/#interface-htmlcollection
- https://html.spec.whatwg.org/multipage/infrastructure.html#htmlformcontrolscollection
- https://html.spec.whatwg.org/multipage/infrastructure.html#the-htmloptionscollection-interface
Firefox and Chrome agree with the specification.
No new tests, rebaselined existing tests.
* bindings/js/JSHTMLFormControlsCollectionCustom.cpp:
(WebCore::JSHTMLFormControlsCollection::namedItem):
* html/HTMLCollection.idl:
* html/HTMLFormControlsCollection.idl:
* html/HTMLOptionsCollection.idl:
LayoutTests:
Update existing test to reflect behavior change.
* fast/dom/non-numeric-values-numeric-parameters-expected.txt:
* fast/dom/script-tests/non-numeric-values-numeric-parameters.js:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsfastdomnonnumericvaluesnumericparametersexpectedtxt">trunk/LayoutTests/fast/dom/non-numeric-values-numeric-parameters-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastdomscripttestsnonnumericvaluesnumericparametersjs">trunk/LayoutTests/fast/dom/script-tests/non-numeric-values-numeric-parameters.js</a></li>
<li><a href="#trunkLayoutTestsimportedw3cChangeLog">trunk/LayoutTests/imported/w3c/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestsdominterfacesexpectedtxt">trunk/LayoutTests/imported/w3c/web-platform-tests/dom/interfaces-expected.txt</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestshtmldominterfacesexpectedtxt">trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorebindingsjsJSHTMLFormControlsCollectionCustomcpp">trunk/Source/WebCore/bindings/js/JSHTMLFormControlsCollectionCustom.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLCollectionidl">trunk/Source/WebCore/html/HTMLCollection.idl</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLFormControlsCollectionidl">trunk/Source/WebCore/html/HTMLFormControlsCollection.idl</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLOptionsCollectionidl">trunk/Source/WebCore/html/HTMLOptionsCollection.idl</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (203623 => 203624)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2016-07-22 22:56:15 UTC (rev 203623)
+++ trunk/LayoutTests/ChangeLog 2016-07-22 23:13:40 UTC (rev 203624)
</span><span class="lines">@@ -1,5 +1,17 @@
</span><span class="cx"> 2016-07-22 Chris Dumez <cdumez@apple.com>
</span><span class="cx">
</span><ins>+ Parameter to HTMLCollection.item() / namedItem() should be mandatory
+ https://bugs.webkit.org/show_bug.cgi?id=160099
+
+ Reviewed by Sam Weinig.
+
+ Update existing test to reflect behavior change.
+
+ * fast/dom/non-numeric-values-numeric-parameters-expected.txt:
+ * fast/dom/script-tests/non-numeric-values-numeric-parameters.js:
+
+2016-07-22 Chris Dumez <cdumez@apple.com>
+
</ins><span class="cx"> First parameter to Window.getComputedStyle() should be mandatory and non-nullable
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=160097
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsfastdomnonnumericvaluesnumericparametersexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/dom/non-numeric-values-numeric-parameters-expected.txt (203623 => 203624)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/dom/non-numeric-values-numeric-parameters-expected.txt 2016-07-22 22:56:15 UTC (rev 203623)
+++ trunk/LayoutTests/fast/dom/non-numeric-values-numeric-parameters-expected.txt 2016-07-22 23:13:40 UTC (rev 203624)
</span><span class="lines">@@ -25,7 +25,7 @@
</span><span class="cx"> PASS nonNumericPolicy('document.body.scrollByPages(x)') is 'any type allowed'
</span><span class="cx"> PASS nonNumericPolicy('document.body.scrollLeft = x') is 'any type allowed'
</span><span class="cx"> PASS nonNumericPolicy('document.body.scrollTop = x') is 'any type allowed'
</span><del>-PASS nonNumericPolicy('document.images.item(x)') is 'any type allowed'
</del><ins>+PASS nonNumericPolicy('document.images.item(x)') is 'any type allowed (but not omitted)'
</ins><span class="cx"> PASS nonNumericPolicy('document.createElement("input").setSelectionRange(x, 0)') is 'any type allowed'
</span><span class="cx"> PASS nonNumericPolicy('document.createElement("input").setSelectionRange(0, x)') is 'any type allowed'
</span><span class="cx"> PASS nonNumericPolicy('createHTMLOptionsCollection().add(document.createElement("option"), x)') is 'any type allowed'
</span><span class="lines">@@ -50,7 +50,7 @@
</span><span class="cx"> PASS nonNumericPolicy('document.createEvent("MouseEvent").initMouseEvent("a", false, false, null, 0, 0, 0, 0, 0, false, false, false, false, x, null)') is 'any type allowed'
</span><span class="cx"> PASS nonNumericPolicy('document.body.attributes.item(x)') is 'any type allowed'
</span><span class="cx"> PASS nonNumericPolicy('document.createNodeIterator(document, x, null, false)') is 'any type allowed'
</span><del>-FAIL nonNumericPolicy('document.getElementsByTagName("div").item(x)') should be any type allowed (but not omitted). Was any type allowed.
</del><ins>+PASS nonNumericPolicy('document.getElementsByTagName("div").item(x)') is 'any type allowed (but not omitted)'
</ins><span class="cx"> PASS nonNumericPolicy('document.createRange().setStart(document, x)') is 'any type allowed'
</span><span class="cx"> PASS nonNumericPolicy('document.createRange().setEnd(document, x)') is 'any type allowed'
</span><span class="cx"> PASS nonNumericPolicy('document.createRange().comparePoint(document, x)') is 'any type allowed'
</span></span></pre></div>
<a id="trunkLayoutTestsfastdomscripttestsnonnumericvaluesnumericparametersjs"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/dom/script-tests/non-numeric-values-numeric-parameters.js (203623 => 203624)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/dom/script-tests/non-numeric-values-numeric-parameters.js 2016-07-22 22:56:15 UTC (rev 203623)
+++ trunk/LayoutTests/fast/dom/script-tests/non-numeric-values-numeric-parameters.js 2016-07-22 23:13:40 UTC (rev 203624)
</span><span class="lines">@@ -235,7 +235,7 @@
</span><span class="cx">
</span><span class="cx"> // HTMLCollection
</span><span class="cx">
</span><del>-shouldBe("nonNumericPolicy('document.images.item(x)')", "'any type allowed'");
</del><ins>+shouldBe("nonNumericPolicy('document.images.item(x)')", "'any type allowed (but not omitted)'");
</ins><span class="cx">
</span><span class="cx"> // HTMLInputElement
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/ChangeLog (203623 => 203624)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/ChangeLog 2016-07-22 22:56:15 UTC (rev 203623)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2016-07-22 23:13:40 UTC (rev 203624)
</span><span class="lines">@@ -1,5 +1,17 @@
</span><span class="cx"> 2016-07-22 Chris Dumez <cdumez@apple.com>
</span><span class="cx">
</span><ins>+ Parameter to HTMLCollection.item() / namedItem() should be mandatory
+ https://bugs.webkit.org/show_bug.cgi?id=160099
+
+ Reviewed by Sam Weinig.
+
+ Rebaseline several W3C tests now that more checks are passing.
+
+ * web-platform-tests/dom/interfaces-expected.txt:
+ * web-platform-tests/html/dom/interfaces-expected.txt:
+
+2016-07-22 Chris Dumez <cdumez@apple.com>
+
</ins><span class="cx"> Parameters to Node.replaceChild() / insertBefore() should be mandatory
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=160091
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestsdominterfacesexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/dom/interfaces-expected.txt (203623 => 203624)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/dom/interfaces-expected.txt 2016-07-22 22:56:15 UTC (rev 203623)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/dom/interfaces-expected.txt 2016-07-22 23:13:40 UTC (rev 203624)
</span><span class="lines">@@ -135,19 +135,15 @@
</span><span class="cx"> PASS HTMLCollection interface: existence and properties of interface prototype object
</span><span class="cx"> PASS HTMLCollection interface: existence and properties of interface prototype object's "constructor" property
</span><span class="cx"> PASS HTMLCollection interface: attribute length
</span><del>-FAIL HTMLCollection interface: operation item(unsigned long) assert_equals: property has wrong .length expected 1 but got 0
-FAIL HTMLCollection interface: operation namedItem(DOMString) assert_equals: property has wrong .length expected 1 but got 0
</del><ins>+PASS HTMLCollection interface: operation item(unsigned long)
+PASS HTMLCollection interface: operation namedItem(DOMString)
</ins><span class="cx"> PASS HTMLCollection must be primary interface of document.body.children
</span><span class="cx"> PASS Stringification of document.body.children
</span><span class="cx"> PASS HTMLCollection interface: document.body.children must inherit property "length" with the proper type (0)
</span><span class="cx"> PASS HTMLCollection interface: document.body.children must inherit property "item" with the proper type (1)
</span><del>-FAIL HTMLCollection interface: calling item(unsigned long) on document.body.children with too few arguments must throw TypeError assert_throws: Called with 0 arguments function "function () {
- fn.apply(obj, args);
- }" did not throw
</del><ins>+PASS HTMLCollection interface: calling item(unsigned long) on document.body.children with too few arguments must throw TypeError
</ins><span class="cx"> PASS HTMLCollection interface: document.body.children must inherit property "namedItem" with the proper type (2)
</span><del>-FAIL HTMLCollection interface: calling namedItem(DOMString) on document.body.children with too few arguments must throw TypeError assert_throws: Called with 0 arguments function "function () {
- fn.apply(obj, args);
- }" did not throw
</del><ins>+PASS HTMLCollection interface: calling namedItem(DOMString) on document.body.children with too few arguments must throw TypeError
</ins><span class="cx"> PASS MutationObserver interface: existence and properties of interface object
</span><span class="cx"> PASS MutationObserver interface object length
</span><span class="cx"> PASS MutationObserver interface object name
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestshtmldominterfacesexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt (203623 => 203624)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt 2016-07-22 22:56:15 UTC (rev 203623)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt 2016-07-22 23:13:40 UTC (rev 203624)
</span><span class="lines">@@ -941,7 +941,7 @@
</span><span class="cx"> PASS HTMLFormControlsCollection interface object name
</span><span class="cx"> PASS HTMLFormControlsCollection interface: existence and properties of interface prototype object
</span><span class="cx"> PASS HTMLFormControlsCollection interface: existence and properties of interface prototype object's "constructor" property
</span><del>-FAIL HTMLFormControlsCollection interface: operation namedItem(DOMString) assert_equals: property has wrong .length expected 1 but got 0
</del><ins>+PASS HTMLFormControlsCollection interface: operation namedItem(DOMString)
</ins><span class="cx"> FAIL HTMLFormControlsCollection must be primary interface of document.createElement("form").elements assert_equals: wrong typeof object expected "function" but got "object"
</span><span class="cx"> FAIL Stringification of document.createElement("form").elements assert_equals: wrong typeof object expected "function" but got "object"
</span><span class="cx"> FAIL HTMLFormControlsCollection interface: document.createElement("form").elements must inherit property "namedItem" with the proper type (0) assert_equals: wrong typeof object expected "function" but got "object"
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (203623 => 203624)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-07-22 22:56:15 UTC (rev 203623)
+++ trunk/Source/WebCore/ChangeLog 2016-07-22 23:13:40 UTC (rev 203624)
</span><span class="lines">@@ -1,5 +1,27 @@
</span><span class="cx"> 2016-07-22 Chris Dumez <cdumez@apple.com>
</span><span class="cx">
</span><ins>+ Parameter to HTMLCollection.item() / namedItem() should be mandatory
+ https://bugs.webkit.org/show_bug.cgi?id=160099
+
+ Reviewed by Sam Weinig.
+
+ Parameter to HTMLCollection.item() / namedItem() should be mandatory:
+ - https://dom.spec.whatwg.org/#interface-htmlcollection
+ - https://html.spec.whatwg.org/multipage/infrastructure.html#htmlformcontrolscollection
+ - https://html.spec.whatwg.org/multipage/infrastructure.html#the-htmloptionscollection-interface
+
+ Firefox and Chrome agree with the specification.
+
+ No new tests, rebaselined existing tests.
+
+ * bindings/js/JSHTMLFormControlsCollectionCustom.cpp:
+ (WebCore::JSHTMLFormControlsCollection::namedItem):
+ * html/HTMLCollection.idl:
+ * html/HTMLFormControlsCollection.idl:
+ * html/HTMLOptionsCollection.idl:
+
+2016-07-22 Chris Dumez <cdumez@apple.com>
+
</ins><span class="cx"> First parameter to Window.getComputedStyle() should be mandatory and non-nullable
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=160097
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsjsJSHTMLFormControlsCollectionCustomcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/js/JSHTMLFormControlsCollectionCustom.cpp (203623 => 203624)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/js/JSHTMLFormControlsCollectionCustom.cpp 2016-07-22 22:56:15 UTC (rev 203623)
+++ trunk/Source/WebCore/bindings/js/JSHTMLFormControlsCollectionCustom.cpp 2016-07-22 23:13:40 UTC (rev 203624)
</span><span class="lines">@@ -56,7 +56,10 @@
</span><span class="cx">
</span><span class="cx"> JSValue JSHTMLFormControlsCollection::namedItem(ExecState& state)
</span><span class="cx"> {
</span><del>- JSValue value = namedItems(state, this, Identifier::fromString(&state, state.argument(0).toString(&state)->value(&state)));
</del><ins>+ if (UNLIKELY(state.argumentCount() < 1))
+ return state.vm().throwException(&state, createNotEnoughArgumentsError(&state));
+
+ JSValue value = namedItems(state, this, Identifier::fromString(&state, state.uncheckedArgument(0).toString(&state)->value(&state)));
</ins><span class="cx"> return value.isUndefined() ? jsNull() : value;
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLCollectionidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLCollection.idl (203623 => 203624)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLCollection.idl 2016-07-22 22:56:15 UTC (rev 203623)
+++ trunk/Source/WebCore/html/HTMLCollection.idl 2016-07-22 23:13:40 UTC (rev 203624)
</span><span class="lines">@@ -27,13 +27,11 @@
</span><span class="cx"> readonly attribute unsigned long length;
</span><span class="cx">
</span><span class="cx"> #if defined(LANGUAGE_OBJECTIVE_C) && LANGUAGE_OBJECTIVE_C || defined(LANGUAGE_GOBJECT) && LANGUAGE_GOBJECT
</span><del>- getter Node item(optional unsigned long index);
- getter Node namedItem(optional DOMString name);
</del><ins>+ getter Node item(unsigned long index);
+ getter Node namedItem(DOMString name);
</ins><span class="cx"> #else
</span><del>- getter Element item(optional unsigned long index = 0);
-
- // FIXME: Using "undefined" as default parameter value is wrong.
- getter Element namedItem(optional DOMString name = "undefined");
</del><ins>+ getter Element? item(unsigned long index);
+ getter Element? namedItem(DOMString name);
</ins><span class="cx"> #endif
</span><span class="cx">
</span><span class="cx"> #if defined(LANGUAGE_OBJECTIVE_C) && LANGUAGE_OBJECTIVE_C
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLFormControlsCollectionidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLFormControlsCollection.idl (203623 => 203624)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLFormControlsCollection.idl 2016-07-22 22:56:15 UTC (rev 203623)
+++ trunk/Source/WebCore/html/HTMLFormControlsCollection.idl 2016-07-22 23:13:40 UTC (rev 203624)
</span><span class="lines">@@ -21,6 +21,6 @@
</span><span class="cx"> [
</span><span class="cx"> GenerateIsReachable=ImplOwnerNodeRoot,
</span><span class="cx"> ] interface HTMLFormControlsCollection : HTMLCollection {
</span><del>- getter HTMLElement (optional unsigned long index = 0);
- [Custom] getter HTMLElement namedItem(optional DOMString name);
</del><ins>+ getter HTMLElement? (unsigned long index);
+ [Custom] getter HTMLElement? namedItem(DOMString name);
</ins><span class="cx"> };
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLOptionsCollectionidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLOptionsCollection.idl (203623 => 203624)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLOptionsCollection.idl 2016-07-22 22:56:15 UTC (rev 203623)
+++ trunk/Source/WebCore/html/HTMLOptionsCollection.idl 2016-07-22 23:13:40 UTC (rev 203624)
</span><span class="lines">@@ -30,9 +30,7 @@
</span><span class="cx"> getter Node namedItem(optional DOMString name);
</span><span class="cx"> #else
</span><span class="cx"> getter HTMLOptionElement? item(unsigned long index);
</span><del>-
- // FIXME: Using "undefined" as default parameter value is wrong.
- getter HTMLOptionElement namedItem(optional DOMString name = "undefined");
</del><ins>+ getter HTMLOptionElement? namedItem(DOMString name);
</ins><span class="cx"> #endif
</span><span class="cx">
</span><span class="cx"> #if (!defined(LANGUAGE_OBJECTIVE_C) || !LANGUAGE_OBJECTIVE_C) && (!defined(LANGUAGE_GOBJECT) || !LANGUAGE_GOBJECT)
</span></span></pre>
</div>
</div>
</body>
</html>