<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[203592] branches/safari-602-branch</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/203592">203592</a></dd>
<dt>Author</dt> <dd>bshafiei@apple.com</dd>
<dt>Date</dt> <dd>2016-07-22 02:38:59 -0700 (Fri, 22 Jul 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Merge <a href="http://trac.webkit.org/projects/webkit/changeset/203545">r203545</a>. rdar://problem/26964090</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#branchessafari602branchSourceWebCoreChangeLog">branches/safari-602-branch/Source/WebCore/ChangeLog</a></li>
<li><a href="#branchessafari602branchSourceWebCorepageSettingscpp">branches/safari-602-branch/Source/WebCore/page/Settings.cpp</a></li>
<li><a href="#branchessafari602branchSourceWebCorepageSettingsin">branches/safari-602-branch/Source/WebCore/page/Settings.in</a></li>
<li><a href="#branchessafari602branchSourceWebCoretestingInternalSettingscpp">branches/safari-602-branch/Source/WebCore/testing/InternalSettings.cpp</a></li>
<li><a href="#branchessafari602branchSourceWebCoretestingInternalSettingsh">branches/safari-602-branch/Source/WebCore/testing/InternalSettings.h</a></li>
<li><a href="#branchessafari602branchSourceWebCoretestingInternalSettingsidl">branches/safari-602-branch/Source/WebCore/testing/InternalSettings.idl</a></li>
<li><a href="#branchessafari602branchSourceWebKitmacChangeLog">branches/safari-602-branch/Source/WebKit/mac/ChangeLog</a></li>
<li><a href="#branchessafari602branchSourceWebKitmacWebViewWebPreferenceKeysPrivateh">branches/safari-602-branch/Source/WebKit/mac/WebView/WebPreferenceKeysPrivate.h</a></li>
<li><a href="#branchessafari602branchSourceWebKitmacWebViewWebPreferencesmm">branches/safari-602-branch/Source/WebKit/mac/WebView/WebPreferences.mm</a></li>
<li><a href="#branchessafari602branchSourceWebKitmacWebViewWebPreferencesPrivateh">branches/safari-602-branch/Source/WebKit/mac/WebView/WebPreferencesPrivate.h</a></li>
<li><a href="#branchessafari602branchSourceWebKitmacWebViewWebViewmm">branches/safari-602-branch/Source/WebKit/mac/WebView/WebView.mm</a></li>
<li><a href="#branchessafari602branchSourceWebKit2ChangeLog">branches/safari-602-branch/Source/WebKit2/ChangeLog</a></li>
<li><a href="#branchessafari602branchSourceWebKit2SharedWebPreferencesDefinitionsh">branches/safari-602-branch/Source/WebKit2/Shared/WebPreferencesDefinitions.h</a></li>
<li><a href="#branchessafari602branchSourceWebKit2UIProcessAPICWKPreferencescpp">branches/safari-602-branch/Source/WebKit2/UIProcess/API/C/WKPreferences.cpp</a></li>
<li><a href="#branchessafari602branchSourceWebKit2UIProcessAPICWKPreferencesRefPrivateh">branches/safari-602-branch/Source/WebKit2/UIProcess/API/C/WKPreferencesRefPrivate.h</a></li>
<li><a href="#branchessafari602branchSourceWebKit2UIProcessAPICocoaWKWebViewmm">branches/safari-602-branch/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm</a></li>
<li><a href="#branchessafari602branchSourceWebKit2UIProcessAPICocoaWKWebViewConfigurationmm">branches/safari-602-branch/Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfiguration.mm</a></li>
<li><a href="#branchessafari602branchSourceWebKit2UIProcessAPICocoaWKWebViewConfigurationPrivateh">branches/safari-602-branch/Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h</a></li>
<li><a href="#branchessafari602branchSourceWebKit2WebProcessWebPageWebPagecpp">branches/safari-602-branch/Source/WebKit2/WebProcess/WebPage/WebPage.cpp</a></li>
<li><a href="#branchessafari602branchToolsChangeLog">branches/safari-602-branch/Tools/ChangeLog</a></li>
<li><a href="#branchessafari602branchToolsDumpRenderTreemacDumpRenderTreemm">branches/safari-602-branch/Tools/DumpRenderTree/mac/DumpRenderTree.mm</a></li>
<li><a href="#branchessafari602branchToolsTestWebKitAPITestsWebKit2CocoaRequiresUserActionForPlaybackmm">branches/safari-602-branch/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm</a></li>
<li><a href="#branchessafari602branchToolsWebKitTestRunnerTestControllercpp">branches/safari-602-branch/Tools/WebKitTestRunner/TestController.cpp</a></li>
<li><a href="#branchessafari602branchToolsWebKitTestRunnercocoaTestControllerCocoamm">branches/safari-602-branch/Tools/WebKitTestRunner/cocoa/TestControllerCocoa.mm</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="branchessafari602branchSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: branches/safari-602-branch/Source/WebCore/ChangeLog (203591 => 203592)</h4>
<pre class="diff"><span>
<span class="info">--- branches/safari-602-branch/Source/WebCore/ChangeLog 2016-07-22 09:38:51 UTC (rev 203591)
+++ branches/safari-602-branch/Source/WebCore/ChangeLog 2016-07-22 09:38:59 UTC (rev 203592)
</span><span class="lines">@@ -1,5 +1,33 @@
</span><span class="cx"> 2016-07-22 Babak Shafiei <bshafiei@apple.com>
</span><span class="cx">
</span><ins>+ Merge r203545. rdar://problem/26964090
+
+ 2016-07-21 Myles C. Maxfield <mmaxfield@apple.com>
+
+ Remove support for deprecated SPI inlineMediaPlaybackRequiresPlaysInlineAttribute
+ https://bugs.webkit.org/show_bug.cgi?id=160066
+
+ Reviewed by Dean Jackson.
+
+ r203520 deprecated inlineMediaPlaybackRequiresPlaysInlineAttribute in favor of
+ allowsInlineMediaPlaybackWithPlaysInlineAttribute and
+ allowsInlineMediaPlaybackWithWebKitPlaysInlineAttribute. The old
+ inlineMediaPlaybackRequiresPlaysInlineAttribute is SPI and was never released
+ to the public. Therefore, it can be removed safely.
+
+ No new tests because there is no behavior change.
+
+ * page/Settings.cpp:
+ * page/Settings.in:
+ * testing/InternalSettings.cpp:
+ (WebCore::InternalSettings::Backup::Backup): Deleted.
+ (WebCore::InternalSettings::Backup::restoreTo): Deleted.
+ (WebCore::InternalSettings::setInlineMediaPlaybackRequiresPlaysInlineAttribute): Deleted.
+ * testing/InternalSettings.h:
+ * testing/InternalSettings.idl:
+
+2016-07-22 Babak Shafiei <bshafiei@apple.com>
+
</ins><span class="cx"> Merge r203520. rdar://problem/26964090
</span><span class="cx">
</span><span class="cx"> 2016-07-21 Myles C. Maxfield <mmaxfield@apple.com>
</span></span></pre></div>
<a id="branchessafari602branchSourceWebCorepageSettingscpp"></a>
<div class="modfile"><h4>Modified: branches/safari-602-branch/Source/WebCore/page/Settings.cpp (203591 => 203592)</h4>
<pre class="diff"><span>
<span class="info">--- branches/safari-602-branch/Source/WebCore/page/Settings.cpp 2016-07-22 09:38:51 UTC (rev 203591)
+++ branches/safari-602-branch/Source/WebCore/page/Settings.cpp 2016-07-22 09:38:59 UTC (rev 203592)
</span><span class="lines">@@ -138,7 +138,6 @@
</span><span class="cx"> static const bool defaultFixedBackgroundsPaintRelativeToDocument = true;
</span><span class="cx"> static const bool defaultAcceleratedCompositingForFixedPositionEnabled = true;
</span><span class="cx"> static const bool defaultAllowsInlineMediaPlayback = false;
</span><del>-static const bool defaultInlineMediaPlaybackRequiresPlaysInlineAttribute = true;
</del><span class="cx"> static const bool defaultAllowsInlineMediaPlaybackWithPlaysInlineAttribute = true;
</span><span class="cx"> static const bool defaultAllowsInlineMediaPlaybackWithWebKitPlaysInlineAttribute = true;
</span><span class="cx"> static const bool defaultVideoPlaybackRequiresUserGesture = true;
</span><span class="lines">@@ -153,7 +152,6 @@
</span><span class="cx"> static const bool defaultFixedBackgroundsPaintRelativeToDocument = false;
</span><span class="cx"> static const bool defaultAcceleratedCompositingForFixedPositionEnabled = false;
</span><span class="cx"> static const bool defaultAllowsInlineMediaPlayback = true;
</span><del>-static const bool defaultInlineMediaPlaybackRequiresPlaysInlineAttribute = false;
</del><span class="cx"> static const bool defaultAllowsInlineMediaPlaybackWithPlaysInlineAttribute = false;
</span><span class="cx"> static const bool defaultAllowsInlineMediaPlaybackWithWebKitPlaysInlineAttribute = false;
</span><span class="cx"> static const bool defaultVideoPlaybackRequiresUserGesture = false;
</span></span></pre></div>
<a id="branchessafari602branchSourceWebCorepageSettingsin"></a>
<div class="modfile"><h4>Modified: branches/safari-602-branch/Source/WebCore/page/Settings.in (203591 => 203592)</h4>
<pre class="diff"><span>
<span class="info">--- branches/safari-602-branch/Source/WebCore/page/Settings.in 2016-07-22 09:38:51 UTC (rev 203591)
+++ branches/safari-602-branch/Source/WebCore/page/Settings.in 2016-07-22 09:38:59 UTC (rev 203592)
</span><span class="lines">@@ -131,7 +131,6 @@
</span><span class="cx"> mainContentUserGestureOverrideEnabled initial=false
</span><span class="cx"> allowsInlineMediaPlayback initial=defaultAllowsInlineMediaPlayback
</span><span class="cx"> allowsInlineMediaPlaybackAfterFullscreen initial=true
</span><del>-inlineMediaPlaybackRequiresPlaysInlineAttribute initial=defaultInlineMediaPlaybackRequiresPlaysInlineAttribute
</del><span class="cx"> allowsInlineMediaPlaybackWithPlaysInlineAttribute initial=defaultAllowsInlineMediaPlaybackWithPlaysInlineAttribute
</span><span class="cx"> allowsInlineMediaPlaybackWithWebKitPlaysInlineAttribute initial=defaultAllowsInlineMediaPlaybackWithWebKitPlaysInlineAttribute
</span><span class="cx"> allowsPictureInPictureMediaPlayback initial=defaultAllowsPictureInPictureMediaPlayback
</span></span></pre></div>
<a id="branchessafari602branchSourceWebCoretestingInternalSettingscpp"></a>
<div class="modfile"><h4>Modified: branches/safari-602-branch/Source/WebCore/testing/InternalSettings.cpp (203591 => 203592)</h4>
<pre class="diff"><span>
<span class="info">--- branches/safari-602-branch/Source/WebCore/testing/InternalSettings.cpp 2016-07-22 09:38:51 UTC (rev 203591)
+++ branches/safari-602-branch/Source/WebCore/testing/InternalSettings.cpp 2016-07-22 09:38:59 UTC (rev 203592)
</span><span class="lines">@@ -106,7 +106,6 @@
</span><span class="cx"> #endif
</span><span class="cx"> , m_allowsInlineMediaPlayback(settings.allowsInlineMediaPlayback())
</span><span class="cx"> , m_allowsInlineMediaPlaybackAfterFullscreen(settings.allowsInlineMediaPlaybackAfterFullscreen())
</span><del>- , m_inlineMediaPlaybackRequiresPlaysInlineAttribute(settings.inlineMediaPlaybackRequiresPlaysInlineAttribute())
</del><span class="cx"> , m_allowsInlineMediaPlaybackWithPlaysInlineAttribute(settings.allowsInlineMediaPlaybackWithPlaysInlineAttribute())
</span><span class="cx"> , m_allowsInlineMediaPlaybackWithWebKitPlaysInlineAttribute(settings.allowsInlineMediaPlaybackWithWebKitPlaysInlineAttribute())
</span><span class="cx"> #if ENABLE(INDEXED_DATABASE_IN_WORKERS)
</span><span class="lines">@@ -183,7 +182,6 @@
</span><span class="cx"> #endif
</span><span class="cx"> settings.setAllowsInlineMediaPlayback(m_allowsInlineMediaPlayback);
</span><span class="cx"> settings.setAllowsInlineMediaPlaybackAfterFullscreen(m_allowsInlineMediaPlaybackAfterFullscreen);
</span><del>- settings.setInlineMediaPlaybackRequiresPlaysInlineAttribute(m_inlineMediaPlaybackRequiresPlaysInlineAttribute);
</del><span class="cx"> settings.setAllowsInlineMediaPlaybackWithPlaysInlineAttribute(m_allowsInlineMediaPlaybackWithPlaysInlineAttribute);
</span><span class="cx"> settings.setAllowsInlineMediaPlaybackWithWebKitPlaysInlineAttribute(m_allowsInlineMediaPlaybackWithWebKitPlaysInlineAttribute);
</span><span class="cx"> RuntimeEnabledFeatures::sharedFeatures().setPluginReplacementEnabled(m_pluginReplacementEnabled);
</span><span class="lines">@@ -570,12 +568,6 @@
</span><span class="cx"> settings()->setAllowsInlineMediaPlaybackAfterFullscreen(allows);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void InternalSettings::setInlineMediaPlaybackRequiresPlaysInlineAttribute(bool requires, ExceptionCode& ec)
-{
- InternalSettingsGuardForSettings();
- settings()->setInlineMediaPlaybackRequiresPlaysInlineAttribute(requires);
-}
-
</del><span class="cx"> void InternalSettings::setAllowsInlineMediaPlaybackWithPlaysInlineAttribute(bool requires, ExceptionCode& ec)
</span><span class="cx"> {
</span><span class="cx"> InternalSettingsGuardForSettings();
</span></span></pre></div>
<a id="branchessafari602branchSourceWebCoretestingInternalSettingsh"></a>
<div class="modfile"><h4>Modified: branches/safari-602-branch/Source/WebCore/testing/InternalSettings.h (203591 => 203592)</h4>
<pre class="diff"><span>
<span class="info">--- branches/safari-602-branch/Source/WebCore/testing/InternalSettings.h 2016-07-22 09:38:51 UTC (rev 203591)
+++ branches/safari-602-branch/Source/WebCore/testing/InternalSettings.h 2016-07-22 09:38:59 UTC (rev 203592)
</span><span class="lines">@@ -106,7 +106,6 @@
</span><span class="cx"> #endif
</span><span class="cx"> bool m_allowsInlineMediaPlayback;
</span><span class="cx"> bool m_allowsInlineMediaPlaybackAfterFullscreen;
</span><del>- bool m_inlineMediaPlaybackRequiresPlaysInlineAttribute;
</del><span class="cx"> bool m_allowsInlineMediaPlaybackWithPlaysInlineAttribute;
</span><span class="cx"> bool m_allowsInlineMediaPlaybackWithWebKitPlaysInlineAttribute;
</span><span class="cx"> #if ENABLE(INDEXED_DATABASE_IN_WORKERS)
</span><span class="lines">@@ -162,7 +161,6 @@
</span><span class="cx"> void setScrollingTreeIncludesFrames(bool, ExceptionCode&);
</span><span class="cx"> void setAllowsInlineMediaPlayback(bool, ExceptionCode&);
</span><span class="cx"> void setAllowsInlineMediaPlaybackAfterFullscreen(bool, ExceptionCode&);
</span><del>- void setInlineMediaPlaybackRequiresPlaysInlineAttribute(bool, ExceptionCode&);
</del><span class="cx"> void setAllowsInlineMediaPlaybackWithPlaysInlineAttribute(bool, ExceptionCode&);
</span><span class="cx"> void setAllowsInlineMediaPlaybackWithWebKitPlaysInlineAttribute(bool, ExceptionCode&);
</span><span class="cx"> void setIndexedDBWorkersEnabled(bool, ExceptionCode&);
</span></span></pre></div>
<a id="branchessafari602branchSourceWebCoretestingInternalSettingsidl"></a>
<div class="modfile"><h4>Modified: branches/safari-602-branch/Source/WebCore/testing/InternalSettings.idl (203591 => 203592)</h4>
<pre class="diff"><span>
<span class="info">--- branches/safari-602-branch/Source/WebCore/testing/InternalSettings.idl 2016-07-22 09:38:51 UTC (rev 203591)
+++ branches/safari-602-branch/Source/WebCore/testing/InternalSettings.idl 2016-07-22 09:38:59 UTC (rev 203592)
</span><span class="lines">@@ -76,7 +76,6 @@
</span><span class="cx"> [RaisesException] void setMinimumTimerInterval(unrestricted double intervalInSeconds);
</span><span class="cx"> [RaisesException] void setAllowsInlineMediaPlayback(boolean allows);
</span><span class="cx"> [RaisesException] void setAllowsInlineMediaPlaybackAfterFullscreen(boolean allows);
</span><del>- [RaisesException] void setInlineMediaPlaybackRequiresPlaysInlineAttribute(boolean requires);
</del><span class="cx"> [RaisesException] void setAllowsInlineMediaPlaybackWithPlaysInlineAttribute(boolean requires);
</span><span class="cx"> [RaisesException] void setAllowsInlineMediaPlaybackWithWebKitPlaysInlineAttribute(boolean requires);
</span><span class="cx">
</span></span></pre></div>
<a id="branchessafari602branchSourceWebKitmacChangeLog"></a>
<div class="modfile"><h4>Modified: branches/safari-602-branch/Source/WebKit/mac/ChangeLog (203591 => 203592)</h4>
<pre class="diff"><span>
<span class="info">--- branches/safari-602-branch/Source/WebKit/mac/ChangeLog 2016-07-22 09:38:51 UTC (rev 203591)
+++ branches/safari-602-branch/Source/WebKit/mac/ChangeLog 2016-07-22 09:38:59 UTC (rev 203592)
</span><span class="lines">@@ -1,5 +1,25 @@
</span><span class="cx"> 2016-07-22 Babak Shafiei <bshafiei@apple.com>
</span><span class="cx">
</span><ins>+ Merge r203545. rdar://problem/26964090
+
+ 2016-07-21 Myles C. Maxfield <mmaxfield@apple.com>
+
+ Remove support for deprecated SPI inlineMediaPlaybackRequiresPlaysInlineAttribute
+ https://bugs.webkit.org/show_bug.cgi?id=160066
+
+ Reviewed by Dean Jackson.
+
+ * WebView/WebPreferenceKeysPrivate.h:
+ * WebView/WebPreferences.mm:
+ (+[WebPreferences initialize]): Deleted.
+ (-[WebPreferences inlineMediaPlaybackRequiresPlaysInlineAttribute]): Deleted.
+ (-[WebPreferences setInlineMediaPlaybackRequiresPlaysInlineAttribute:]): Deleted.
+ * WebView/WebPreferencesPrivate.h:
+ * WebView/WebView.mm:
+ (-[WebView _preferencesChanged:]): Deleted.
+
+2016-07-22 Babak Shafiei <bshafiei@apple.com>
+
</ins><span class="cx"> Merge r203520. rdar://problem/26964090
</span><span class="cx">
</span><span class="cx"> 2016-07-21 Myles C. Maxfield <mmaxfield@apple.com>
</span></span></pre></div>
<a id="branchessafari602branchSourceWebKitmacWebViewWebPreferenceKeysPrivateh"></a>
<div class="modfile"><h4>Modified: branches/safari-602-branch/Source/WebKit/mac/WebView/WebPreferenceKeysPrivate.h (203591 => 203592)</h4>
<pre class="diff"><span>
<span class="info">--- branches/safari-602-branch/Source/WebKit/mac/WebView/WebPreferenceKeysPrivate.h 2016-07-22 09:38:51 UTC (rev 203591)
+++ branches/safari-602-branch/Source/WebKit/mac/WebView/WebPreferenceKeysPrivate.h 2016-07-22 09:38:59 UTC (rev 203592)
</span><span class="lines">@@ -126,7 +126,6 @@
</span><span class="cx"> #define WebKitMainContentUserGestureOverrideEnabledPreferenceKey @"WebKitMainContentUserGestureOverrideEnabled"
</span><span class="cx"> #define WebKitAllowsInlineMediaPlaybackPreferenceKey @"WebKitMediaPlaybackAllowsInline"
</span><span class="cx"> #define WebKitAllowsInlineMediaPlaybackAfterFullscreenPreferenceKey @"WebKitAllowsInlineMediaPlaybackAfterFullscreen"
</span><del>-#define WebKitInlineMediaPlaybackRequiresPlaysInlineAttributeKey @"InlineMediaPlaybackRequiresPlaysInlineAttribute"
</del><span class="cx"> #define WebKitAllowsInlineMediaPlaybackWithPlaysInlineAttributeKey @"AllowsInlineMediaPlaybackWithPlaysInlineAttribute"
</span><span class="cx"> #define WebKitAllowsInlineMediaPlaybackWithWebKitPlaysInlineAttributeKey @"AllowsInlineMediaPlaybackWithWebKitPlaysInlineAttribute"
</span><span class="cx"> #define WebKitInvisibleAutoplayNotPermittedKey @"InvisibleAutoplayNotPermitted"
</span></span></pre></div>
<a id="branchessafari602branchSourceWebKitmacWebViewWebPreferencesmm"></a>
<div class="modfile"><h4>Modified: branches/safari-602-branch/Source/WebKit/mac/WebView/WebPreferences.mm (203591 => 203592)</h4>
<pre class="diff"><span>
<span class="info">--- branches/safari-602-branch/Source/WebKit/mac/WebView/WebPreferences.mm 2016-07-22 09:38:51 UTC (rev 203591)
+++ branches/safari-602-branch/Source/WebKit/mac/WebView/WebPreferences.mm 2016-07-22 09:38:59 UTC (rev 203592)
</span><span class="lines">@@ -525,7 +525,6 @@
</span><span class="cx"> #if !PLATFORM(IOS)
</span><span class="cx"> [NSNumber numberWithBool:YES], WebKitAllowsInlineMediaPlaybackPreferenceKey,
</span><span class="cx"> [NSNumber numberWithBool:NO], WebKitAllowsInlineMediaPlaybackAfterFullscreenPreferenceKey,
</span><del>- [NSNumber numberWithBool:NO], WebKitInlineMediaPlaybackRequiresPlaysInlineAttributeKey,
</del><span class="cx"> [NSNumber numberWithBool:NO], WebKitAllowsInlineMediaPlaybackWithPlaysInlineAttributeKey,
</span><span class="cx"> [NSNumber numberWithBool:NO], WebKitAllowsInlineMediaPlaybackWithWebKitPlaysInlineAttributeKey,
</span><span class="cx"> [NSNumber numberWithBool:YES], WebKitMediaControlsScaleWithPageZoomPreferenceKey,
</span><span class="lines">@@ -540,7 +539,6 @@
</span><span class="cx"> #else
</span><span class="cx"> [NSNumber numberWithBool:allowsInlineMediaPlayback], WebKitAllowsInlineMediaPlaybackPreferenceKey,
</span><span class="cx"> [NSNumber numberWithBool:allowsInlineMediaPlaybackAfterFullscreen], WebKitAllowsInlineMediaPlaybackAfterFullscreenPreferenceKey,
</span><del>- [NSNumber numberWithBool:requiresPlaysInlineAttribute], WebKitInlineMediaPlaybackRequiresPlaysInlineAttributeKey,
</del><span class="cx"> [NSNumber numberWithBool:requiresPlaysInlineAttribute], WebKitAllowsInlineMediaPlaybackWithPlaysInlineAttributeKey,
</span><span class="cx"> [NSNumber numberWithBool:requiresPlaysInlineAttribute], WebKitAllowsInlineMediaPlaybackWithWebKitPlaysInlineAttributeKey,
</span><span class="cx"> [NSNumber numberWithBool:NO], WebKitMediaControlsScaleWithPageZoomPreferenceKey,
</span><span class="lines">@@ -2287,16 +2285,6 @@
</span><span class="cx"> [self _setBoolValue:flag forKey:WebKitAllowsInlineMediaPlaybackPreferenceKey];
</span><span class="cx"> }
</span><span class="cx">
</span><del>-- (BOOL)inlineMediaPlaybackRequiresPlaysInlineAttribute
-{
- return [self _boolValueForKey:WebKitInlineMediaPlaybackRequiresPlaysInlineAttributeKey];
-}
-
-- (void)setInlineMediaPlaybackRequiresPlaysInlineAttribute:(BOOL)flag
-{
- [self _setBoolValue:flag forKey:WebKitInlineMediaPlaybackRequiresPlaysInlineAttributeKey];
-}
-
</del><span class="cx"> - (BOOL)allowsInlineMediaPlaybackWithPlaysInlineAttribute
</span><span class="cx"> {
</span><span class="cx"> return [self _boolValueForKey:WebKitAllowsInlineMediaPlaybackWithPlaysInlineAttributeKey];
</span></span></pre></div>
<a id="branchessafari602branchSourceWebKitmacWebViewWebPreferencesPrivateh"></a>
<div class="modfile"><h4>Modified: branches/safari-602-branch/Source/WebKit/mac/WebView/WebPreferencesPrivate.h (203591 => 203592)</h4>
<pre class="diff"><span>
<span class="info">--- branches/safari-602-branch/Source/WebKit/mac/WebView/WebPreferencesPrivate.h 2016-07-22 09:38:51 UTC (rev 203591)
+++ branches/safari-602-branch/Source/WebKit/mac/WebView/WebPreferencesPrivate.h 2016-07-22 09:38:59 UTC (rev 203592)
</span><span class="lines">@@ -262,9 +262,6 @@
</span><span class="cx"> - (void)setMediaPlaybackAllowsInline:(BOOL)flag;
</span><span class="cx"> - (BOOL)mediaPlaybackAllowsInline;
</span><span class="cx">
</span><del>-- (void)setInlineMediaPlaybackRequiresPlaysInlineAttribute:(BOOL)flag;
-- (BOOL)inlineMediaPlaybackRequiresPlaysInlineAttribute;
-
</del><span class="cx"> - (void)setAllowsInlineMediaPlaybackWithPlaysInlineAttribute:(BOOL)flag;
</span><span class="cx"> - (BOOL)allowsInlineMediaPlaybackWithPlaysInlineAttribute;
</span><span class="cx">
</span></span></pre></div>
<a id="branchessafari602branchSourceWebKitmacWebViewWebViewmm"></a>
<div class="modfile"><h4>Modified: branches/safari-602-branch/Source/WebKit/mac/WebView/WebView.mm (203591 => 203592)</h4>
<pre class="diff"><span>
<span class="info">--- branches/safari-602-branch/Source/WebKit/mac/WebView/WebView.mm 2016-07-22 09:38:51 UTC (rev 203591)
+++ branches/safari-602-branch/Source/WebKit/mac/WebView/WebView.mm 2016-07-22 09:38:59 UTC (rev 203592)
</span><span class="lines">@@ -2348,7 +2348,6 @@
</span><span class="cx"> settings.setMainContentUserGestureOverrideEnabled([preferences overrideUserGestureRequirementForMainContent]);
</span><span class="cx"> settings.setAllowsInlineMediaPlayback([preferences mediaPlaybackAllowsInline]);
</span><span class="cx"> settings.setAllowsInlineMediaPlaybackAfterFullscreen([preferences allowsInlineMediaPlaybackAfterFullscreen]);
</span><del>- settings.setInlineMediaPlaybackRequiresPlaysInlineAttribute([preferences inlineMediaPlaybackRequiresPlaysInlineAttribute]);
</del><span class="cx"> settings.setAllowsInlineMediaPlaybackWithPlaysInlineAttribute([preferences allowsInlineMediaPlaybackWithPlaysInlineAttribute]);
</span><span class="cx"> settings.setAllowsInlineMediaPlaybackWithWebKitPlaysInlineAttribute([preferences allowsInlineMediaPlaybackWithWebKitPlaysInlineAttribute]);
</span><span class="cx"> settings.setInvisibleAutoplayNotPermitted([preferences invisibleAutoplayNotPermitted]);
</span></span></pre></div>
<a id="branchessafari602branchSourceWebKit2ChangeLog"></a>
<div class="modfile"><h4>Modified: branches/safari-602-branch/Source/WebKit2/ChangeLog (203591 => 203592)</h4>
<pre class="diff"><span>
<span class="info">--- branches/safari-602-branch/Source/WebKit2/ChangeLog 2016-07-22 09:38:51 UTC (rev 203591)
+++ branches/safari-602-branch/Source/WebKit2/ChangeLog 2016-07-22 09:38:59 UTC (rev 203592)
</span><span class="lines">@@ -1,5 +1,32 @@
</span><span class="cx"> 2016-07-22 Babak Shafiei <bshafiei@apple.com>
</span><span class="cx">
</span><ins>+ Merge r203545. rdar://problem/26964090
+
+ 2016-07-21 Myles C. Maxfield <mmaxfield@apple.com>
+
+ Remove support for deprecated SPI inlineMediaPlaybackRequiresPlaysInlineAttribute
+ https://bugs.webkit.org/show_bug.cgi?id=160066
+
+ Reviewed by Dean Jackson.
+
+ * Shared/WebPreferencesDefinitions.h:
+ * UIProcess/API/C/WKPreferences.cpp:
+ (WKPreferencesSetInlineMediaPlaybackRequiresPlaysInlineAttribute): Deleted.
+ (WKPreferencesGetInlineMediaPlaybackRequiresPlaysInlineAttribute): Deleted.
+ * UIProcess/API/C/WKPreferencesRefPrivate.h:
+ * UIProcess/API/Cocoa/WKWebView.mm:
+ (-[WKWebView _initializeWithConfiguration:]): Deleted.
+ * UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
+ (-[WKWebViewConfiguration init]): Deleted.
+ (-[WKWebViewConfiguration copyWithZone:]): Deleted.
+ (-[WKWebViewConfiguration _inlineMediaPlaybackRequiresPlaysInlineAttribute]): Deleted.
+ (-[WKWebViewConfiguration _setInlineMediaPlaybackRequiresPlaysInlineAttribute:]): Deleted.
+ * UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:
+ * WebProcess/WebPage/WebPage.cpp:
+ (WebKit::WebPage::updatePreferences): Deleted.
+
+2016-07-22 Babak Shafiei <bshafiei@apple.com>
+
</ins><span class="cx"> Merge r203520. rdar://problem/26964090
</span><span class="cx">
</span><span class="cx"> 2016-07-21 Myles C. Maxfield <mmaxfield@apple.com>
</span></span></pre></div>
<a id="branchessafari602branchSourceWebKit2SharedWebPreferencesDefinitionsh"></a>
<div class="modfile"><h4>Modified: branches/safari-602-branch/Source/WebKit2/Shared/WebPreferencesDefinitions.h (203591 => 203592)</h4>
<pre class="diff"><span>
<span class="info">--- branches/safari-602-branch/Source/WebKit2/Shared/WebPreferencesDefinitions.h 2016-07-22 09:38:51 UTC (rev 203591)
+++ branches/safari-602-branch/Source/WebKit2/Shared/WebPreferencesDefinitions.h 2016-07-22 09:38:59 UTC (rev 203592)
</span><span class="lines">@@ -156,7 +156,6 @@
</span><span class="cx"> macro(MainContentUserGestureOverrideEnabled, mainContentUserGestureOverrideEnabled, Bool, bool, false, "", "") \
</span><span class="cx"> macro(AllowsInlineMediaPlayback, allowsInlineMediaPlayback, Bool, bool, DEFAULT_ALLOWS_INLINE_MEDIA_PLAYBACK, "", "") \
</span><span class="cx"> macro(AllowsInlineMediaPlaybackAfterFullscreen, allowsInlineMediaPlaybackAfterFullscreen, Bool, bool, DEFAULT_ALLOWS_INLINE_MEDIA_PLAYBACK_AFTER_FULLSCREEN, "", "") \
</span><del>- macro(InlineMediaPlaybackRequiresPlaysInlineAttribute, inlineMediaPlaybackRequiresPlaysInlineAttribute, Bool, bool, DEFAULT_INLINE_MEDIA_PLAYBACK_REQUIRES_PLAYS_INLINE_ATTRIBUTE, "", "") \
</del><span class="cx"> macro(AllowsInlineMediaPlaybackWithPlaysInlineAttribute, allowsInlineMediaPlaybackWithPlaysInlineAttribute, Bool, bool, DEFAULT_ALLOWS_INLINE_MEDIA_PLAYBACK_WITH_PLAYS_INLINE_ATTRIBUTE, "", "") \
</span><span class="cx"> macro(AllowsInlineMediaPlaybackWithWebKitPlaysInlineAttribute, allowsInlineMediaPlaybackWithWebKitPlaysInlineAttribute, Bool, bool, DEFAULT_ALLOWS_INLINE_MEDIA_PLAYBACK_WITH_WEBKIT_PLAYS_INLINE_ATTRIBUTE, "", "") \
</span><span class="cx"> macro(InvisibleAutoplayNotPermitted, invisibleAutoplayNotPermitted, Bool, bool, DEFAULT_INVISIBLE_AUTOPLAY_NOT_PERMITTED, "", "") \
</span></span></pre></div>
<a id="branchessafari602branchSourceWebKit2UIProcessAPICWKPreferencescpp"></a>
<div class="modfile"><h4>Modified: branches/safari-602-branch/Source/WebKit2/UIProcess/API/C/WKPreferences.cpp (203591 => 203592)</h4>
<pre class="diff"><span>
<span class="info">--- branches/safari-602-branch/Source/WebKit2/UIProcess/API/C/WKPreferences.cpp 2016-07-22 09:38:51 UTC (rev 203591)
+++ branches/safari-602-branch/Source/WebKit2/UIProcess/API/C/WKPreferences.cpp 2016-07-22 09:38:59 UTC (rev 203592)
</span><span class="lines">@@ -793,16 +793,6 @@
</span><span class="cx"> return toImpl(preferencesRef)->allowsInlineMediaPlayback();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void WKPreferencesSetInlineMediaPlaybackRequiresPlaysInlineAttribute(WKPreferencesRef preferencesRef, bool flag)
-{
- toImpl(preferencesRef)->setInlineMediaPlaybackRequiresPlaysInlineAttribute(flag);
-}
-
-bool WKPreferencesGetInlineMediaPlaybackRequiresPlaysInlineAttribute(WKPreferencesRef preferencesRef)
-{
- return toImpl(preferencesRef)->inlineMediaPlaybackRequiresPlaysInlineAttribute();
-}
-
</del><span class="cx"> void WKPreferencesSetAllowsInlineMediaPlaybackWithPlaysInlineAttribute(WKPreferencesRef preferencesRef, bool flag)
</span><span class="cx"> {
</span><span class="cx"> toImpl(preferencesRef)->setAllowsInlineMediaPlaybackWithPlaysInlineAttribute(flag);
</span></span></pre></div>
<a id="branchessafari602branchSourceWebKit2UIProcessAPICWKPreferencesRefPrivateh"></a>
<div class="modfile"><h4>Modified: branches/safari-602-branch/Source/WebKit2/UIProcess/API/C/WKPreferencesRefPrivate.h (203591 => 203592)</h4>
<pre class="diff"><span>
<span class="info">--- branches/safari-602-branch/Source/WebKit2/UIProcess/API/C/WKPreferencesRefPrivate.h 2016-07-22 09:38:51 UTC (rev 203591)
+++ branches/safari-602-branch/Source/WebKit2/UIProcess/API/C/WKPreferencesRefPrivate.h 2016-07-22 09:38:59 UTC (rev 203592)
</span><span class="lines">@@ -191,10 +191,6 @@
</span><span class="cx"> WK_EXPORT void WKPreferencesSetMediaPlaybackAllowsInline(WKPreferencesRef preferencesRef, bool flag);
</span><span class="cx"> WK_EXPORT bool WKPreferencesGetMediaPlaybackAllowsInline(WKPreferencesRef preferencesRef);
</span><span class="cx">
</span><del>-// Defaults to false.
-WK_EXPORT void WKPreferencesSetInlineMediaPlaybackRequiresPlaysInlineAttribute(WKPreferencesRef preferencesRef, bool flag);
-WK_EXPORT bool WKPreferencesGetInlineMediaPlaybackRequiresPlaysInlineAttribute(WKPreferencesRef preferencesRef);
-
</del><span class="cx"> // Defaults to true on iOS, false elsewhere.
</span><span class="cx"> WK_EXPORT void WKPreferencesSetAllowsInlineMediaPlaybackWithPlaysInlineAttribute(WKPreferencesRef preferencesRef, bool flag);
</span><span class="cx"> WK_EXPORT bool WKPreferencesGetAllowsInlineMediaPlaybackWithPlaysInlineAttribute(WKPreferencesRef preferencesRef);
</span></span></pre></div>
<a id="branchessafari602branchSourceWebKit2UIProcessAPICocoaWKWebViewmm"></a>
<div class="modfile"><h4>Modified: branches/safari-602-branch/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm (203591 => 203592)</h4>
<pre class="diff"><span>
<span class="info">--- branches/safari-602-branch/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm 2016-07-22 09:38:51 UTC (rev 203591)
+++ branches/safari-602-branch/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm 2016-07-22 09:38:59 UTC (rev 203592)
</span><span class="lines">@@ -455,7 +455,6 @@
</span><span class="cx">
</span><span class="cx"> pageConfiguration->preferenceValues().set(WebKit::WebPreferencesKey::allowsInlineMediaPlaybackKey(), WebKit::WebPreferencesStore::Value(!![_configuration allowsInlineMediaPlayback]));
</span><span class="cx"> pageConfiguration->preferenceValues().set(WebKit::WebPreferencesKey::allowsInlineMediaPlaybackAfterFullscreenKey(), WebKit::WebPreferencesStore::Value(!![_configuration _allowsInlineMediaPlaybackAfterFullscreen]));
</span><del>- pageConfiguration->preferenceValues().set(WebKit::WebPreferencesKey::inlineMediaPlaybackRequiresPlaysInlineAttributeKey(), WebKit::WebPreferencesStore::Value(!![_configuration _inlineMediaPlaybackRequiresPlaysInlineAttribute]));
</del><span class="cx"> pageConfiguration->preferenceValues().set(WebKit::WebPreferencesKey::allowsInlineMediaPlaybackWithPlaysInlineAttributeKey(), WebKit::WebPreferencesStore::Value(!![_configuration _allowsInlineMediaPlaybackWithPlaysInlineAttribute]));
</span><span class="cx"> pageConfiguration->preferenceValues().set(WebKit::WebPreferencesKey::allowsInlineMediaPlaybackWithWebKitPlaysInlineAttributeKey(), WebKit::WebPreferencesStore::Value(!![_configuration _allowsInlineMediaPlaybackWithWebKitPlaysInlineAttribute]));
</span><span class="cx"> pageConfiguration->preferenceValues().set(WebKit::WebPreferencesKey::allowsPictureInPictureMediaPlaybackKey(), WebKit::WebPreferencesStore::Value(!![_configuration allowsPictureInPictureMediaPlayback] && shouldAllowPictureInPictureMediaPlayback()));
</span></span></pre></div>
<a id="branchessafari602branchSourceWebKit2UIProcessAPICocoaWKWebViewConfigurationmm"></a>
<div class="modfile"><h4>Modified: branches/safari-602-branch/Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfiguration.mm (203591 => 203592)</h4>
<pre class="diff"><span>
<span class="info">--- branches/safari-602-branch/Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfiguration.mm 2016-07-22 09:38:51 UTC (rev 203591)
+++ branches/safari-602-branch/Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfiguration.mm 2016-07-22 09:38:59 UTC (rev 203592)
</span><span class="lines">@@ -107,7 +107,6 @@
</span><span class="cx"> LazyInitialized<RetainPtr<WKWebViewContentProviderRegistry>> _contentProviderRegistry;
</span><span class="cx"> BOOL _alwaysRunsAtForegroundPriority;
</span><span class="cx"> BOOL _allowsInlineMediaPlayback;
</span><del>- BOOL _inlineMediaPlaybackRequiresPlaysInlineAttribute;
</del><span class="cx"> BOOL _allowsInlineMediaPlaybackWithPlaysInlineAttribute;
</span><span class="cx"> BOOL _allowsInlineMediaPlaybackWithWebKitPlaysInlineAttribute;
</span><span class="cx"> BOOL _allowsInlineMediaPlaybackAfterFullscreen;
</span><span class="lines">@@ -139,7 +138,6 @@
</span><span class="cx"> #if PLATFORM(IOS)
</span><span class="cx"> _allowsPictureInPictureMediaPlayback = YES;
</span><span class="cx"> _allowsInlineMediaPlayback = WebCore::deviceClass() == MGDeviceClassiPad;
</span><del>- _inlineMediaPlaybackRequiresPlaysInlineAttribute = !_allowsInlineMediaPlayback;
</del><span class="cx"> _allowsInlineMediaPlaybackWithPlaysInlineAttribute = !_allowsInlineMediaPlayback;
</span><span class="cx"> _allowsInlineMediaPlaybackWithWebKitPlaysInlineAttribute = !_allowsInlineMediaPlayback;
</span><span class="cx"> _allowsInlineMediaPlaybackAfterFullscreen = !_allowsInlineMediaPlayback;
</span><span class="lines">@@ -292,7 +290,6 @@
</span><span class="cx"> #if PLATFORM(IOS)
</span><span class="cx"> configuration->_allowsInlineMediaPlayback = self->_allowsInlineMediaPlayback;
</span><span class="cx"> configuration->_allowsInlineMediaPlaybackAfterFullscreen = self->_allowsInlineMediaPlaybackAfterFullscreen;
</span><del>- configuration->_inlineMediaPlaybackRequiresPlaysInlineAttribute = self->_inlineMediaPlaybackRequiresPlaysInlineAttribute;
</del><span class="cx"> configuration->_allowsInlineMediaPlaybackWithPlaysInlineAttribute = self->_allowsInlineMediaPlaybackWithPlaysInlineAttribute;
</span><span class="cx"> configuration->_allowsInlineMediaPlaybackWithWebKitPlaysInlineAttribute = self->_allowsInlineMediaPlaybackWithWebKitPlaysInlineAttribute;
</span><span class="cx"> configuration->_allowsPictureInPictureMediaPlayback = self->_allowsPictureInPictureMediaPlayback;
</span><span class="lines">@@ -574,16 +571,6 @@
</span><span class="cx"> _alwaysRunsAtForegroundPriority = alwaysRunsAtForegroundPriority;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-- (BOOL)_inlineMediaPlaybackRequiresPlaysInlineAttribute
-{
- return _inlineMediaPlaybackRequiresPlaysInlineAttribute;
-}
-
-- (void)_setInlineMediaPlaybackRequiresPlaysInlineAttribute:(BOOL)requires
-{
- _inlineMediaPlaybackRequiresPlaysInlineAttribute = requires;
-}
-
</del><span class="cx"> - (BOOL)_allowsInlineMediaPlaybackWithPlaysInlineAttribute
</span><span class="cx"> {
</span><span class="cx"> return _allowsInlineMediaPlaybackWithPlaysInlineAttribute;
</span></span></pre></div>
<a id="branchessafari602branchSourceWebKit2UIProcessAPICocoaWKWebViewConfigurationPrivateh"></a>
<div class="modfile"><h4>Modified: branches/safari-602-branch/Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h (203591 => 203592)</h4>
<pre class="diff"><span>
<span class="info">--- branches/safari-602-branch/Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h 2016-07-22 09:38:51 UTC (rev 203591)
+++ branches/safari-602-branch/Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h 2016-07-22 09:38:59 UTC (rev 203592)
</span><span class="lines">@@ -59,7 +59,6 @@
</span><span class="cx">
</span><span class="cx"> #if TARGET_OS_IPHONE
</span><span class="cx"> @property (nonatomic, setter=_setAlwaysRunsAtForegroundPriority:) BOOL _alwaysRunsAtForegroundPriority WK_API_AVAILABLE(ios(9_0));
</span><del>-@property (nonatomic, setter=_setInlineMediaPlaybackRequiresPlaysInlineAttribute:) BOOL _inlineMediaPlaybackRequiresPlaysInlineAttribute WK_API_AVAILABLE(ios(WK_IOS_TBA));
</del><span class="cx"> @property (nonatomic, setter=_setAllowsInlineMediaPlaybackWithPlaysInlineAttribute:) BOOL _allowsInlineMediaPlaybackWithPlaysInlineAttribute WK_API_AVAILABLE(ios(WK_IOS_TBA));
</span><span class="cx"> @property (nonatomic, setter=_setAllowsInlineMediaPlaybackWithWebKitPlaysInlineAttribute:) BOOL _allowsInlineMediaPlaybackWithWebKitPlaysInlineAttribute WK_API_AVAILABLE(ios(WK_IOS_TBA));
</span><span class="cx"> @property (nonatomic, setter=_setAllowsInlineMediaPlaybackAfterFullscreen:) BOOL _allowsInlineMediaPlaybackAfterFullscreen WK_API_AVAILABLE(ios(WK_IOS_TBA));
</span></span></pre></div>
<a id="branchessafari602branchSourceWebKit2WebProcessWebPageWebPagecpp"></a>
<div class="modfile"><h4>Modified: branches/safari-602-branch/Source/WebKit2/WebProcess/WebPage/WebPage.cpp (203591 => 203592)</h4>
<pre class="diff"><span>
<span class="info">--- branches/safari-602-branch/Source/WebKit2/WebProcess/WebPage/WebPage.cpp 2016-07-22 09:38:51 UTC (rev 203591)
+++ branches/safari-602-branch/Source/WebKit2/WebProcess/WebPage/WebPage.cpp 2016-07-22 09:38:59 UTC (rev 203592)
</span><span class="lines">@@ -2985,7 +2985,6 @@
</span><span class="cx"> settings.setMainContentUserGestureOverrideEnabled(store.getBoolValueForKey(WebPreferencesKey::mainContentUserGestureOverrideEnabledKey()));
</span><span class="cx"> settings.setAllowsInlineMediaPlayback(store.getBoolValueForKey(WebPreferencesKey::allowsInlineMediaPlaybackKey()));
</span><span class="cx"> settings.setAllowsInlineMediaPlaybackAfterFullscreen(store.getBoolValueForKey(WebPreferencesKey::allowsInlineMediaPlaybackAfterFullscreenKey()));
</span><del>- settings.setInlineMediaPlaybackRequiresPlaysInlineAttribute(store.getBoolValueForKey(WebPreferencesKey::inlineMediaPlaybackRequiresPlaysInlineAttributeKey()));
</del><span class="cx"> settings.setAllowsInlineMediaPlaybackWithPlaysInlineAttribute(store.getBoolValueForKey(WebPreferencesKey::allowsInlineMediaPlaybackWithPlaysInlineAttributeKey()));
</span><span class="cx"> settings.setAllowsInlineMediaPlaybackWithWebKitPlaysInlineAttribute(store.getBoolValueForKey(WebPreferencesKey::allowsInlineMediaPlaybackWithWebKitPlaysInlineAttributeKey()));
</span><span class="cx"> settings.setInvisibleAutoplayNotPermitted(store.getBoolValueForKey(WebPreferencesKey::invisibleAutoplayNotPermittedKey()));
</span></span></pre></div>
<a id="branchessafari602branchToolsChangeLog"></a>
<div class="modfile"><h4>Modified: branches/safari-602-branch/Tools/ChangeLog (203591 => 203592)</h4>
<pre class="diff"><span>
<span class="info">--- branches/safari-602-branch/Tools/ChangeLog 2016-07-22 09:38:51 UTC (rev 203591)
+++ branches/safari-602-branch/Tools/ChangeLog 2016-07-22 09:38:59 UTC (rev 203592)
</span><span class="lines">@@ -1,5 +1,25 @@
</span><span class="cx"> 2016-07-22 Babak Shafiei <bshafiei@apple.com>
</span><span class="cx">
</span><ins>+ Merge r203545. rdar://problem/26964090
+
+ 2016-07-21 Myles C. Maxfield <mmaxfield@apple.com>
+
+ Remove support for deprecated SPI inlineMediaPlaybackRequiresPlaysInlineAttribute
+ https://bugs.webkit.org/show_bug.cgi?id=160066
+
+ Reviewed by Dean Jackson.
+
+ * DumpRenderTree/mac/DumpRenderTree.mm:
+ (setDefaultsToConsistentValuesForTesting): Deleted.
+ * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
+ (RequiresUserActionForPlaybackTest::SetUp): Deleted.
+ * WebKitTestRunner/TestController.cpp:
+ (WTR::TestController::resetPreferencesToConsistentValues): Deleted.
+ * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
+ (WTR::initializeWebViewConfiguration): Deleted.
+
+2016-07-22 Babak Shafiei <bshafiei@apple.com>
+
</ins><span class="cx"> Merge r203540. rdar://problem/26964090
</span><span class="cx">
</span><span class="cx"> 2016-07-21 Myles C. Maxfield <mmaxfield@apple.com>
</span></span></pre></div>
<a id="branchessafari602branchToolsDumpRenderTreemacDumpRenderTreemm"></a>
<div class="modfile"><h4>Modified: branches/safari-602-branch/Tools/DumpRenderTree/mac/DumpRenderTree.mm (203591 => 203592)</h4>
<pre class="diff"><span>
<span class="info">--- branches/safari-602-branch/Tools/DumpRenderTree/mac/DumpRenderTree.mm 2016-07-22 09:38:51 UTC (rev 203591)
+++ branches/safari-602-branch/Tools/DumpRenderTree/mac/DumpRenderTree.mm 2016-07-22 09:38:59 UTC (rev 203592)
</span><span class="lines">@@ -1017,7 +1017,6 @@
</span><span class="cx"> WebKitEnableFullDocumentTeardownPreferenceKey: @YES,
</span><span class="cx"> WebKitFullScreenEnabledPreferenceKey: @YES,
</span><span class="cx"> WebKitAllowsInlineMediaPlaybackPreferenceKey: @YES,
</span><del>- WebKitInlineMediaPlaybackRequiresPlaysInlineAttributeKey: @NO,
</del><span class="cx"> WebKitAllowsInlineMediaPlaybackWithPlaysInlineAttributeKey: @NO,
</span><span class="cx"> WebKitAllowsInlineMediaPlaybackWithWebKitPlaysInlineAttributeKey: @NO,
</span><span class="cx"> @"UseWebKitWebInspector": @YES,
</span></span></pre></div>
<a id="branchessafari602branchToolsTestWebKitAPITestsWebKit2CocoaRequiresUserActionForPlaybackmm"></a>
<div class="modfile"><h4>Modified: branches/safari-602-branch/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm (203591 => 203592)</h4>
<pre class="diff"><span>
<span class="info">--- branches/safari-602-branch/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm 2016-07-22 09:38:51 UTC (rev 203591)
+++ branches/safari-602-branch/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm 2016-07-22 09:38:59 UTC (rev 203592)
</span><span class="lines">@@ -76,7 +76,6 @@
</span><span class="cx"> configuration.get()._mediaDataLoadsAutomatically = YES;
</span><span class="cx"> #if TARGET_OS_IPHONE
</span><span class="cx"> configuration.get().allowsInlineMediaPlayback = YES;
</span><del>- configuration.get()._inlineMediaPlaybackRequiresPlaysInlineAttribute = NO;
</del><span class="cx"> configuration.get()._allowsInlineMediaPlaybackWithPlaysInlineAttribute = NO;
</span><span class="cx"> configuration.get()._allowsInlineMediaPlaybackWithWebKitPlaysInlineAttribute = NO;
</span><span class="cx"> #endif
</span></span></pre></div>
<a id="branchessafari602branchToolsWebKitTestRunnerTestControllercpp"></a>
<div class="modfile"><h4>Modified: branches/safari-602-branch/Tools/WebKitTestRunner/TestController.cpp (203591 => 203592)</h4>
<pre class="diff"><span>
<span class="info">--- branches/safari-602-branch/Tools/WebKitTestRunner/TestController.cpp 2016-07-22 09:38:51 UTC (rev 203591)
+++ branches/safari-602-branch/Tools/WebKitTestRunner/TestController.cpp 2016-07-22 09:38:59 UTC (rev 203592)
</span><span class="lines">@@ -684,7 +684,6 @@
</span><span class="cx"> WKPreferencesSetStorageBlockingPolicy(preferences, kWKAllowAllStorage);
</span><span class="cx">
</span><span class="cx"> WKPreferencesSetMediaPlaybackAllowsInline(preferences, true);
</span><del>- WKPreferencesSetInlineMediaPlaybackRequiresPlaysInlineAttribute(preferences, false);
</del><span class="cx"> WKPreferencesSetAllowsInlineMediaPlaybackWithPlaysInlineAttribute(preferences, false);
</span><span class="cx"> WKPreferencesSetAllowsInlineMediaPlaybackWithWebKitPlaysInlineAttribute(preferences, false);
</span><span class="cx">
</span></span></pre></div>
<a id="branchessafari602branchToolsWebKitTestRunnercocoaTestControllerCocoamm"></a>
<div class="modfile"><h4>Modified: branches/safari-602-branch/Tools/WebKitTestRunner/cocoa/TestControllerCocoa.mm (203591 => 203592)</h4>
<pre class="diff"><span>
<span class="info">--- branches/safari-602-branch/Tools/WebKitTestRunner/cocoa/TestControllerCocoa.mm 2016-07-22 09:38:51 UTC (rev 203591)
+++ branches/safari-602-branch/Tools/WebKitTestRunner/cocoa/TestControllerCocoa.mm 2016-07-22 09:38:59 UTC (rev 203592)
</span><span class="lines">@@ -61,7 +61,6 @@
</span><span class="cx">
</span><span class="cx"> #if TARGET_OS_IPHONE
</span><span class="cx"> globalWebViewConfiguration.allowsInlineMediaPlayback = YES;
</span><del>- globalWebViewConfiguration._inlineMediaPlaybackRequiresPlaysInlineAttribute = NO;
</del><span class="cx"> globalWebViewConfiguration._allowsInlineMediaPlaybackWithPlaysInlineAttribute = NO;
</span><span class="cx"> globalWebViewConfiguration._allowsInlineMediaPlaybackWithWebKitPlaysInlineAttribute = NO;
</span><span class="cx"> globalWebViewConfiguration._invisibleAutoplayNotPermitted = NO;
</span></span></pre>
</div>
</div>
</body>
</html>