<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[203550] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/203550">203550</a></dd>
<dt>Author</dt> <dd>cdumez@apple.com</dd>
<dt>Date</dt> <dd>2016-07-21 20:29:16 -0700 (Thu, 21 Jul 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Parameter to Document.createEvent() should be mandatory
https://bugs.webkit.org/show_bug.cgi?id=160065
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
Rebaseline several W3C tests now that more checks are passing.
* web-platform-tests/dom/interfaces-expected.txt:
* web-platform-tests/html/dom/interfaces-expected.txt:
Source/WebCore:
Parameter to Document.createEvent() should be mandatory as per the
specification:
- https://dom.spec.whatwg.org/#document
We already throw anyway when the parameter is omitted because we use
"undefined" as event type, which is invalid. However, we throw the
wrong exception.
Firefox and Chrome agree with the specification here.
No new tests, rebaselined existing tests.
* dom/Document.idl:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsimportedw3cChangeLog">trunk/LayoutTests/imported/w3c/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestsdominterfacesexpectedtxt">trunk/LayoutTests/imported/w3c/web-platform-tests/dom/interfaces-expected.txt</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestshtmldominterfacesexpectedtxt">trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoredomDocumentidl">trunk/Source/WebCore/dom/Document.idl</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsimportedw3cChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/ChangeLog (203549 => 203550)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/ChangeLog 2016-07-22 03:00:07 UTC (rev 203549)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2016-07-22 03:29:16 UTC (rev 203550)
</span><span class="lines">@@ -1,5 +1,17 @@
</span><span class="cx"> 2016-07-21 Chris Dumez <cdumez@apple.com>
</span><span class="cx">
</span><ins>+ Parameter to Document.createEvent() should be mandatory
+ https://bugs.webkit.org/show_bug.cgi?id=160065
+
+ Reviewed by Darin Adler.
+
+ Rebaseline several W3C tests now that more checks are passing.
+
+ * web-platform-tests/dom/interfaces-expected.txt:
+ * web-platform-tests/html/dom/interfaces-expected.txt:
+
+2016-07-21 Chris Dumez <cdumez@apple.com>
+
</ins><span class="cx"> Make parameters to Element.getElementsBy*() operations mandatory
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=160060
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestsdominterfacesexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/dom/interfaces-expected.txt (203549 => 203550)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/dom/interfaces-expected.txt 2016-07-22 03:00:07 UTC (rev 203549)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/dom/interfaces-expected.txt 2016-07-22 03:29:16 UTC (rev 203550)
</span><span class="lines">@@ -268,7 +268,7 @@
</span><span class="cx"> PASS Document interface: operation adoptNode(Node)
</span><span class="cx"> PASS Document interface: operation createAttribute(DOMString)
</span><span class="cx"> PASS Document interface: operation createAttributeNS(DOMString,DOMString)
</span><del>-FAIL Document interface: operation createEvent(DOMString) assert_equals: property has wrong .length expected 1 but got 0
</del><ins>+PASS Document interface: operation createEvent(DOMString)
</ins><span class="cx"> PASS Document interface: operation createRange()
</span><span class="cx"> PASS Document interface: operation createNodeIterator(Node,unsigned long,NodeFilter)
</span><span class="cx"> PASS Document interface: operation createTreeWalker(Node,unsigned long,NodeFilter)
</span><span class="lines">@@ -320,9 +320,7 @@
</span><span class="cx"> PASS Document interface: new Document() must inherit property "createAttributeNS" with the proper type (23)
</span><span class="cx"> PASS Document interface: calling createAttributeNS(DOMString,DOMString) on new Document() with too few arguments must throw TypeError
</span><span class="cx"> PASS Document interface: new Document() must inherit property "createEvent" with the proper type (24)
</span><del>-FAIL Document interface: calling createEvent(DOMString) on new Document() with too few arguments must throw TypeError assert_throws: Called with 0 arguments function "function () {
- fn.apply(obj, args);
- }" threw object "NotSupportedError (DOM Exception 9): The operation is not..." ("NotSupportedError") expected object "TypeError" ("TypeError")
</del><ins>+PASS Document interface: calling createEvent(DOMString) on new Document() with too few arguments must throw TypeError
</ins><span class="cx"> PASS Document interface: new Document() must inherit property "createRange" with the proper type (25)
</span><span class="cx"> PASS Document interface: new Document() must inherit property "createNodeIterator" with the proper type (26)
</span><span class="cx"> PASS Document interface: calling createNodeIterator(Node,unsigned long,NodeFilter) on new Document() with too few arguments must throw TypeError
</span><span class="lines">@@ -468,9 +466,7 @@
</span><span class="cx"> PASS Document interface: xmlDoc must inherit property "createAttributeNS" with the proper type (23)
</span><span class="cx"> PASS Document interface: calling createAttributeNS(DOMString,DOMString) on xmlDoc with too few arguments must throw TypeError
</span><span class="cx"> PASS Document interface: xmlDoc must inherit property "createEvent" with the proper type (24)
</span><del>-FAIL Document interface: calling createEvent(DOMString) on xmlDoc with too few arguments must throw TypeError assert_throws: Called with 0 arguments function "function () {
- fn.apply(obj, args);
- }" threw object "NotSupportedError (DOM Exception 9): The operation is not..." ("NotSupportedError") expected object "TypeError" ("TypeError")
</del><ins>+PASS Document interface: calling createEvent(DOMString) on xmlDoc with too few arguments must throw TypeError
</ins><span class="cx"> PASS Document interface: xmlDoc must inherit property "createRange" with the proper type (25)
</span><span class="cx"> PASS Document interface: xmlDoc must inherit property "createNodeIterator" with the proper type (26)
</span><span class="cx"> PASS Document interface: calling createNodeIterator(Node,unsigned long,NodeFilter) on xmlDoc with too few arguments must throw TypeError
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestshtmldominterfacesexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt (203549 => 203550)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt 2016-07-22 03:00:07 UTC (rev 203549)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt 2016-07-22 03:29:16 UTC (rev 203550)
</span><span class="lines">@@ -160,9 +160,7 @@
</span><span class="cx"> PASS Document interface: iframe.contentDocument must inherit property "createAttributeNS" with the proper type (23)
</span><span class="cx"> PASS Document interface: calling createAttributeNS(DOMString,DOMString) on iframe.contentDocument with too few arguments must throw TypeError
</span><span class="cx"> PASS Document interface: iframe.contentDocument must inherit property "createEvent" with the proper type (24)
</span><del>-FAIL Document interface: calling createEvent(DOMString) on iframe.contentDocument with too few arguments must throw TypeError assert_throws: Called with 0 arguments function "function () {
- fn.apply(obj, args);
- }" threw object "NotSupportedError (DOM Exception 9): The operation is not..." ("NotSupportedError") expected object "TypeError" ("TypeError")
</del><ins>+PASS Document interface: calling createEvent(DOMString) on iframe.contentDocument with too few arguments must throw TypeError
</ins><span class="cx"> PASS Document interface: iframe.contentDocument must inherit property "createRange" with the proper type (25)
</span><span class="cx"> PASS Document interface: iframe.contentDocument must inherit property "createNodeIterator" with the proper type (26)
</span><span class="cx"> PASS Document interface: calling createNodeIterator(Node,unsigned long,NodeFilter) on iframe.contentDocument with too few arguments must throw TypeError
</span><span class="lines">@@ -442,9 +440,7 @@
</span><span class="cx"> PASS Document interface: new Document() must inherit property "createAttributeNS" with the proper type (23)
</span><span class="cx"> PASS Document interface: calling createAttributeNS(DOMString,DOMString) on new Document() with too few arguments must throw TypeError
</span><span class="cx"> PASS Document interface: new Document() must inherit property "createEvent" with the proper type (24)
</span><del>-FAIL Document interface: calling createEvent(DOMString) on new Document() with too few arguments must throw TypeError assert_throws: Called with 0 arguments function "function () {
- fn.apply(obj, args);
- }" threw object "NotSupportedError (DOM Exception 9): The operation is not..." ("NotSupportedError") expected object "TypeError" ("TypeError")
</del><ins>+PASS Document interface: calling createEvent(DOMString) on new Document() with too few arguments must throw TypeError
</ins><span class="cx"> PASS Document interface: new Document() must inherit property "createRange" with the proper type (25)
</span><span class="cx"> PASS Document interface: new Document() must inherit property "createNodeIterator" with the proper type (26)
</span><span class="cx"> PASS Document interface: calling createNodeIterator(Node,unsigned long,NodeFilter) on new Document() with too few arguments must throw TypeError
</span><span class="lines">@@ -727,9 +723,7 @@
</span><span class="cx"> PASS Document interface: document.implementation.createDocument(null, "", null) must inherit property "createAttributeNS" with the proper type (23)
</span><span class="cx"> PASS Document interface: calling createAttributeNS(DOMString,DOMString) on document.implementation.createDocument(null, "", null) with too few arguments must throw TypeError
</span><span class="cx"> PASS Document interface: document.implementation.createDocument(null, "", null) must inherit property "createEvent" with the proper type (24)
</span><del>-FAIL Document interface: calling createEvent(DOMString) on document.implementation.createDocument(null, "", null) with too few arguments must throw TypeError assert_throws: Called with 0 arguments function "function () {
- fn.apply(obj, args);
- }" threw object "NotSupportedError (DOM Exception 9): The operation is not..." ("NotSupportedError") expected object "TypeError" ("TypeError")
</del><ins>+PASS Document interface: calling createEvent(DOMString) on document.implementation.createDocument(null, "", null) with too few arguments must throw TypeError
</ins><span class="cx"> PASS Document interface: document.implementation.createDocument(null, "", null) must inherit property "createRange" with the proper type (25)
</span><span class="cx"> PASS Document interface: document.implementation.createDocument(null, "", null) must inherit property "createNodeIterator" with the proper type (26)
</span><span class="cx"> PASS Document interface: calling createNodeIterator(Node,unsigned long,NodeFilter) on document.implementation.createDocument(null, "", null) with too few arguments must throw TypeError
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (203549 => 203550)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-07-22 03:00:07 UTC (rev 203549)
+++ trunk/Source/WebCore/ChangeLog 2016-07-22 03:29:16 UTC (rev 203550)
</span><span class="lines">@@ -1,3 +1,24 @@
</span><ins>+2016-07-21 Chris Dumez <cdumez@apple.com>
+
+ Parameter to Document.createEvent() should be mandatory
+ https://bugs.webkit.org/show_bug.cgi?id=160065
+
+ Reviewed by Darin Adler.
+
+ Parameter to Document.createEvent() should be mandatory as per the
+ specification:
+ - https://dom.spec.whatwg.org/#document
+
+ We already throw anyway when the parameter is omitted because we use
+ "undefined" as event type, which is invalid. However, we throw the
+ wrong exception.
+
+ Firefox and Chrome agree with the specification here.
+
+ No new tests, rebaselined existing tests.
+
+ * dom/Document.idl:
+
</ins><span class="cx"> 2016-07-21 Brian Burg <bburg@apple.com>
</span><span class="cx">
</span><span class="cx"> REGRESSION(r62549): Objective-C DOM bindings sometimes fail to regenerate when CodeGenerator.pm is modified
</span></span></pre></div>
<a id="trunkSourceWebCoredomDocumentidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Document.idl (203549 => 203550)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Document.idl 2016-07-22 03:00:07 UTC (rev 203549)
+++ trunk/Source/WebCore/dom/Document.idl 2016-07-22 03:29:16 UTC (rev 203550)
</span><span class="lines">@@ -86,8 +86,7 @@
</span><span class="cx">
</span><span class="cx"> // DOM Level 2 Events (DocumentEvents interface)
</span><span class="cx">
</span><del>- // FIXME: Using "undefined" as default parameter value is wrong.
- [RaisesException, NewObject] Event createEvent(optional DOMString eventType = "undefined");
</del><ins>+ [RaisesException, NewObject] Event createEvent(DOMString eventType);
</ins><span class="cx">
</span><span class="cx"> // DOM Level 2 Tranversal and Range (DocumentRange interface)
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>