<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[203531] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/203531">203531</a></dd>
<dt>Author</dt> <dd>cdumez@apple.com</dd>
<dt>Date</dt> <dd>2016-07-21 14:31:16 -0700 (Thu, 21 Jul 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Fix null handling of SVGAngle/SVGLength.valueAsString attribute
https://bugs.webkit.org/show_bug.cgi?id=160025
Reviewed by Ryosuke Niwa.
Source/WebCore:
Fix null handling of SVGAngle/SVGLength.valueAsString attribute
to match the specification:
- https://www.w3.org/TR/SVG2/types.html#InterfaceSVGAngle
- https://www.w3.org/TR/SVG2/types.html#InterfaceSVGLength
In particular, this patch drops [TreatNullAs=EmptyString] IDL
extended attribute from this attribute. This is not supposed
to change behavior given that both "" and "null" are invalid
numbers and the specification says to throw a SYNTAX_ERR in
this case.
However, WebKit currently ignores assignments to "" instead
of throwing. As a result, assigning to null will now throw
instead of being ignored. The compatibility risk should be
low because both Firefox and Chrome throw when assigning
null.
I did not change the behavior when assigning to "" because
it is a bit out of scope for this patch and browsers to not
seem to agree:
- Firefox throws
- Chrome set value to "0"
- WebKit ignores the assignment
The specification seems to agree with Firefox as far as I
can tell given that "" is not a valid number as per:
- https://www.w3.org/TR/css3-values/#numbers
Test: svg/dom/valueAsString-null.html
* svg/SVGAngle.idl:
* svg/SVGLength.idl:
LayoutTests:
Add test coverage.
* svg/dom/svg-element-attribute-js-null-expected.txt:
* svg/dom/svg-element-attribute-js-null.xhtml:
* svg/dom/valueAsString-null-expected.txt: Added.
* svg/dom/valueAsString-null.html: Added.
There are a couple of failures in this test because WebKit ignores
assignments to "" instead of throwing. Firefox passes all the checks.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestssvgdomsvgelementattributejsnullexpectedtxt">trunk/LayoutTests/svg/dom/svg-element-attribute-js-null-expected.txt</a></li>
<li><a href="#trunkLayoutTestssvgdomsvgelementattributejsnullxhtml">trunk/LayoutTests/svg/dom/svg-element-attribute-js-null.xhtml</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoresvgSVGAngleidl">trunk/Source/WebCore/svg/SVGAngle.idl</a></li>
<li><a href="#trunkSourceWebCoresvgSVGLengthidl">trunk/Source/WebCore/svg/SVGLength.idl</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestssvgdomvalueAsStringnullexpectedtxt">trunk/LayoutTests/svg/dom/valueAsString-null-expected.txt</a></li>
<li><a href="#trunkLayoutTestssvgdomvalueAsStringnullhtml">trunk/LayoutTests/svg/dom/valueAsString-null.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (203530 => 203531)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2016-07-21 21:25:45 UTC (rev 203530)
+++ trunk/LayoutTests/ChangeLog 2016-07-21 21:31:16 UTC (rev 203531)
</span><span class="lines">@@ -1,5 +1,21 @@
</span><span class="cx"> 2016-07-21 Chris Dumez <cdumez@apple.com>
</span><span class="cx">
</span><ins>+ Fix null handling of SVGAngle/SVGLength.valueAsString attribute
+ https://bugs.webkit.org/show_bug.cgi?id=160025
+
+ Reviewed by Ryosuke Niwa.
+
+ Add test coverage.
+
+ * svg/dom/svg-element-attribute-js-null-expected.txt:
+ * svg/dom/svg-element-attribute-js-null.xhtml:
+ * svg/dom/valueAsString-null-expected.txt: Added.
+ * svg/dom/valueAsString-null.html: Added.
+ There are a couple of failures in this test because WebKit ignores
+ assignments to "" instead of throwing. Firefox passes all the checks.
+
+2016-07-21 Chris Dumez <cdumez@apple.com>
+
</ins><span class="cx"> Fix null handling of HTMLFontElement.color
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=160036
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestssvgdomsvgelementattributejsnullexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/svg/dom/svg-element-attribute-js-null-expected.txt (203530 => 203531)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/svg/dom/svg-element-attribute-js-null-expected.txt 2016-07-21 21:25:45 UTC (rev 203530)
+++ trunk/LayoutTests/svg/dom/svg-element-attribute-js-null-expected.txt 2016-07-21 21:31:16 UTC (rev 203531)
</span><span class="lines">@@ -2,10 +2,6 @@
</span><span class="cx">
</span><span class="cx"> TEST SUCCEEDED: The value was the string 'null'. [tested SVGElement.id]
</span><span class="cx">
</span><del>-TEST SUCCEEDED: The value was the string '0'. [tested SVGAngle.valueAsString]
-
-TEST SUCCEEDED: The value was the string '0'. [tested SVGLength.valueAsString]
-
</del><span class="cx"> TEST SUCCEEDED: The value was the string 'null'. [tested SVGScriptElement.type]
</span><span class="cx">
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestssvgdomsvgelementattributejsnullxhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/svg/dom/svg-element-attribute-js-null.xhtml (203530 => 203531)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/svg/dom/svg-element-attribute-js-null.xhtml 2016-07-21 21:25:45 UTC (rev 203530)
+++ trunk/LayoutTests/svg/dom/svg-element-attribute-js-null.xhtml 2016-07-21 21:31:16 UTC (rev 203531)
</span><span class="lines">@@ -56,20 +56,6 @@
</span><span class="cx"> ]
</span><span class="cx"> },
</span><span class="cx"> {
</span><del>- type: 'SVGAngle',
- elementToUse: svg.createSVGAngle(),
- attributes: [
- {name: 'valueAsString', expectedNull: '0'}
- ]
- },
- {
- type: 'SVGLength',
- elementToUse: svg.createSVGLength(),
- attributes: [
- {name: 'valueAsString', expectedNull: '0'}
- ]
- },
- {
</del><span class="cx"> type: 'SVGScriptElement',
</span><span class="cx"> elementToUse: document.createElementNS(svgNS, 'script'),
</span><span class="cx"> attributes: [
</span></span></pre></div>
<a id="trunkLayoutTestssvgdomvalueAsStringnullexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/svg/dom/valueAsString-null-expected.txt (0 => 203531)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/svg/dom/valueAsString-null-expected.txt (rev 0)
+++ trunk/LayoutTests/svg/dom/valueAsString-null-expected.txt 2016-07-21 21:31:16 UTC (rev 203531)
</span><span class="lines">@@ -0,0 +1,24 @@
</span><ins>+Test assigning null to SVGAngle.valueAsString / SVGLength.valueAsString
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS angle.valueAsString is "0"
+PASS angle.valueAsString = null threw exception SyntaxError (DOM Exception 12): The string did not match the expected pattern..
+PASS angle.valueAsString is "0"
+PASS angle.valueAsString = '10' did not throw exception.
+PASS angle.valueAsString is "10"
+FAIL angle.valueAsString = '' should throw an exception. Was .
+PASS angle.valueAsString is "10"
+
+PASS length.valueAsString is "0"
+PASS length.valueAsString = null threw exception SyntaxError (DOM Exception 12): The string did not match the expected pattern..
+PASS length.valueAsString is "0"
+PASS length.valueAsString = '10' did not throw exception.
+PASS length.valueAsString is "10"
+FAIL length.valueAsString = '' should throw an exception. Was .
+PASS length.valueAsString is "10"
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
</ins></span></pre></div>
<a id="trunkLayoutTestssvgdomvalueAsStringnullhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/svg/dom/valueAsString-null.html (0 => 203531)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/svg/dom/valueAsString-null.html (rev 0)
+++ trunk/LayoutTests/svg/dom/valueAsString-null.html 2016-07-21 21:31:16 UTC (rev 203531)
</span><span class="lines">@@ -0,0 +1,30 @@
</span><ins>+<!DOCTYPE html>
+<html>
+<body>
+<script src="../../resources/js-test-pre.js"></script>
+<script>
+description("Test assigning null to SVGAngle.valueAsString / SVGLength.valueAsString");
+
+var svg = document.createElementNS('http://www.w3.org/2000/svg', 'svg');
+var angle = svg.createSVGAngle();
+shouldBeEqualToString("angle.valueAsString", "0");
+shouldThrow("angle.valueAsString = null");
+shouldBeEqualToString("angle.valueAsString", "0");
+shouldNotThrow("angle.valueAsString = '10'");
+shouldBeEqualToString("angle.valueAsString", "10");
+shouldThrow("angle.valueAsString = ''");
+shouldBeEqualToString("angle.valueAsString", "10");
+
+debug("");
+var length = svg.createSVGLength();
+shouldBeEqualToString("length.valueAsString", "0");
+shouldThrow("length.valueAsString = null");
+shouldBeEqualToString("length.valueAsString", "0");
+shouldNotThrow("length.valueAsString = '10'");
+shouldBeEqualToString("length.valueAsString", "10");
+shouldThrow("length.valueAsString = ''");
+shouldBeEqualToString("length.valueAsString", "10");
+</script>
+<script src="../../resources/js-test-post.js"></script>
+</body>
+</html>
</ins></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (203530 => 203531)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-07-21 21:25:45 UTC (rev 203530)
+++ trunk/Source/WebCore/ChangeLog 2016-07-21 21:31:16 UTC (rev 203531)
</span><span class="lines">@@ -1,5 +1,45 @@
</span><span class="cx"> 2016-07-21 Chris Dumez <cdumez@apple.com>
</span><span class="cx">
</span><ins>+ Fix null handling of SVGAngle/SVGLength.valueAsString attribute
+ https://bugs.webkit.org/show_bug.cgi?id=160025
+
+ Reviewed by Ryosuke Niwa.
+
+ Fix null handling of SVGAngle/SVGLength.valueAsString attribute
+ to match the specification:
+ - https://www.w3.org/TR/SVG2/types.html#InterfaceSVGAngle
+ - https://www.w3.org/TR/SVG2/types.html#InterfaceSVGLength
+
+ In particular, this patch drops [TreatNullAs=EmptyString] IDL
+ extended attribute from this attribute. This is not supposed
+ to change behavior given that both "" and "null" are invalid
+ numbers and the specification says to throw a SYNTAX_ERR in
+ this case.
+
+ However, WebKit currently ignores assignments to "" instead
+ of throwing. As a result, assigning to null will now throw
+ instead of being ignored. The compatibility risk should be
+ low because both Firefox and Chrome throw when assigning
+ null.
+
+ I did not change the behavior when assigning to "" because
+ it is a bit out of scope for this patch and browsers to not
+ seem to agree:
+ - Firefox throws
+ - Chrome set value to "0"
+ - WebKit ignores the assignment
+
+ The specification seems to agree with Firefox as far as I
+ can tell given that "" is not a valid number as per:
+ - https://www.w3.org/TR/css3-values/#numbers
+
+ Test: svg/dom/valueAsString-null.html
+
+ * svg/SVGAngle.idl:
+ * svg/SVGLength.idl:
+
+2016-07-21 Chris Dumez <cdumez@apple.com>
+
</ins><span class="cx"> Fix null handling of HTMLFontElement.color
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=160036
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoresvgSVGAngleidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/svg/SVGAngle.idl (203530 => 203531)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/svg/SVGAngle.idl 2016-07-21 21:25:45 UTC (rev 203530)
+++ trunk/Source/WebCore/svg/SVGAngle.idl 2016-07-21 21:31:16 UTC (rev 203531)
</span><span class="lines">@@ -32,8 +32,7 @@
</span><span class="cx"> [StrictTypeChecking] attribute unrestricted float value;
</span><span class="cx"> [StrictTypeChecking] attribute unrestricted float valueInSpecifiedUnits;
</span><span class="cx">
</span><del>- // FIXME: This should not have [TreatNullAs=EmptyString].
- [TreatNullAs=EmptyString, SetterRaisesException] attribute DOMString valueAsString;
</del><ins>+ [SetterRaisesException] attribute DOMString valueAsString;
</ins><span class="cx">
</span><span class="cx"> [StrictTypeChecking, RaisesException] void newValueSpecifiedUnits(unsigned short unitType, unrestricted float valueInSpecifiedUnits);
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoresvgSVGLengthidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/svg/SVGLength.idl (203530 => 203531)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/svg/SVGLength.idl 2016-07-21 21:25:45 UTC (rev 203530)
+++ trunk/Source/WebCore/svg/SVGLength.idl 2016-07-21 21:31:16 UTC (rev 203531)
</span><span class="lines">@@ -39,8 +39,7 @@
</span><span class="cx">
</span><span class="cx"> [StrictTypeChecking] attribute unrestricted float valueInSpecifiedUnits;
</span><span class="cx">
</span><del>- // FIXME: This should not use [TreatNullAs=EmptyString].
- [TreatNullAs=EmptyString, StrictTypeChecking, SetterRaisesException] attribute DOMString valueAsString;
</del><ins>+ [StrictTypeChecking, SetterRaisesException] attribute DOMString valueAsString;
</ins><span class="cx">
</span><span class="cx"> [StrictTypeChecking, RaisesException] void newValueSpecifiedUnits(unsigned short unitType,
</span><span class="cx"> unrestricted float valueInSpecifiedUnits);
</span></span></pre>
</div>
</div>
</body>
</html>