<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[203526] trunk/LayoutTests</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/203526">203526</a></dd>
<dt>Author</dt> <dd>dbates@webkit.org</dd>
<dt>Date</dt> <dd>2016-07-21 14:19:22 -0700 (Thu, 21 Jul 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Test platform/ios-simulator/ios/plugin/youtube-flash-plugin-iframe.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=160002
Reviewed by Alexey Proskuryakov.
The file platform/ios-simulator/ios/plugin/youtube-flash-plugin-iframe.html tests loading
plugin content from the main frame and from a subframe. Depending on timing the plugin
content loaded in the subframe may complete before plugin content loaded in the main frame.
We should test loading plugin content in a subframe after perform all main frame sub-tests
so as to ensure a well-defined sub-test order.
Add logic to ensure that an embedded YouTube flash video loaded in a subframe actually creates
a shadow DOM. Additionally, simplify the test logic by making use window.jsTestIsAsync/finishJSTest()
to mark the test as asynchronous and notify test completion instead of calling
window.testRunner.{waitUntilDone, notifyDone}(), remove the call to
testRunner.dumpAsText() (js-test-pre.js calls this for us), remove all of the DOM elements
used in the test to avoid noise in the expected results, and fix some style nits.
* platform/ios-simulator/ios/plugin/youtube-flash-plugin-iframe-expected.txt:
* platform/ios-simulator/ios/plugin/youtube-flash-plugin-iframe.html:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsplatformiossimulatoriospluginyoutubeflashpluginiframeexpectedtxt">trunk/LayoutTests/platform/ios-simulator/ios/plugin/youtube-flash-plugin-iframe-expected.txt</a></li>
<li><a href="#trunkLayoutTestsplatformiossimulatoriospluginyoutubeflashpluginiframehtml">trunk/LayoutTests/platform/ios-simulator/ios/plugin/youtube-flash-plugin-iframe.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (203525 => 203526)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2016-07-21 21:11:06 UTC (rev 203525)
+++ trunk/LayoutTests/ChangeLog 2016-07-21 21:19:22 UTC (rev 203526)
</span><span class="lines">@@ -1,3 +1,26 @@
</span><ins>+2016-07-21 Daniel Bates <dabates@apple.com>
+
+ Test platform/ios-simulator/ios/plugin/youtube-flash-plugin-iframe.html is flaky
+ https://bugs.webkit.org/show_bug.cgi?id=160002
+
+ Reviewed by Alexey Proskuryakov.
+
+ The file platform/ios-simulator/ios/plugin/youtube-flash-plugin-iframe.html tests loading
+ plugin content from the main frame and from a subframe. Depending on timing the plugin
+ content loaded in the subframe may complete before plugin content loaded in the main frame.
+ We should test loading plugin content in a subframe after perform all main frame sub-tests
+ so as to ensure a well-defined sub-test order.
+
+ Add logic to ensure that an embedded YouTube flash video loaded in a subframe actually creates
+ a shadow DOM. Additionally, simplify the test logic by making use window.jsTestIsAsync/finishJSTest()
+ to mark the test as asynchronous and notify test completion instead of calling
+ window.testRunner.{waitUntilDone, notifyDone}(), remove the call to
+ testRunner.dumpAsText() (js-test-pre.js calls this for us), remove all of the DOM elements
+ used in the test to avoid noise in the expected results, and fix some style nits.
+
+ * platform/ios-simulator/ios/plugin/youtube-flash-plugin-iframe-expected.txt:
+ * platform/ios-simulator/ios/plugin/youtube-flash-plugin-iframe.html:
+
</ins><span class="cx"> 2016-07-21 Chris Dumez <cdumez@apple.com>
</span><span class="cx">
</span><span class="cx"> Fix null handling for several HTMLBodyElement attributes
</span></span></pre></div>
<a id="trunkLayoutTestsplatformiossimulatoriospluginyoutubeflashpluginiframeexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/ios-simulator/ios/plugin/youtube-flash-plugin-iframe-expected.txt (203525 => 203526)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/ios-simulator/ios/plugin/youtube-flash-plugin-iframe-expected.txt 2016-07-21 21:11:06 UTC (rev 203525)
+++ trunk/LayoutTests/platform/ios-simulator/ios/plugin/youtube-flash-plugin-iframe-expected.txt 2016-07-21 21:19:22 UTC (rev 203526)
</span><span class="lines">@@ -8,9 +8,6 @@
</span><span class="cx"> On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
</span><span class="cx">
</span><span class="cx">
</span><del>-PASS successfullyParsed is true
-
-TEST COMPLETE
</del><span class="cx"> PASS normalEmbed.tagName is "EMBED"
</span><span class="cx"> PASS elinkEmbed.tagName is "EMBED"
</span><span class="cx"> PASS objectEmbed.tagName is "EMBED"
</span><span class="lines">@@ -22,13 +19,9 @@
</span><span class="cx"> PASS objectEmbedShadowRoot.firstChild.firstChild.tagName is "IFRAME"
</span><span class="cx"> PASS internals.shadowPseudoId(objectNoEmbedShadowRoot.firstChild) is "-webkit-plugin-replacement"
</span><span class="cx"> PASS objectNoEmbedShadowRoot.firstChild.firstChild.tagName is "IFRAME"
</span><del>-Normal Embed:
</del><ins>+PASS internals.shadowPseudoId(normalEmbedInIframeShadowRoot.firstChild) is "-webkit-plugin-replacement"
+PASS normalEmbedInIframeShadowRoot.firstChild.firstChild.tagName is "IFRAME"
+PASS successfullyParsed is true
</ins><span class="cx">
</span><del>-E-link Embed:
</del><ins>+TEST COMPLETE
</ins><span class="cx">
</span><del>-Object with embed:
-
-Object without embed:
-
-Embed inside iframe:
-
</del></span></pre></div>
<a id="trunkLayoutTestsplatformiossimulatoriospluginyoutubeflashpluginiframehtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/ios-simulator/ios/plugin/youtube-flash-plugin-iframe.html (203525 => 203526)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/ios-simulator/ios/plugin/youtube-flash-plugin-iframe.html 2016-07-21 21:11:06 UTC (rev 203525)
+++ trunk/LayoutTests/platform/ios-simulator/ios/plugin/youtube-flash-plugin-iframe.html 2016-07-21 21:19:22 UTC (rev 203526)
</span><span class="lines">@@ -3,15 +3,37 @@
</span><span class="cx"> <head>
</span><span class="cx"> <script src="../../../../resources/js-test-pre.js"></script>
</span><span class="cx"> <script>
</span><del>-if (window.testRunner) {
- testRunner.waitUntilDone();
- testRunner.dumpAsText();
-}
</del><ins>+window.jsTestIsAsync = true;
</ins><span class="cx">
</span><span class="cx"> description(
</span><span class="cx"> 'Test transforming youtube flash plugin to youtube iFrame based player. &lt;<a href="rdar://problem/11201356"> rdar://problem/11201356</a>&gt;'
</span><span class="cx"> );
</span><span class="cx">
</span><ins>+function checkEmbeddedYouTubeVideoInsideIframe()
+{
+ normalEmbedInIframe = document.getElementById('test-iframe').contentDocument.getElementById('normal-embed');
+ normalEmbedInIframeShadowRoot = internals.shadowRoot(normalEmbedInIframe);
+ shouldBe('internals.shadowPseudoId(normalEmbedInIframeShadowRoot.firstChild)', '"-webkit-plugin-replacement"');
+ shouldBe('normalEmbedInIframeShadowRoot.firstChild.firstChild.tagName', '"IFRAME"');
+
+ document.body.removeChild(document.getElementById("test-container"));
+ finishJSTest();
+}
+
+function testEmbedYouTubeVideoInsideIframe()
+{
+ var markup = [
+ '<body>',
+ '<p>Normal Embed:<br><embed id="normal-embed" src="http://www.youtube.com/v/N0gb9v4LI4o" type="application/x-shockwave-flash" width="425" height="350"></p>',
+ '<script>',
+ 'window.setTimeout(window.parent.checkEmbeddedYouTubeVideoInsideIframe, 0);',
+ '</' + 'script>',
+ '</body>',
+ ];
+ var iframe = document.getElementById('test-iframe');
+ iframe.srcdoc = markup.join("");
+}
+
</ins><span class="cx"> function Test()
</span><span class="cx"> {
</span><span class="cx"> setTimeout(function() {
</span><span class="lines">@@ -42,9 +64,8 @@
</span><span class="cx"> shouldBe('internals.shadowPseudoId(objectNoEmbedShadowRoot.firstChild)', '"-webkit-plugin-replacement"');
</span><span class="cx"> shouldBe('objectNoEmbedShadowRoot.firstChild.firstChild.tagName', '"IFRAME"');
</span><span class="cx">
</span><del>- var successfullyParsed = true;
- testRunner.notifyDone();
- }, 100);
</del><ins>+ testEmbedYouTubeVideoInsideIframe();
+ }, 0);
</ins><span class="cx"> }
</span><span class="cx"> </script>
</span><span class="cx"> </head>
</span><span class="lines">@@ -52,13 +73,20 @@
</span><span class="cx"> <p id="description"></p>
</span><span class="cx"> <div id="console"></div>
</span><span class="cx">
</span><del>-<p>Normal Embed:<br><embed id='normal-embed' src="http://www.youtube.com/v/N0gb9v4LI4o" type="application/x-shockwave-flash" width="425" height="350"></p>
-<p>E-link Embed:<br><embed id='elink-embed' src="http://www.youtube.com/e/N0gb9v4LI4o" type="application/x-shockwave-flash" width="425" height="350"></p>
-<p>Object with embed:<br><object width="425" height="350"><param name="movie" value="http://www.youtube.com/v/N0gb9v4LI4o?version=3&amp;hl=en_US"></param><param name="allowFullScreen" value="true"></param><param name="allowscriptaccess" value="always"></param><embed id='object-embed' src="http://www.youtube.com/v/N0gb9v4LI4o?version=3&amp;hl=en_US" type="application/x-shockwave-flash" width="425" height="350" allowscriptaccess="always" allowfullscreen="true"></embed></object></p>
-<p>Object without embed:<br><object id='object-no-embed' width="425" height="350" type="application/x-shockwave-flash" data="http://www.youtube.com/v/N0gb9v4LI4o?version=3&amp;hl=en_US"></object>
-<p>Embed inside iframe:<br>
-<iframe width="300" height="200"id='container-iframe' src='data:text/html,<body><p>Normal Embed:<br><embed id="normal-embed" src="http://www.youtube.com/v/N0gb9v4LI4o" type="application/x-shockwave-flash" width="425" height="350"></p></body>' >
-</iframe>
</del><ins>+<div id="test-container">
+ <p>Normal Embed:<br><embed id="normal-embed" src="http://www.youtube.com/v/N0gb9v4LI4o" type="application/x-shockwave-flash" width="425" height="350"></p>
+ <p>E-link Embed:<br><embed id="elink-embed" src="http://www.youtube.com/e/N0gb9v4LI4o" type="application/x-shockwave-flash" width="425" height="350"></p>
+ <p>Object with embed:<br>
+ <object width="425" height="350">
+ <param name="movie" value="http://www.youtube.com/v/N0gb9v4LI4o?version=3&amp;hl=en_US"></param>
+ <param name="allowFullScreen" value="true"></param><param name="allowscriptaccess" value="always"></param>
+ <embed id="object-embed" src="http://www.youtube.com/v/N0gb9v4LI4o?version=3&amp;hl=en_US" type="application/x-shockwave-flash" width="425" height="350" allowscriptaccess="always" allowfullscreen="true"></embed>
+ </object>
+ </p>
+ <p>Object without embed:<br><object id="object-no-embed" width="425" height="350" type="application/x-shockwave-flash" data="http://www.youtube.com/v/N0gb9v4LI4o?version=3&amp;hl=en_US"></object>
+ <p>Embed inside iframe:<br>
+ <iframe width="300" height="200" id="test-iframe"></iframe>
+</div>
</ins><span class="cx">
</span><span class="cx"> <script src="../../../../resources/js-test-post.js"></script>
</span><span class="cx"> </body>
</span></span></pre>
</div>
</div>
</body>
</html>