<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[203552] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/203552">203552</a></dd>
<dt>Author</dt> <dd>cdumez@apple.com</dd>
<dt>Date</dt> <dd>2016-07-21 21:51:28 -0700 (Thu, 21 Jul 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Parameter to Node.isSameNode() / isEqualNode() should be mandatory
https://bugs.webkit.org/show_bug.cgi?id=160070
Reviewed by Ryosuke Niwa.
LayoutTests/imported/w3c:
Rebaseline several W3C tests now that more checks are passing.
* web-platform-tests/dom/interfaces-expected.txt:
* web-platform-tests/html/dom/interfaces-expected.txt:
Source/WebCore:
Parameter to Node.isSameNode() / isEqualNode() should be mandatory as
per the specification:
- https://dom.spec.whatwg.org/#interface-node
Chrome and Firefox agree with the specification (although Firefox does
not support isSameNode()).
No new tests, rebaselined existing tests.
* dom/Node.idl:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsimportedw3cChangeLog">trunk/LayoutTests/imported/w3c/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestsdominterfacesexpectedtxt">trunk/LayoutTests/imported/w3c/web-platform-tests/dom/interfaces-expected.txt</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestshtmldominterfacesexpectedtxt">trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoredomNodeidl">trunk/Source/WebCore/dom/Node.idl</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsimportedw3cChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/ChangeLog (203551 => 203552)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/ChangeLog 2016-07-22 04:45:20 UTC (rev 203551)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2016-07-22 04:51:28 UTC (rev 203552)
</span><span class="lines">@@ -1,5 +1,17 @@
</span><span class="cx"> 2016-07-21 Chris Dumez <cdumez@apple.com>
</span><span class="cx">
</span><ins>+ Parameter to Node.isSameNode() / isEqualNode() should be mandatory
+ https://bugs.webkit.org/show_bug.cgi?id=160070
+
+ Reviewed by Ryosuke Niwa.
+
+ Rebaseline several W3C tests now that more checks are passing.
+
+ * web-platform-tests/dom/interfaces-expected.txt:
+ * web-platform-tests/html/dom/interfaces-expected.txt:
+
+2016-07-21 Chris Dumez <cdumez@apple.com>
+
</ins><span class="cx"> Parameter to Document.createEvent() should be mandatory
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=160065
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestsdominterfacesexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/dom/interfaces-expected.txt (203551 => 203552)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/dom/interfaces-expected.txt 2016-07-22 04:45:20 UTC (rev 203551)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/dom/interfaces-expected.txt 2016-07-22 04:51:28 UTC (rev 203552)
</span><span class="lines">@@ -216,8 +216,8 @@
</span><span class="cx"> PASS Node interface: attribute textContent
</span><span class="cx"> PASS Node interface: operation normalize()
</span><span class="cx"> PASS Node interface: operation cloneNode(boolean)
</span><del>-FAIL Node interface: operation isEqualNode(Node) assert_equals: property has wrong .length expected 1 but got 0
-FAIL Node interface: operation isSameNode(Node) assert_equals: property has wrong .length expected 1 but got 0
</del><ins>+PASS Node interface: operation isEqualNode(Node)
+PASS Node interface: operation isSameNode(Node)
</ins><span class="cx"> PASS Node interface: constant DOCUMENT_POSITION_DISCONNECTED on interface object
</span><span class="cx"> PASS Node interface: constant DOCUMENT_POSITION_DISCONNECTED on interface prototype object
</span><span class="cx"> PASS Node interface: constant DOCUMENT_POSITION_PRECEDING on interface object
</span><span class="lines">@@ -373,13 +373,9 @@
</span><span class="cx"> PASS Node interface: new Document() must inherit property "cloneNode" with the proper type (28)
</span><span class="cx"> PASS Node interface: calling cloneNode(boolean) on new Document() with too few arguments must throw TypeError
</span><span class="cx"> PASS Node interface: new Document() must inherit property "isEqualNode" with the proper type (29)
</span><del>-FAIL Node interface: calling isEqualNode(Node) on new Document() with too few arguments must throw TypeError assert_throws: Called with 0 arguments function "function () {
- fn.apply(obj, args);
- }" did not throw
</del><ins>+PASS Node interface: calling isEqualNode(Node) on new Document() with too few arguments must throw TypeError
</ins><span class="cx"> PASS Node interface: new Document() must inherit property "isSameNode" with the proper type (30)
</span><del>-FAIL Node interface: calling isSameNode(Node) on new Document() with too few arguments must throw TypeError assert_throws: Called with 0 arguments function "function () {
- fn.apply(obj, args);
- }" did not throw
</del><ins>+PASS Node interface: calling isSameNode(Node) on new Document() with too few arguments must throw TypeError
</ins><span class="cx"> PASS Node interface: new Document() must inherit property "DOCUMENT_POSITION_DISCONNECTED" with the proper type (31)
</span><span class="cx"> PASS Node interface: new Document() must inherit property "DOCUMENT_POSITION_PRECEDING" with the proper type (32)
</span><span class="cx"> PASS Node interface: new Document() must inherit property "DOCUMENT_POSITION_FOLLOWING" with the proper type (33)
</span><span class="lines">@@ -519,13 +515,9 @@
</span><span class="cx"> PASS Node interface: xmlDoc must inherit property "cloneNode" with the proper type (28)
</span><span class="cx"> PASS Node interface: calling cloneNode(boolean) on xmlDoc with too few arguments must throw TypeError
</span><span class="cx"> PASS Node interface: xmlDoc must inherit property "isEqualNode" with the proper type (29)
</span><del>-FAIL Node interface: calling isEqualNode(Node) on xmlDoc with too few arguments must throw TypeError assert_throws: Called with 0 arguments function "function () {
- fn.apply(obj, args);
- }" did not throw
</del><ins>+PASS Node interface: calling isEqualNode(Node) on xmlDoc with too few arguments must throw TypeError
</ins><span class="cx"> PASS Node interface: xmlDoc must inherit property "isSameNode" with the proper type (30)
</span><del>-FAIL Node interface: calling isSameNode(Node) on xmlDoc with too few arguments must throw TypeError assert_throws: Called with 0 arguments function "function () {
- fn.apply(obj, args);
- }" did not throw
</del><ins>+PASS Node interface: calling isSameNode(Node) on xmlDoc with too few arguments must throw TypeError
</ins><span class="cx"> PASS Node interface: xmlDoc must inherit property "DOCUMENT_POSITION_DISCONNECTED" with the proper type (31)
</span><span class="cx"> PASS Node interface: xmlDoc must inherit property "DOCUMENT_POSITION_PRECEDING" with the proper type (32)
</span><span class="cx"> PASS Node interface: xmlDoc must inherit property "DOCUMENT_POSITION_FOLLOWING" with the proper type (33)
</span><span class="lines">@@ -643,13 +635,9 @@
</span><span class="cx"> PASS Node interface: document.doctype must inherit property "cloneNode" with the proper type (28)
</span><span class="cx"> PASS Node interface: calling cloneNode(boolean) on document.doctype with too few arguments must throw TypeError
</span><span class="cx"> PASS Node interface: document.doctype must inherit property "isEqualNode" with the proper type (29)
</span><del>-FAIL Node interface: calling isEqualNode(Node) on document.doctype with too few arguments must throw TypeError assert_throws: Called with 0 arguments function "function () {
- fn.apply(obj, args);
- }" did not throw
</del><ins>+PASS Node interface: calling isEqualNode(Node) on document.doctype with too few arguments must throw TypeError
</ins><span class="cx"> PASS Node interface: document.doctype must inherit property "isSameNode" with the proper type (30)
</span><del>-FAIL Node interface: calling isSameNode(Node) on document.doctype with too few arguments must throw TypeError assert_throws: Called with 0 arguments function "function () {
- fn.apply(obj, args);
- }" did not throw
</del><ins>+PASS Node interface: calling isSameNode(Node) on document.doctype with too few arguments must throw TypeError
</ins><span class="cx"> PASS Node interface: document.doctype must inherit property "DOCUMENT_POSITION_DISCONNECTED" with the proper type (31)
</span><span class="cx"> PASS Node interface: document.doctype must inherit property "DOCUMENT_POSITION_PRECEDING" with the proper type (32)
</span><span class="cx"> PASS Node interface: document.doctype must inherit property "DOCUMENT_POSITION_FOLLOWING" with the proper type (33)
</span><span class="lines">@@ -755,13 +743,9 @@
</span><span class="cx"> PASS Node interface: document.createDocumentFragment() must inherit property "cloneNode" with the proper type (28)
</span><span class="cx"> PASS Node interface: calling cloneNode(boolean) on document.createDocumentFragment() with too few arguments must throw TypeError
</span><span class="cx"> PASS Node interface: document.createDocumentFragment() must inherit property "isEqualNode" with the proper type (29)
</span><del>-FAIL Node interface: calling isEqualNode(Node) on document.createDocumentFragment() with too few arguments must throw TypeError assert_throws: Called with 0 arguments function "function () {
- fn.apply(obj, args);
- }" did not throw
</del><ins>+PASS Node interface: calling isEqualNode(Node) on document.createDocumentFragment() with too few arguments must throw TypeError
</ins><span class="cx"> PASS Node interface: document.createDocumentFragment() must inherit property "isSameNode" with the proper type (30)
</span><del>-FAIL Node interface: calling isSameNode(Node) on document.createDocumentFragment() with too few arguments must throw TypeError assert_throws: Called with 0 arguments function "function () {
- fn.apply(obj, args);
- }" did not throw
</del><ins>+PASS Node interface: calling isSameNode(Node) on document.createDocumentFragment() with too few arguments must throw TypeError
</ins><span class="cx"> PASS Node interface: document.createDocumentFragment() must inherit property "DOCUMENT_POSITION_DISCONNECTED" with the proper type (31)
</span><span class="cx"> PASS Node interface: document.createDocumentFragment() must inherit property "DOCUMENT_POSITION_PRECEDING" with the proper type (32)
</span><span class="cx"> PASS Node interface: document.createDocumentFragment() must inherit property "DOCUMENT_POSITION_FOLLOWING" with the proper type (33)
</span><span class="lines">@@ -976,13 +960,9 @@
</span><span class="cx"> PASS Node interface: element must inherit property "cloneNode" with the proper type (28)
</span><span class="cx"> PASS Node interface: calling cloneNode(boolean) on element with too few arguments must throw TypeError
</span><span class="cx"> PASS Node interface: element must inherit property "isEqualNode" with the proper type (29)
</span><del>-FAIL Node interface: calling isEqualNode(Node) on element with too few arguments must throw TypeError assert_throws: Called with 0 arguments function "function () {
- fn.apply(obj, args);
- }" did not throw
</del><ins>+PASS Node interface: calling isEqualNode(Node) on element with too few arguments must throw TypeError
</ins><span class="cx"> PASS Node interface: element must inherit property "isSameNode" with the proper type (30)
</span><del>-FAIL Node interface: calling isSameNode(Node) on element with too few arguments must throw TypeError assert_throws: Called with 0 arguments function "function () {
- fn.apply(obj, args);
- }" did not throw
</del><ins>+PASS Node interface: calling isSameNode(Node) on element with too few arguments must throw TypeError
</ins><span class="cx"> PASS Node interface: element must inherit property "DOCUMENT_POSITION_DISCONNECTED" with the proper type (31)
</span><span class="cx"> PASS Node interface: element must inherit property "DOCUMENT_POSITION_PRECEDING" with the proper type (32)
</span><span class="cx"> PASS Node interface: element must inherit property "DOCUMENT_POSITION_FOLLOWING" with the proper type (33)
</span><span class="lines">@@ -1153,13 +1133,9 @@
</span><span class="cx"> PASS Node interface: document.createTextNode("abc") must inherit property "cloneNode" with the proper type (28)
</span><span class="cx"> PASS Node interface: calling cloneNode(boolean) on document.createTextNode("abc") with too few arguments must throw TypeError
</span><span class="cx"> PASS Node interface: document.createTextNode("abc") must inherit property "isEqualNode" with the proper type (29)
</span><del>-FAIL Node interface: calling isEqualNode(Node) on document.createTextNode("abc") with too few arguments must throw TypeError assert_throws: Called with 0 arguments function "function () {
- fn.apply(obj, args);
- }" did not throw
</del><ins>+PASS Node interface: calling isEqualNode(Node) on document.createTextNode("abc") with too few arguments must throw TypeError
</ins><span class="cx"> PASS Node interface: document.createTextNode("abc") must inherit property "isSameNode" with the proper type (30)
</span><del>-FAIL Node interface: calling isSameNode(Node) on document.createTextNode("abc") with too few arguments must throw TypeError assert_throws: Called with 0 arguments function "function () {
- fn.apply(obj, args);
- }" did not throw
</del><ins>+PASS Node interface: calling isSameNode(Node) on document.createTextNode("abc") with too few arguments must throw TypeError
</ins><span class="cx"> PASS Node interface: document.createTextNode("abc") must inherit property "DOCUMENT_POSITION_DISCONNECTED" with the proper type (31)
</span><span class="cx"> PASS Node interface: document.createTextNode("abc") must inherit property "DOCUMENT_POSITION_PRECEDING" with the proper type (32)
</span><span class="cx"> PASS Node interface: document.createTextNode("abc") must inherit property "DOCUMENT_POSITION_FOLLOWING" with the proper type (33)
</span><span class="lines">@@ -1263,13 +1239,9 @@
</span><span class="cx"> PASS Node interface: xmlDoc.createProcessingInstruction("abc", "def") must inherit property "cloneNode" with the proper type (28)
</span><span class="cx"> PASS Node interface: calling cloneNode(boolean) on xmlDoc.createProcessingInstruction("abc", "def") with too few arguments must throw TypeError
</span><span class="cx"> PASS Node interface: xmlDoc.createProcessingInstruction("abc", "def") must inherit property "isEqualNode" with the proper type (29)
</span><del>-FAIL Node interface: calling isEqualNode(Node) on xmlDoc.createProcessingInstruction("abc", "def") with too few arguments must throw TypeError assert_throws: Called with 0 arguments function "function () {
- fn.apply(obj, args);
- }" did not throw
</del><ins>+PASS Node interface: calling isEqualNode(Node) on xmlDoc.createProcessingInstruction("abc", "def") with too few arguments must throw TypeError
</ins><span class="cx"> PASS Node interface: xmlDoc.createProcessingInstruction("abc", "def") must inherit property "isSameNode" with the proper type (30)
</span><del>-FAIL Node interface: calling isSameNode(Node) on xmlDoc.createProcessingInstruction("abc", "def") with too few arguments must throw TypeError assert_throws: Called with 0 arguments function "function () {
- fn.apply(obj, args);
- }" did not throw
</del><ins>+PASS Node interface: calling isSameNode(Node) on xmlDoc.createProcessingInstruction("abc", "def") with too few arguments must throw TypeError
</ins><span class="cx"> PASS Node interface: xmlDoc.createProcessingInstruction("abc", "def") must inherit property "DOCUMENT_POSITION_DISCONNECTED" with the proper type (31)
</span><span class="cx"> PASS Node interface: xmlDoc.createProcessingInstruction("abc", "def") must inherit property "DOCUMENT_POSITION_PRECEDING" with the proper type (32)
</span><span class="cx"> PASS Node interface: xmlDoc.createProcessingInstruction("abc", "def") must inherit property "DOCUMENT_POSITION_FOLLOWING" with the proper type (33)
</span><span class="lines">@@ -1371,13 +1343,9 @@
</span><span class="cx"> PASS Node interface: document.createComment("abc") must inherit property "cloneNode" with the proper type (28)
</span><span class="cx"> PASS Node interface: calling cloneNode(boolean) on document.createComment("abc") with too few arguments must throw TypeError
</span><span class="cx"> PASS Node interface: document.createComment("abc") must inherit property "isEqualNode" with the proper type (29)
</span><del>-FAIL Node interface: calling isEqualNode(Node) on document.createComment("abc") with too few arguments must throw TypeError assert_throws: Called with 0 arguments function "function () {
- fn.apply(obj, args);
- }" did not throw
</del><ins>+PASS Node interface: calling isEqualNode(Node) on document.createComment("abc") with too few arguments must throw TypeError
</ins><span class="cx"> PASS Node interface: document.createComment("abc") must inherit property "isSameNode" with the proper type (30)
</span><del>-FAIL Node interface: calling isSameNode(Node) on document.createComment("abc") with too few arguments must throw TypeError assert_throws: Called with 0 arguments function "function () {
- fn.apply(obj, args);
- }" did not throw
</del><ins>+PASS Node interface: calling isSameNode(Node) on document.createComment("abc") with too few arguments must throw TypeError
</ins><span class="cx"> PASS Node interface: document.createComment("abc") must inherit property "DOCUMENT_POSITION_DISCONNECTED" with the proper type (31)
</span><span class="cx"> PASS Node interface: document.createComment("abc") must inherit property "DOCUMENT_POSITION_PRECEDING" with the proper type (32)
</span><span class="cx"> PASS Node interface: document.createComment("abc") must inherit property "DOCUMENT_POSITION_FOLLOWING" with the proper type (33)
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestshtmldominterfacesexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt (203551 => 203552)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt 2016-07-22 04:45:20 UTC (rev 203551)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt 2016-07-22 04:51:28 UTC (rev 203552)
</span><span class="lines">@@ -356,9 +356,7 @@
</span><span class="cx"> PASS Node interface: iframe.contentDocument must inherit property "cloneNode" with the proper type (27)
</span><span class="cx"> PASS Node interface: calling cloneNode(boolean) on iframe.contentDocument with too few arguments must throw TypeError
</span><span class="cx"> PASS Node interface: iframe.contentDocument must inherit property "isEqualNode" with the proper type (28)
</span><del>-FAIL Node interface: calling isEqualNode(Node) on iframe.contentDocument with too few arguments must throw TypeError assert_throws: Called with 0 arguments function "function () {
- fn.apply(obj, args);
- }" did not throw
</del><ins>+PASS Node interface: calling isEqualNode(Node) on iframe.contentDocument with too few arguments must throw TypeError
</ins><span class="cx"> PASS Node interface: iframe.contentDocument must inherit property "DOCUMENT_POSITION_DISCONNECTED" with the proper type (29)
</span><span class="cx"> PASS Node interface: iframe.contentDocument must inherit property "DOCUMENT_POSITION_PRECEDING" with the proper type (30)
</span><span class="cx"> PASS Node interface: iframe.contentDocument must inherit property "DOCUMENT_POSITION_FOLLOWING" with the proper type (31)
</span><span class="lines">@@ -636,9 +634,7 @@
</span><span class="cx"> PASS Node interface: new Document() must inherit property "cloneNode" with the proper type (27)
</span><span class="cx"> PASS Node interface: calling cloneNode(boolean) on new Document() with too few arguments must throw TypeError
</span><span class="cx"> PASS Node interface: new Document() must inherit property "isEqualNode" with the proper type (28)
</span><del>-FAIL Node interface: calling isEqualNode(Node) on new Document() with too few arguments must throw TypeError assert_throws: Called with 0 arguments function "function () {
- fn.apply(obj, args);
- }" did not throw
</del><ins>+PASS Node interface: calling isEqualNode(Node) on new Document() with too few arguments must throw TypeError
</ins><span class="cx"> PASS Node interface: new Document() must inherit property "DOCUMENT_POSITION_DISCONNECTED" with the proper type (29)
</span><span class="cx"> PASS Node interface: new Document() must inherit property "DOCUMENT_POSITION_PRECEDING" with the proper type (30)
</span><span class="cx"> PASS Node interface: new Document() must inherit property "DOCUMENT_POSITION_FOLLOWING" with the proper type (31)
</span><span class="lines">@@ -919,9 +915,7 @@
</span><span class="cx"> PASS Node interface: document.implementation.createDocument(null, "", null) must inherit property "cloneNode" with the proper type (27)
</span><span class="cx"> PASS Node interface: calling cloneNode(boolean) on document.implementation.createDocument(null, "", null) with too few arguments must throw TypeError
</span><span class="cx"> PASS Node interface: document.implementation.createDocument(null, "", null) must inherit property "isEqualNode" with the proper type (28)
</span><del>-FAIL Node interface: calling isEqualNode(Node) on document.implementation.createDocument(null, "", null) with too few arguments must throw TypeError assert_throws: Called with 0 arguments function "function () {
- fn.apply(obj, args);
- }" did not throw
</del><ins>+PASS Node interface: calling isEqualNode(Node) on document.implementation.createDocument(null, "", null) with too few arguments must throw TypeError
</ins><span class="cx"> PASS Node interface: document.implementation.createDocument(null, "", null) must inherit property "DOCUMENT_POSITION_DISCONNECTED" with the proper type (29)
</span><span class="cx"> PASS Node interface: document.implementation.createDocument(null, "", null) must inherit property "DOCUMENT_POSITION_PRECEDING" with the proper type (30)
</span><span class="cx"> PASS Node interface: document.implementation.createDocument(null, "", null) must inherit property "DOCUMENT_POSITION_FOLLOWING" with the proper type (31)
</span><span class="lines">@@ -1325,9 +1319,7 @@
</span><span class="cx"> PASS Node interface: document.createElement("noscript") must inherit property "cloneNode" with the proper type (27)
</span><span class="cx"> PASS Node interface: calling cloneNode(boolean) on document.createElement("noscript") with too few arguments must throw TypeError
</span><span class="cx"> PASS Node interface: document.createElement("noscript") must inherit property "isEqualNode" with the proper type (28)
</span><del>-FAIL Node interface: calling isEqualNode(Node) on document.createElement("noscript") with too few arguments must throw TypeError assert_throws: Called with 0 arguments function "function () {
- fn.apply(obj, args);
- }" did not throw
</del><ins>+PASS Node interface: calling isEqualNode(Node) on document.createElement("noscript") with too few arguments must throw TypeError
</ins><span class="cx"> PASS Node interface: document.createElement("noscript") must inherit property "DOCUMENT_POSITION_DISCONNECTED" with the proper type (29)
</span><span class="cx"> PASS Node interface: document.createElement("noscript") must inherit property "DOCUMENT_POSITION_PRECEDING" with the proper type (30)
</span><span class="cx"> PASS Node interface: document.createElement("noscript") must inherit property "DOCUMENT_POSITION_FOLLOWING" with the proper type (31)
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (203551 => 203552)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-07-22 04:45:20 UTC (rev 203551)
+++ trunk/Source/WebCore/ChangeLog 2016-07-22 04:51:28 UTC (rev 203552)
</span><span class="lines">@@ -1,5 +1,23 @@
</span><span class="cx"> 2016-07-21 Chris Dumez <cdumez@apple.com>
</span><span class="cx">
</span><ins>+ Parameter to Node.isSameNode() / isEqualNode() should be mandatory
+ https://bugs.webkit.org/show_bug.cgi?id=160070
+
+ Reviewed by Ryosuke Niwa.
+
+ Parameter to Node.isSameNode() / isEqualNode() should be mandatory as
+ per the specification:
+ - https://dom.spec.whatwg.org/#interface-node
+
+ Chrome and Firefox agree with the specification (although Firefox does
+ not support isSameNode()).
+
+ No new tests, rebaselined existing tests.
+
+ * dom/Node.idl:
+
+2016-07-21 Chris Dumez <cdumez@apple.com>
+
</ins><span class="cx"> Parameter to Document.createEvent() should be mandatory
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=160065
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoredomNodeidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Node.idl (203551 => 203552)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Node.idl 2016-07-22 04:45:20 UTC (rev 203551)
+++ trunk/Source/WebCore/dom/Node.idl 2016-07-22 04:51:28 UTC (rev 203552)
</span><span class="lines">@@ -96,10 +96,8 @@
</span><span class="cx"> // FIXME: the spec says this can also raise on retrieval.
</span><span class="cx"> [SetterRaisesException] attribute DOMString? textContent;
</span><span class="cx">
</span><del>- // FIXME: other should not be optional.
- boolean isSameNode(optional Node? other = null);
- // FIXME: other should not be optional.
- boolean isEqualNode(optional Node? other = null);
</del><ins>+ boolean isSameNode(Node? other);
+ boolean isEqualNode(Node? other);
</ins><span class="cx">
</span><span class="cx"> DOMString? lookupPrefix(optional DOMString? namespaceURI = null);
</span><span class="cx"> boolean isDefaultNamespace(optional DOMString? namespaceURI = null);
</span></span></pre>
</div>
</div>
</body>
</html>