<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[203500] trunk/Source/WebKit2</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/203500">203500</a></dd>
<dt>Author</dt> <dd>carlosgc@webkit.org</dd>
<dt>Date</dt> <dd>2016-07-21 00:35:49 -0700 (Thu, 21 Jul 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>[GTK] White page when loaded tab is visited until it's hovered when AC mode is always on
https://bugs.webkit.org/show_bug.cgi?id=159512
Reviewed by Michael Catanzaro.
The redirected window is always mapped, but offscreen, to ensure that the web process can always render
there. When the web process renders something into the offscreen window, we receive a damage event in the UI
process and queue a redraw of the web view. However, when the web view is not mapped, even if we still receive
the damage events, the web view redraws are ignored until the view is mapped again (gtk_widget_queue_draw()
returns early when the widget is not visible). The redirected window updates its pixmap on demand when the
surface is requested, which happens when the web view draws its contents. So when the web view becames visible,
the redirected window creates a new pixmap and surface (the first time or if the web view was resized), that we
initialize to avoid artifacts when the web process hasn't render anything yet. That initialization is actually
overwriting anything rendered into the redirected window while the view was unmapped. That's why see white pages
the first time, and previous contents after a resize, and we don't see the actual contents until the web process
renders again and we reuse the existing pixmap. The white page didn't happen for tabs with accelerated content,
because in those cases the web process was rendering a new frame every 16ms, but instead there was a flickering
effect due to the current frame being overwritten when the view is mapped until the next frame.
So, instead of lazily create and initialize the redirected window pixmap and surface, we should always create
the new pixmap as soon as the window is created or resized (and not empty) This fixes the issues but also makes
resizing the window a bit smoother when AC mode is enabled.
* UIProcess/gtk/RedirectedXCompositeWindow.cpp:
(WebKit::RedirectedXCompositeWindow::RedirectedXCompositeWindow): Create the pixmap and surface if the window is
not empty.
(WebKit::RedirectedXCompositeWindow::resize): Ditto.
(WebKit::RedirectedXCompositeWindow::createNewPixampAndPixampSurface): Create the pixmap and surface.
(WebKit::RedirectedXCompositeWindow::surface): Deleted.
* UIProcess/gtk/RedirectedXCompositeWindow.h:
(WebKit::RedirectedXCompositeWindow::surface):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebKit2ChangeLog">trunk/Source/WebKit2/ChangeLog</a></li>
<li><a href="#trunkSourceWebKit2UIProcessgtkRedirectedXCompositeWindowcpp">trunk/Source/WebKit2/UIProcess/gtk/RedirectedXCompositeWindow.cpp</a></li>
<li><a href="#trunkSourceWebKit2UIProcessgtkRedirectedXCompositeWindowh">trunk/Source/WebKit2/UIProcess/gtk/RedirectedXCompositeWindow.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebKit2ChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/ChangeLog (203499 => 203500)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/ChangeLog 2016-07-21 07:33:28 UTC (rev 203499)
+++ trunk/Source/WebKit2/ChangeLog 2016-07-21 07:35:49 UTC (rev 203500)
</span><span class="lines">@@ -1,5 +1,38 @@
</span><span class="cx"> 2016-07-21 Carlos Garcia Campos <cgarcia@igalia.com>
</span><span class="cx">
</span><ins>+ [GTK] White page when loaded tab is visited until it's hovered when AC mode is always on
+ https://bugs.webkit.org/show_bug.cgi?id=159512
+
+ Reviewed by Michael Catanzaro.
+
+ The redirected window is always mapped, but offscreen, to ensure that the web process can always render
+ there. When the web process renders something into the offscreen window, we receive a damage event in the UI
+ process and queue a redraw of the web view. However, when the web view is not mapped, even if we still receive
+ the damage events, the web view redraws are ignored until the view is mapped again (gtk_widget_queue_draw()
+ returns early when the widget is not visible). The redirected window updates its pixmap on demand when the
+ surface is requested, which happens when the web view draws its contents. So when the web view becames visible,
+ the redirected window creates a new pixmap and surface (the first time or if the web view was resized), that we
+ initialize to avoid artifacts when the web process hasn't render anything yet. That initialization is actually
+ overwriting anything rendered into the redirected window while the view was unmapped. That's why see white pages
+ the first time, and previous contents after a resize, and we don't see the actual contents until the web process
+ renders again and we reuse the existing pixmap. The white page didn't happen for tabs with accelerated content,
+ because in those cases the web process was rendering a new frame every 16ms, but instead there was a flickering
+ effect due to the current frame being overwritten when the view is mapped until the next frame.
+ So, instead of lazily create and initialize the redirected window pixmap and surface, we should always create
+ the new pixmap as soon as the window is created or resized (and not empty) This fixes the issues but also makes
+ resizing the window a bit smoother when AC mode is enabled.
+
+ * UIProcess/gtk/RedirectedXCompositeWindow.cpp:
+ (WebKit::RedirectedXCompositeWindow::RedirectedXCompositeWindow): Create the pixmap and surface if the window is
+ not empty.
+ (WebKit::RedirectedXCompositeWindow::resize): Ditto.
+ (WebKit::RedirectedXCompositeWindow::createNewPixampAndPixampSurface): Create the pixmap and surface.
+ (WebKit::RedirectedXCompositeWindow::surface): Deleted.
+ * UIProcess/gtk/RedirectedXCompositeWindow.h:
+ (WebKit::RedirectedXCompositeWindow::surface):
+
+2016-07-21 Carlos Garcia Campos <cgarcia@igalia.com>
+
</ins><span class="cx"> [GTK][Threaded Compositor] Web view background colors don't work
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=159465
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessgtkRedirectedXCompositeWindowcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/gtk/RedirectedXCompositeWindow.cpp (203499 => 203500)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/gtk/RedirectedXCompositeWindow.cpp 2016-07-21 07:33:28 UTC (rev 203499)
+++ trunk/Source/WebKit2/UIProcess/gtk/RedirectedXCompositeWindow.cpp 2016-07-21 07:35:49 UTC (rev 203500)
</span><span class="lines">@@ -204,6 +204,8 @@
</span><span class="cx"> }
</span><span class="cx"> XSelectInput(m_display, m_window.get(), NoEventMask);
</span><span class="cx"> XCompositeRedirectWindow(m_display, m_window.get(), CompositeRedirectManual);
</span><ins>+ if (!m_size.isEmpty())
+ createNewPixampAndPixampSurface();
</ins><span class="cx"> m_damage = XDamageCreate(m_display, m_window.get(), XDamageReportNonEmpty);
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -234,9 +236,10 @@
</span><span class="cx"> XFlush(m_display);
</span><span class="cx">
</span><span class="cx"> m_size = scaledSize;
</span><del>- m_needsNewPixmapAfterResize = true;
</del><span class="cx"> if (m_size.isEmpty())
</span><span class="cx"> cleanupPixmapAndPixmapSurface();
</span><ins>+ else
+ createNewPixampAndPixampSurface();
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void RedirectedXCompositeWindow::cleanupPixmapAndPixmapSurface()
</span><span class="lines">@@ -248,26 +251,20 @@
</span><span class="cx"> m_pixmap.reset();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-cairo_surface_t* RedirectedXCompositeWindow::surface()
</del><ins>+void RedirectedXCompositeWindow::createNewPixampAndPixampSurface()
</ins><span class="cx"> {
</span><span class="cx"> // This should never be called with an empty size (not in Accelerated Compositing mode).
</span><span class="cx"> ASSERT(!m_size.isEmpty());
</span><del>-
- if (!m_needsNewPixmapAfterResize && m_surface)
- return m_surface.get();
-
- m_needsNewPixmapAfterResize = false;
-
</del><span class="cx"> XUniquePixmap newPixmap(XCompositeNameWindowPixmap(m_display, m_window.get()));
</span><span class="cx"> if (!newPixmap) {
</span><span class="cx"> cleanupPixmapAndPixmapSurface();
</span><del>- return nullptr;
</del><ins>+ return;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> XWindowAttributes windowAttributes;
</span><span class="cx"> if (!XGetWindowAttributes(m_display, m_window.get(), &windowAttributes)) {
</span><span class="cx"> cleanupPixmapAndPixmapSurface();
</span><del>- return nullptr;
</del><ins>+ return;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> RefPtr<cairo_surface_t> newSurface = adoptRef(cairo_xlib_surface_create(m_display, newPixmap.get(), windowAttributes.visual, m_size.width(), m_size.height()));
</span><span class="lines">@@ -292,8 +289,7 @@
</span><span class="cx">
</span><span class="cx"> cleanupPixmapAndPixmapSurface();
</span><span class="cx"> m_pixmap = WTFMove(newPixmap);
</span><del>- m_surface = newSurface;
- return m_surface.get();
</del><ins>+ m_surface = WTFMove(newSurface);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> } // namespace WebCore
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessgtkRedirectedXCompositeWindowh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/gtk/RedirectedXCompositeWindow.h (203499 => 203500)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/gtk/RedirectedXCompositeWindow.h 2016-07-21 07:33:28 UTC (rev 203499)
+++ trunk/Source/WebKit2/UIProcess/gtk/RedirectedXCompositeWindow.h 2016-07-21 07:35:49 UTC (rev 203500)
</span><span class="lines">@@ -50,10 +50,11 @@
</span><span class="cx">
</span><span class="cx"> Window windowID() const { return m_window.get(); }
</span><span class="cx"> void resize(const WebCore::IntSize&);
</span><del>- cairo_surface_t* surface();
</del><ins>+ cairo_surface_t* surface() const { return m_surface.get(); };
</ins><span class="cx">
</span><span class="cx"> private:
</span><span class="cx"> RedirectedXCompositeWindow(WebPageProxy&, const WebCore::IntSize&, std::function<void ()>&& damageNotify);
</span><ins>+ void createNewPixampAndPixampSurface();
</ins><span class="cx"> void cleanupPixmapAndPixmapSurface();
</span><span class="cx">
</span><span class="cx"> WebPageProxy& m_webPage;
</span><span class="lines">@@ -64,7 +65,6 @@
</span><span class="cx"> WebCore::XUniquePixmap m_pixmap;
</span><span class="cx"> WebCore::XUniqueDamage m_damage;
</span><span class="cx"> RefPtr<cairo_surface_t> m_surface;
</span><del>- bool m_needsNewPixmapAfterResize { false };
</del><span class="cx"> };
</span><span class="cx">
</span><span class="cx"> } // namespace WebKit
</span></span></pre>
</div>
</div>
</body>
</html>