<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[203474] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/203474">203474</a></dd>
<dt>Author</dt> <dd>cdumez@apple.com</dd>
<dt>Date</dt> <dd>2016-07-20 16:06:35 -0700 (Wed, 20 Jul 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Fix null handling of HTMLFrameElement.marginWidth / marginHeight
https://bugs.webkit.org/show_bug.cgi?id=159987
Reviewed by Ryosuke Niwa.
LayoutTests/imported/w3c:
Rebaseline now that more checks are passing.
* web-platform-tests/html/dom/reflection-obsolete-expected.txt:
Source/WebCore:
Fix null handling of HTMLFrameElement.marginWidth / marginHeight:
- https://html.spec.whatwg.org/multipage/obsolete.html#htmlframeelement
We are supposed to treat null as the empty string but we treat it as
the string "null".
Firefox and Chrome both match the specification.
No new tests, updated existing tests.
* html/HTMLFrameElement.idl:
LayoutTests:
Update existing test to reflect the expected behavior change.
* fast/dom/element-attribute-js-null-expected.txt:
* fast/dom/element-attribute-js-null.html:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsfastdomelementattributejsnullexpectedtxt">trunk/LayoutTests/fast/dom/element-attribute-js-null-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastdomelementattributejsnullhtml">trunk/LayoutTests/fast/dom/element-attribute-js-null.html</a></li>
<li><a href="#trunkLayoutTestsimportedw3cChangeLog">trunk/LayoutTests/imported/w3c/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestshtmldomreflectionobsoleteexpectedtxt">trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/reflection-obsolete-expected.txt</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLFrameElementidl">trunk/Source/WebCore/html/HTMLFrameElement.idl</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (203473 => 203474)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog        2016-07-20 22:56:08 UTC (rev 203473)
+++ trunk/LayoutTests/ChangeLog        2016-07-20 23:06:35 UTC (rev 203474)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2016-07-20 Chris Dumez <cdumez@apple.com>
+
+ Fix null handling of HTMLFrameElement.marginWidth / marginHeight
+ https://bugs.webkit.org/show_bug.cgi?id=159987
+
+ Reviewed by Ryosuke Niwa.
+
+ Update existing test to reflect the expected behavior change.
+
+ * fast/dom/element-attribute-js-null-expected.txt:
+ * fast/dom/element-attribute-js-null.html:
+
</ins><span class="cx"> 2016-07-20 Myles C. Maxfield <mmaxfield@apple.com>
</span><span class="cx">
</span><span class="cx"> [iPhone] Playing a video on tudou.com plays only sound, no video
</span></span></pre></div>
<a id="trunkLayoutTestsfastdomelementattributejsnullexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/dom/element-attribute-js-null-expected.txt (203473 => 203474)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/dom/element-attribute-js-null-expected.txt        2016-07-20 22:56:08 UTC (rev 203473)
+++ trunk/LayoutTests/fast/dom/element-attribute-js-null-expected.txt        2016-07-20 23:06:35 UTC (rev 203474)
</span><span class="lines">@@ -76,8 +76,8 @@
</span><span class="cx"> TEST SUCCEEDED: The value was the string 'null'. [tested HTMLFormElement.target]
</span><span class="cx">
</span><span class="cx"> TEST SUCCEEDED: The value was the string 'null'. [tested HTMLFrameElement.frameBorder]
</span><del>-TEST SUCCEEDED: The value was the string 'null'. [tested HTMLFrameElement.marginHeight]
-TEST SUCCEEDED: The value was the string 'null'. [tested HTMLFrameElement.marginWidth]
</del><ins>+TEST SUCCEEDED: The value was the empty string. [tested HTMLFrameElement.marginHeight]
+TEST SUCCEEDED: The value was the empty string. [tested HTMLFrameElement.marginWidth]
</ins><span class="cx"> TEST SUCCEEDED: The value was the string 'null'. [tested HTMLFrameElement.name]
</span><span class="cx"> TEST SUCCEEDED: The value was the string 'null'. [tested HTMLFrameElement.scrolling]
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsfastdomelementattributejsnullhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/dom/element-attribute-js-null.html (203473 => 203474)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/dom/element-attribute-js-null.html        2016-07-20 22:56:08 UTC (rev 203473)
+++ trunk/LayoutTests/fast/dom/element-attribute-js-null.html        2016-07-20 23:06:35 UTC (rev 203474)
</span><span class="lines">@@ -227,8 +227,8 @@
</span><span class="cx"> elementToUse: document.createElement('frame'),
</span><span class="cx"> attributes: [
</span><span class="cx"> {name: 'frameBorder', expectedNull: 'null'},
</span><del>- {name: 'marginHeight', expectedNull: 'null'},
- {name: 'marginWidth', expectedNull: 'null'},
</del><ins>+ {name: 'marginHeight', expectedNull: ''},
+ {name: 'marginWidth', expectedNull: ''},
</ins><span class="cx"> {name: 'name', expectedNull: 'null'},
</span><span class="cx"> {name: 'scrolling', expectedNull: 'null'},
</span><span class="cx"> ]
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/ChangeLog (203473 => 203474)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/ChangeLog        2016-07-20 22:56:08 UTC (rev 203473)
+++ trunk/LayoutTests/imported/w3c/ChangeLog        2016-07-20 23:06:35 UTC (rev 203474)
</span><span class="lines">@@ -1,5 +1,16 @@
</span><span class="cx"> 2016-07-20 Chris Dumez <cdumez@apple.com>
</span><span class="cx">
</span><ins>+ Fix null handling of HTMLFrameElement.marginWidth / marginHeight
+ https://bugs.webkit.org/show_bug.cgi?id=159987
+
+ Reviewed by Ryosuke Niwa.
+
+ Rebaseline now that more checks are passing.
+
+ * web-platform-tests/html/dom/reflection-obsolete-expected.txt:
+
+2016-07-20 Chris Dumez <cdumez@apple.com>
+
</ins><span class="cx"> Fix null handling of HTMLMediaElement.mediaGroup
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=159974
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestshtmldomreflectionobsoleteexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/reflection-obsolete-expected.txt (203473 => 203474)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/reflection-obsolete-expected.txt        2016-07-20 22:56:08 UTC (rev 203473)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/reflection-obsolete-expected.txt        2016-07-20 23:06:35 UTC (rev 203474)
</span><span class="lines">@@ -5045,8 +5045,8 @@
</span><span class="cx"> PASS frame.marginHeight: IDL set to "\0" followed by getAttribute()
</span><span class="cx"> PASS frame.marginHeight: IDL set to "\0" followed by IDL get
</span><span class="cx"> PASS frame.marginHeight: IDL set to null should not throw
</span><del>-FAIL frame.marginHeight: IDL set to null followed by getAttribute() assert_equals: expected "" but got "null"
-FAIL frame.marginHeight: IDL set to null followed by IDL get assert_equals: expected "" but got "null"
</del><ins>+PASS frame.marginHeight: IDL set to null followed by getAttribute()
+PASS frame.marginHeight: IDL set to null followed by IDL get
</ins><span class="cx"> PASS frame.marginHeight: IDL set to object "test-toString" should not throw
</span><span class="cx"> PASS frame.marginHeight: IDL set to object "test-toString" followed by getAttribute()
</span><span class="cx"> PASS frame.marginHeight: IDL set to object "test-toString" followed by IDL get
</span><span class="lines">@@ -5122,8 +5122,8 @@
</span><span class="cx"> PASS frame.marginWidth: IDL set to "\0" followed by getAttribute()
</span><span class="cx"> PASS frame.marginWidth: IDL set to "\0" followed by IDL get
</span><span class="cx"> PASS frame.marginWidth: IDL set to null should not throw
</span><del>-FAIL frame.marginWidth: IDL set to null followed by getAttribute() assert_equals: expected "" but got "null"
-FAIL frame.marginWidth: IDL set to null followed by IDL get assert_equals: expected "" but got "null"
</del><ins>+PASS frame.marginWidth: IDL set to null followed by getAttribute()
+PASS frame.marginWidth: IDL set to null followed by IDL get
</ins><span class="cx"> PASS frame.marginWidth: IDL set to object "test-toString" should not throw
</span><span class="cx"> PASS frame.marginWidth: IDL set to object "test-toString" followed by getAttribute()
</span><span class="cx"> PASS frame.marginWidth: IDL set to object "test-toString" followed by IDL get
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (203473 => 203474)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog        2016-07-20 22:56:08 UTC (rev 203473)
+++ trunk/Source/WebCore/ChangeLog        2016-07-20 23:06:35 UTC (rev 203474)
</span><span class="lines">@@ -1,3 +1,22 @@
</span><ins>+2016-07-20 Chris Dumez <cdumez@apple.com>
+
+ Fix null handling of HTMLFrameElement.marginWidth / marginHeight
+ https://bugs.webkit.org/show_bug.cgi?id=159987
+
+ Reviewed by Ryosuke Niwa.
+
+ Fix null handling of HTMLFrameElement.marginWidth / marginHeight:
+ - https://html.spec.whatwg.org/multipage/obsolete.html#htmlframeelement
+
+ We are supposed to treat null as the empty string but we treat it as
+ the string "null".
+
+ Firefox and Chrome both match the specification.
+
+ No new tests, updated existing tests.
+
+ * html/HTMLFrameElement.idl:
+
</ins><span class="cx"> 2016-07-20 Wenson Hsieh <wenson_hsieh@apple.com>
</span><span class="cx">
</span><span class="cx"> Pausing autoplayed media should not remove all restrictions for that media element
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLFrameElementidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLFrameElement.idl (203473 => 203474)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLFrameElement.idl        2016-07-20 22:56:08 UTC (rev 203473)
+++ trunk/Source/WebCore/html/HTMLFrameElement.idl        2016-07-20 23:06:35 UTC (rev 203474)
</span><span class="lines">@@ -23,9 +23,8 @@
</span><span class="cx"> [Reflect] attribute DOMString frameBorder;
</span><span class="cx"> [Reflect] attribute DOMString longDesc;
</span><span class="cx">
</span><del>- // FIXME: These should use [TreatNullAs=EmptyString].
- [Reflect] attribute DOMString marginHeight;
- [Reflect] attribute DOMString marginWidth;
</del><ins>+ [Reflect, TreatNullAs=EmptyString] attribute DOMString marginHeight;
+ [Reflect, TreatNullAs=EmptyString] attribute DOMString marginWidth;
</ins><span class="cx">
</span><span class="cx"> [Reflect] attribute DOMString name;
</span><span class="cx"> [Reflect] attribute boolean noResize;
</span></span></pre>
</div>
</div>
</body>
</html>