<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[203443] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/203443">203443</a></dd>
<dt>Author</dt> <dd>cdumez@apple.com</dd>
<dt>Date</dt> <dd>2016-07-19 22:09:51 -0700 (Tue, 19 Jul 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Fix null handling of several HTMLDocument attributes
https://bugs.webkit.org/show_bug.cgi?id=159923
Reviewed by Benjamin Poulain.
LayoutTests/imported/w3c:
Rebaseline now that more checks are passing.
* web-platform-tests/html/dom/reflection-sections-expected.txt:
Source/WebCore:
Fix null handling of several HTMLDocument attributes:
- https://html.spec.whatwg.org/multipage/dom.html#document
- https://html.spec.whatwg.org/multipage/obsolete.html#document-partial
In particular, null handling was incorrect in WebKit for 'dir',
'bgColor', 'fgColor', 'alinkColor', 'linkColor' and 'vlinkColor'.
Firefox and Chrome match the specification.
Test: fast/dom/HTMLDocument/null-handling.html
* html/HTMLDocument.idl:
LayoutTests:
Add layout test coverage. I have verified that this test is passing in
both Firefox and Chrome.
* fast/dom/HTMLDocument/null-handling-expected.txt: Added.
* fast/dom/HTMLDocument/null-handling.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsimportedw3cChangeLog">trunk/LayoutTests/imported/w3c/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestshtmldomreflectionsectionsexpectedtxt">trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/reflection-sections-expected.txt</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLDocumentidl">trunk/Source/WebCore/html/HTMLDocument.idl</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsfastdomHTMLDocumentnullhandlingexpectedtxt">trunk/LayoutTests/fast/dom/HTMLDocument/null-handling-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastdomHTMLDocumentnullhandlinghtml">trunk/LayoutTests/fast/dom/HTMLDocument/null-handling.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (203442 => 203443)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2016-07-20 03:23:18 UTC (rev 203442)
+++ trunk/LayoutTests/ChangeLog 2016-07-20 05:09:51 UTC (rev 203443)
</span><span class="lines">@@ -1,5 +1,18 @@
</span><span class="cx"> 2016-07-19 Chris Dumez <cdumez@apple.com>
</span><span class="cx">
</span><ins>+ Fix null handling of several HTMLDocument attributes
+ https://bugs.webkit.org/show_bug.cgi?id=159923
+
+ Reviewed by Benjamin Poulain.
+
+ Add layout test coverage. I have verified that this test is passing in
+ both Firefox and Chrome.
+
+ * fast/dom/HTMLDocument/null-handling-expected.txt: Added.
+ * fast/dom/HTMLDocument/null-handling.html: Added.
+
+2016-07-19 Chris Dumez <cdumez@apple.com>
+
</ins><span class="cx"> Document.createElementNS() / createAttributeNS() parameters should be mandatory
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=159938
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsfastdomHTMLDocumentnullhandlingexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/dom/HTMLDocument/null-handling-expected.txt (0 => 203443)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/dom/HTMLDocument/null-handling-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/dom/HTMLDocument/null-handling-expected.txt 2016-07-20 05:09:51 UTC (rev 203443)
</span><span class="lines">@@ -0,0 +1,29 @@
</span><ins>+Tests null handling of several HTMLDocument attributes
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS htmlDocument.documentElement.getAttribute('dir') is null
+PASS htmlDocument.body.getAttribute('bgColor') is null
+PASS htmlDocument.body.getAttribute('text') is null
+PASS htmlDocument.body.getAttribute('alink') is null
+PASS htmlDocument.body.getAttribute('link') is null
+PASS htmlDocument.body.getAttribute('vlink') is null
+htmlDocument.dir = null
+PASS htmlDocument.documentElement.getAttribute('dir') is "null"
+htmlDocument.bgColor = null
+PASS htmlDocument.body.getAttribute('bgColor') is ""
+htmlDocument.bgColor = null
+PASS htmlDocument.body.getAttribute('bgColor') is ""
+htmlDocument.fgColor = null
+PASS htmlDocument.body.getAttribute('text') is ""
+htmlDocument.alinkColor = null
+PASS htmlDocument.body.getAttribute('alink') is ""
+htmlDocument.linkColor = null
+PASS htmlDocument.body.getAttribute('link') is ""
+htmlDocument.vlinkColor = null
+PASS htmlDocument.body.getAttribute('vlink') is ""
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
</ins></span></pre></div>
<a id="trunkLayoutTestsfastdomHTMLDocumentnullhandlinghtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/dom/HTMLDocument/null-handling.html (0 => 203443)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/dom/HTMLDocument/null-handling.html (rev 0)
+++ trunk/LayoutTests/fast/dom/HTMLDocument/null-handling.html 2016-07-20 05:09:51 UTC (rev 203443)
</span><span class="lines">@@ -0,0 +1,33 @@
</span><ins>+<DOCTYPE html>
+<html>
+<body>
+<script src="../../../resources/js-test-pre.js"></script>
+<script>
+description("Tests null handling of several HTMLDocument attributes");
+
+var htmlDocument = document.implementation.createHTMLDocument();
+shouldBeNull("htmlDocument.documentElement.getAttribute('dir')");
+shouldBeNull("htmlDocument.body.getAttribute('bgColor')");
+shouldBeNull("htmlDocument.body.getAttribute('text')");
+shouldBeNull("htmlDocument.body.getAttribute('alink')");
+shouldBeNull("htmlDocument.body.getAttribute('link')");
+shouldBeNull("htmlDocument.body.getAttribute('vlink')");
+
+evalAndLog("htmlDocument.dir = null");
+shouldBeEqualToString("htmlDocument.documentElement.getAttribute('dir')", "null");
+evalAndLog("htmlDocument.bgColor = null");
+shouldBeEqualToString("htmlDocument.body.getAttribute('bgColor')", "");
+evalAndLog("htmlDocument.bgColor = null");
+shouldBeEqualToString("htmlDocument.body.getAttribute('bgColor')", "");
+evalAndLog("htmlDocument.fgColor = null");
+shouldBeEqualToString("htmlDocument.body.getAttribute('text')", "");
+evalAndLog("htmlDocument.alinkColor = null");
+shouldBeEqualToString("htmlDocument.body.getAttribute('alink')", "");
+evalAndLog("htmlDocument.linkColor = null");
+shouldBeEqualToString("htmlDocument.body.getAttribute('link')", "");
+evalAndLog("htmlDocument.vlinkColor = null");
+shouldBeEqualToString("htmlDocument.body.getAttribute('vlink')", "");
+</script>
+<script src="../../../resources/js-test-post.js"></script>
+</body>
+</html>
</ins></span></pre></div>
<a id="trunkLayoutTestsimportedw3cChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/ChangeLog (203442 => 203443)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/ChangeLog 2016-07-20 03:23:18 UTC (rev 203442)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2016-07-20 05:09:51 UTC (rev 203443)
</span><span class="lines">@@ -1,5 +1,16 @@
</span><span class="cx"> 2016-07-19 Chris Dumez <cdumez@apple.com>
</span><span class="cx">
</span><ins>+ Fix null handling of several HTMLDocument attributes
+ https://bugs.webkit.org/show_bug.cgi?id=159923
+
+ Reviewed by Benjamin Poulain.
+
+ Rebaseline now that more checks are passing.
+
+ * web-platform-tests/html/dom/reflection-sections-expected.txt:
+
+2016-07-19 Chris Dumez <cdumez@apple.com>
+
</ins><span class="cx"> Document.createElementNS() / createAttributeNS() parameters should be mandatory
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=159938
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestshtmldomreflectionsectionsexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/reflection-sections-expected.txt (203442 => 203443)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/reflection-sections-expected.txt 2016-07-20 03:23:18 UTC (rev 203442)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/reflection-sections-expected.txt 2016-07-20 05:09:51 UTC (rev 203443)
</span><span class="lines">@@ -10012,7 +10012,7 @@
</span><span class="cx"> PASS #document.fgColor (<body text>): IDL set to "\0" followed by getAttribute()
</span><span class="cx"> PASS #document.fgColor (<body text>): IDL set to "\0" followed by IDL get
</span><span class="cx"> PASS #document.fgColor (<body text>): IDL set to null should not throw
</span><del>-FAIL #document.fgColor (<body text>): IDL set to null followed by getAttribute() assert_equals: expected (string) "" but got (object) null
</del><ins>+PASS #document.fgColor (<body text>): IDL set to null followed by getAttribute()
</ins><span class="cx"> PASS #document.fgColor (<body text>): IDL set to null followed by IDL get
</span><span class="cx"> PASS #document.fgColor (<body text>): IDL set to object "test-toString" should not throw
</span><span class="cx"> PASS #document.fgColor (<body text>): IDL set to object "test-toString" followed by getAttribute()
</span><span class="lines">@@ -10089,7 +10089,7 @@
</span><span class="cx"> PASS #document.linkColor (<body link>): IDL set to "\0" followed by getAttribute()
</span><span class="cx"> PASS #document.linkColor (<body link>): IDL set to "\0" followed by IDL get
</span><span class="cx"> PASS #document.linkColor (<body link>): IDL set to null should not throw
</span><del>-FAIL #document.linkColor (<body link>): IDL set to null followed by getAttribute() assert_equals: expected (string) "" but got (object) null
</del><ins>+PASS #document.linkColor (<body link>): IDL set to null followed by getAttribute()
</ins><span class="cx"> PASS #document.linkColor (<body link>): IDL set to null followed by IDL get
</span><span class="cx"> PASS #document.linkColor (<body link>): IDL set to object "test-toString" should not throw
</span><span class="cx"> PASS #document.linkColor (<body link>): IDL set to object "test-toString" followed by getAttribute()
</span><span class="lines">@@ -10166,7 +10166,7 @@
</span><span class="cx"> PASS #document.vlinkColor (<body vlink>): IDL set to "\0" followed by getAttribute()
</span><span class="cx"> PASS #document.vlinkColor (<body vlink>): IDL set to "\0" followed by IDL get
</span><span class="cx"> PASS #document.vlinkColor (<body vlink>): IDL set to null should not throw
</span><del>-FAIL #document.vlinkColor (<body vlink>): IDL set to null followed by getAttribute() assert_equals: expected (string) "" but got (object) null
</del><ins>+PASS #document.vlinkColor (<body vlink>): IDL set to null followed by getAttribute()
</ins><span class="cx"> PASS #document.vlinkColor (<body vlink>): IDL set to null followed by IDL get
</span><span class="cx"> PASS #document.vlinkColor (<body vlink>): IDL set to object "test-toString" should not throw
</span><span class="cx"> PASS #document.vlinkColor (<body vlink>): IDL set to object "test-toString" followed by getAttribute()
</span><span class="lines">@@ -10243,7 +10243,7 @@
</span><span class="cx"> PASS #document.alinkColor (<body alink>): IDL set to "\0" followed by getAttribute()
</span><span class="cx"> PASS #document.alinkColor (<body alink>): IDL set to "\0" followed by IDL get
</span><span class="cx"> PASS #document.alinkColor (<body alink>): IDL set to null should not throw
</span><del>-FAIL #document.alinkColor (<body alink>): IDL set to null followed by getAttribute() assert_equals: expected (string) "" but got (object) null
</del><ins>+PASS #document.alinkColor (<body alink>): IDL set to null followed by getAttribute()
</ins><span class="cx"> PASS #document.alinkColor (<body alink>): IDL set to null followed by IDL get
</span><span class="cx"> PASS #document.alinkColor (<body alink>): IDL set to object "test-toString" should not throw
</span><span class="cx"> PASS #document.alinkColor (<body alink>): IDL set to object "test-toString" followed by getAttribute()
</span><span class="lines">@@ -10320,7 +10320,7 @@
</span><span class="cx"> PASS #document.bgColor (<body bgcolor>): IDL set to "\0" followed by getAttribute()
</span><span class="cx"> PASS #document.bgColor (<body bgcolor>): IDL set to "\0" followed by IDL get
</span><span class="cx"> PASS #document.bgColor (<body bgcolor>): IDL set to null should not throw
</span><del>-FAIL #document.bgColor (<body bgcolor>): IDL set to null followed by getAttribute() assert_equals: expected (string) "" but got (object) null
</del><ins>+PASS #document.bgColor (<body bgcolor>): IDL set to null followed by getAttribute()
</ins><span class="cx"> PASS #document.bgColor (<body bgcolor>): IDL set to null followed by IDL get
</span><span class="cx"> PASS #document.bgColor (<body bgcolor>): IDL set to object "test-toString" should not throw
</span><span class="cx"> PASS #document.bgColor (<body bgcolor>): IDL set to object "test-toString" followed by getAttribute()
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (203442 => 203443)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-07-20 03:23:18 UTC (rev 203442)
+++ trunk/Source/WebCore/ChangeLog 2016-07-20 05:09:51 UTC (rev 203443)
</span><span class="lines">@@ -1,5 +1,25 @@
</span><span class="cx"> 2016-07-19 Chris Dumez <cdumez@apple.com>
</span><span class="cx">
</span><ins>+ Fix null handling of several HTMLDocument attributes
+ https://bugs.webkit.org/show_bug.cgi?id=159923
+
+ Reviewed by Benjamin Poulain.
+
+ Fix null handling of several HTMLDocument attributes:
+ - https://html.spec.whatwg.org/multipage/dom.html#document
+ - https://html.spec.whatwg.org/multipage/obsolete.html#document-partial
+
+ In particular, null handling was incorrect in WebKit for 'dir',
+ 'bgColor', 'fgColor', 'alinkColor', 'linkColor' and 'vlinkColor'.
+
+ Firefox and Chrome match the specification.
+
+ Test: fast/dom/HTMLDocument/null-handling.html
+
+ * html/HTMLDocument.idl:
+
+2016-07-19 Chris Dumez <cdumez@apple.com>
+
</ins><span class="cx"> Document.createElementNS() / createAttributeNS() parameters should be mandatory
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=159938
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLDocumentidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLDocument.idl (203442 => 203443)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLDocument.idl 2016-07-20 03:23:18 UTC (rev 203442)
+++ trunk/Source/WebCore/html/HTMLDocument.idl 2016-07-20 05:09:51 UTC (rev 203443)
</span><span class="lines">@@ -51,18 +51,16 @@
</span><span class="cx"> readonly attribute long height;
</span><span class="cx"> #endif
</span><span class="cx">
</span><del>- // FIXME: This should not have [TreatNullAs=LegacyNullString].
- [TreatNullAs=LegacyNullString] attribute DOMString dir;
</del><ins>+ attribute DOMString dir;
</ins><span class="cx">
</span><span class="cx"> attribute DOMString designMode;
</span><span class="cx"> readonly attribute DOMString compatMode;
</span><span class="cx">
</span><span class="cx"> // Deprecated attributes.
</span><del>- // FIXME: These should not have [TreatNullAs=LegacyNullString].
- [TreatNullAs=LegacyNullString] attribute DOMString bgColor;
- [TreatNullAs=LegacyNullString] attribute DOMString fgColor;
- [TreatNullAs=LegacyNullString] attribute DOMString alinkColor;
- [TreatNullAs=LegacyNullString] attribute DOMString linkColor;
- [TreatNullAs=LegacyNullString] attribute DOMString vlinkColor;
</del><ins>+ [TreatNullAs=EmptyString] attribute DOMString bgColor;
+ [TreatNullAs=EmptyString] attribute DOMString fgColor;
+ [TreatNullAs=EmptyString] attribute DOMString alinkColor;
+ [TreatNullAs=EmptyString] attribute DOMString linkColor;
+ [TreatNullAs=EmptyString] attribute DOMString vlinkColor;
</ins><span class="cx"> };
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>