<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[203438] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/203438">203438</a></dd>
<dt>Author</dt> <dd>cdumez@apple.com</dd>
<dt>Date</dt> <dd>2016-07-19 18:27:24 -0700 (Tue, 19 Jul 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Drop SVGElement.xmlbase attribute
https://bugs.webkit.org/show_bug.cgi?id=159926
Reviewed by Benjamin Poulain.
Source/WebCore:
Drop SVGElement.xmlbase attribute as it is no longer part of the
specification:
- https://www.w3.org/TR/SVG2/types.html#InterfaceSVGElement
Both Firefox and Chrome have already dropped support for
SVGElement.xmlbase.
Chrome's intent to remove:
https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/TfwMq4d25hk/C-v_iC_wKfAJ
Test: svg/dom/SVGElement-xmlbase.html
* svg/SVGElement.cpp:
(WebCore::SVGElement::removedFrom): Deleted.
* svg/SVGElement.h:
* svg/SVGElement.idl:
LayoutTests:
* svg/dom/SVGElement-xmlbase-expected.txt: Added.
* svg/dom/SVGElement-xmlbase.html: Added.
Check that SVGElement.xmlbase does not exist.
* svg/dom/svg-element-attribute-js-null-expected.txt:
* svg/dom/svg-element-attribute-js-null.xhtml:
Drop obsolete testing for SVGElement.xmlbase.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestssvgdomsvgelementattributejsnullexpectedtxt">trunk/LayoutTests/svg/dom/svg-element-attribute-js-null-expected.txt</a></li>
<li><a href="#trunkLayoutTestssvgdomsvgelementattributejsnullxhtml">trunk/LayoutTests/svg/dom/svg-element-attribute-js-null.xhtml</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoresvgSVGElementcpp">trunk/Source/WebCore/svg/SVGElement.cpp</a></li>
<li><a href="#trunkSourceWebCoresvgSVGElementh">trunk/Source/WebCore/svg/SVGElement.h</a></li>
<li><a href="#trunkSourceWebCoresvgSVGElementidl">trunk/Source/WebCore/svg/SVGElement.idl</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestssvgdomSVGElementxmlbaseexpectedtxt">trunk/LayoutTests/svg/dom/SVGElement-xmlbase-expected.txt</a></li>
<li><a href="#trunkLayoutTestssvgdomSVGElementxmlbasehtml">trunk/LayoutTests/svg/dom/SVGElement-xmlbase.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (203437 => 203438)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2016-07-20 01:20:23 UTC (rev 203437)
+++ trunk/LayoutTests/ChangeLog 2016-07-20 01:27:24 UTC (rev 203438)
</span><span class="lines">@@ -1,5 +1,20 @@
</span><span class="cx"> 2016-07-19 Chris Dumez <cdumez@apple.com>
</span><span class="cx">
</span><ins>+ Drop SVGElement.xmlbase attribute
+ https://bugs.webkit.org/show_bug.cgi?id=159926
+
+ Reviewed by Benjamin Poulain.
+
+ * svg/dom/SVGElement-xmlbase-expected.txt: Added.
+ * svg/dom/SVGElement-xmlbase.html: Added.
+ Check that SVGElement.xmlbase does not exist.
+
+ * svg/dom/svg-element-attribute-js-null-expected.txt:
+ * svg/dom/svg-element-attribute-js-null.xhtml:
+ Drop obsolete testing for SVGElement.xmlbase.
+
+2016-07-19 Chris Dumez <cdumez@apple.com>
+
</ins><span class="cx"> Align CSSStyleDeclaration.setProperty() with the specification
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=159955
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestssvgdomSVGElementxmlbaseexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/svg/dom/SVGElement-xmlbase-expected.txt (0 => 203438)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/svg/dom/SVGElement-xmlbase-expected.txt (rev 0)
+++ trunk/LayoutTests/svg/dom/SVGElement-xmlbase-expected.txt 2016-07-20 01:27:24 UTC (rev 203438)
</span><span class="lines">@@ -0,0 +1,10 @@
</span><ins>+Check that SVGElement.xmlbase does not exist.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS svgElement.xmlbase is undefined.
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
</ins></span></pre></div>
<a id="trunkLayoutTestssvgdomSVGElementxmlbasehtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/svg/dom/SVGElement-xmlbase.html (0 => 203438)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/svg/dom/SVGElement-xmlbase.html (rev 0)
+++ trunk/LayoutTests/svg/dom/SVGElement-xmlbase.html 2016-07-20 01:27:24 UTC (rev 203438)
</span><span class="lines">@@ -0,0 +1,13 @@
</span><ins>+<!DOCTYPE html>
+<html>
+<body>
+<script src="../../resources/js-test-pre.js"></script>
+<script>
+description("Check that SVGElement.xmlbase does not exist.");
+
+var svgElement = document.createElementNS("http://www.w3.org/2000/svg", "svg");
+shouldBeUndefined("svgElement.xmlbase");
+</script>
+<script src="../../resources/js-test-post.js"></script>
+</body>
+</html>
</ins></span></pre></div>
<a id="trunkLayoutTestssvgdomsvgelementattributejsnullexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/svg/dom/svg-element-attribute-js-null-expected.txt (203437 => 203438)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/svg/dom/svg-element-attribute-js-null-expected.txt 2016-07-20 01:20:23 UTC (rev 203437)
+++ trunk/LayoutTests/svg/dom/svg-element-attribute-js-null-expected.txt 2016-07-20 01:27:24 UTC (rev 203438)
</span><span class="lines">@@ -1,7 +1,6 @@
</span><span class="cx"> This test setting various attributes of a SVG elements to JavaScript null.
</span><span class="cx">
</span><span class="cx"> TEST SUCCEEDED: The value was the string 'null'. [tested SVGElement.id]
</span><del>-TEST SUCCEEDED: The value was the empty string. [tested SVGElement.xmlbase]
</del><span class="cx">
</span><span class="cx"> TEST SUCCEEDED: The value was the string '0'. [tested SVGAngle.valueAsString]
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestssvgdomsvgelementattributejsnullxhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/svg/dom/svg-element-attribute-js-null.xhtml (203437 => 203438)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/svg/dom/svg-element-attribute-js-null.xhtml 2016-07-20 01:20:23 UTC (rev 203437)
+++ trunk/LayoutTests/svg/dom/svg-element-attribute-js-null.xhtml 2016-07-20 01:27:24 UTC (rev 203438)
</span><span class="lines">@@ -53,7 +53,6 @@
</span><span class="cx"> elementToUse: svg,
</span><span class="cx"> attributes: [
</span><span class="cx"> {name: 'id', expectedNull: 'null'},
</span><del>- {name: 'xmlbase', expectedNull: ''}
</del><span class="cx"> ]
</span><span class="cx"> },
</span><span class="cx"> {
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (203437 => 203438)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-07-20 01:20:23 UTC (rev 203437)
+++ trunk/Source/WebCore/ChangeLog 2016-07-20 01:27:24 UTC (rev 203438)
</span><span class="lines">@@ -1,5 +1,29 @@
</span><span class="cx"> 2016-07-19 Chris Dumez <cdumez@apple.com>
</span><span class="cx">
</span><ins>+ Drop SVGElement.xmlbase attribute
+ https://bugs.webkit.org/show_bug.cgi?id=159926
+
+ Reviewed by Benjamin Poulain.
+
+ Drop SVGElement.xmlbase attribute as it is no longer part of the
+ specification:
+ - https://www.w3.org/TR/SVG2/types.html#InterfaceSVGElement
+
+ Both Firefox and Chrome have already dropped support for
+ SVGElement.xmlbase.
+
+ Chrome's intent to remove:
+ https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/TfwMq4d25hk/C-v_iC_wKfAJ
+
+ Test: svg/dom/SVGElement-xmlbase.html
+
+ * svg/SVGElement.cpp:
+ (WebCore::SVGElement::removedFrom): Deleted.
+ * svg/SVGElement.h:
+ * svg/SVGElement.idl:
+
+2016-07-19 Chris Dumez <cdumez@apple.com>
+
</ins><span class="cx"> Align CSSStyleDeclaration.setProperty() with the specification
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=159955
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoresvgSVGElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/svg/SVGElement.cpp (203437 => 203438)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/svg/SVGElement.cpp 2016-07-20 01:20:23 UTC (rev 203437)
+++ trunk/Source/WebCore/svg/SVGElement.cpp 2016-07-20 01:27:24 UTC (rev 203438)
</span><span class="lines">@@ -367,16 +367,6 @@
</span><span class="cx"> return DOMImplementation::hasFeature(feature, version);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-String SVGElement::xmlbase() const
-{
- return attributeWithoutSynchronization(XMLNames::baseAttr);
-}
-
-void SVGElement::setXmlbase(const String& value, ExceptionCode&)
-{
- setAttributeWithoutSynchronization(XMLNames::baseAttr, value);
-}
-
</del><span class="cx"> void SVGElement::removedFrom(ContainerNode& rootParent)
</span><span class="cx"> {
</span><span class="cx"> bool wasInDocument = rootParent.inDocument();
</span></span></pre></div>
<a id="trunkSourceWebCoresvgSVGElementh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/svg/SVGElement.h (203437 => 203438)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/svg/SVGElement.h 2016-07-20 01:20:23 UTC (rev 203437)
+++ trunk/Source/WebCore/svg/SVGElement.h 2016-07-20 01:27:24 UTC (rev 203438)
</span><span class="lines">@@ -53,9 +53,6 @@
</span><span class="cx"> public:
</span><span class="cx"> bool isOutermostSVGSVGElement() const;
</span><span class="cx">
</span><del>- String xmlbase() const;
- void setXmlbase(const String&, ExceptionCode&);
-
</del><span class="cx"> SVGSVGElement* ownerSVGElement() const;
</span><span class="cx"> SVGElement* viewportElement() const;
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoresvgSVGElementidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/svg/SVGElement.idl (203437 => 203438)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/svg/SVGElement.idl 2016-07-20 01:20:23 UTC (rev 203437)
+++ trunk/Source/WebCore/svg/SVGElement.idl 2016-07-20 01:27:24 UTC (rev 203438)
</span><span class="lines">@@ -23,10 +23,6 @@
</span><span class="cx"> [
</span><span class="cx"> JSGenerateToNativeObject,
</span><span class="cx"> ] interface SVGElement : Element {
</span><del>- // FIXME: the xmlbase attribute is no longer part of SVG2 and Chrome already dropped it.
- // FIXME: This should not use [TreatNullAs=LegacyNullString].
- [TreatNullAs=LegacyNullString, SetterRaisesException] attribute DOMString xmlbase;
-
</del><span class="cx"> readonly attribute SVGSVGElement ownerSVGElement;
</span><span class="cx"> readonly attribute SVGElement viewportElement;
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>