<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[203444] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/203444">203444</a></dd>
<dt>Author</dt> <dd>cdumez@apple.com</dd>
<dt>Date</dt> <dd>2016-07-19 22:13:06 -0700 (Tue, 19 Jul 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Fix null handling of SVGScriptElement.type attribute
https://bugs.webkit.org/show_bug.cgi?id=159927
Reviewed by Benjamin Poulain.
Source/WebCore:
Fix null handling of SVGScriptElement.type attribute:
- https://www.w3.org/TR/SVG2/interact.html#InterfaceSVGScriptElement
We were treating null as the null String which would end up removing
the 'type' content attribute. However, we should treat null as the
String "null".
Firefox and Chrome match the specification.
No new tests, updated existing test.
* svg/SVGScriptElement.idl:
LayoutTests:
Rebaseline existing test to reflect the behavior change.
* svg/dom/svg-element-attribute-js-null-expected.txt:
* svg/dom/svg-element-attribute-js-null.xhtml:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestssvgdomsvgelementattributejsnullexpectedtxt">trunk/LayoutTests/svg/dom/svg-element-attribute-js-null-expected.txt</a></li>
<li><a href="#trunkLayoutTestssvgdomsvgelementattributejsnullxhtml">trunk/LayoutTests/svg/dom/svg-element-attribute-js-null.xhtml</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoresvgSVGScriptElementidl">trunk/Source/WebCore/svg/SVGScriptElement.idl</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (203443 => 203444)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2016-07-20 05:09:51 UTC (rev 203443)
+++ trunk/LayoutTests/ChangeLog 2016-07-20 05:13:06 UTC (rev 203444)
</span><span class="lines">@@ -1,5 +1,17 @@
</span><span class="cx"> 2016-07-19 Chris Dumez <cdumez@apple.com>
</span><span class="cx">
</span><ins>+ Fix null handling of SVGScriptElement.type attribute
+ https://bugs.webkit.org/show_bug.cgi?id=159927
+
+ Reviewed by Benjamin Poulain.
+
+ Rebaseline existing test to reflect the behavior change.
+
+ * svg/dom/svg-element-attribute-js-null-expected.txt:
+ * svg/dom/svg-element-attribute-js-null.xhtml:
+
+2016-07-19 Chris Dumez <cdumez@apple.com>
+
</ins><span class="cx"> Fix null handling of several HTMLDocument attributes
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=159923
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestssvgdomsvgelementattributejsnullexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/svg/dom/svg-element-attribute-js-null-expected.txt (203443 => 203444)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/svg/dom/svg-element-attribute-js-null-expected.txt 2016-07-20 05:09:51 UTC (rev 203443)
+++ trunk/LayoutTests/svg/dom/svg-element-attribute-js-null-expected.txt 2016-07-20 05:13:06 UTC (rev 203444)
</span><span class="lines">@@ -6,6 +6,6 @@
</span><span class="cx">
</span><span class="cx"> TEST SUCCEEDED: The value was the string '0'. [tested SVGLength.valueAsString]
</span><span class="cx">
</span><del>-TEST SUCCEEDED: The value was the empty string. [tested SVGScriptElement.type]
</del><ins>+TEST SUCCEEDED: The value was the string 'null'. [tested SVGScriptElement.type]
</ins><span class="cx">
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestssvgdomsvgelementattributejsnullxhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/svg/dom/svg-element-attribute-js-null.xhtml (203443 => 203444)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/svg/dom/svg-element-attribute-js-null.xhtml 2016-07-20 05:09:51 UTC (rev 203443)
+++ trunk/LayoutTests/svg/dom/svg-element-attribute-js-null.xhtml 2016-07-20 05:13:06 UTC (rev 203444)
</span><span class="lines">@@ -73,7 +73,7 @@
</span><span class="cx"> type: 'SVGScriptElement',
</span><span class="cx"> elementToUse: document.createElementNS(svgNS, 'script'),
</span><span class="cx"> attributes: [
</span><del>- {name: 'type', expectedNull: ''}
</del><ins>+ {name: 'type', expectedNull: 'null'}
</ins><span class="cx"> ]
</span><span class="cx"> }
</span><span class="cx"> ];
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (203443 => 203444)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-07-20 05:09:51 UTC (rev 203443)
+++ trunk/Source/WebCore/ChangeLog 2016-07-20 05:13:06 UTC (rev 203444)
</span><span class="lines">@@ -1,5 +1,25 @@
</span><span class="cx"> 2016-07-19 Chris Dumez <cdumez@apple.com>
</span><span class="cx">
</span><ins>+ Fix null handling of SVGScriptElement.type attribute
+ https://bugs.webkit.org/show_bug.cgi?id=159927
+
+ Reviewed by Benjamin Poulain.
+
+ Fix null handling of SVGScriptElement.type attribute:
+ - https://www.w3.org/TR/SVG2/interact.html#InterfaceSVGScriptElement
+
+ We were treating null as the null String which would end up removing
+ the 'type' content attribute. However, we should treat null as the
+ String "null".
+
+ Firefox and Chrome match the specification.
+
+ No new tests, updated existing test.
+
+ * svg/SVGScriptElement.idl:
+
+2016-07-19 Chris Dumez <cdumez@apple.com>
+
</ins><span class="cx"> Fix null handling of several HTMLDocument attributes
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=159923
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoresvgSVGScriptElementidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/svg/SVGScriptElement.idl (203443 => 203444)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/svg/SVGScriptElement.idl 2016-07-20 05:09:51 UTC (rev 203443)
+++ trunk/Source/WebCore/svg/SVGScriptElement.idl 2016-07-20 05:13:06 UTC (rev 203444)
</span><span class="lines">@@ -24,8 +24,7 @@
</span><span class="cx"> */
</span><span class="cx">
</span><span class="cx"> interface SVGScriptElement : SVGElement {
</span><del>- // FIXME: This should not use [TreatNullAs=LegacyNullString].
- [TreatNullAs=LegacyNullString, Reflect] attribute DOMString type;
</del><ins>+ [Reflect] attribute DOMString type;
</ins><span class="cx"> };
</span><span class="cx">
</span><span class="cx"> SVGScriptElement implements SVGExternalResourcesRequired;
</span></span></pre>
</div>
</div>
</body>
</html>