<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[203401] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/203401">203401</a></dd>
<dt>Author</dt> <dd>cdumez@apple.com</dd>
<dt>Date</dt> <dd>2016-07-19 00:41:21 -0700 (Tue, 19 Jul 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>form.enctype / encoding / method should treat null as "null" string
https://bugs.webkit.org/show_bug.cgi?id=159916
Reviewed by Ryosuke Niwa.
Source/WebCore:
form.enctype / encoding / method should treat null as "null" string:
- https://html.spec.whatwg.org/multipage/forms.html#htmlformelement
Previously, WebKit would treat null as the null String, which would
end up removing the existing attribute.
Firefox and Chrome match the specification.
Test: fast/dom/HTMLFormElement/null-handling.html
* html/HTMLFormElement.h:
* html/HTMLFormElement.idl:
LayoutTests:
Add layout test coverage.
* fast/dom/HTMLFormElement/null-handling-expected.txt: Added.
* fast/dom/HTMLFormElement/null-handling.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLFormElementh">trunk/Source/WebCore/html/HTMLFormElement.h</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLFormElementidl">trunk/Source/WebCore/html/HTMLFormElement.idl</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsfastdomHTMLFormElementnullhandlingexpectedtxt">trunk/LayoutTests/fast/dom/HTMLFormElement/null-handling-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastdomHTMLFormElementnullhandlinghtml">trunk/LayoutTests/fast/dom/HTMLFormElement/null-handling.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (203400 => 203401)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog        2016-07-19 07:38:55 UTC (rev 203400)
+++ trunk/LayoutTests/ChangeLog        2016-07-19 07:41:21 UTC (rev 203401)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2016-07-19 Chris Dumez <cdumez@apple.com>
+
+ form.enctype / encoding / method should treat null as "null" string
+ https://bugs.webkit.org/show_bug.cgi?id=159916
+
+ Reviewed by Ryosuke Niwa.
+
+ Add layout test coverage.
+
+ * fast/dom/HTMLFormElement/null-handling-expected.txt: Added.
+ * fast/dom/HTMLFormElement/null-handling.html: Added.
+
</ins><span class="cx"> 2016-07-19 Youenn Fablet <youenn@apple.com>
</span><span class="cx">
</span><span class="cx"> Add new aliases to http test server
</span></span></pre></div>
<a id="trunkLayoutTestsfastdomHTMLFormElementnullhandlingexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/dom/HTMLFormElement/null-handling-expected.txt (0 => 203401)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/dom/HTMLFormElement/null-handling-expected.txt         (rev 0)
+++ trunk/LayoutTests/fast/dom/HTMLFormElement/null-handling-expected.txt        2016-07-19 07:41:21 UTC (rev 203401)
</span><span class="lines">@@ -0,0 +1,20 @@
</span><ins>+Tests null handling of several HTMLFormElement attributes
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS form.getAttribute('method') is null
+PASS form.getAttribute('enctype') is null
+PASS form.getAttribute('encoding') is null
+form.method = null
+PASS form.getAttribute('method') is "null"
+form.enctype = null
+PASS form.getAttribute('enctype') is "null"
+form.encoding = 'test'
+PASS form.getAttribute('enctype') is "test"
+form.encoding = null
+PASS form.getAttribute('enctype') is "null"
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
</ins></span></pre></div>
<a id="trunkLayoutTestsfastdomHTMLFormElementnullhandlinghtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/dom/HTMLFormElement/null-handling.html (0 => 203401)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/dom/HTMLFormElement/null-handling.html         (rev 0)
+++ trunk/LayoutTests/fast/dom/HTMLFormElement/null-handling.html        2016-07-19 07:41:21 UTC (rev 203401)
</span><span class="lines">@@ -0,0 +1,23 @@
</span><ins>+<DOCTYPE html>
+<html>
+<body>
+<script src="../../../resources/js-test-pre.js"></script>
+<script>
+description("Tests null handling of several HTMLFormElement attributes");
+
+var form = document.createElement("form");
+shouldBeNull("form.getAttribute('method')", "");
+shouldBeNull("form.getAttribute('enctype')", "");
+shouldBeNull("form.getAttribute('encoding')", "");
+evalAndLog("form.method = null");
+shouldBeEqualToString("form.getAttribute('method')", "null");
+evalAndLog("form.enctype = null");
+shouldBeEqualToString("form.getAttribute('enctype')", "null");
+evalAndLog("form.encoding = 'test'");
+shouldBeEqualToString("form.getAttribute('enctype')", "test");
+evalAndLog("form.encoding = null");
+shouldBeEqualToString("form.getAttribute('enctype')", "null");
+</script>
+<script src="../../../resources/js-test-post.js"></script>
+</body>
+</html>
</ins></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (203400 => 203401)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog        2016-07-19 07:38:55 UTC (rev 203400)
+++ trunk/Source/WebCore/ChangeLog        2016-07-19 07:41:21 UTC (rev 203401)
</span><span class="lines">@@ -1,3 +1,23 @@
</span><ins>+2016-07-19 Chris Dumez <cdumez@apple.com>
+
+ form.enctype / encoding / method should treat null as "null" string
+ https://bugs.webkit.org/show_bug.cgi?id=159916
+
+ Reviewed by Ryosuke Niwa.
+
+ form.enctype / encoding / method should treat null as "null" string:
+ - https://html.spec.whatwg.org/multipage/forms.html#htmlformelement
+
+ Previously, WebKit would treat null as the null String, which would
+ end up removing the existing attribute.
+
+ Firefox and Chrome match the specification.
+
+ Test: fast/dom/HTMLFormElement/null-handling.html
+
+ * html/HTMLFormElement.h:
+ * html/HTMLFormElement.idl:
+
</ins><span class="cx"> 2016-07-18 Csaba Osztrogonác <ossy@webkit.org>
</span><span class="cx">
</span><span class="cx"> All-in-one buildfix after r202439
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLFormElementh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLFormElement.h (203400 => 203401)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLFormElement.h        2016-07-19 07:38:55 UTC (rev 203400)
+++ trunk/Source/WebCore/html/HTMLFormElement.h        2016-07-19 07:41:21 UTC (rev 203401)
</span><span class="lines">@@ -61,9 +61,6 @@
</span><span class="cx"> String enctype() const { return m_attributes.encodingType(); }
</span><span class="cx"> void setEnctype(const String&);
</span><span class="cx">
</span><del>- String encoding() const { return m_attributes.encodingType(); }
- void setEncoding(const String& value) { setEnctype(value); }
-
</del><span class="cx"> bool shouldAutocomplete() const;
</span><span class="cx">
</span><span class="cx"> void setAutocomplete(const AtomicString&);
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLFormElementidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLFormElement.idl (203400 => 203401)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLFormElement.idl        2016-07-19 07:38:55 UTC (rev 203400)
+++ trunk/Source/WebCore/html/HTMLFormElement.idl        2016-07-19 07:41:21 UTC (rev 203401)
</span><span class="lines">@@ -26,10 +26,9 @@
</span><span class="cx"> [Reflect, URL] attribute DOMString action;
</span><span class="cx"> attribute DOMString autocomplete;
</span><span class="cx">
</span><del>- // FIXME: These should not have [TreatNullAs=LegacyNullString].
- [TreatNullAs=LegacyNullString] attribute DOMString enctype;
- [TreatNullAs=LegacyNullString] attribute DOMString encoding;
- [TreatNullAs=LegacyNullString] attribute DOMString method;
</del><ins>+ attribute DOMString enctype;
+ [ImplementedAs=enctype] attribute DOMString encoding;
+ attribute DOMString method;
</ins><span class="cx">
</span><span class="cx"> [Reflect] attribute DOMString name;
</span><span class="cx"> [Reflect] attribute boolean noValidate;
</span></span></pre>
</div>
</div>
</body>
</html>