<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[203427] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/203427">203427</a></dd>
<dt>Author</dt> <dd>cdumez@apple.com</dd>
<dt>Date</dt> <dd>2016-07-19 15:55:21 -0700 (Tue, 19 Jul 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>autocapitalize attribute should not use [TreatNullAs=LegacyNullString]
https://bugs.webkit.org/show_bug.cgi?id=159934
Reviewed by Benjamin Poulain.
Source/WebCore:
autocapitalize attribute should not use [TreatNullAs=LegacyNullString]. This is
non-standard and we want to drop support for it from the bindings generator.
Instead, use [TreatNullAs=EmptyString] in order to maintain existing behavior
given that both a missing/empty attribute result in using the default
autocapitalization mode and that autocapitalize returns the empty string by
default.
Test: platform/ios-simulator/ios/fast/forms/autocapitalize-null.html
* html/HTMLFormElement.idl:
* html/HTMLInputElement.idl:
* html/HTMLTextAreaElement.idl:
LayoutTests:
Add layout test coverage.
* platform/ios-simulator/ios/fast/forms/autocapitalize-null-expected.txt: Added.
* platform/ios-simulator/ios/fast/forms/autocapitalize-null.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLFormElementidl">trunk/Source/WebCore/html/HTMLFormElement.idl</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLInputElementidl">trunk/Source/WebCore/html/HTMLInputElement.idl</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLTextAreaElementidl">trunk/Source/WebCore/html/HTMLTextAreaElement.idl</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsplatformiossimulatoriosfastformsautocapitalizenullexpectedtxt">trunk/LayoutTests/platform/ios-simulator/ios/fast/forms/autocapitalize-null-expected.txt</a></li>
<li><a href="#trunkLayoutTestsplatformiossimulatoriosfastformsautocapitalizenullhtml">trunk/LayoutTests/platform/ios-simulator/ios/fast/forms/autocapitalize-null.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (203426 => 203427)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog        2016-07-19 22:51:13 UTC (rev 203426)
+++ trunk/LayoutTests/ChangeLog        2016-07-19 22:55:21 UTC (rev 203427)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2016-07-19 Chris Dumez <cdumez@apple.com>
+
+ autocapitalize attribute should not use [TreatNullAs=LegacyNullString]
+ https://bugs.webkit.org/show_bug.cgi?id=159934
+
+ Reviewed by Benjamin Poulain.
+
+ Add layout test coverage.
+
+ * platform/ios-simulator/ios/fast/forms/autocapitalize-null-expected.txt: Added.
+ * platform/ios-simulator/ios/fast/forms/autocapitalize-null.html: Added.
+
</ins><span class="cx"> 2016-07-19 George Ruan <gruan@apple.com>
</span><span class="cx">
</span><span class="cx"> HTMLVideoElement frames do not update on iOS when src is a MediaStream blob
</span></span></pre></div>
<a id="trunkLayoutTestsplatformiossimulatoriosfastformsautocapitalizenullexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/platform/ios-simulator/ios/fast/forms/autocapitalize-null-expected.txt (0 => 203427)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/ios-simulator/ios/fast/forms/autocapitalize-null-expected.txt         (rev 0)
+++ trunk/LayoutTests/platform/ios-simulator/ios/fast/forms/autocapitalize-null-expected.txt        2016-07-19 22:55:21 UTC (rev 203427)
</span><span class="lines">@@ -0,0 +1,21 @@
</span><ins>+Test null handling on the autocapitalize attribute
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS form.getAttribute('autocapitalize') is null
+form.autocapitalize = null
+PASS form.getAttribute('autocapitalize') is ""
+PASS form.autocapitalize is ""
+PASS input.getAttribute('autocapitalize') is null
+input.autocapitalize = null
+PASS input.getAttribute('autocapitalize') is ""
+PASS input.autocapitalize is ""
+PASS textarea.getAttribute('autocapitalize') is null
+textarea.autocapitalize = null
+PASS textarea.getAttribute('autocapitalize') is ""
+PASS textarea.autocapitalize is ""
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
</ins></span></pre></div>
<a id="trunkLayoutTestsplatformiossimulatoriosfastformsautocapitalizenullhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/platform/ios-simulator/ios/fast/forms/autocapitalize-null.html (0 => 203427)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/ios-simulator/ios/fast/forms/autocapitalize-null.html         (rev 0)
+++ trunk/LayoutTests/platform/ios-simulator/ios/fast/forms/autocapitalize-null.html        2016-07-19 22:55:21 UTC (rev 203427)
</span><span class="lines">@@ -0,0 +1,28 @@
</span><ins>+<!DOCTYPE html>
+<html>
+<body>
+<script src="../../../../../resources/js-test-pre.js"></script>
+<script>
+description("Test null handling on the autocapitalize attribute");
+
+var form = document.createElement("form");
+shouldBeNull("form.getAttribute('autocapitalize')");
+evalAndLog("form.autocapitalize = null");
+shouldBeEqualToString("form.getAttribute('autocapitalize')", "");
+shouldBeEqualToString("form.autocapitalize", "");
+
+var input = document.createElement("input");
+shouldBeNull("input.getAttribute('autocapitalize')");
+evalAndLog("input.autocapitalize = null");
+shouldBeEqualToString("input.getAttribute('autocapitalize')", "");
+shouldBeEqualToString("input.autocapitalize", "");
+
+var textarea = document.createElement("textarea");
+shouldBeNull("textarea.getAttribute('autocapitalize')");
+evalAndLog("textarea.autocapitalize = null");
+shouldBeEqualToString("textarea.getAttribute('autocapitalize')", "");
+shouldBeEqualToString("textarea.autocapitalize", "");
+</script>
+<script src="../../../../../resources/js-test-post.js"></script>
+</body>
+</html>
</ins></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (203426 => 203427)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog        2016-07-19 22:51:13 UTC (rev 203426)
+++ trunk/Source/WebCore/ChangeLog        2016-07-19 22:55:21 UTC (rev 203427)
</span><span class="lines">@@ -1,3 +1,24 @@
</span><ins>+2016-07-19 Chris Dumez <cdumez@apple.com>
+
+ autocapitalize attribute should not use [TreatNullAs=LegacyNullString]
+ https://bugs.webkit.org/show_bug.cgi?id=159934
+
+ Reviewed by Benjamin Poulain.
+
+ autocapitalize attribute should not use [TreatNullAs=LegacyNullString]. This is
+ non-standard and we want to drop support for it from the bindings generator.
+
+ Instead, use [TreatNullAs=EmptyString] in order to maintain existing behavior
+ given that both a missing/empty attribute result in using the default
+ autocapitalization mode and that autocapitalize returns the empty string by
+ default.
+
+ Test: platform/ios-simulator/ios/fast/forms/autocapitalize-null.html
+
+ * html/HTMLFormElement.idl:
+ * html/HTMLInputElement.idl:
+ * html/HTMLTextAreaElement.idl:
+
</ins><span class="cx"> 2016-07-19 Zalan Bujtas <zalan@apple.com>
</span><span class="cx">
</span><span class="cx"> REGRESSION(r203415): ASSERTION FAILED: !m_layoutRoot->container() || !m_layoutRoot->container()->needsLayout()
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLFormElementidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLFormElement.idl (203426 => 203427)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLFormElement.idl        2016-07-19 22:51:13 UTC (rev 203426)
+++ trunk/Source/WebCore/html/HTMLFormElement.idl        2016-07-19 22:55:21 UTC (rev 203427)
</span><span class="lines">@@ -45,8 +45,7 @@
</span><span class="cx">
</span><span class="cx"> [Conditional=IOS_AUTOCORRECT_AND_AUTOCAPITALIZE] attribute boolean autocorrect;
</span><span class="cx">
</span><del>- // FIXME: This should not use [TreatNullAs=LegacyNullString].
- [Conditional=IOS_AUTOCORRECT_AND_AUTOCAPITALIZE, TreatNullAs=LegacyNullString] attribute DOMString autocapitalize;
</del><ins>+ [Conditional=IOS_AUTOCORRECT_AND_AUTOCAPITALIZE, TreatNullAs=EmptyString] attribute DOMString autocapitalize;
</ins><span class="cx">
</span><span class="cx"> #if defined(LANGUAGE_JAVASCRIPT) && LANGUAGE_JAVASCRIPT
</span><span class="cx"> [ImplementedAs=submitFromJavaScript] void submit();
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLInputElementidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLInputElement.idl (203426 => 203427)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLInputElement.idl        2016-07-19 22:51:13 UTC (rev 203426)
+++ trunk/Source/WebCore/html/HTMLInputElement.idl        2016-07-19 22:55:21 UTC (rev 203427)
</span><span class="lines">@@ -126,8 +126,7 @@
</span><span class="cx">
</span><span class="cx"> [Conditional=IOS_AUTOCORRECT_AND_AUTOCAPITALIZE] attribute boolean autocorrect;
</span><span class="cx">
</span><del>- // FIXME: This should not use TreatNullAs=LegacyNullString.
- [Conditional=IOS_AUTOCORRECT_AND_AUTOCAPITALIZE, TreatNullAs=LegacyNullString] attribute DOMString autocapitalize;
</del><ins>+ [Conditional=IOS_AUTOCORRECT_AND_AUTOCAPITALIZE, TreatNullAs=EmptyString] attribute DOMString autocapitalize;
</ins><span class="cx">
</span><span class="cx"> // See http://www.w3.org/TR/html-media-capture/
</span><span class="cx"> [Conditional=MEDIA_CAPTURE, Reflect] attribute boolean capture;
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLTextAreaElementidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLTextAreaElement.idl (203426 => 203427)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLTextAreaElement.idl        2016-07-19 22:51:13 UTC (rev 203426)
+++ trunk/Source/WebCore/html/HTMLTextAreaElement.idl        2016-07-19 22:55:21 UTC (rev 203427)
</span><span class="lines">@@ -72,8 +72,7 @@
</span><span class="cx">
</span><span class="cx"> [Conditional=IOS_AUTOCORRECT_AND_AUTOCAPITALIZE] attribute boolean autocorrect;
</span><span class="cx">
</span><del>- // FIXME: This should not use [TreatNullAs=LegacyNullString].
- [Conditional=IOS_AUTOCORRECT_AND_AUTOCAPITALIZE, TreatNullAs=LegacyNullString] attribute DOMString autocapitalize;
</del><ins>+ [Conditional=IOS_AUTOCORRECT_AND_AUTOCAPITALIZE, TreatNullAs=EmptyString] attribute DOMString autocapitalize;
</ins><span class="cx">
</span><span class="cx"> #if defined(LANGUAGE_OBJECTIVE_C) && LANGUAGE_OBJECTIVE_C
</span><span class="cx"> [Reflect] attribute DOMString accessKey;
</span></span></pre>
</div>
</div>
</body>
</html>