<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[203326] trunk/Source/WebCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/203326">203326</a></dd>
<dt>Author</dt> <dd>cdumez@apple.com</dd>
<dt>Date</dt> <dd>2016-07-16 10:21:07 -0700 (Sat, 16 Jul 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Use fastHasAttribute() when possible
https://bugs.webkit.org/show_bug.cgi?id=159838
Reviewed by Ryosuke Niwa.
Use fastHasAttribute() when possible, for performance.
* editing/DeleteSelectionCommand.cpp:
(WebCore::DeleteSelectionCommand::makeStylingElementsDirectChildrenOfEditableRootToPreventStyleLoss):
* editing/markup.cpp:
(WebCore::createMarkupInternal):
* html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::draggable):
* html/HTMLFrameElementBase.cpp:
(WebCore::HTMLFrameElementBase::parseAttribute):
* mathml/MathMLSelectElement.cpp:
(WebCore::MathMLSelectElement::getSelectedSemanticsChild):
* rendering/RenderThemeIOS.mm:
(WebCore::RenderThemeIOS::adjustMenuListButtonStyle):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreeditingDeleteSelectionCommandcpp">trunk/Source/WebCore/editing/DeleteSelectionCommand.cpp</a></li>
<li><a href="#trunkSourceWebCoreeditingmarkupcpp">trunk/Source/WebCore/editing/markup.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLAnchorElementcpp">trunk/Source/WebCore/html/HTMLAnchorElement.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLFrameElementBasecpp">trunk/Source/WebCore/html/HTMLFrameElementBase.cpp</a></li>
<li><a href="#trunkSourceWebCoremathmlMathMLSelectElementcpp">trunk/Source/WebCore/mathml/MathMLSelectElement.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderThemeIOSmm">trunk/Source/WebCore/rendering/RenderThemeIOS.mm</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (203325 => 203326)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-07-16 16:33:11 UTC (rev 203325)
+++ trunk/Source/WebCore/ChangeLog 2016-07-16 17:21:07 UTC (rev 203326)
</span><span class="lines">@@ -1,3 +1,25 @@
</span><ins>+2016-07-16 Chris Dumez <cdumez@apple.com>
+
+ Use fastHasAttribute() when possible
+ https://bugs.webkit.org/show_bug.cgi?id=159838
+
+ Reviewed by Ryosuke Niwa.
+
+ Use fastHasAttribute() when possible, for performance.
+
+ * editing/DeleteSelectionCommand.cpp:
+ (WebCore::DeleteSelectionCommand::makeStylingElementsDirectChildrenOfEditableRootToPreventStyleLoss):
+ * editing/markup.cpp:
+ (WebCore::createMarkupInternal):
+ * html/HTMLAnchorElement.cpp:
+ (WebCore::HTMLAnchorElement::draggable):
+ * html/HTMLFrameElementBase.cpp:
+ (WebCore::HTMLFrameElementBase::parseAttribute):
+ * mathml/MathMLSelectElement.cpp:
+ (WebCore::MathMLSelectElement::getSelectedSemanticsChild):
+ * rendering/RenderThemeIOS.mm:
+ (WebCore::RenderThemeIOS::adjustMenuListButtonStyle):
+
</ins><span class="cx"> 2016-07-16 Ryosuke Niwa <rniwa@webkit.org>
</span><span class="cx">
</span><span class="cx"> Rename fastGetAttribute to attributeWithoutSynchronization
</span></span></pre></div>
<a id="trunkSourceWebCoreeditingDeleteSelectionCommandcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/editing/DeleteSelectionCommand.cpp (203325 => 203326)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/editing/DeleteSelectionCommand.cpp 2016-07-16 16:33:11 UTC (rev 203325)
+++ trunk/Source/WebCore/editing/DeleteSelectionCommand.cpp 2016-07-16 17:21:07 UTC (rev 203326)
</span><span class="lines">@@ -434,7 +434,7 @@
</span><span class="cx"> RefPtr<Node> node = range->firstNode();
</span><span class="cx"> while (node && node != range->pastLastNode()) {
</span><span class="cx"> RefPtr<Node> nextNode = NodeTraversal::next(*node);
</span><del>- if ((is<HTMLStyleElement>(*node) && !downcast<HTMLStyleElement>(*node).hasAttribute(scopedAttr)) || is<HTMLLinkElement>(*node)) {
</del><ins>+ if ((is<HTMLStyleElement>(*node) && !downcast<HTMLStyleElement>(*node).fastHasAttribute(scopedAttr)) || is<HTMLLinkElement>(*node)) {
</ins><span class="cx"> nextNode = NodeTraversal::nextSkippingChildren(*node);
</span><span class="cx"> RefPtr<ContainerNode> rootEditableElement = node->rootEditableElement();
</span><span class="cx"> if (rootEditableElement) {
</span></span></pre></div>
<a id="trunkSourceWebCoreeditingmarkupcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/editing/markup.cpp (203325 => 203326)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/editing/markup.cpp 2016-07-16 16:33:11 UTC (rev 203325)
+++ trunk/Source/WebCore/editing/markup.cpp 2016-07-16 17:21:07 UTC (rev 203326)
</span><span class="lines">@@ -629,7 +629,7 @@
</span><span class="cx"> // Bring the background attribute over, but not as an attribute because a background attribute on a div
</span><span class="cx"> // appears to have no effect.
</span><span class="cx"> if ((!fullySelectedRootStyle || !fullySelectedRootStyle->style() || !fullySelectedRootStyle->style()->getPropertyCSSValue(CSSPropertyBackgroundImage))
</span><del>- && fullySelectedRoot->hasAttribute(backgroundAttr))
</del><ins>+ && fullySelectedRoot->fastHasAttribute(backgroundAttr))
</ins><span class="cx"> fullySelectedRootStyle->style()->setProperty(CSSPropertyBackgroundImage, "url('" + fullySelectedRoot->getAttribute(backgroundAttr) + "')");
</span><span class="cx">
</span><span class="cx"> if (fullySelectedRootStyle->style()) {
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLAnchorElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLAnchorElement.cpp (203325 => 203326)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLAnchorElement.cpp 2016-07-16 16:33:11 UTC (rev 203325)
+++ trunk/Source/WebCore/html/HTMLAnchorElement.cpp 2016-07-16 17:21:07 UTC (rev 203326)
</span><span class="lines">@@ -281,7 +281,7 @@
</span><span class="cx"> return true;
</span><span class="cx"> if (equalLettersIgnoringASCIICase(value, "false"))
</span><span class="cx"> return false;
</span><del>- return hasAttribute(hrefAttr);
</del><ins>+ return fastHasAttribute(hrefAttr);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> URL HTMLAnchorElement::href() const
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLFrameElementBasecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLFrameElementBase.cpp (203325 => 203326)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLFrameElementBase.cpp 2016-07-16 16:33:11 UTC (rev 203325)
+++ trunk/Source/WebCore/html/HTMLFrameElementBase.cpp 2016-07-16 17:21:07 UTC (rev 203326)
</span><span class="lines">@@ -99,7 +99,7 @@
</span><span class="cx"> else if (name == idAttr) {
</span><span class="cx"> HTMLFrameOwnerElement::parseAttribute(name, value);
</span><span class="cx"> // Falling back to using the 'id' attribute is not standard but some content relies on this behavior.
</span><del>- if (!hasAttribute(nameAttr))
</del><ins>+ if (!fastHasAttribute(nameAttr))
</ins><span class="cx"> m_frameName = value;
</span><span class="cx"> } else if (name == nameAttr) {
</span><span class="cx"> m_frameName = value;
</span></span></pre></div>
<a id="trunkSourceWebCoremathmlMathMLSelectElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/mathml/MathMLSelectElement.cpp (203325 => 203326)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/mathml/MathMLSelectElement.cpp 2016-07-16 16:33:11 UTC (rev 203325)
+++ trunk/Source/WebCore/mathml/MathMLSelectElement.cpp 2016-07-16 17:21:07 UTC (rev 203326)
</span><span class="lines">@@ -174,7 +174,7 @@
</span><span class="cx">
</span><span class="cx"> if (child->hasTagName(MathMLNames::annotationTag)) {
</span><span class="cx"> // If the <annotation> element has an src attribute then it is a reference to arbitrary binary data and it is not clear whether we can display it. Hence we just ignore the annotation.
</span><del>- if (child->hasAttribute(MathMLNames::srcAttr))
</del><ins>+ if (child->fastHasAttribute(MathMLNames::srcAttr))
</ins><span class="cx"> continue;
</span><span class="cx"> // Otherwise, we assume it is a text annotation that can always be displayed and we stop here.
</span><span class="cx"> return child;
</span><span class="lines">@@ -182,7 +182,7 @@
</span><span class="cx">
</span><span class="cx"> if (child->hasTagName(MathMLNames::annotation_xmlTag)) {
</span><span class="cx"> // If the <annotation-xml> element has an src attribute then it is a reference to arbitrary binary data and it is not clear whether we can display it. Hence we just ignore the annotation.
</span><del>- if (child->hasAttribute(MathMLNames::srcAttr))
</del><ins>+ if (child->fastHasAttribute(MathMLNames::srcAttr))
</ins><span class="cx"> continue;
</span><span class="cx"> // If the <annotation-xml> element has an encoding attribute describing presentation MathML, SVG or HTML we assume the content can be displayed and we stop here.
</span><span class="cx"> const AtomicString& value = child->attributeWithoutSynchronization(MathMLNames::encodingAttr);
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderThemeIOSmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderThemeIOS.mm (203325 => 203326)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderThemeIOS.mm 2016-07-16 16:33:11 UTC (rev 203325)
+++ trunk/Source/WebCore/rendering/RenderThemeIOS.mm 2016-07-16 17:21:07 UTC (rev 203326)
</span><span class="lines">@@ -625,7 +625,7 @@
</span><span class="cx"> // Enforce some default styles in the case that this is a non-multiple <select> element,
</span><span class="cx"> // or a date input. We don't force these if this is just an element with
</span><span class="cx"> // "-webkit-appearance: menulist-button".
</span><del>- if (is<HTMLSelectElement>(*element) && !element->hasAttribute(HTMLNames::multipleAttr))
</del><ins>+ if (is<HTMLSelectElement>(*element) && !element->fastHasAttribute(HTMLNames::multipleAttr))
</ins><span class="cx"> adjustSelectListButtonStyle(style, *element);
</span><span class="cx"> else if (is<HTMLInputElement>(*element))
</span><span class="cx"> adjustInputElementButtonStyle(style, downcast<HTMLInputElement>(*element));
</span></span></pre>
</div>
</div>
</body>
</html>