<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[203321] trunk/LayoutTests</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/203321">203321</a></dd>
<dt>Author</dt> <dd>benjamin@webkit.org</dd>
<dt>Date</dt> <dd>2016-07-15 21:17:21 -0700 (Fri, 15 Jul 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>[mac] LayoutTest fast/css/ancestor-of-hovered-element-detached.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=159173
Reviewed by Alexey Proskuryakov.
The test ancestor-of-hovered-element-detached.html is not reliably
covering <a href="http://trac.webkit.org/projects/webkit/changeset/202324">r202324</a>.
In the case of that test, the first style update is done with
the flag TeardownType::KeepHoverAndActive. This keeps the ":hover" state
set despite the subtree losing their renderer.
This looks like a serious issue that should be tested separately.
* fast/css/ancestor-of-hovered-element-removed.html:
The :hover update timer is actually a zero timer.
It is reasonable to expect a full update after one frame update.
* fast/css/ancestor-of-hovered-element-detached-expected.txt: Removed.
* fast/css/ancestor-of-hovered-element-detached.html: Removed.
* platform/ios-simulator/TestExpectations:
* platform/mac/TestExpectations:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsfastcssancestorofhoveredelementremovedhtml">trunk/LayoutTests/fast/css/ancestor-of-hovered-element-removed.html</a></li>
<li><a href="#trunkLayoutTestsplatformiossimulatorTestExpectations">trunk/LayoutTests/platform/ios-simulator/TestExpectations</a></li>
<li><a href="#trunkLayoutTestsplatformmacTestExpectations">trunk/LayoutTests/platform/mac/TestExpectations</a></li>
</ul>
<h3>Removed Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsfastcssancestorofhoveredelementdetachedexpectedtxt">trunk/LayoutTests/fast/css/ancestor-of-hovered-element-detached-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastcssancestorofhoveredelementdetachedhtml">trunk/LayoutTests/fast/css/ancestor-of-hovered-element-detached.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (203320 => 203321)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2016-07-16 04:16:30 UTC (rev 203320)
+++ trunk/LayoutTests/ChangeLog 2016-07-16 04:17:21 UTC (rev 203321)
</span><span class="lines">@@ -1,3 +1,27 @@
</span><ins>+2016-07-15 Benjamin Poulain <benjamin@webkit.org>
+
+ [mac] LayoutTest fast/css/ancestor-of-hovered-element-detached.html is flaky
+ https://bugs.webkit.org/show_bug.cgi?id=159173
+
+ Reviewed by Alexey Proskuryakov.
+
+ The test ancestor-of-hovered-element-detached.html is not reliably
+ covering r202324.
+
+ In the case of that test, the first style update is done with
+ the flag TeardownType::KeepHoverAndActive. This keeps the ":hover" state
+ set despite the subtree losing their renderer.
+ This looks like a serious issue that should be tested separately.
+
+ * fast/css/ancestor-of-hovered-element-removed.html:
+ The :hover update timer is actually a zero timer.
+ It is reasonable to expect a full update after one frame update.
+
+ * fast/css/ancestor-of-hovered-element-detached-expected.txt: Removed.
+ * fast/css/ancestor-of-hovered-element-detached.html: Removed.
+ * platform/ios-simulator/TestExpectations:
+ * platform/mac/TestExpectations:
+
</ins><span class="cx"> 2016-07-15 Myles C. Maxfield <mmaxfield@apple.com>
</span><span class="cx">
</span><span class="cx"> Test gardening after r203314
</span></span></pre></div>
<a id="trunkLayoutTestsfastcssancestorofhoveredelementdetachedexpectedtxt"></a>
<div class="delfile"><h4>Deleted: trunk/LayoutTests/fast/css/ancestor-of-hovered-element-detached-expected.txt (203320 => 203321)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/css/ancestor-of-hovered-element-detached-expected.txt 2016-07-16 04:16:30 UTC (rev 203320)
+++ trunk/LayoutTests/fast/css/ancestor-of-hovered-element-detached-expected.txt 2016-07-16 04:17:21 UTC (rev 203321)
</span><span class="lines">@@ -1,16 +0,0 @@
</span><del>-Verify the hovered state is updated correctly when an ancestor of the hovered element loses its renderer
-On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-
- Initial state
-PASS elementsWithHoverStyle() is ["html", "body", "prime-ancestor"]
-PASS elementsMatchingHoverSelector() is ["html", "body", "prime-ancestor"]
-Moving over #target
-PASS elementsWithHoverStyle() is ["html", "body", "prime-ancestor", "group", "element-to-remove", "target"]
-PASS elementsMatchingHoverSelector() is ["html", "body", "prime-ancestor", "group", "element-to-remove", "target"]
-Removing the renderer of #element-to-remove
-PASS elementsWithHoverStyle() is ["html", "body", "prime-ancestor", "interceptor"]
-PASS elementsMatchingHoverSelector() is ["html", "body", "prime-ancestor", "interceptor"]
-PASS successfullyParsed is true
-
-TEST COMPLETE
-
</del></span></pre></div>
<a id="trunkLayoutTestsfastcssancestorofhoveredelementdetachedhtml"></a>
<div class="delfile"><h4>Deleted: trunk/LayoutTests/fast/css/ancestor-of-hovered-element-detached.html (203320 => 203321)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/css/ancestor-of-hovered-element-detached.html 2016-07-16 04:16:30 UTC (rev 203320)
+++ trunk/LayoutTests/fast/css/ancestor-of-hovered-element-detached.html 2016-07-16 04:17:21 UTC (rev 203321)
</span><span class="lines">@@ -1,98 +0,0 @@
</span><del>-<!DOCTYPE html>
-<html id="html">
-<head>
-<style>
- * {
- background-color: white;
- margin: 0;
- padding: 0;
- }
- :hover {
- background-color: rgb(50, 100, 150) !important;
- }
- #prime-ancestor >> div {
- width: 100px;
- height: 100px;
- }
- #target {
- width: 100px;
- height: 100px;
- background-color: green;
- position: absolute;
- left: 100px;
- }
- #interceptor {
- position: absolute;
- left: 100px;
- }
-</style>
-</head>
-<script src="../../resources/js-test-pre.js"></script>
-<body id="body">
- <div id="prime-ancestor">
- <div id="interceptor">
- </div>
- <div id="group">
- <div id="element-to-remove">
- <div id="target">
- </div>
- </div>
- </div>
- </div>
- <div id="console">
- </div>
- <script>
- description("Verify the hovered state is updated correctly when an ancestor of the hovered element loses its renderer");
- window.jsTestIsAsync = true;
-
- function elementsWithHoverStyle() {
- let elements = [];
- for (let element of document.querySelectorAll("*")) {
- if (getComputedStyle(element).backgroundColor === "rgb(50, 100, 150)")
- elements.push(element.id);
- }
- return elements;
- }
- function elementsMatchingHoverSelector() {
- let elements = [];
- for (let element of document.querySelectorAll(":hover")) {
- elements.push(element.id);
- }
- return elements;
- }
-
- if (!window.eventSender) {
- debug("This test requires eventSender");
- }
- eventSender.mouseMoveTo(300, 50);
- {
- // See https://bugs.webkit.org/show_bug.cgi?id=74264
- eventSender.mouseDown()
- eventSender.mouseUp()
- }
-
- debug("Initial state");
- shouldBe('elementsWithHoverStyle()', '["html", "body", "prime-ancestor"]');
- shouldBe('elementsMatchingHoverSelector()', '["html", "body", "prime-ancestor"]');
-
- debug("Moving over #target")
- eventSender.mouseMoveTo(150, 50);
- shouldBe('elementsWithHoverStyle()', '["html", "body", "prime-ancestor", "group", "element-to-remove", "target"]');
- shouldBe('elementsMatchingHoverSelector()', '["html", "body", "prime-ancestor", "group", "element-to-remove", "target"]');
-
- debug("Removing the renderer of #element-to-remove");
- var elementToRemove = document.getElementById("element-to-remove");
- elementToRemove.style.display = "none";
- // Force layout.
- offsetTop = elementToRemove.offsetTop;
-
- // hover updates happen on timer.
- setTimeout(function() {
- shouldBe('elementsWithHoverStyle()', '["html", "body", "prime-ancestor", "interceptor"]');
- shouldBe('elementsMatchingHoverSelector()', '["html", "body", "prime-ancestor", "interceptor"]');
- finishJSTest();
- }, 125);
- </script>
- <script src="../../resources/js-test-post.js"></script>
-</body>
-</html>
</del></span></pre></div>
<a id="trunkLayoutTestsfastcssancestorofhoveredelementremovedhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/css/ancestor-of-hovered-element-removed.html (203320 => 203321)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/css/ancestor-of-hovered-element-removed.html 2016-07-16 04:16:30 UTC (rev 203320)
+++ trunk/LayoutTests/fast/css/ancestor-of-hovered-element-removed.html 2016-07-16 04:17:21 UTC (rev 203321)
</span><span class="lines">@@ -93,7 +93,7 @@
</span><span class="cx"> shouldBe('elementsWithHoverStyle()', '["html", "body", "prime-ancestor", "interceptor"]');
</span><span class="cx"> shouldBe('elementsMatchingHoverSelector()', '["html", "body", "prime-ancestor", "interceptor"]');
</span><span class="cx"> finishJSTest();
</span><del>- }, 125);
</del><ins>+ }, 17);
</ins><span class="cx"> </script>
</span><span class="cx"> <script src="../../resources/js-test-post.js"></script>
</span><span class="cx"> </body>
</span></span></pre></div>
<a id="trunkLayoutTestsplatformiossimulatorTestExpectations"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/ios-simulator/TestExpectations (203320 => 203321)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/ios-simulator/TestExpectations 2016-07-16 04:16:30 UTC (rev 203320)
+++ trunk/LayoutTests/platform/ios-simulator/TestExpectations 2016-07-16 04:17:21 UTC (rev 203321)
</span><span class="lines">@@ -1412,7 +1412,6 @@
</span><span class="cx"> fast/clip/clip-when-rect-has-fractional-pixel-value.html [ ImageOnlyFailure ]
</span><span class="cx"> fast/css-generated-content/table-parts-before-and-after.html [ Failure ]
</span><span class="cx"> fast/css/absolute-child-with-percent-height-inside-relative-parent.html [ Failure ]
</span><del>-fast/css/ancestor-of-hovered-element-detached.html [ Failure ]
</del><span class="cx"> fast/css/ancestor-of-hovered-element-removed.html [ Failure ]
</span><span class="cx"> fast/css/background-image-with-baseurl.html [ Failure ]
</span><span class="cx"> fast/css/button-height.html [ Failure ]
</span></span></pre></div>
<a id="trunkLayoutTestsplatformmacTestExpectations"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/mac/TestExpectations (203320 => 203321)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/mac/TestExpectations 2016-07-16 04:16:30 UTC (rev 203320)
+++ trunk/LayoutTests/platform/mac/TestExpectations 2016-07-16 04:17:21 UTC (rev 203321)
</span><span class="lines">@@ -1449,6 +1449,4 @@
</span><span class="cx">
</span><span class="cx"> webkit.org/b/158500 storage/indexeddb/database-close-private.html [ Pass Failure ]
</span><span class="cx">
</span><del>-webkit.org/b/159173 fast/css/ancestor-of-hovered-element-detached.html [ Pass Failure ]
-
</del><span class="cx"> webkit.org/b/158640 imported/blink/storage/indexeddb/blob-valid-after-deletion.html [ Pass Failure ]
</span></span></pre>
</div>
</div>
</body>
</html>