<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[203291] trunk/Websites/webkit.org</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/203291">203291</a></dd>
<dt>Author</dt> <dd>jond@apple.com</dd>
<dt>Date</dt> <dd>2016-07-15 12:27:54 -0700 (Fri, 15 Jul 2016)</dd>
</dl>

<h3>Log Message</h3>
<pre>Fixed content overflow and missing build information behavior.
https://bugs.webkit.org/show_bug.cgi?id=159820

Reviewed by Timothy Hatcher.

* wp-content/themes/webkit/nightly-start.php:</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkWebsiteswebkitorgChangeLog">trunk/Websites/webkit.org/ChangeLog</a></li>
<li><a href="#trunkWebsiteswebkitorgwpcontentthemeswebkitnightlystartphp">trunk/Websites/webkit.org/wp-content/themes/webkit/nightly-start.php</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkWebsiteswebkitorgChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Websites/webkit.org/ChangeLog (203290 => 203291)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/webkit.org/ChangeLog        2016-07-15 19:01:56 UTC (rev 203290)
+++ trunk/Websites/webkit.org/ChangeLog        2016-07-15 19:27:54 UTC (rev 203291)
</span><span class="lines">@@ -1,3 +1,12 @@
</span><ins>+2016-07-15  Jon Davis  &lt;jond@apple.com&gt;
+
+        Fixed content overflow and missing build information behavior.
+        https://bugs.webkit.org/show_bug.cgi?id=159820
+
+        Reviewed by Timothy Hatcher.
+
+        * wp-content/themes/webkit/nightly-start.php:
+
</ins><span class="cx"> 2016-07-14  Jon Davis  &lt;jond@apple.com&gt;
</span><span class="cx"> 
</span><span class="cx">         Improved WebKit Nightly start page design.
</span></span></pre></div>
<a id="trunkWebsiteswebkitorgwpcontentthemeswebkitnightlystartphp"></a>
<div class="modfile"><h4>Modified: trunk/Websites/webkit.org/wp-content/themes/webkit/nightly-start.php (203290 => 203291)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/webkit.org/wp-content/themes/webkit/nightly-start.php        2016-07-15 19:01:56 UTC (rev 203290)
+++ trunk/Websites/webkit.org/wp-content/themes/webkit/nightly-start.php        2016-07-15 19:27:54 UTC (rev 203291)
</span><span class="lines">@@ -9,17 +9,18 @@
</span><span class="cx"> $branch = get_query_var('nightly_branch');
</span><span class="cx"> $build = intval(get_query_var('nightly_build'));
</span><span class="cx"> 
</span><del>-if ($build &lt; 11976 || $build &gt; $latest || empty($branch))
-    return show_404_page();
-
</del><span class="cx"> get_header();
</span><span class="cx"> 
</span><span class="cx"> add_filter('the_content', function ($content) {
</span><span class="cx">     $branch = get_query_var('nightly_branch');
</span><span class="cx">     $build = intval(get_query_var('nightly_build'));
</span><ins>+    
+    if (empty($Build) || empty($branch) || $build &lt; 11976) {
+        $content = preg_replace('/&lt;p&gt;(.*?)%1\$s&lt;\/p&gt;/', '&lt;p&gt;&lt;/p&gt;', $content);
+    } else {
+        $content = sprintf($content, &quot;r$build&quot;, $branch);
+    }
</ins><span class="cx"> 
</span><del>-    $content = sprintf($content, &quot;r$build&quot;, $branch);
-
</del><span class="cx">     return $content;
</span><span class="cx"> });
</span><span class="cx"> ?&gt;
</span><span class="lines">@@ -151,13 +152,12 @@
</span><span class="cx"> .update-nag {
</span><span class="cx">     background-color: #FF9D00;
</span><span class="cx">     color: #000000;
</span><del>-    width: 100vw;
-    left: 50%;
</del><ins>+    width: 100%;
+    top: 0;
+    left: 0;
</ins><span class="cx">     position: absolute;
</span><del>-    transform: translate(-50vw);
-    padding: 1.5rem;
</del><ins>+    padding-bottom: 1.5rem;
</ins><span class="cx">     padding-top: 11.5rem;
</span><del>-    top: 0;
</del><span class="cx"> }
</span><span class="cx"> 
</span><span class="cx"> .admin-bar .update-nag {
</span><span class="lines">@@ -186,8 +186,6 @@
</span><span class="cx"> }
</span><span class="cx"> 
</span><span class="cx"> &lt;/style&gt;
</span><del>-&lt;?xml version=&quot;1.0&quot; encoding=&quot;utf-8&quot;?&gt;
-&lt;!-- Copyright © 2015 Apple Inc. All rights reserved. --&gt;
</del><span class="cx"> &lt;svg xmlns=&quot;http://www.w3.org/2000/svg&quot; xmlns:xlink=&quot;http://www.w3.org/1999/xlink&quot; version=&quot;1.1&quot; id=&quot;icons-sprite&quot;&gt;
</span><span class="cx">     &lt;style&gt;
</span><span class="cx">         svg,symbol { color: white; }
</span><span class="lines">@@ -252,8 +250,9 @@
</span><span class="cx">     &lt;/defs&gt;
</span><span class="cx"> &lt;/svg&gt;
</span><span class="cx"> &lt;?php if ( (int)$build &lt; (int)$latest ):
</span><del>-    $prompt_text = &quot;A new nightly build is available. Please update before continuing.&quot;;
-    $prompt_meta = get_post_meta(get_the_ID(), 'prompt', true);
</del><ins>+    $prompt_text = &quot;Please be sure you are running the latest WebKit Nightly build before continuing to test.&quot;;
+    if (!empty($build))
+        $prompt_meta = get_post_meta(get_the_ID(), 'prompt', true);
</ins><span class="cx">     if (!empty($prompt_meta)) $prompt_text = $prompt_meta;
</span><span class="cx"> ?&gt;
</span><span class="cx"> &lt;div class=&quot;update-nag&quot;&gt;
</span></span></pre>
</div>
</div>

</body>
</html>