<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[203253] trunk/Source/WebInspectorUI</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/203253">203253</a></dd>
<dt>Author</dt> <dd>mattbaker@apple.com</dd>
<dt>Date</dt> <dd>2016-07-14 16:37:37 -0700 (Thu, 14 Jul 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Web Inspector: SidebarPanel classes should use View.layout instead of "refresh"
https://bugs.webkit.org/show_bug.cgi?id=159745
<rdar://problem/27335252>
Reviewed by Timothy Hatcher.
* UserInterface/Views/ApplicationCacheDetailsSidebarPanel.js:
(WebInspector.ApplicationCacheDetailsSidebarPanel.prototype.set applicationCacheFrame):
Use needsLayout.
* UserInterface/Views/CSSStyleDetailsSidebarPanel.js:
(WebInspector.CSSStyleDetailsSidebarPanel.prototype.layout):
Move refresh logic to layout.
(WebInspector.CSSStyleDetailsSidebarPanel.prototype.initialLayout):
(WebInspector.CSSStyleDetailsSidebarPanel.prototype._styleSheetAddedOrRemoved):
Defer layout to coalesce updates.
(WebInspector.CSSStyleDetailsSidebarPanel):
(WebInspector.CSSStyleDetailsSidebarPanel.prototype.refresh): Deleted.
* UserInterface/Views/DOMDetailsSidebarPanel.js:
(WebInspector.DOMDetailsSidebarPanel.prototype.set domNode):
Use needsLayout.
* UserInterface/Views/DOMNodeDetailsSidebarPanel.js:
Move refresh logic to layout.
* UserInterface/Views/DetailsSidebarPanel.js:
(WebInspector.DetailsSidebarPanel.prototype.shown): Deleted.
Base class already forces a layout when shown.
(WebInspector.DetailsSidebarPanel.prototype.needsRefresh): Deleted.
No longer needed.
(WebInspector.DetailsSidebarPanel.prototype.refresh): Deleted.
Renamed layout.
(WebInspector.DetailsSidebarPanel): Deleted.
* UserInterface/Views/LayerTreeDetailsSidebarPanel.js:
(WebInspector.LayerTreeDetailsSidebarPanel.prototype.supportsDOMNode):
(WebInspector.LayerTreeDetailsSidebarPanel.prototype._layerTreeDidChange):
Use needsLayout.
(WebInspector.LayerTreeDetailsSidebarPanel.prototype.shown):
Base class already forces a layout when shown.
* UserInterface/Views/ResourceDetailsSidebarPanel.js:
(WebInspector.ResourceDetailsSidebarPanel.prototype.set resource):
Use needsLayout.
* UserInterface/Views/ScopeChainDetailsSidebarPanel.js:
(WebInspector.ScopeChainDetailsSidebarPanel):
(WebInspector.ScopeChainDetailsSidebarPanel.prototype.set callFrame):
(WebInspector.ScopeChainDetailsSidebarPanel.prototype._addWatchExpression):
(WebInspector.ScopeChainDetailsSidebarPanel.prototype._removeWatchExpression):
(WebInspector.ScopeChainDetailsSidebarPanel.prototype._clearAllWatchExpressions):
(WebInspector.ScopeChainDetailsSidebarPanel.prototype._refreshAllWatchExpressionsButtonClicked):
(WebInspector.ScopeChainDetailsSidebarPanel.prototype._didEvaluateExpression):
(WebInspector.ScopeChainDetailsSidebarPanel.prototype._mainResourceDidChange):
Use needsLayout.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebInspectorUIChangeLog">trunk/Source/WebInspectorUI/ChangeLog</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsApplicationCacheDetailsSidebarPaneljs">trunk/Source/WebInspectorUI/UserInterface/Views/ApplicationCacheDetailsSidebarPanel.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsCSSStyleDetailsSidebarPaneljs">trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDetailsSidebarPanel.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsDOMDetailsSidebarPaneljs">trunk/Source/WebInspectorUI/UserInterface/Views/DOMDetailsSidebarPanel.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsDOMNodeDetailsSidebarPaneljs">trunk/Source/WebInspectorUI/UserInterface/Views/DOMNodeDetailsSidebarPanel.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsDetailsSidebarPaneljs">trunk/Source/WebInspectorUI/UserInterface/Views/DetailsSidebarPanel.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsLayerTreeDetailsSidebarPaneljs">trunk/Source/WebInspectorUI/UserInterface/Views/LayerTreeDetailsSidebarPanel.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsResourceDetailsSidebarPaneljs">trunk/Source/WebInspectorUI/UserInterface/Views/ResourceDetailsSidebarPanel.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsScopeChainDetailsSidebarPaneljs">trunk/Source/WebInspectorUI/UserInterface/Views/ScopeChainDetailsSidebarPanel.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebInspectorUIChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/ChangeLog (203252 => 203253)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/ChangeLog 2016-07-14 23:33:13 UTC (rev 203252)
+++ trunk/Source/WebInspectorUI/ChangeLog 2016-07-14 23:37:37 UTC (rev 203253)
</span><span class="lines">@@ -1,3 +1,62 @@
</span><ins>+2016-07-14 Matt Baker <mattbaker@apple.com>
+
+ Web Inspector: SidebarPanel classes should use View.layout instead of "refresh"
+ https://bugs.webkit.org/show_bug.cgi?id=159745
+ <rdar://problem/27335252>
+
+ Reviewed by Timothy Hatcher.
+
+ * UserInterface/Views/ApplicationCacheDetailsSidebarPanel.js:
+ (WebInspector.ApplicationCacheDetailsSidebarPanel.prototype.set applicationCacheFrame):
+ Use needsLayout.
+
+ * UserInterface/Views/CSSStyleDetailsSidebarPanel.js:
+ (WebInspector.CSSStyleDetailsSidebarPanel.prototype.layout):
+ Move refresh logic to layout.
+ (WebInspector.CSSStyleDetailsSidebarPanel.prototype.initialLayout):
+ (WebInspector.CSSStyleDetailsSidebarPanel.prototype._styleSheetAddedOrRemoved):
+ Defer layout to coalesce updates.
+ (WebInspector.CSSStyleDetailsSidebarPanel):
+ (WebInspector.CSSStyleDetailsSidebarPanel.prototype.refresh): Deleted.
+
+ * UserInterface/Views/DOMDetailsSidebarPanel.js:
+ (WebInspector.DOMDetailsSidebarPanel.prototype.set domNode):
+ Use needsLayout.
+
+ * UserInterface/Views/DOMNodeDetailsSidebarPanel.js:
+ Move refresh logic to layout.
+
+ * UserInterface/Views/DetailsSidebarPanel.js:
+ (WebInspector.DetailsSidebarPanel.prototype.shown): Deleted.
+ Base class already forces a layout when shown.
+ (WebInspector.DetailsSidebarPanel.prototype.needsRefresh): Deleted.
+ No longer needed.
+ (WebInspector.DetailsSidebarPanel.prototype.refresh): Deleted.
+ Renamed layout.
+ (WebInspector.DetailsSidebarPanel): Deleted.
+
+ * UserInterface/Views/LayerTreeDetailsSidebarPanel.js:
+ (WebInspector.LayerTreeDetailsSidebarPanel.prototype.supportsDOMNode):
+ (WebInspector.LayerTreeDetailsSidebarPanel.prototype._layerTreeDidChange):
+ Use needsLayout.
+ (WebInspector.LayerTreeDetailsSidebarPanel.prototype.shown):
+ Base class already forces a layout when shown.
+
+ * UserInterface/Views/ResourceDetailsSidebarPanel.js:
+ (WebInspector.ResourceDetailsSidebarPanel.prototype.set resource):
+ Use needsLayout.
+
+ * UserInterface/Views/ScopeChainDetailsSidebarPanel.js:
+ (WebInspector.ScopeChainDetailsSidebarPanel):
+ (WebInspector.ScopeChainDetailsSidebarPanel.prototype.set callFrame):
+ (WebInspector.ScopeChainDetailsSidebarPanel.prototype._addWatchExpression):
+ (WebInspector.ScopeChainDetailsSidebarPanel.prototype._removeWatchExpression):
+ (WebInspector.ScopeChainDetailsSidebarPanel.prototype._clearAllWatchExpressions):
+ (WebInspector.ScopeChainDetailsSidebarPanel.prototype._refreshAllWatchExpressionsButtonClicked):
+ (WebInspector.ScopeChainDetailsSidebarPanel.prototype._didEvaluateExpression):
+ (WebInspector.ScopeChainDetailsSidebarPanel.prototype._mainResourceDidChange):
+ Use needsLayout.
+
</ins><span class="cx"> 2016-07-14 Joseph Pecoraro <pecoraro@apple.com>
</span><span class="cx">
</span><span class="cx"> Web Inspector: Maintain selected function when switching between different profile representations
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsApplicationCacheDetailsSidebarPaneljs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ApplicationCacheDetailsSidebarPanel.js (203252 => 203253)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/ApplicationCacheDetailsSidebarPanel.js 2016-07-14 23:33:13 UTC (rev 203252)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ApplicationCacheDetailsSidebarPanel.js 2016-07-14 23:37:37 UTC (rev 203253)
</span><span class="lines">@@ -89,10 +89,12 @@
</span><span class="cx">
</span><span class="cx"> this._applicationCacheFrame = applicationCacheFrame;
</span><span class="cx">
</span><del>- this.needsRefresh();
</del><ins>+ this.needsLayout();
</ins><span class="cx"> }
</span><span class="cx">
</span><del>- refresh()
</del><ins>+ // Protected
+
+ layout()
</ins><span class="cx"> {
</span><span class="cx"> if (!this.applicationCacheFrame)
</span><span class="cx"> return;
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsCSSStyleDetailsSidebarPaneljs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDetailsSidebarPanel.js (203252 => 203253)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDetailsSidebarPanel.js 2016-07-14 23:33:13 UTC (rev 203252)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDetailsSidebarPanel.js 2016-07-14 23:37:37 UTC (rev 203253)
</span><span class="lines">@@ -54,25 +54,6 @@
</span><span class="cx"> return nodeToInspect.nodeType() === Node.ELEMENT_NODE;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- refresh()
- {
- let domNode = this.domNode;
- if (!domNode)
- return;
-
- this.contentView.element.scrollTop = this._initialScrollOffset;
-
- for (let panel of this._panels) {
- panel.element._savedScrollTop = undefined;
- panel.markAsNeedsRefresh(domNode);
- }
-
- this._updatePseudoClassCheckboxes();
-
- if (!this._classListContainer.hidden)
- this._populateClassToggles();
- }
-
</del><span class="cx"> visibilityDidChange()
</span><span class="cx"> {
</span><span class="cx"> super.visibilityDidChange();
</span><span class="lines">@@ -101,6 +82,25 @@
</span><span class="cx">
</span><span class="cx"> // Protected
</span><span class="cx">
</span><ins>+ layout()
+ {
+ let domNode = this.domNode;
+ if (!domNode)
+ return;
+
+ this.contentView.element.scrollTop = this._initialScrollOffset;
+
+ for (let panel of this._panels) {
+ panel.element._savedScrollTop = undefined;
+ panel.markAsNeedsRefresh(domNode);
+ }
+
+ this._updatePseudoClassCheckboxes();
+
+ if (!this._classListContainer.hidden)
+ this._populateClassToggles();
+ }
+
</ins><span class="cx"> addEventListeners()
</span><span class="cx"> {
</span><span class="cx"> let effectiveDOMNode = this.domNode.isPseudoElement() ? this.domNode.parentNode : this.domNode;
</span><span class="lines">@@ -199,8 +199,8 @@
</span><span class="cx"> this._addClassInput.addEventListener("keypress", this._addClassInputKeyPressed.bind(this));
</span><span class="cx"> this._addClassInput.addEventListener("blur", this._addClassInputBlur.bind(this));
</span><span class="cx">
</span><del>- WebInspector.cssStyleManager.addEventListener(WebInspector.CSSStyleManager.Event.StyleSheetAdded, this.refresh, this);
- WebInspector.cssStyleManager.addEventListener(WebInspector.CSSStyleManager.Event.StyleSheetRemoved, this.refresh, this);
</del><ins>+ WebInspector.cssStyleManager.addEventListener(WebInspector.CSSStyleManager.Event.StyleSheetAdded, this._styleSheetAddedOrRemoved, this);
+ WebInspector.cssStyleManager.addEventListener(WebInspector.CSSStyleManager.Event.StyleSheetRemoved, this._styleSheetAddedOrRemoved, this);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> sizeDidChange()
</span><span class="lines">@@ -459,6 +459,11 @@
</span><span class="cx">
</span><span class="cx"> this._selectedPanel.filterDidChange(this._filterBar);
</span><span class="cx"> }
</span><ins>+
+ _styleSheetAddedOrRemoved()
+ {
+ this.needsLayout();
+ }
</ins><span class="cx"> };
</span><span class="cx">
</span><span class="cx"> WebInspector.CSSStyleDetailsSidebarPanel.NoForcedPseudoClassesScrollOffset = 30; // Default height of the forced pseudo classes container. Updated in sizeDidChange.
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsDOMDetailsSidebarPaneljs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DOMDetailsSidebarPanel.js (203252 => 203253)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/DOMDetailsSidebarPanel.js 2016-07-14 23:33:13 UTC (rev 203252)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DOMDetailsSidebarPanel.js 2016-07-14 23:37:37 UTC (rev 203253)
</span><span class="lines">@@ -78,7 +78,7 @@
</span><span class="cx"> if (this._domNode)
</span><span class="cx"> this.addEventListeners();
</span><span class="cx">
</span><del>- this.needsRefresh();
</del><ins>+ this.needsLayout();
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> supportsDOMNode(nodeToInspect)
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsDOMNodeDetailsSidebarPaneljs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DOMNodeDetailsSidebarPanel.js (203252 => 203253)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/DOMNodeDetailsSidebarPanel.js 2016-07-14 23:33:13 UTC (rev 203252)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DOMNodeDetailsSidebarPanel.js 2016-07-14 23:37:37 UTC (rev 203253)
</span><span class="lines">@@ -94,9 +94,9 @@
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><del>- // Public
</del><ins>+ // Protected
</ins><span class="cx">
</span><del>- refresh()
</del><ins>+ layout()
</ins><span class="cx"> {
</span><span class="cx"> var domNode = this.domNode;
</span><span class="cx"> if (!domNode)
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsDetailsSidebarPaneljs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DetailsSidebarPanel.js (203252 => 203253)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/DetailsSidebarPanel.js 2016-07-14 23:33:13 UTC (rev 203252)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DetailsSidebarPanel.js 2016-07-14 23:37:37 UTC (rev 203253)
</span><span class="lines">@@ -47,29 +47,4 @@
</span><span class="cx"> // Implemented by subclasses.
</span><span class="cx"> return false;
</span><span class="cx"> }
</span><del>-
- shown()
- {
- super.shown();
-
- if (this._needsRefresh) {
- this._needsRefresh = false;
- this.refresh();
- }
- }
-
- needsRefresh()
- {
- if (!this.selected) {
- this._needsRefresh = true;
- return;
- }
-
- this.refresh();
- }
-
- refresh()
- {
- // Implemented by subclasses.
- }
</del><span class="cx"> };
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsLayerTreeDetailsSidebarPaneljs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/LayerTreeDetailsSidebarPanel.js (203252 => 203253)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/LayerTreeDetailsSidebarPanel.js 2016-07-14 23:33:13 UTC (rev 203252)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/LayerTreeDetailsSidebarPanel.js 2016-07-14 23:37:37 UTC (rev 203253)
</span><span class="lines">@@ -50,8 +50,6 @@
</span><span class="cx">
</span><span class="cx"> console.assert(this.parentSidebar);
</span><span class="cx">
</span><del>- this.needsRefresh();
-
</del><span class="cx"> super.shown();
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -62,8 +60,17 @@
</span><span class="cx"> super.hidden();
</span><span class="cx"> }
</span><span class="cx">
</span><del>- refresh()
</del><ins>+ // DOMDetailsSidebarPanel Overrides
+
+ supportsDOMNode(nodeToInspect)
</ins><span class="cx"> {
</span><ins>+ return WebInspector.layerTreeManager.supported && nodeToInspect.nodeType() === Node.ELEMENT_NODE;
+ }
+
+ // Protected
+
+ layout()
+ {
</ins><span class="cx"> if (!this.domNode)
</span><span class="cx"> return;
</span><span class="cx">
</span><span class="lines">@@ -73,18 +80,11 @@
</span><span class="cx"> });
</span><span class="cx"> }
</span><span class="cx">
</span><del>- // DOMDetailsSidebarPanel Overrides
-
- supportsDOMNode(nodeToInspect)
- {
- return WebInspector.layerTreeManager.supported && nodeToInspect.nodeType() === Node.ELEMENT_NODE;
- }
-
</del><span class="cx"> // Private
</span><span class="cx">
</span><span class="cx"> _layerTreeDidChange(event)
</span><span class="cx"> {
</span><del>- this.needsRefresh();
</del><ins>+ this.needsLayout();
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> _showShadowDOMSettingChanged(event)
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsResourceDetailsSidebarPaneljs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ResourceDetailsSidebarPanel.js (203252 => 203253)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/ResourceDetailsSidebarPanel.js 2016-07-14 23:33:13 UTC (rev 203252)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ResourceDetailsSidebarPanel.js 2016-07-14 23:37:37 UTC (rev 203253)
</span><span class="lines">@@ -174,10 +174,12 @@
</span><span class="cx"> this._resource.addEventListener(WebInspector.Resource.Event.InitiatedResourcesDidChange, this._refreshRelatedResourcesSection, this);
</span><span class="cx"> }
</span><span class="cx">
</span><del>- this.needsRefresh();
</del><ins>+ this.needsLayout();
</ins><span class="cx"> }
</span><span class="cx">
</span><del>- refresh()
</del><ins>+ // Protected
+
+ layout()
</ins><span class="cx"> {
</span><span class="cx"> if (!this._resource)
</span><span class="cx"> return;
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsScopeChainDetailsSidebarPaneljs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ScopeChainDetailsSidebarPanel.js (203252 => 203253)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/ScopeChainDetailsSidebarPanel.js 2016-07-14 23:33:13 UTC (rev 203252)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ScopeChainDetailsSidebarPanel.js 2016-07-14 23:37:37 UTC (rev 203253)
</span><span class="lines">@@ -58,7 +58,7 @@
</span><span class="cx">
</span><span class="cx"> this._updateWatchExpressionsNavigationBar();
</span><span class="cx">
</span><del>- this.needsRefresh();
</del><ins>+ this.needsLayout();
</ins><span class="cx">
</span><span class="cx"> // Update on console prompt eval as objects in the scope chain may have changed.
</span><span class="cx"> WebInspector.runtimeManager.addEventListener(WebInspector.RuntimeManager.Event.DidEvaluate, this._didEvaluateExpression, this);
</span><span class="lines">@@ -102,10 +102,12 @@
</span><span class="cx">
</span><span class="cx"> this._callFrame = callFrame;
</span><span class="cx">
</span><del>- this.needsRefresh();
</del><ins>+ this.needsLayout();
</ins><span class="cx"> }
</span><span class="cx">
</span><del>- refresh()
</del><ins>+ // Protected
+
+ layout()
</ins><span class="cx"> {
</span><span class="cx"> let callFrame = this._callFrame;
</span><span class="cx">
</span><span class="lines">@@ -303,7 +305,7 @@
</span><span class="cx"> watchExpressions.push(expression);
</span><span class="cx"> this._watchExpressionsSetting.value = watchExpressions;
</span><span class="cx">
</span><del>- this.needsRefresh();
</del><ins>+ this.needsLayout();
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> _removeWatchExpression(expression)
</span><span class="lines">@@ -312,7 +314,7 @@
</span><span class="cx"> watchExpressions.remove(expression, true);
</span><span class="cx"> this._watchExpressionsSetting.value = watchExpressions;
</span><span class="cx">
</span><del>- this.needsRefresh();
</del><ins>+ this.needsLayout();
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> _clearAllWatchExpressions()
</span><span class="lines">@@ -319,7 +321,7 @@
</span><span class="cx"> {
</span><span class="cx"> this._watchExpressionsSetting.value = [];
</span><span class="cx">
</span><del>- this.needsRefresh();
</del><ins>+ this.needsLayout();
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> _addWatchExpressionButtonClicked(event)
</span><span class="lines">@@ -396,7 +398,7 @@
</span><span class="cx">
</span><span class="cx"> _refreshAllWatchExpressionsButtonClicked(event)
</span><span class="cx"> {
</span><del>- this.needsRefresh();
</del><ins>+ this.needsLayout();
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> _clearAllWatchExpressionsButtonClicked(event)
</span><span class="lines">@@ -409,7 +411,7 @@
</span><span class="cx"> if (event.data.objectGroup === WebInspector.ScopeChainDetailsSidebarPanel.WatchExpressionsObjectGroupName)
</span><span class="cx"> return;
</span><span class="cx">
</span><del>- this.needsRefresh();
</del><ins>+ this.needsLayout();
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> _mainResourceDidChange(event)
</span><span class="lines">@@ -417,7 +419,7 @@
</span><span class="cx"> if (!event.target.isMainFrame())
</span><span class="cx"> return;
</span><span class="cx">
</span><del>- this.needsRefresh();
</del><ins>+ this.needsLayout();
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> _objectTreeElementAddContextMenuItems(objectTreeElement, contextMenu)
</span></span></pre>
</div>
</div>
</body>
</html>