<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[203250] trunk/Source</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/203250">203250</a></dd>
<dt>Author</dt> <dd>cdumez@apple.com</dd>
<dt>Date</dt> <dd>2016-07-14 16:17:51 -0700 (Thu, 14 Jul 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Use emptyString() instead of "" when possible
https://bugs.webkit.org/show_bug.cgi?id=159789
Reviewed by Alex Christensen.
Use emptyString() instead of "" when possible to reduce String allocations.
Source/WebCore:
* Modules/webdatabase/Database.cpp:
(WebCore::Database::performOpenAndVerify):
* css/CSSSelector.h:
* css/StyleProperties.cpp:
(WebCore::MutableStyleProperties::removeProperty):
(WebCore::MutableStyleProperties::removeCustomProperty):
* editing/TextCheckingHelper.cpp:
(WebCore::TextCheckingHelper::findFirstMisspellingOrBadGrammar):
(WebCore::TextCheckingHelper::findFirstBadGrammar):
* editing/TypingCommand.h:
(WebCore::TypingCommand::create):
* fileapi/FileReaderLoader.cpp:
(WebCore::FileReaderLoader::cleanup):
* inspector/InspectorStyleSheet.cpp:
(WebCore::fillMediaListChain):
* page/UserContentURLPattern.cpp:
(WebCore::UserContentURLPattern::parse):
* platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::load):
* platform/gtk/DataObjectGtk.h:
(WebCore::DataObjectGtk::clearURIList):
* platform/network/curl/ResourceHandleCurl.cpp:
(WebCore::ResourceHandle::receivedRequestToContinueWithoutCredential):
* platform/network/curl/ResourceHandleManager.h:
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::layerTreeAsText):
* rendering/RenderListMarker.cpp:
(WebCore::RenderListMarker::updateContent):
* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::noneDashboardRegions):
* rendering/svg/SVGTextMetrics.cpp:
(WebCore::SVGTextMetrics::SVGTextMetrics):
* xml/XPathParser.cpp:
(WebCore::XPath::Parser::lexString):
Source/WebKit/cf:
* WebCoreSupport/WebInspectorClientCF.cpp:
(populateSetting):
Source/WebKit/win:
* Plugins/PluginView.cpp:
(WebCore::parseRFC822HeaderFields):
Source/WebKit2:
* UIProcess/Cocoa/WebViewImpl.mm:
(WebKit::WebViewImpl::pasteboardChangedOwner):
* WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
(WebKit::parseRFC822HeaderFields):
(WebKit::NPN_Status):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreModuleswebdatabaseDatabasecpp">trunk/Source/WebCore/Modules/webdatabase/Database.cpp</a></li>
<li><a href="#trunkSourceWebCorecssCSSSelectorh">trunk/Source/WebCore/css/CSSSelector.h</a></li>
<li><a href="#trunkSourceWebCorecssStylePropertiescpp">trunk/Source/WebCore/css/StyleProperties.cpp</a></li>
<li><a href="#trunkSourceWebCoreeditingTextCheckingHelpercpp">trunk/Source/WebCore/editing/TextCheckingHelper.cpp</a></li>
<li><a href="#trunkSourceWebCoreeditingTypingCommandh">trunk/Source/WebCore/editing/TypingCommand.h</a></li>
<li><a href="#trunkSourceWebCorefileapiFileReaderLoadercpp">trunk/Source/WebCore/fileapi/FileReaderLoader.cpp</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorStyleSheetcpp">trunk/Source/WebCore/inspector/InspectorStyleSheet.cpp</a></li>
<li><a href="#trunkSourceWebCorepageUserContentURLPatterncpp">trunk/Source/WebCore/page/UserContentURLPattern.cpp</a></li>
<li><a href="#trunkSourceWebCoreplatformgraphicsMediaPlayercpp">trunk/Source/WebCore/platform/graphics/MediaPlayer.cpp</a></li>
<li><a href="#trunkSourceWebCoreplatformgtkDataObjectGtkh">trunk/Source/WebCore/platform/gtk/DataObjectGtk.h</a></li>
<li><a href="#trunkSourceWebCoreplatformnetworkcurlResourceHandleCurlcpp">trunk/Source/WebCore/platform/network/curl/ResourceHandleCurl.cpp</a></li>
<li><a href="#trunkSourceWebCoreplatformnetworkcurlResourceHandleManagerh">trunk/Source/WebCore/platform/network/curl/ResourceHandleManager.h</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderLayerCompositorcpp">trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderListMarkercpp">trunk/Source/WebCore/rendering/RenderListMarker.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingstyleRenderStylecpp">trunk/Source/WebCore/rendering/style/RenderStyle.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingsvgSVGTextMetricscpp">trunk/Source/WebCore/rendering/svg/SVGTextMetrics.cpp</a></li>
<li><a href="#trunkSourceWebCorexmlXPathParsercpp">trunk/Source/WebCore/xml/XPathParser.cpp</a></li>
<li><a href="#trunkSourceWebKitcfChangeLog">trunk/Source/WebKit/cf/ChangeLog</a></li>
<li><a href="#trunkSourceWebKitcfWebCoreSupportWebInspectorClientCFcpp">trunk/Source/WebKit/cf/WebCoreSupport/WebInspectorClientCF.cpp</a></li>
<li><a href="#trunkSourceWebKitwinChangeLog">trunk/Source/WebKit/win/ChangeLog</a></li>
<li><a href="#trunkSourceWebKitwinPluginsPluginViewcpp">trunk/Source/WebKit/win/Plugins/PluginView.cpp</a></li>
<li><a href="#trunkSourceWebKit2ChangeLog">trunk/Source/WebKit2/ChangeLog</a></li>
<li><a href="#trunkSourceWebKit2UIProcessCocoaWebViewImplmm">trunk/Source/WebKit2/UIProcess/Cocoa/WebViewImpl.mm</a></li>
<li><a href="#trunkSourceWebKit2WebProcessPluginsNetscapeNetscapeBrowserFuncscpp">trunk/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (203249 => 203250)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-07-14 23:15:20 UTC (rev 203249)
+++ trunk/Source/WebCore/ChangeLog 2016-07-14 23:17:51 UTC (rev 203250)
</span><span class="lines">@@ -1,3 +1,47 @@
</span><ins>+2016-07-14 Chris Dumez <cdumez@apple.com>
+
+ Use emptyString() instead of "" when possible
+ https://bugs.webkit.org/show_bug.cgi?id=159789
+
+ Reviewed by Alex Christensen.
+
+ Use emptyString() instead of "" when possible to reduce String allocations.
+
+ * Modules/webdatabase/Database.cpp:
+ (WebCore::Database::performOpenAndVerify):
+ * css/CSSSelector.h:
+ * css/StyleProperties.cpp:
+ (WebCore::MutableStyleProperties::removeProperty):
+ (WebCore::MutableStyleProperties::removeCustomProperty):
+ * editing/TextCheckingHelper.cpp:
+ (WebCore::TextCheckingHelper::findFirstMisspellingOrBadGrammar):
+ (WebCore::TextCheckingHelper::findFirstBadGrammar):
+ * editing/TypingCommand.h:
+ (WebCore::TypingCommand::create):
+ * fileapi/FileReaderLoader.cpp:
+ (WebCore::FileReaderLoader::cleanup):
+ * inspector/InspectorStyleSheet.cpp:
+ (WebCore::fillMediaListChain):
+ * page/UserContentURLPattern.cpp:
+ (WebCore::UserContentURLPattern::parse):
+ * platform/graphics/MediaPlayer.cpp:
+ (WebCore::MediaPlayer::load):
+ * platform/gtk/DataObjectGtk.h:
+ (WebCore::DataObjectGtk::clearURIList):
+ * platform/network/curl/ResourceHandleCurl.cpp:
+ (WebCore::ResourceHandle::receivedRequestToContinueWithoutCredential):
+ * platform/network/curl/ResourceHandleManager.h:
+ * rendering/RenderLayerCompositor.cpp:
+ (WebCore::RenderLayerCompositor::layerTreeAsText):
+ * rendering/RenderListMarker.cpp:
+ (WebCore::RenderListMarker::updateContent):
+ * rendering/style/RenderStyle.cpp:
+ (WebCore::RenderStyle::noneDashboardRegions):
+ * rendering/svg/SVGTextMetrics.cpp:
+ (WebCore::SVGTextMetrics::SVGTextMetrics):
+ * xml/XPathParser.cpp:
+ (WebCore::XPath::Parser::lexString):
+
</ins><span class="cx"> 2016-07-14 Brent Fulgham <bfulgham@apple.com>
</span><span class="cx">
</span><span class="cx"> editing/spelling/spellcheck-async.html sometimes crashes with GuardMalloc
</span></span></pre></div>
<a id="trunkSourceWebCoreModuleswebdatabaseDatabasecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/webdatabase/Database.cpp (203249 => 203250)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/webdatabase/Database.cpp 2016-07-14 23:15:20 UTC (rev 203249)
+++ trunk/Source/WebCore/Modules/webdatabase/Database.cpp 2016-07-14 23:17:51 UTC (rev 203250)
</span><span class="lines">@@ -440,7 +440,7 @@
</span><span class="cx">
</span><span class="cx"> if (currentVersion.isNull()) {
</span><span class="cx"> LOG(StorageAPI, "Database %s does not have its version set", databaseDebugName().ascii().data());
</span><del>- currentVersion = "";
</del><ins>+ currentVersion = emptyString();
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> // If the expected version isn't the empty string, ensure that the current database version we have matches that version. Otherwise, set an exception.
</span><span class="lines">@@ -463,7 +463,7 @@
</span><span class="cx"> onExitCaller.setOpenSucceeded();
</span><span class="cx">
</span><span class="cx"> if (m_new && !shouldSetVersionInNewDatabase)
</span><del>- m_expectedVersion = ""; // The caller provided a creationCallback which will set the expected version.
</del><ins>+ m_expectedVersion = emptyString(); // The caller provided a creationCallback which will set the expected version.
</ins><span class="cx">
</span><span class="cx"> if (databaseContext()->databaseThread())
</span><span class="cx"> databaseContext()->databaseThread()->recordDatabaseOpen(this);
</span></span></pre></div>
<a id="trunkSourceWebCorecssCSSSelectorh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/CSSSelector.h (203249 => 203250)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/CSSSelector.h 2016-07-14 23:15:20 UTC (rev 203249)
+++ trunk/Source/WebCore/css/CSSSelector.h 2016-07-14 23:17:51 UTC (rev 203250)
</span><span class="lines">@@ -48,7 +48,7 @@
</span><span class="cx"> /**
</span><span class="cx"> * Re-create selector text from selector's data
</span><span class="cx"> */
</span><del>- String selectorText(const String& = "") const;
</del><ins>+ String selectorText(const String& = emptyString()) const;
</ins><span class="cx">
</span><span class="cx"> // checks if the 2 selectors (including sub selectors) agree.
</span><span class="cx"> bool operator==(const CSSSelector&) const;
</span></span></pre></div>
<a id="trunkSourceWebCorecssStylePropertiescpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/StyleProperties.cpp (203249 => 203250)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/StyleProperties.cpp 2016-07-14 23:15:20 UTC (rev 203249)
+++ trunk/Source/WebCore/css/StyleProperties.cpp 2016-07-14 23:17:51 UTC (rev 203250)
</span><span class="lines">@@ -656,7 +656,7 @@
</span><span class="cx"> if (removeShorthandProperty(propertyID)) {
</span><span class="cx"> // FIXME: Return an equivalent shorthand when possible.
</span><span class="cx"> if (returnText)
</span><del>- *returnText = "";
</del><ins>+ *returnText = emptyString();
</ins><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -663,7 +663,7 @@
</span><span class="cx"> int foundPropertyIndex = findPropertyIndex(propertyID);
</span><span class="cx"> if (foundPropertyIndex == -1) {
</span><span class="cx"> if (returnText)
</span><del>- *returnText = "";
</del><ins>+ *returnText = emptyString();
</ins><span class="cx"> return false;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -682,7 +682,7 @@
</span><span class="cx"> int foundPropertyIndex = findCustomPropertyIndex(propertyName);
</span><span class="cx"> if (foundPropertyIndex == -1) {
</span><span class="cx"> if (returnText)
</span><del>- *returnText = "";
</del><ins>+ *returnText = emptyString();
</ins><span class="cx"> return false;
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreeditingTextCheckingHelpercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/editing/TextCheckingHelper.cpp (203249 => 203250)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/editing/TextCheckingHelper.cpp 2016-07-14 23:15:20 UTC (rev 203249)
+++ trunk/Source/WebCore/editing/TextCheckingHelper.cpp 2016-07-14 23:17:51 UTC (rev 203250)
</span><span class="lines">@@ -313,7 +313,7 @@
</span><span class="cx"> outGrammarDetail.location = -1;
</span><span class="cx"> outGrammarDetail.length = 0;
</span><span class="cx"> outGrammarDetail.guesses.clear();
</span><del>- outGrammarDetail.userDescription = "";
</del><ins>+ outGrammarDetail.userDescription = emptyString();
</ins><span class="cx">
</span><span class="cx"> // Expand the search range to encompass entire paragraphs, since text checking needs that much context.
</span><span class="cx"> // Determine the character offset from the start of the paragraph to the start of the original search range,
</span><span class="lines">@@ -471,7 +471,7 @@
</span><span class="cx"> outGrammarDetail.location = -1;
</span><span class="cx"> outGrammarDetail.length = 0;
</span><span class="cx"> outGrammarDetail.guesses.clear();
</span><del>- outGrammarDetail.userDescription = "";
</del><ins>+ outGrammarDetail.userDescription = emptyString();
</ins><span class="cx"> outGrammarPhraseOffset = 0;
</span><span class="cx">
</span><span class="cx"> String firstBadGrammarPhrase;
</span></span></pre></div>
<a id="trunkSourceWebCoreeditingTypingCommandh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/editing/TypingCommand.h (203249 => 203250)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/editing/TypingCommand.h 2016-07-14 23:15:20 UTC (rev 203249)
+++ trunk/Source/WebCore/editing/TypingCommand.h 2016-07-14 23:17:51 UTC (rev 203250)
</span><span class="lines">@@ -85,7 +85,7 @@
</span><span class="cx"> #endif
</span><span class="cx">
</span><span class="cx"> private:
</span><del>- static Ref<TypingCommand> create(Document& document, ETypingCommand command, const String& text = "", Options options = 0, TextGranularity granularity = CharacterGranularity)
</del><ins>+ static Ref<TypingCommand> create(Document& document, ETypingCommand command, const String& text = emptyString(), Options options = 0, TextGranularity granularity = CharacterGranularity)
</ins><span class="cx"> {
</span><span class="cx"> return adoptRef(*new TypingCommand(document, command, text, options, granularity, TextCompositionNone));
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCorefileapiFileReaderLoadercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/fileapi/FileReaderLoader.cpp (203249 => 203250)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/fileapi/FileReaderLoader.cpp 2016-07-14 23:15:20 UTC (rev 203249)
+++ trunk/Source/WebCore/fileapi/FileReaderLoader.cpp 2016-07-14 23:17:51 UTC (rev 203250)
</span><span class="lines">@@ -121,7 +121,7 @@
</span><span class="cx"> // If we get any error, we do not need to keep a buffer around.
</span><span class="cx"> if (m_errorCode) {
</span><span class="cx"> m_rawData = nullptr;
</span><del>- m_stringResult = "";
</del><ins>+ m_stringResult = emptyString();
</ins><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorStyleSheetcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorStyleSheet.cpp (203249 => 203250)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorStyleSheet.cpp 2016-07-14 23:15:20 UTC (rev 203249)
+++ trunk/Source/WebCore/inspector/InspectorStyleSheet.cpp 2016-07-14 23:17:51 UTC (rev 203250)
</span><span class="lines">@@ -246,7 +246,7 @@
</span><span class="cx"> if (sourceURL.isEmpty())
</span><span class="cx"> sourceURL = InspectorDOMAgent::documentURLString(parentStyleSheet->ownerDocument());
</span><span class="cx"> } else
</span><del>- sourceURL = "";
</del><ins>+ sourceURL = emptyString();
</ins><span class="cx">
</span><span class="cx"> if (mediaList && mediaList->length())
</span><span class="cx"> mediaArray.addItem(buildMediaObject(mediaList, isMediaRule ? MediaListSourceMediaRule : MediaListSourceImportRule, sourceURL));
</span><span class="lines">@@ -264,7 +264,7 @@
</span><span class="cx"> else if (!styleSheet->contents().baseURL().isEmpty())
</span><span class="cx"> sourceURL = styleSheet->contents().baseURL();
</span><span class="cx"> else
</span><del>- sourceURL = "";
</del><ins>+ sourceURL = emptyString();
</ins><span class="cx"> mediaArray.addItem(buildMediaObject(mediaList, styleSheet->ownerNode() ? MediaListSourceLinkedSheet : MediaListSourceInlineSheet, sourceURL));
</span><span class="cx"> }
</span><span class="cx"> parentRule = styleSheet->ownerRule();
</span></span></pre></div>
<a id="trunkSourceWebCorepageUserContentURLPatterncpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/UserContentURLPattern.cpp (203249 => 203250)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/UserContentURLPattern.cpp 2016-07-14 23:15:20 UTC (rev 203249)
+++ trunk/Source/WebCore/page/UserContentURLPattern.cpp 2016-07-14 23:17:51 UTC (rev 203250)
</span><span class="lines">@@ -89,7 +89,7 @@
</span><span class="cx">
</span><span class="cx"> if (m_host == "*") {
</span><span class="cx"> // The pattern can be just '*', which means match all domains.
</span><del>- m_host = "";
</del><ins>+ m_host = emptyString();
</ins><span class="cx"> m_matchSubdomains = true;
</span><span class="cx"> } else if (m_host.startsWith("*.")) {
</span><span class="cx"> // The first component can be '*', which means to match all subdomains.
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformgraphicsMediaPlayercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/graphics/MediaPlayer.cpp (203249 => 203250)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/graphics/MediaPlayer.cpp 2016-07-14 23:15:20 UTC (rev 203249)
+++ trunk/Source/WebCore/platform/graphics/MediaPlayer.cpp 2016-07-14 23:17:51 UTC (rev 203250)
</span><span class="lines">@@ -396,7 +396,7 @@
</span><span class="cx"> m_contentMIMEType = contentType.type().convertToASCIILowercase();
</span><span class="cx"> m_contentTypeCodecs = contentType.parameter(codecs());
</span><span class="cx"> m_url = url;
</span><del>- m_keySystem = "";
</del><ins>+ m_keySystem = emptyString();
</ins><span class="cx"> m_contentMIMETypeWasInferredFromExtension = false;
</span><span class="cx"> loadWithNextMediaEngine(0);
</span><span class="cx"> return m_currentMediaEngine;
</span><span class="lines">@@ -410,8 +410,8 @@
</span><span class="cx"> ASSERT(mediaStream);
</span><span class="cx">
</span><span class="cx"> m_mediaStream = mediaStream;
</span><del>- m_keySystem = "";
- m_contentMIMEType = "";
</del><ins>+ m_keySystem = emptyString();
+ m_contentMIMEType = emptyString();
</ins><span class="cx"> m_contentMIMETypeWasInferredFromExtension = false;
</span><span class="cx"> loadWithNextMediaEngine(0);
</span><span class="cx"> return m_currentMediaEngine;
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformgtkDataObjectGtkh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/gtk/DataObjectGtk.h (203249 => 203250)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/gtk/DataObjectGtk.h 2016-07-14 23:15:20 UTC (rev 203249)
+++ trunk/Source/WebCore/platform/gtk/DataObjectGtk.h 2016-07-14 23:17:51 UTC (rev 203250)
</span><span class="lines">@@ -47,7 +47,7 @@
</span><span class="cx"> bool hasURL() const { return !m_url.isEmpty() && m_url.isValid(); }
</span><span class="cx"> bool hasFilenames() const { return !m_filenames.isEmpty(); }
</span><span class="cx"> bool hasImage() const { return m_image; }
</span><del>- void clearURIList() { m_uriList = ""; }
</del><ins>+ void clearURIList() { m_uriList = emptyString(); }
</ins><span class="cx"> void clearURL() { m_url = URL(); }
</span><span class="cx"> void clearImage() { m_image = nullptr; }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformnetworkcurlResourceHandleCurlcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/network/curl/ResourceHandleCurl.cpp (203249 => 203250)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/network/curl/ResourceHandleCurl.cpp 2016-07-14 23:15:20 UTC (rev 203249)
+++ trunk/Source/WebCore/platform/network/curl/ResourceHandleCurl.cpp 2016-07-14 23:17:51 UTC (rev 203250)
</span><span class="lines">@@ -249,7 +249,7 @@
</span><span class="cx"> if (challenge != d->m_currentWebChallenge)
</span><span class="cx"> return;
</span><span class="cx">
</span><del>- String userpass = "";
</del><ins>+ String userpass = emptyString();
</ins><span class="cx"> curl_easy_setopt(d->m_handle, CURLOPT_USERPWD, userpass.utf8().data());
</span><span class="cx">
</span><span class="cx"> clearAuthentication();
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformnetworkcurlResourceHandleManagerh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/network/curl/ResourceHandleManager.h (203249 => 203250)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/network/curl/ResourceHandleManager.h 2016-07-14 23:15:20 UTC (rev 203249)
+++ trunk/Source/WebCore/platform/network/curl/ResourceHandleManager.h 2016-07-14 23:17:51 UTC (rev 203250)
</span><span class="lines">@@ -67,11 +67,7 @@
</span><span class="cx"> void setupPOST(ResourceHandle*, struct curl_slist**);
</span><span class="cx"> void setupPUT(ResourceHandle*, struct curl_slist**);
</span><span class="cx">
</span><del>- void setProxyInfo(const String& host = "",
- unsigned long port = 0,
- ProxyType type = HTTP,
- const String& username = "",
- const String& password = "");
</del><ins>+ void setProxyInfo(const String& host = emptyString(), unsigned long port = 0, ProxyType = HTTP, const String& username = emptyString(), const String& password = emptyString());
</ins><span class="cx">
</span><span class="cx"> private:
</span><span class="cx"> ResourceHandleManager();
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderLayerCompositorcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp (203249 => 203250)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp 2016-07-14 23:15:20 UTC (rev 203249)
+++ trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp 2016-07-14 23:17:51 UTC (rev 203250)
</span><span class="lines">@@ -1847,7 +1847,7 @@
</span><span class="cx"> // Dump an empty layer tree only if the only composited layer is the main frame's tiled backing,
</span><span class="cx"> // so that tests expecting us to drop out of accelerated compositing when there are no layers succeed.
</span><span class="cx"> if (!hasAnyAdditionalCompositedLayers(rootRenderLayer()) && documentUsesTiledBacking() && !(layerTreeBehavior & LayerTreeAsTextIncludeTileCaches))
</span><del>- layerTreeText = "";
</del><ins>+ layerTreeText = emptyString();
</ins><span class="cx">
</span><span class="cx"> // The true root layer is not included in the dump, so if we want to report
</span><span class="cx"> // its repaint rects, they must be included here.
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderListMarkercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderListMarker.cpp (203249 => 203250)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderListMarker.cpp 2016-07-14 23:15:20 UTC (rev 203249)
+++ trunk/Source/WebCore/rendering/RenderListMarker.cpp 2016-07-14 23:17:51 UTC (rev 203250)
</span><span class="lines">@@ -1418,7 +1418,7 @@
</span><span class="cx"> if (!preferredLogicalWidthsDirty())
</span><span class="cx"> return;
</span><span class="cx">
</span><del>- m_text = "";
</del><ins>+ m_text = emptyString();
</ins><span class="cx">
</span><span class="cx"> if (isImage()) {
</span><span class="cx"> // FIXME: This is a somewhat arbitrary width. Generated images for markers really won't become particularly useful
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingstyleRenderStylecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/style/RenderStyle.cpp (203249 => 203250)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/style/RenderStyle.cpp 2016-07-14 23:15:20 UTC (rev 203249)
+++ trunk/Source/WebCore/rendering/style/RenderStyle.cpp 2016-07-14 23:17:51 UTC (rev 203250)
</span><span class="lines">@@ -1343,7 +1343,7 @@
</span><span class="cx">
</span><span class="cx"> if (!noneListInitialized) {
</span><span class="cx"> StyleDashboardRegion region;
</span><del>- region.label = "";
</del><ins>+ region.label = emptyString();
</ins><span class="cx"> region.offset.top() = Length();
</span><span class="cx"> region.offset.right() = Length();
</span><span class="cx"> region.offset.bottom() = Length();
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingsvgSVGTextMetricscpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/svg/SVGTextMetrics.cpp (203249 => 203250)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/svg/SVGTextMetrics.cpp 2016-07-14 23:15:20 UTC (rev 203249)
+++ trunk/Source/WebCore/rendering/svg/SVGTextMetrics.cpp 2016-07-14 23:17:51 UTC (rev 203250)
</span><span class="lines">@@ -50,7 +50,7 @@
</span><span class="cx"> // Calculate width/height using the scaled font, divide this result by the scalingFactor afterwards.
</span><span class="cx"> m_width = scaledFont.width(run) / scalingFactor;
</span><span class="cx"> length = run.length();
</span><del>- m_glyph.name = "";
</del><ins>+ m_glyph.name = emptyString();
</ins><span class="cx"> m_height = scaledFont.fontMetrics().floatHeight() / scalingFactor;
</span><span class="cx">
</span><span class="cx"> m_glyph.unicodeString = run.is8Bit() ? String(run.characters8(), length) : String(run.characters16(), length);
</span></span></pre></div>
<a id="trunkSourceWebCorexmlXPathParsercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/xml/XPathParser.cpp (203249 => 203250)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/xml/XPathParser.cpp 2016-07-14 23:15:20 UTC (rev 203249)
+++ trunk/Source/WebCore/xml/XPathParser.cpp 2016-07-14 23:17:51 UTC (rev 203250)
</span><span class="lines">@@ -188,7 +188,7 @@
</span><span class="cx"> if (m_data[m_nextPos] == delimiter) {
</span><span class="cx"> String value = m_data.substring(startPos, m_nextPos - startPos);
</span><span class="cx"> if (value.isNull())
</span><del>- value = "";
</del><ins>+ value = emptyString();
</ins><span class="cx"> ++m_nextPos; // Consume the char.
</span><span class="cx"> return Token(LITERAL, value);
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebKitcfChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/cf/ChangeLog (203249 => 203250)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/cf/ChangeLog 2016-07-14 23:15:20 UTC (rev 203249)
+++ trunk/Source/WebKit/cf/ChangeLog 2016-07-14 23:17:51 UTC (rev 203250)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2016-07-14 Chris Dumez <cdumez@apple.com>
+
+ Use emptyString() instead of "" when possible
+ https://bugs.webkit.org/show_bug.cgi?id=159789
+
+ Reviewed by Alex Christensen.
+
+ Use emptyString() instead of "" when possible to reduce String allocations.
+
+ * WebCoreSupport/WebInspectorClientCF.cpp:
+ (populateSetting):
+
</ins><span class="cx"> 2015-05-01 Martin Robinson <mrobinson@igalia.com>
</span><span class="cx">
</span><span class="cx"> USE(...) macro should expect unprefixed variables
</span></span></pre></div>
<a id="trunkSourceWebKitcfWebCoreSupportWebInspectorClientCFcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/cf/WebCoreSupport/WebInspectorClientCF.cpp (203249 => 203250)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/cf/WebCoreSupport/WebInspectorClientCF.cpp 2016-07-14 23:15:20 UTC (rev 203249)
+++ trunk/Source/WebKit/cf/WebCoreSupport/WebInspectorClientCF.cpp 2016-07-14 23:17:51 UTC (rev 203250)
</span><span class="lines">@@ -82,7 +82,7 @@
</span><span class="cx"> else if (type == CFBooleanGetTypeID())
</span><span class="cx"> *setting = static_cast<bool>(CFBooleanGetValue(static_cast<CFBooleanRef>(value.get()))) ? "true" : "false";
</span><span class="cx"> else
</span><del>- *setting = "";
</del><ins>+ *setting = emptyString();
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> static void storeSetting(const String& key, const String& setting)
</span></span></pre></div>
<a id="trunkSourceWebKitwinChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/win/ChangeLog (203249 => 203250)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/win/ChangeLog 2016-07-14 23:15:20 UTC (rev 203249)
+++ trunk/Source/WebKit/win/ChangeLog 2016-07-14 23:17:51 UTC (rev 203250)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2016-07-14 Chris Dumez <cdumez@apple.com>
+
+ Use emptyString() instead of "" when possible
+ https://bugs.webkit.org/show_bug.cgi?id=159789
+
+ Reviewed by Alex Christensen.
+
+ Use emptyString() instead of "" when possible to reduce String allocations.
+
+ * Plugins/PluginView.cpp:
+ (WebCore::parseRFC822HeaderFields):
+
</ins><span class="cx"> 2016-07-14 Alex Christensen <achristensen@webkit.org>
</span><span class="cx">
</span><span class="cx"> Use SocketProvider to create SocketStreamHandles
</span></span></pre></div>
<a id="trunkSourceWebKitwinPluginsPluginViewcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/win/Plugins/PluginView.cpp (203249 => 203250)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/win/Plugins/PluginView.cpp 2016-07-14 23:15:20 UTC (rev 203249)
+++ trunk/Source/WebKit/win/Plugins/PluginView.cpp 2016-07-14 23:17:51 UTC (rev 203250)
</span><span class="lines">@@ -1020,7 +1020,7 @@
</span><span class="cx"> break;
</span><span class="cx"> }
</span><span class="cx"> if (colon == eol)
</span><del>- value = "";
</del><ins>+ value = emptyString();
</ins><span class="cx"> else
</span><span class="cx"> value = String(colon, eol - colon);
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebKit2ChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/ChangeLog (203249 => 203250)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/ChangeLog 2016-07-14 23:15:20 UTC (rev 203249)
+++ trunk/Source/WebKit2/ChangeLog 2016-07-14 23:17:51 UTC (rev 203250)
</span><span class="lines">@@ -1,3 +1,18 @@
</span><ins>+2016-07-14 Chris Dumez <cdumez@apple.com>
+
+ Use emptyString() instead of "" when possible
+ https://bugs.webkit.org/show_bug.cgi?id=159789
+
+ Reviewed by Alex Christensen.
+
+ Use emptyString() instead of "" when possible to reduce String allocations.
+
+ * UIProcess/Cocoa/WebViewImpl.mm:
+ (WebKit::WebViewImpl::pasteboardChangedOwner):
+ * WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
+ (WebKit::parseRFC822HeaderFields):
+ (WebKit::NPN_Status):
+
</ins><span class="cx"> 2016-07-14 Alex Christensen <achristensen@webkit.org>
</span><span class="cx">
</span><span class="cx"> Use more Refs with WorkQueues
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessCocoaWebViewImplmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/Cocoa/WebViewImpl.mm (203249 => 203250)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/Cocoa/WebViewImpl.mm 2016-07-14 23:15:20 UTC (rev 203249)
+++ trunk/Source/WebKit2/UIProcess/Cocoa/WebViewImpl.mm 2016-07-14 23:17:51 UTC (rev 203250)
</span><span class="lines">@@ -3004,8 +3004,8 @@
</span><span class="cx"> void WebViewImpl::pasteboardChangedOwner(NSPasteboard *pasteboard)
</span><span class="cx"> {
</span><span class="cx"> m_promisedImage = nullptr;
</span><del>- m_promisedFilename = "";
- m_promisedURL = "";
</del><ins>+ m_promisedFilename = emptyString();
+ m_promisedURL = emptyString();
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void WebViewImpl::provideDataForPasteboard(NSPasteboard *pasteboard, NSString *type)
</span></span></pre></div>
<a id="trunkSourceWebKit2WebProcessPluginsNetscapeNetscapeBrowserFuncscpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp (203249 => 203250)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp 2016-07-14 23:15:20 UTC (rev 203249)
+++ trunk/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp 2016-07-14 23:17:51 UTC (rev 203250)
</span><span class="lines">@@ -205,7 +205,7 @@
</span><span class="cx"> break;
</span><span class="cx"> }
</span><span class="cx"> if (colon == endOfLine)
</span><del>- value = "";
</del><ins>+ value = emptyString();
</ins><span class="cx"> else
</span><span class="cx"> value = String(colon, endOfLine - colon);
</span><span class="cx">
</span><span class="lines">@@ -340,7 +340,7 @@
</span><span class="cx"> {
</span><span class="cx"> String statusbarText;
</span><span class="cx"> if (!message)
</span><del>- statusbarText = "";
</del><ins>+ statusbarText = emptyString();
</ins><span class="cx"> else
</span><span class="cx"> statusbarText = String::fromUTF8WithLatin1Fallback(message, strlen(message));
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>