<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[203236] trunk/Source/WTF</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/203236">203236</a></dd>
<dt>Author</dt> <dd>cdumez@apple.com</dd>
<dt>Date</dt> <dd>2016-07-14 12:45:22 -0700 (Thu, 14 Jul 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Avoid an extra heap allocation when dispatching Functions to WorkQueue
https://bugs.webkit.org/show_bug.cgi?id=158367
Reviewed by Anders Carlsson.
Avoid an extra heap allocation when dispatching Functions to WorkQueue
by adding leakCallable() / adoptCallable() functions to Function.
* wtf/Function.h:
* wtf/cocoa/WorkQueueCocoa.cpp:
(WTF::WorkQueue::dispatch):
(WTF::WorkQueue::dispatchAfter):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWTFChangeLog">trunk/Source/WTF/ChangeLog</a></li>
<li><a href="#trunkSourceWTFwtfFunctionh">trunk/Source/WTF/wtf/Function.h</a></li>
<li><a href="#trunkSourceWTFwtfcocoaWorkQueueCocoacpp">trunk/Source/WTF/wtf/cocoa/WorkQueueCocoa.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWTFChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WTF/ChangeLog (203235 => 203236)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WTF/ChangeLog 2016-07-14 19:32:24 UTC (rev 203235)
+++ trunk/Source/WTF/ChangeLog 2016-07-14 19:45:22 UTC (rev 203236)
</span><span class="lines">@@ -1,3 +1,18 @@
</span><ins>+2016-07-14 Chris Dumez <cdumez@apple.com>
+
+ Avoid an extra heap allocation when dispatching Functions to WorkQueue
+ https://bugs.webkit.org/show_bug.cgi?id=158367
+
+ Reviewed by Anders Carlsson.
+
+ Avoid an extra heap allocation when dispatching Functions to WorkQueue
+ by adding leakCallable() / adoptCallable() functions to Function.
+
+ * wtf/Function.h:
+ * wtf/cocoa/WorkQueueCocoa.cpp:
+ (WTF::WorkQueue::dispatch):
+ (WTF::WorkQueue::dispatchAfter):
+
</ins><span class="cx"> 2016-07-13 Myles C. Maxfield <mmaxfield@apple.com>
</span><span class="cx">
</span><span class="cx"> Addressing post-review comments after r203119
</span></span></pre></div>
<a id="trunkSourceWTFwtfFunctionh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WTF/wtf/Function.h (203235 => 203236)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WTF/wtf/Function.h 2016-07-14 19:32:24 UTC (rev 203235)
+++ trunk/Source/WTF/wtf/Function.h 2016-07-14 19:45:22 UTC (rev 203236)
</span><span class="lines">@@ -66,7 +66,6 @@
</span><span class="cx"> return *this;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-private:
</del><span class="cx"> class CallableWrapperBase {
</span><span class="cx"> WTF_MAKE_FAST_ALLOCATED;
</span><span class="cx"> public:
</span><span class="lines">@@ -75,6 +74,19 @@
</span><span class="cx"> virtual Out call(In...) = 0;
</span><span class="cx"> };
</span><span class="cx">
</span><ins>+ CallableWrapperBase* leakCallable() WARN_UNUSED_RETURN
+ {
+ return m_callableWrapper.release();
+ }
+
+ static Function adoptCallable(CallableWrapperBase* callable)
+ {
+ Function function;
+ function.m_callableWrapper.reset(callable);
+ return function;
+ }
+
+private:
</ins><span class="cx"> template<typename CallableType>
</span><span class="cx"> class CallableWrapper : public CallableWrapperBase {
</span><span class="cx"> public:
</span></span></pre></div>
<a id="trunkSourceWTFwtfcocoaWorkQueueCocoacpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WTF/wtf/cocoa/WorkQueueCocoa.cpp (203235 => 203236)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WTF/wtf/cocoa/WorkQueueCocoa.cpp 2016-07-14 19:32:24 UTC (rev 203235)
+++ trunk/Source/WTF/wtf/cocoa/WorkQueueCocoa.cpp 2016-07-14 19:45:22 UTC (rev 203236)
</span><span class="lines">@@ -31,10 +31,10 @@
</span><span class="cx"> void WorkQueue::dispatch(Function<void ()>&& function)
</span><span class="cx"> {
</span><span class="cx"> ref();
</span><del>- auto* functionPtr = new Function<void ()>(WTFMove(function));
</del><ins>+ auto* callable = function.leakCallable();
</ins><span class="cx"> dispatch_async(m_dispatchQueue, ^{
</span><del>- (*functionPtr)();
- delete functionPtr;
</del><ins>+ auto function = Function<void ()>::adoptCallable(callable);
+ function();
</ins><span class="cx"> deref();
</span><span class="cx"> });
</span><span class="cx"> }
</span><span class="lines">@@ -42,10 +42,10 @@
</span><span class="cx"> void WorkQueue::dispatchAfter(std::chrono::nanoseconds duration, Function<void ()>&& function)
</span><span class="cx"> {
</span><span class="cx"> ref();
</span><del>- auto* functionPtr = new Function<void ()>(WTFMove(function));
</del><ins>+ auto* callable = function.leakCallable();
</ins><span class="cx"> dispatch_after(dispatch_time(DISPATCH_TIME_NOW, duration.count()), m_dispatchQueue, ^{
</span><del>- (*functionPtr)();
- delete functionPtr;
</del><ins>+ auto function = Function<void ()>::adoptCallable(callable);
+ function();
</ins><span class="cx"> deref();
</span><span class="cx"> });
</span><span class="cx"> }
</span></span></pre>
</div>
</div>
</body>
</html>