<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[203267] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/203267">203267</a></dd>
<dt>Author</dt> <dd>tonikitoo@webkit.org</dd>
<dt>Date</dt> <dd>2016-07-14 20:56:51 -0700 (Thu, 14 Jul 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>[RTL Scrollbars] Frame scrollbars don't move to the right when text direction changes to RTL
https://bugs.webkit.org/show_bug.cgi?id=158252
Patch by Antonio Gomes <tonikitoo@igalia.com> on 2016-07-14
Reviewed by Myles C. Maxfield.
Source/WebCore:
When the 'dir' attribute changes either on body or on the document
element level, the associated FrameView does not trigger an update on
the frame level vertical scrollbar.
Patch adds a 'hook' so that RenderBox::styleDidChange can call in
order to get the document level scrollbar placed properly in the next
layout.
Test: fast/scrolling/rtl-scrollbars-alternate-body-dir-attr-does-not-update-scrollbar-placement.html
fast/scrolling/rtl-scrollbars-alternate-body-dir-attr-does-not-update-scrollbar-placement-2.html
fast/scrolling/rtl-scrollbars-alternate-iframe-body-dir-attr-does-not-update-scrollbar-placement.html
* page/FrameView.cpp:
(WebCore::FrameView::topContentDirectionDidChange):
* page/FrameView.h:
* rendering/RenderBox.cpp:
(WebCore::RenderBox::styleDidChange):
LayoutTests:
* fast/scrolling/rtl-scrollbars-alternate-body-dir-attr-does-not-update-scrollbar-placement.html: Added.
* fast/scrolling/rtl-scrollbars-alternate-body-dir-attr-does-not-update-scrollbar-placement-expected.txt: Added.
* fast/scrolling/rtl-scrollbars-alternate-body-dir-attr-does-not-update-scrollbar-placement-2.html: Added.
* fast/scrolling/rtl-scrollbars-alternate-body-dir-attr-does-not-update-scrollbar-placement-2-expected.html: Added.
* fast/scrolling/rtl-scrollbars-alternate-iframe-body-dir-attr-does-not-update-scrollbar-placement.html: Added.
* fast/scrolling/rtl-scrollbars-alternate-iframe-body-dir-attr-does-not-update-scrollbar-placement-expected.txt: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsTestExpectations">trunk/LayoutTests/TestExpectations</a></li>
<li><a href="#trunkLayoutTestsplatformgtkTestExpectations">trunk/LayoutTests/platform/gtk/TestExpectations</a></li>
<li><a href="#trunkLayoutTestsplatformmacwk2TestExpectations">trunk/LayoutTests/platform/mac-wk2/TestExpectations</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorepageFrameViewcpp">trunk/Source/WebCore/page/FrameView.cpp</a></li>
<li><a href="#trunkSourceWebCorepageFrameViewh">trunk/Source/WebCore/page/FrameView.h</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderBoxcpp">trunk/Source/WebCore/rendering/RenderBox.cpp</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsfastscrollingrtlscrollbarsalternatebodydirattrdoesnotupdatescrollbarplacement2expectedhtml">trunk/LayoutTests/fast/scrolling/rtl-scrollbars-alternate-body-dir-attr-does-not-update-scrollbar-placement-2-expected.html</a></li>
<li><a href="#trunkLayoutTestsfastscrollingrtlscrollbarsalternatebodydirattrdoesnotupdatescrollbarplacement2html">trunk/LayoutTests/fast/scrolling/rtl-scrollbars-alternate-body-dir-attr-does-not-update-scrollbar-placement-2.html</a></li>
<li><a href="#trunkLayoutTestsfastscrollingrtlscrollbarsalternatebodydirattrdoesnotupdatescrollbarplacementexpectedtxt">trunk/LayoutTests/fast/scrolling/rtl-scrollbars-alternate-body-dir-attr-does-not-update-scrollbar-placement-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastscrollingrtlscrollbarsalternatebodydirattrdoesnotupdatescrollbarplacementhtml">trunk/LayoutTests/fast/scrolling/rtl-scrollbars-alternate-body-dir-attr-does-not-update-scrollbar-placement.html</a></li>
<li><a href="#trunkLayoutTestsfastscrollingrtlscrollbarsalternateiframebodydirattrdoesnotupdatescrollbarplacementexpectedhtml">trunk/LayoutTests/fast/scrolling/rtl-scrollbars-alternate-iframe-body-dir-attr-does-not-update-scrollbar-placement-expected.html</a></li>
<li><a href="#trunkLayoutTestsfastscrollingrtlscrollbarsalternateiframebodydirattrdoesnotupdatescrollbarplacementhtml">trunk/LayoutTests/fast/scrolling/rtl-scrollbars-alternate-iframe-body-dir-attr-does-not-update-scrollbar-placement.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (203266 => 203267)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2016-07-15 03:11:15 UTC (rev 203266)
+++ trunk/LayoutTests/ChangeLog 2016-07-15 03:56:51 UTC (rev 203267)
</span><span class="lines">@@ -1,3 +1,17 @@
</span><ins>+2016-07-14 Antonio Gomes <tonikitoo@igalia.com>
+
+ [RTL Scrollbars] Frame scrollbars don't move to the right when text direction changes to RTL
+ https://bugs.webkit.org/show_bug.cgi?id=158252
+
+ Reviewed by Myles C. Maxfield.
+
+ * fast/scrolling/rtl-scrollbars-alternate-body-dir-attr-does-not-update-scrollbar-placement.html: Added.
+ * fast/scrolling/rtl-scrollbars-alternate-body-dir-attr-does-not-update-scrollbar-placement-expected.txt: Added.
+ * fast/scrolling/rtl-scrollbars-alternate-body-dir-attr-does-not-update-scrollbar-placement-2.html: Added.
+ * fast/scrolling/rtl-scrollbars-alternate-body-dir-attr-does-not-update-scrollbar-placement-2-expected.html: Added.
+ * fast/scrolling/rtl-scrollbars-alternate-iframe-body-dir-attr-does-not-update-scrollbar-placement.html: Added.
+ * fast/scrolling/rtl-scrollbars-alternate-iframe-body-dir-attr-does-not-update-scrollbar-placement-expected.txt: Added.
+
</ins><span class="cx"> 2016-07-14 Myles C. Maxfield <mmaxfield@apple.com>
</span><span class="cx">
</span><span class="cx"> Support new emoji group candidates
</span></span></pre></div>
<a id="trunkLayoutTestsTestExpectations"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/TestExpectations (203266 => 203267)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/TestExpectations 2016-07-15 03:11:15 UTC (rev 203266)
+++ trunk/LayoutTests/TestExpectations 2016-07-15 03:56:51 UTC (rev 203267)
</span><span class="lines">@@ -973,6 +973,9 @@
</span><span class="cx"> fast/scrolling/rtl-scrollbars-listbox-simple.html [ ImageOnlyFailure ]
</span><span class="cx"> fast/scrolling/rtl-scrollbars-listbox.html [ ImageOnlyFailure ]
</span><span class="cx"> fast/scrolling/rtl-scrollbars-positioned-intersect-scrollbars.html [ ImageOnlyFailure ]
</span><ins>+fast/scrolling/rtl-scrollbars-alternate-body-dir-attr-does-not-update-scrollbar-placement.html [ ImageOnlyFailure ]
+fast/scrolling/rtl-scrollbars-alternate-body-dir-attr-does-not-update-scrollbar-placement-2.html [ ImageOnlyFailure ]
+fast/scrolling/rtl-scrollbars-alternate-iframe-body-dir-attr-does-not-update-scrollbar-placement.html [ ImageOnlyFailure ]
</ins><span class="cx">
</span><span class="cx"> # <a download> does not support Blobs
</span><span class="cx"> webkit.org/b/156099 http/tests/security/anchor-download-allow-blob.html [ Failure ]
</span></span></pre></div>
<a id="trunkLayoutTestsfastscrollingrtlscrollbarsalternatebodydirattrdoesnotupdatescrollbarplacement2expectedhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/scrolling/rtl-scrollbars-alternate-body-dir-attr-does-not-update-scrollbar-placement-2-expected.html (0 => 203267)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/scrolling/rtl-scrollbars-alternate-body-dir-attr-does-not-update-scrollbar-placement-2-expected.html (rev 0)
+++ trunk/LayoutTests/fast/scrolling/rtl-scrollbars-alternate-body-dir-attr-does-not-update-scrollbar-placement-2-expected.html 2016-07-15 03:56:51 UTC (rev 203267)
</span><span class="lines">@@ -0,0 +1,15 @@
</span><ins>+<!DOCTYPE html>
+<head>
+ <style type='text/css'>
+ body {
+ height: 5000px;
+ }
+ </style>
+ <script>
+ if (window.internals) {
+ internals.settings.setUserInterfaceDirectionPolicy("View");
+ internals.settings.setSystemLayoutDirection("RTL");
+ }
+ </script>
+</head>
+<body style='min-height: 5000px'></body>
</ins></span></pre></div>
<a id="trunkLayoutTestsfastscrollingrtlscrollbarsalternatebodydirattrdoesnotupdatescrollbarplacement2html"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/scrolling/rtl-scrollbars-alternate-body-dir-attr-does-not-update-scrollbar-placement-2.html (0 => 203267)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/scrolling/rtl-scrollbars-alternate-body-dir-attr-does-not-update-scrollbar-placement-2.html (rev 0)
+++ trunk/LayoutTests/fast/scrolling/rtl-scrollbars-alternate-body-dir-attr-does-not-update-scrollbar-placement-2.html 2016-07-15 03:56:51 UTC (rev 203267)
</span><span class="lines">@@ -0,0 +1,20 @@
</span><ins>+<!DOCTYPE html>
+<head>
+ <style type='text/css'>
+ body {
+ height: 5000px;
+ direction: ltr;
+ }
+ </style>
+ <script>
+ if (window.internals)
+ internals.settings.setUserInterfaceDirectionPolicy('Content');
+
+ function startTest()
+ {
+ document.scrollingElement.scrollTop = 0;
+ document.body.style.direction = 'rtl';
+ }
+ </script>
+</head>
+<body style='min-height: 5000px' onload='startTest();'></body>
</ins></span></pre></div>
<a id="trunkLayoutTestsfastscrollingrtlscrollbarsalternatebodydirattrdoesnotupdatescrollbarplacementexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/scrolling/rtl-scrollbars-alternate-body-dir-attr-does-not-update-scrollbar-placement-expected.txt (0 => 203267)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/scrolling/rtl-scrollbars-alternate-body-dir-attr-does-not-update-scrollbar-placement-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/scrolling/rtl-scrollbars-alternate-body-dir-attr-does-not-update-scrollbar-placement-expected.txt 2016-07-15 03:56:51 UTC (rev 203267)
</span><span class="lines">@@ -0,0 +1,6 @@
</span><ins>+ACTION : Drag the outermost frame LTR scrollbar.
+PASS scroller.scrollTop is not 0
+ACTION : Flip 'dir' from 'rtl' to 'ltr'.
+ACTION : Drag the outermost frame RTL scrollbar.
+PASS scroller.scrollTop is not 0
+
</ins></span></pre></div>
<a id="trunkLayoutTestsfastscrollingrtlscrollbarsalternatebodydirattrdoesnotupdatescrollbarplacementhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/scrolling/rtl-scrollbars-alternate-body-dir-attr-does-not-update-scrollbar-placement.html (0 => 203267)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/scrolling/rtl-scrollbars-alternate-body-dir-attr-does-not-update-scrollbar-placement.html (rev 0)
+++ trunk/LayoutTests/fast/scrolling/rtl-scrollbars-alternate-body-dir-attr-does-not-update-scrollbar-placement.html 2016-07-15 03:56:51 UTC (rev 203267)
</span><span class="lines">@@ -0,0 +1,60 @@
</span><ins>+<!-- webkit-test-runner [ useThreadedScrolling=false ] -->
+<!DOCTYPE html>
+<head>
+ <style type='text/css'>
+ body {
+ height: 5000px;
+ direction: ltr;
+ }
+ </style>
+ <script src="../../resources/js-test-pre.js"></script>
+ <script>
+ window.jsTestIsAsync = true;
+
+ var scroller;
+ var previousScrollPosition;
+
+ if (window.internals)
+ internals.settings.setUserInterfaceDirectionPolicy('Content');
+
+ function doTest()
+ {
+ previousScrollPosition = scroller.scrollTop;
+
+ debug('ACTION : Drag the outermost frame LTR scrollbar.');
+ eventSender.mouseMoveTo(window.innerWidth - 4, 20);
+ eventSender.mouseDown();
+ eventSender.mouseMoveTo(window.innerWidth - 4, 50);
+ eventSender.mouseUp();
+
+ shouldNotBe("scroller.scrollTop", "0");
+
+ debug('ACTION : Flip \'dir\' from \'rtl\' to \'ltr\'.');
+ document.scrollingElement.scrollTop = 0;
+ document.body.style.direction = 'rtl';
+
+ debug('ACTION : Drag the outermost frame RTL scrollbar.');
+ previousScrollPosition = scroller.scrollTop;
+ eventSender.mouseMoveTo(4, 20);
+ eventSender.mouseDown();
+ eventSender.mouseMoveTo(4, 50);
+ eventSender.mouseUp();
+
+ shouldNotBe("scroller.scrollTop", "0");
+ testRunner.notifyDone();
+ }
+
+ function startTest()
+ {
+ if (window.eventSender) {
+ testRunner.dumpAsText();
+ testRunner.waitUntilDone();
+
+ scroller = document.scrollingElement;
+ setTimeout(doTest, 0);
+ }
+ }
+ </script>
+ <script src="../../resources/js-test-post.js"></script>
+</head>
+<body style='min-height: 5000px' onload='startTest();'></body>
</ins></span></pre></div>
<a id="trunkLayoutTestsfastscrollingrtlscrollbarsalternateiframebodydirattrdoesnotupdatescrollbarplacementexpectedhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/scrolling/rtl-scrollbars-alternate-iframe-body-dir-attr-does-not-update-scrollbar-placement-expected.html (0 => 203267)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/scrolling/rtl-scrollbars-alternate-iframe-body-dir-attr-does-not-update-scrollbar-placement-expected.html (rev 0)
+++ trunk/LayoutTests/fast/scrolling/rtl-scrollbars-alternate-iframe-body-dir-attr-does-not-update-scrollbar-placement-expected.html 2016-07-15 03:56:51 UTC (rev 203267)
</span><span class="lines">@@ -0,0 +1,19 @@
</span><ins>+<html>
+ <script>
+ if (window.internals) {
+ internals.settings.setUserInterfaceDirectionPolicy("View");
+ internals.settings.setSystemLayoutDirection("RTL");
+ }
+ </script>
+ <iframe width="200" height="100" scrolling="yes" src="data:text/html,
+ <html>
+ <body id='body' dir='rtl'>
+ Lorem ipsum dolor sit amet, consectetur adipisicing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua.
+ Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure
+ dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non
+ proident, sunt in culpa qui officia deserunt mollit anim id est laborum.
+ </body>
+ </html>">
+ </iframe>
+</html>
+
</ins></span></pre></div>
<a id="trunkLayoutTestsfastscrollingrtlscrollbarsalternateiframebodydirattrdoesnotupdatescrollbarplacementhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/scrolling/rtl-scrollbars-alternate-iframe-body-dir-attr-does-not-update-scrollbar-placement.html (0 => 203267)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/scrolling/rtl-scrollbars-alternate-iframe-body-dir-attr-does-not-update-scrollbar-placement.html (rev 0)
+++ trunk/LayoutTests/fast/scrolling/rtl-scrollbars-alternate-iframe-body-dir-attr-does-not-update-scrollbar-placement.html 2016-07-15 03:56:51 UTC (rev 203267)
</span><span class="lines">@@ -0,0 +1,20 @@
</span><ins>+<html>
+ <iframe width="200" height="100" scrolling="yes" src="data:text/html,
+ <html>
+ <script>
+ function load()
+ {
+ var body = document.getElementById('body');
+ body.style.direction='rtl';
+ }
+ </script>
+ <body id='body' onload='setTimeout(load, 0);'>
+ Lorem ipsum dolor sit amet, consectetur adipisicing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua.
+ Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure
+ dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non
+ proident, sunt in culpa qui officia deserunt mollit anim id est laborum.
+ </body>
+ </html>">
+ </iframe>
+</html>
+
</ins></span></pre></div>
<a id="trunkLayoutTestsplatformgtkTestExpectations"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/gtk/TestExpectations (203266 => 203267)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/gtk/TestExpectations 2016-07-15 03:11:15 UTC (rev 203266)
+++ trunk/LayoutTests/platform/gtk/TestExpectations 2016-07-15 03:56:51 UTC (rev 203267)
</span><span class="lines">@@ -2649,6 +2649,9 @@
</span><span class="cx"> fast/scrolling/rtl-scrollbars-listbox-simple.html [ Pass ]
</span><span class="cx"> fast/scrolling/rtl-scrollbars-listbox.html [ Pass ]
</span><span class="cx"> fast/scrolling/rtl-scrollbars-positioned-intersect-scrollbars.html [ Pass ]
</span><ins>+fast/scrolling/rtl-scrollbars-alternate-body-dir-attr-does-not-update-scrollbar-placement.html [ Pass ]
+fast/scrolling/rtl-scrollbars-alternate-body-dir-attr-does-not-update-scrollbar-placement-2.html [ Pass ]
+fast/scrolling/rtl-scrollbars-alternate-iframe-body-dir-attr-does-not-update-scrollbar-placement.html [ Pass ]
</ins><span class="cx">
</span><span class="cx"> # https://bugs.webkit.org/show_bug.cgi?id=156612
</span><span class="cx"> http/tests/security/contentSecurityPolicy/embed-redirect-blocked3.html [ Pass ]
</span></span></pre></div>
<a id="trunkLayoutTestsplatformmacwk2TestExpectations"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (203266 => 203267)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/mac-wk2/TestExpectations 2016-07-15 03:11:15 UTC (rev 203266)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations 2016-07-15 03:56:51 UTC (rev 203267)
</span><span class="lines">@@ -506,6 +506,9 @@
</span><span class="cx"> [ Sierra+ ] fast/scrolling/rtl-scrollbars-listbox-simple.html [ Pass ]
</span><span class="cx"> [ Sierra+ ] fast/scrolling/rtl-scrollbars-listbox.html [ Pass ]
</span><span class="cx"> [ Sierra+ ] fast/scrolling/rtl-scrollbars-positioned-intersect-scrollbars.html [ Pass ]
</span><ins>+[ Sierra+ ] fast/scrolling/rtl-scrollbars-alternate-body-dir-attr-does-not-update-scrollbar-placement.html [ Pass ]
+[ Sierra+ ] fast/scrolling/rtl-scrollbars-alternate-body-dir-attr-does-not-update-scrollbar-placement-2.html [ Pass ]
+[ Sierra+ ] fast/scrolling/rtl-scrollbars-alternate-iframe-body-dir-attr-does-not-update-scrollbar-placement.html [ Pass ]
</ins><span class="cx">
</span><span class="cx"> # <rdar://problem/25063128>
</span><span class="cx"> [ Sierra+ ] media/media-controls-drag-timeline-set-controls-property.html [ Pass Timeout ]
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (203266 => 203267)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-07-15 03:11:15 UTC (rev 203266)
+++ trunk/Source/WebCore/ChangeLog 2016-07-15 03:56:51 UTC (rev 203267)
</span><span class="lines">@@ -1,3 +1,28 @@
</span><ins>+2016-07-14 Antonio Gomes <tonikitoo@igalia.com>
+
+ [RTL Scrollbars] Frame scrollbars don't move to the right when text direction changes to RTL
+ https://bugs.webkit.org/show_bug.cgi?id=158252
+
+ Reviewed by Myles C. Maxfield.
+
+ When the 'dir' attribute changes either on body or on the document
+ element level, the associated FrameView does not trigger an update on
+ the frame level vertical scrollbar.
+
+ Patch adds a 'hook' so that RenderBox::styleDidChange can call in
+ order to get the document level scrollbar placed properly in the next
+ layout.
+
+ Test: fast/scrolling/rtl-scrollbars-alternate-body-dir-attr-does-not-update-scrollbar-placement.html
+ fast/scrolling/rtl-scrollbars-alternate-body-dir-attr-does-not-update-scrollbar-placement-2.html
+ fast/scrolling/rtl-scrollbars-alternate-iframe-body-dir-attr-does-not-update-scrollbar-placement.html
+
+ * page/FrameView.cpp:
+ (WebCore::FrameView::topContentDirectionDidChange):
+ * page/FrameView.h:
+ * rendering/RenderBox.cpp:
+ (WebCore::RenderBox::styleDidChange):
+
</ins><span class="cx"> 2016-07-14 Myles C. Maxfield <mmaxfield@apple.com>
</span><span class="cx">
</span><span class="cx"> Support new emoji group candidates
</span></span></pre></div>
<a id="trunkSourceWebCorepageFrameViewcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/FrameView.cpp (203266 => 203267)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/FrameView.cpp 2016-07-15 03:11:15 UTC (rev 203266)
+++ trunk/Source/WebCore/page/FrameView.cpp 2016-07-15 03:56:51 UTC (rev 203267)
</span><span class="lines">@@ -319,6 +319,7 @@
</span><span class="cx"> m_isVisuallyNonEmpty = false;
</span><span class="cx"> m_firstVisuallyNonEmptyLayoutCallbackPending = true;
</span><span class="cx"> m_viewportIsStable = true;
</span><ins>+ m_needsDeferredScrollbarsUpdate = false;
</ins><span class="cx"> m_maintainScrollPositionAnchor = nullptr;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -1126,6 +1127,23 @@
</span><span class="cx"> if (TiledBacking* tiledBacking = this->tiledBacking())
</span><span class="cx"> tiledBacking->setTopContentInset(newTopContentInset);
</span><span class="cx"> }
</span><ins>+
+void FrameView::topContentDirectionDidChange()
+{
+ m_needsDeferredScrollbarsUpdate = true;
+}
+
+void FrameView::handleDeferredScrollbarsUpdateAfterDirectionChange()
+{
+ if (!m_needsDeferredScrollbarsUpdate)
+ return;
+
+ m_needsDeferredScrollbarsUpdate = false;
+
+ ASSERT(m_layoutPhase == InPostLayerPositionsUpdatedAfterLayout);
+ updateScrollbars(scrollPosition());
+ positionScrollbarLayers();
+}
</ins><span class="cx">
</span><span class="cx"> bool FrameView::hasCompositedContent() const
</span><span class="cx"> {
</span><span class="lines">@@ -1479,6 +1497,8 @@
</span><span class="cx">
</span><span class="cx"> handleDeferredScrollUpdateAfterContentSizeChange();
</span><span class="cx">
</span><ins>+ handleDeferredScrollbarsUpdateAfterDirectionChange();
+
</ins><span class="cx"> if (document.hasListenerType(Document::OVERFLOWCHANGED_LISTENER))
</span><span class="cx"> updateOverflowStatus(layoutWidth() < contentsWidth(), layoutHeight() < contentsHeight());
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorepageFrameViewh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/FrameView.h (203266 => 203267)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/FrameView.h 2016-07-15 03:11:15 UTC (rev 203266)
+++ trunk/Source/WebCore/page/FrameView.h 2016-07-15 03:56:51 UTC (rev 203267)
</span><span class="lines">@@ -504,6 +504,8 @@
</span><span class="cx"> WEBCORE_EXPORT float topContentInset(TopContentInsetType = TopContentInsetType::WebCoreContentInset) const override;
</span><span class="cx"> void topContentInsetDidChange(float newTopContentInset);
</span><span class="cx">
</span><ins>+ void topContentDirectionDidChange();
+
</ins><span class="cx"> WEBCORE_EXPORT void willStartLiveResize() override;
</span><span class="cx"> WEBCORE_EXPORT void willEndLiveResize() override;
</span><span class="cx">
</span><span class="lines">@@ -657,6 +659,8 @@
</span><span class="cx"> IntSize sizeForResizeEvent() const;
</span><span class="cx"> void sendResizeEventIfNeeded();
</span><span class="cx">
</span><ins>+ void handleDeferredScrollbarsUpdateAfterDirectionChange();
+
</ins><span class="cx"> void updateScrollableAreaSet();
</span><span class="cx">
</span><span class="cx"> void notifyPageThatContentAreaWillPaint() const override;
</span><span class="lines">@@ -772,6 +776,8 @@
</span><span class="cx">
</span><span class="cx"> bool m_viewportIsStable { true };
</span><span class="cx">
</span><ins>+ bool m_needsDeferredScrollbarsUpdate { false };
+
</ins><span class="cx"> RefPtr<ContainerNode> m_maintainScrollPositionAnchor;
</span><span class="cx">
</span><span class="cx"> // Renderer to hold our custom scroll corner.
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderBoxcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderBox.cpp (203266 => 203267)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderBox.cpp 2016-07-15 03:11:15 UTC (rev 203266)
+++ trunk/Source/WebCore/rendering/RenderBox.cpp 2016-07-15 03:56:51 UTC (rev 203267)
</span><span class="lines">@@ -401,6 +401,8 @@
</span><span class="cx"> rootStyleChanged = true;
</span><span class="cx"> }
</span><span class="cx"> setNeedsLayoutAndPrefWidthsRecalc();
</span><ins>+
+ view().frameView().topContentDirectionDidChange();
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> if (viewStyle.writingMode() != newStyle.writingMode() && (isDocElementRenderer || !documentElementRenderer->style().hasExplicitlySetWritingMode())) {
</span></span></pre>
</div>
</div>
</body>
</html>