<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[203158] trunk/Source/WebCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/203158">203158</a></dd>
<dt>Author</dt> <dd>carlosgc@webkit.org</dd>
<dt>Date</dt> <dd>2016-07-13 04:37:48 -0700 (Wed, 13 Jul 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Unreviewed. Fix GObject DOM bindings API breaks after <a href="http://trac.webkit.org/projects/webkit/changeset/203047">r203047</a>-
webkit_dom_document_set_title() and webkit_dom_html_title_element_set_text() now can raise exceptions.
* bindings/gobject/WebKitDOMDeprecated.cpp:
(webkit_dom_document_set_title):
(webkit_dom_html_title_element_set_text):
* bindings/gobject/WebKitDOMDeprecated.h:
* bindings/gobject/WebKitDOMDeprecated.symbols:
* bindings/gobject/webkitdom.symbols:
* bindings/scripts/CodeGeneratorGObject.pm:
(GenerateProperty):
(FunctionUsedToNotRaiseException):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorebindingsgobjectWebKitDOMDeprecatedcpp">trunk/Source/WebCore/bindings/gobject/WebKitDOMDeprecated.cpp</a></li>
<li><a href="#trunkSourceWebCorebindingsgobjectWebKitDOMDeprecatedh">trunk/Source/WebCore/bindings/gobject/WebKitDOMDeprecated.h</a></li>
<li><a href="#trunkSourceWebCorebindingsgobjectWebKitDOMDeprecatedsymbols">trunk/Source/WebCore/bindings/gobject/WebKitDOMDeprecated.symbols</a></li>
<li><a href="#trunkSourceWebCorebindingsgobjectwebkitdomsymbols">trunk/Source/WebCore/bindings/gobject/webkitdom.symbols</a></li>
<li><a href="#trunkSourceWebCorebindingsscriptsCodeGeneratorGObjectpm">trunk/Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (203157 => 203158)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-07-13 11:00:43 UTC (rev 203157)
+++ trunk/Source/WebCore/ChangeLog 2016-07-13 11:37:48 UTC (rev 203158)
</span><span class="lines">@@ -1,5 +1,21 @@
</span><span class="cx"> 2016-07-13 Carlos Garcia Campos <cgarcia@igalia.com>
</span><span class="cx">
</span><ins>+ Unreviewed. Fix GObject DOM bindings API breaks after r203047-
+
+ webkit_dom_document_set_title() and webkit_dom_html_title_element_set_text() now can raise exceptions.
+
+ * bindings/gobject/WebKitDOMDeprecated.cpp:
+ (webkit_dom_document_set_title):
+ (webkit_dom_html_title_element_set_text):
+ * bindings/gobject/WebKitDOMDeprecated.h:
+ * bindings/gobject/WebKitDOMDeprecated.symbols:
+ * bindings/gobject/webkitdom.symbols:
+ * bindings/scripts/CodeGeneratorGObject.pm:
+ (GenerateProperty):
+ (FunctionUsedToNotRaiseException):
+
+2016-07-13 Carlos Garcia Campos <cgarcia@igalia.com>
+
</ins><span class="cx"> [Coordinated Graphics] Remove toCoordinatedGraphicsLayer and use downcast instead
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=159469
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsgobjectWebKitDOMDeprecatedcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/gobject/WebKitDOMDeprecated.cpp (203157 => 203158)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/gobject/WebKitDOMDeprecated.cpp 2016-07-13 11:00:43 UTC (rev 203157)
+++ trunk/Source/WebCore/bindings/gobject/WebKitDOMDeprecated.cpp 2016-07-13 11:37:48 UTC (rev 203158)
</span><span class="lines">@@ -24,6 +24,7 @@
</span><span class="cx"> #include "JSMainThreadExecState.h"
</span><span class="cx"> #include "WebKitDOMDocumentPrivate.h"
</span><span class="cx"> #include "WebKitDOMElementPrivate.h"
</span><ins>+#include "WebKitDOMHTMLTitleElement.h"
</ins><span class="cx"> #include "WebKitDOMNodeListPrivate.h"
</span><span class="cx"> #include <wtf/GetPtr.h>
</span><span class="cx"> #include <wtf/RefPtr.h>
</span><span class="lines">@@ -132,6 +133,16 @@
</span><span class="cx"> return webkit_dom_node_clone_node_with_error(self, deep, nullptr);
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+void webkit_dom_document_set_title(WebKitDOMDocument* self, const gchar* title)
+{
+ webkit_dom_document_set_title_with_error(self, title, nullptr);
+}
+
+void webkit_dom_html_title_element_set_text(WebKitDOMHTMLTitleElement* self, const gchar* text)
+{
+ webkit_dom_html_title_element_set_text_with_error(self, text, nullptr);
+}
+
</ins><span class="cx"> G_DEFINE_TYPE(WebKitDOMEntityReference, webkit_dom_entity_reference, WEBKIT_DOM_TYPE_NODE)
</span><span class="cx">
</span><span class="cx"> static void webkit_dom_entity_reference_init(WebKitDOMEntityReference*)
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsgobjectWebKitDOMDeprecatedh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/gobject/WebKitDOMDeprecated.h (203157 => 203158)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/gobject/WebKitDOMDeprecated.h 2016-07-13 11:00:43 UTC (rev 203157)
+++ trunk/Source/WebCore/bindings/gobject/WebKitDOMDeprecated.h 2016-07-13 11:37:48 UTC (rev 203158)
</span><span class="lines">@@ -171,7 +171,26 @@
</span><span class="cx"> WEBKIT_DEPRECATED_FOR(webkit_dom_node_clone_node_with_error) WebKitDOMNode*
</span><span class="cx"> webkit_dom_node_clone_node(WebKitDOMNode* self, gboolean deep, GError** error);
</span><span class="cx">
</span><ins>+/**
+ * webkit_dom_document_set_title:
+ * @self: A #WebKitDOMDocument
+ * @title: A #gchar
+ *
+ * Deprecated: 2.14: Use webkit_dom_document_set_title_with_error() instead.
+ */
+WEBKIT_DEPRECATED_FOR(webkit_dom_document_set_title_with_error) void
+webkit_dom_document_set_title(WebKitDOMDocument* self, const gchar* title);
</ins><span class="cx">
</span><ins>+/**
+ * webkit_dom_html_title_element_set_text:
+ * @self: A #WebKitDOMHTMLTitleElement
+ * @text: A #gchar
+ *
+ * Deprecated: 2.14: Use webkit_dom_html_title_element_set_text_with_error() instead.
+ */
+WEBKIT_DEPRECATED_FOR(webkit_dom_html_title_element_set_text_with_error) void
+webkit_dom_html_title_element_set_text(WebKitDOMHTMLTitleElement* self, const gchar* text);
+
</ins><span class="cx"> #define WEBKIT_DOM_TYPE_ENTITY_REFERENCE (webkit_dom_entity_reference_get_type())
</span><span class="cx"> #define WEBKIT_DOM_ENTITY_REFERENCE(obj) (G_TYPE_CHECK_INSTANCE_CAST((obj), WEBKIT_DOM_TYPE_ENTITY_REFERENCE, WebKitDOMEntityReference))
</span><span class="cx"> #define WEBKIT_DOM_ENTITY_REFERENCE_CLASS(klass) (G_TYPE_CHECK_CLASS_CAST((klass), WEBKIT_DOM_TYPE_ENTITY_REFERENCE, WebKitDOMEntityReferenceClass)
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsgobjectWebKitDOMDeprecatedsymbols"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/gobject/WebKitDOMDeprecated.symbols (203157 => 203158)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/gobject/WebKitDOMDeprecated.symbols 2016-07-13 11:00:43 UTC (rev 203157)
+++ trunk/Source/WebCore/bindings/gobject/WebKitDOMDeprecated.symbols 2016-07-13 11:37:48 UTC (rev 203158)
</span><span class="lines">@@ -21,3 +21,5 @@
</span><span class="cx"> void webkit_dom_html_base_font_element_set_face(WebKitDOMHTMLBaseFontElement*, const gchar*)
</span><span class="cx"> void webkit_dom_html_base_font_element_set_size(WebKitDOMHTMLBaseFontElement*, glong)
</span><span class="cx"> WebKitDOMNode* webkit_dom_node_clone_node(WebKitDOMNode*, gboolean)
</span><ins>+void webkit_dom_document_set_title(WebKitDOMDocument*, const gchar*)
+void webkit_dom_html_title_element_set_text(WebKitDOMHTMLTitleElement*, const gchar*)
</ins></span></pre></div>
<a id="trunkSourceWebCorebindingsgobjectwebkitdomsymbols"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/gobject/webkitdom.symbols (203157 => 203158)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/gobject/webkitdom.symbols 2016-07-13 11:00:43 UTC (rev 203157)
+++ trunk/Source/WebCore/bindings/gobject/webkitdom.symbols 2016-07-13 11:37:48 UTC (rev 203158)
</span><span class="lines">@@ -28,6 +28,7 @@
</span><span class="cx"> WebKitDOMHTMLCollection* webkit_dom_document_get_images(WebKitDOMDocument*)
</span><span class="cx"> gchar* webkit_dom_document_get_title(WebKitDOMDocument*)
</span><span class="cx"> void webkit_dom_document_set_title(WebKitDOMDocument*, const gchar*)
</span><ins>+void webkit_dom_document_set_title_with_error(WebKitDOMDocument*, const gchar*, GError**)@2.14
</ins><span class="cx"> gchar* webkit_dom_document_get_charset(WebKitDOMDocument*)
</span><span class="cx"> void webkit_dom_document_set_charset(WebKitDOMDocument*, const gchar*)
</span><span class="cx"> gchar* webkit_dom_document_get_default_charset(WebKitDOMDocument*)
</span><span class="lines">@@ -950,6 +951,7 @@
</span><span class="cx"> GType webkit_dom_html_title_element_get_type(void)
</span><span class="cx"> gchar* webkit_dom_html_title_element_get_text(WebKitDOMHTMLTitleElement*)
</span><span class="cx"> void webkit_dom_html_title_element_set_text(WebKitDOMHTMLTitleElement*, const gchar*)
</span><ins>+void webkit_dom_html_title_element_set_text_with_error(WebKitDOMHTMLTitleElement*, const gchar*, GError**)@2.14
</ins><span class="cx"> GType webkit_dom_html_u_list_element_get_type(void)
</span><span class="cx"> gchar* webkit_dom_html_u_list_element_get_type_attr(WebKitDOMHTMLUListElement*)
</span><span class="cx"> void webkit_dom_html_u_list_element_set_type_attr(WebKitDOMHTMLUListElement*, const gchar*)
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsscriptsCodeGeneratorGObjectpm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm (203157 => 203158)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm 2016-07-13 11:00:43 UTC (rev 203157)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm 2016-07-13 11:37:48 UTC (rev 203158)
</span><span class="lines">@@ -560,6 +560,9 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> my $getterFunctionName = "webkit_dom_${decamelizeInterfaceName}_get_" . $propFunctionName;
</span><ins>+ if (FunctionUsedToNotRaiseException($getterFunctionName)) {
+ $getterFunctionName = $getterFunctionName . "_with_error";
+ }
</ins><span class="cx"> my @getterArguments = ();
</span><span class="cx"> push(@getterArguments, "self");
</span><span class="cx"> push(@getterArguments, "nullptr") if $hasGetterException || FunctionUsedToRaiseException($getterFunctionName);
</span><span class="lines">@@ -566,6 +569,9 @@
</span><span class="cx">
</span><span class="cx"> if (grep {$_ eq $attribute} @writeableProperties) {
</span><span class="cx"> my $setterFunctionName = "webkit_dom_${decamelizeInterfaceName}_set_" . $propFunctionName;
</span><ins>+ if (FunctionUsedToNotRaiseException($setterFunctionName)) {
+ $setterFunctionName = $setterFunctionName . "_with_error";
+ }
</ins><span class="cx"> my @setterArguments = ();
</span><span class="cx"> push(@setterArguments, "self, g_value_get_$gtype(value)");
</span><span class="cx"> push(@setterArguments, "nullptr") if $hasSetterException || FunctionUsedToRaiseException($setterFunctionName);
</span><span class="lines">@@ -1048,7 +1054,9 @@
</span><span class="cx"> sub FunctionUsedToNotRaiseException {
</span><span class="cx"> my $functionName = shift;
</span><span class="cx">
</span><del>- return $functionName eq "webkit_dom_node_clone_node";
</del><ins>+ return $functionName eq "webkit_dom_document_set_title"
+ || $functionName eq "webkit_dom_html_title_element_set_text"
+ || $functionName eq "webkit_dom_node_clone_node";
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> sub GenerateFunction {
</span></span></pre>
</div>
</div>
</body>
</html>