<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[203110] trunk/Source/WebCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/203110">203110</a></dd>
<dt>Author</dt> <dd>yoav@yoav.ws</dd>
<dt>Date</dt> <dd>2016-07-12 02:04:49 -0700 (Tue, 12 Jul 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>js/dom/global-constructors-attributes.html is flaky: ResourceTiming runtime feature leaks between tests
https://bugs.webkit.org/show_bug.cgi?id=158902
Reviewed by Benjamin Poulain.
Adds a new reset() mechanism to RuntimeEnabledFeatures so that they could be brought back to the initial state.
This reset() is then called from DumpRenderTree and WebKitTestRunner.
No new tests but hopefully current tests will be less flaky.
* bindings/generic/RuntimeEnabledFeatures.cpp:
(WebCore::RuntimeEnabledFeatures::RuntimeEnabledFeatures):
(WebCore::RuntimeEnabledFeatures::reset):
* bindings/generic/RuntimeEnabledFeatures.h:
* testing/Internals.cpp:
(WebCore::Internals::resetToConsistentState): reset RuntimeEnabledFeatures.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorebindingsgenericRuntimeEnabledFeaturescpp">trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.cpp</a></li>
<li><a href="#trunkSourceWebCorebindingsgenericRuntimeEnabledFeaturesh">trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.h</a></li>
<li><a href="#trunkSourceWebCoretestingInternalscpp">trunk/Source/WebCore/testing/Internals.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (203109 => 203110)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-07-12 06:24:30 UTC (rev 203109)
+++ trunk/Source/WebCore/ChangeLog 2016-07-12 09:04:49 UTC (rev 203110)
</span><span class="lines">@@ -1,3 +1,22 @@
</span><ins>+2016-07-12 Yoav Weiss <yoav@yoav.ws>
+
+ js/dom/global-constructors-attributes.html is flaky: ResourceTiming runtime feature leaks between tests
+ https://bugs.webkit.org/show_bug.cgi?id=158902
+
+ Reviewed by Benjamin Poulain.
+
+ Adds a new reset() mechanism to RuntimeEnabledFeatures so that they could be brought back to the initial state.
+ This reset() is then called from DumpRenderTree and WebKitTestRunner.
+
+ No new tests but hopefully current tests will be less flaky.
+
+ * bindings/generic/RuntimeEnabledFeatures.cpp:
+ (WebCore::RuntimeEnabledFeatures::RuntimeEnabledFeatures):
+ (WebCore::RuntimeEnabledFeatures::reset):
+ * bindings/generic/RuntimeEnabledFeatures.h:
+ * testing/Internals.cpp:
+ (WebCore::Internals::resetToConsistentState): reset RuntimeEnabledFeatures.
+
</ins><span class="cx"> 2016-07-11 Gyuyoung Kim <gyuyoung.kim@webkit.org>
</span><span class="cx">
</span><span class="cx"> Purge PassRefPtr in platform/efl and platform/mac
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsgenericRuntimeEnabledFeaturescpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.cpp (203109 => 203110)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.cpp 2016-07-12 06:24:30 UTC (rev 203109)
+++ trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.cpp 2016-07-12 09:04:49 UTC (rev 203110)
</span><span class="lines">@@ -40,78 +40,84 @@
</span><span class="cx"> namespace WebCore {
</span><span class="cx">
</span><span class="cx"> RuntimeEnabledFeatures::RuntimeEnabledFeatures()
</span><del>- : m_isLocalStorageEnabled(true)
- , m_isSessionStorageEnabled(true)
- , m_isWebkitNotificationsEnabled(false)
- , m_isApplicationCacheEnabled(true)
- , m_isDataTransferItemsEnabled(true)
- , m_isGeolocationEnabled(true)
- , m_isTouchEnabled(true)
- , m_isDeviceMotionEnabled(true)
- , m_isDeviceOrientationEnabled(true)
- , m_isLinkPreloadEnabled(false)
- , m_isLangAttributeAwareFormControlUIEnabled(false)
</del><ins>+{
+ reset();
+}
+
+void RuntimeEnabledFeatures::reset()
+{
+ m_isLocalStorageEnabled = true;
+ m_isSessionStorageEnabled = true;
+ m_isWebkitNotificationsEnabled = false;
+ m_isApplicationCacheEnabled = true;
+ m_isDataTransferItemsEnabled = true;
+ m_isGeolocationEnabled = true;
+ m_isTouchEnabled = true;
+ m_isDeviceMotionEnabled = true;
+ m_isDeviceOrientationEnabled = true;
+ m_isLinkPreloadEnabled = false;
+ m_isLangAttributeAwareFormControlUIEnabled = false;
</ins><span class="cx"> #if PLATFORM(IOS)
</span><del>- , m_isPluginReplacementEnabled(true)
</del><ins>+ m_isPluginReplacementEnabled = true;
</ins><span class="cx"> #else
</span><del>- , m_isPluginReplacementEnabled(false)
</del><ins>+ m_isPluginReplacementEnabled = false;
</ins><span class="cx"> #endif
</span><del>- , m_isResourceTimingEnabled(false)
</del><ins>+ m_isResourceTimingEnabled = false;
</ins><span class="cx"> #if ENABLE(INDEXED_DATABASE)
</span><del>- , m_isIndexedDBEnabled(false)
</del><ins>+ m_isIndexedDBEnabled = true;
</ins><span class="cx"> #endif
</span><span class="cx"> #if ENABLE(INDEXED_DATABASE_IN_WORKERS)
</span><del>- , m_isIndexedDBWorkersEnabled(true)
</del><ins>+ m_isIndexedDBWorkersEnabled = true;
</ins><span class="cx"> #endif
</span><span class="cx"> #if ENABLE(MEDIA_STREAM) && PLATFORM(COCOA)
</span><del>- , m_isMediaStreamEnabled(false)
</del><ins>+ m_isMediaStreamEnabled = false;
</ins><span class="cx"> #endif
</span><span class="cx"> #if ENABLE(WEB_RTC)
</span><del>- , m_isPeerConnectionEnabled(true)
</del><ins>+ m_isPeerConnectionEnabled = true;
</ins><span class="cx"> #endif
</span><span class="cx"> #if ENABLE(LEGACY_CSS_VENDOR_PREFIXES)
</span><del>- , m_isLegacyCSSVendorPrefixesEnabled(false)
</del><ins>+ m_isLegacyCSSVendorPrefixesEnabled = false;
</ins><span class="cx"> #endif
</span><span class="cx"> #if ENABLE(JAVASCRIPT_I18N_API)
</span><del>- , m_isJavaScriptI18NAPIEnabled(false)
</del><ins>+ m_isJavaScriptI18NAPIEnabled = false;
</ins><span class="cx"> #endif
</span><span class="cx"> #if ENABLE(INPUT_TYPE_DATE)
</span><del>- , m_isInputTypeDateEnabled(true)
</del><ins>+ m_isInputTypeDateEnabled = true;
</ins><span class="cx"> #endif
</span><span class="cx"> #if ENABLE(INPUT_TYPE_DATETIME_INCOMPLETE)
</span><del>- , m_isInputTypeDateTimeEnabled(false)
</del><ins>+ m_isInputTypeDateTimeEnabled = false;
</ins><span class="cx"> #endif
</span><span class="cx"> #if ENABLE(INPUT_TYPE_DATETIMELOCAL)
</span><del>- , m_isInputTypeDateTimeLocalEnabled(true)
</del><ins>+ m_isInputTypeDateTimeLocalEnabled = true;
</ins><span class="cx"> #endif
</span><span class="cx"> #if ENABLE(INPUT_TYPE_MONTH)
</span><del>- , m_isInputTypeMonthEnabled(true)
</del><ins>+ m_isInputTypeMonthEnabled = true;
</ins><span class="cx"> #endif
</span><span class="cx"> #if ENABLE(INPUT_TYPE_TIME)
</span><del>- , m_isInputTypeTimeEnabled(true)
</del><ins>+ m_isInputTypeTimeEnabled = true;
</ins><span class="cx"> #endif
</span><span class="cx"> #if ENABLE(INPUT_TYPE_WEEK)
</span><del>- , m_isInputTypeWeekEnabled(true)
</del><ins>+ m_isInputTypeWeekEnabled = true;
</ins><span class="cx"> #endif
</span><span class="cx"> #if ENABLE(CSP_NEXT)
</span><del>- , m_areExperimentalContentSecurityPolicyFeaturesEnabled(false)
</del><ins>+ m_areExperimentalContentSecurityPolicyFeaturesEnabled = false;
</ins><span class="cx"> #endif
</span><span class="cx"> #if ENABLE(FONT_LOAD_EVENTS)
</span><del>- , m_isFontLoadEventsEnabled(true)
</del><ins>+ m_isFontLoadEventsEnabled = true;
</ins><span class="cx"> #endif
</span><span class="cx"> #if ENABLE(GAMEPAD)
</span><del>- , m_areGamepadsEnabled(false)
</del><ins>+ m_areGamepadsEnabled = false;
</ins><span class="cx"> #endif
</span><span class="cx"> #if ENABLE(CSS_ANIMATIONS_LEVEL_2)
</span><del>- , m_areAnimationTriggersEnabled(false)
</del><ins>+ m_areAnimationTriggersEnabled = false;
</ins><span class="cx"> #endif
</span><span class="cx"> #if ENABLE(WEB_ANIMATIONS)
</span><del>- , m_areWebAnimationsEnabled(false)
</del><ins>+ m_areWebAnimationsEnabled = false;
</ins><span class="cx"> #endif
</span><span class="cx"> #if ENABLE(CSS_GRID_LAYOUT)
</span><del>- , m_cssGridLayoutEnabled(true)
</del><ins>+ m_cssGridLayoutEnabled = true;
</ins><span class="cx"> #endif
</span><del>-{
</del><ins>+
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> RuntimeEnabledFeatures& RuntimeEnabledFeatures::sharedFeatures()
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsgenericRuntimeEnabledFeaturesh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.h (203109 => 203110)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.h 2016-07-12 06:24:30 UTC (rev 203109)
+++ trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.h 2016-07-12 09:04:49 UTC (rev 203110)
</span><span class="lines">@@ -228,6 +228,8 @@
</span><span class="cx">
</span><span class="cx"> WEBCORE_EXPORT static RuntimeEnabledFeatures& sharedFeatures();
</span><span class="cx">
</span><ins>+ WEBCORE_EXPORT void reset();
+
</ins><span class="cx"> private:
</span><span class="cx"> // Never instantiate.
</span><span class="cx"> RuntimeEnabledFeatures();
</span></span></pre></div>
<a id="trunkSourceWebCoretestingInternalscpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/testing/Internals.cpp (203109 => 203110)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/testing/Internals.cpp 2016-07-12 06:24:30 UTC (rev 203109)
+++ trunk/Source/WebCore/testing/Internals.cpp 2016-07-12 09:04:49 UTC (rev 203110)
</span><span class="lines">@@ -428,6 +428,7 @@
</span><span class="cx"> if (document.page())
</span><span class="cx"> document.page()->setMockMediaPlaybackTargetPickerEnabled(true);
</span><span class="cx"> #endif
</span><ins>+ RuntimeEnabledFeatures::sharedFeatures().reset();
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> Document* Internals::contextDocument() const
</span></span></pre>
</div>
</div>
</body>
</html>