<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[203065] trunk/Source/WebCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/203065">203065</a></dd>
<dt>Author</dt> <dd>nael.ouedraogo@crf.canon.fr</dd>
<dt>Date</dt> <dd>2016-07-11 09:26:00 -0700 (Mon, 11 Jul 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>toNative functions in JSDOMBinding.h should take an ExecState reference instead of pointer
https://bugs.webkit.org/show_bug.cgi?id=159298
Reviewed by Youenn Fablet.
Pass ExecState by reference instead of pointer.
* bindings/js/IDBBindingUtilities.cpp:
(WebCore::idbKeyPathFromValue):
* bindings/js/JSBlobCustom.cpp:
(WebCore::constructJSBlob):
* bindings/js/JSDOMBinding.h: Pass ExecState by reference instead of pointer.
(WebCore::toJSSequence):
(WebCore::NativeValueTraits<String>::nativeValue):
(WebCore::NativeValueTraits<unsigned>::nativeValue):
(WebCore::NativeValueTraits<float>::nativeValue):
(WebCore::NativeValueTraits<double>::nativeValue):
(WebCore::toNativeArray):
(WebCore::toNativeArguments):
* bindings/js/JSDOMConvert.h:
(WebCore::Converter<Vector<T>>::convert):
* bindings/js/JSDictionary.cpp:
(WebCore::JSDictionary::convertValue):
* bindings/js/JSFileCustom.cpp:
(WebCore::constructJSFile):
* bindings/js/JSMessagePortCustom.cpp:
(WebCore::fillMessagePortArray):
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateParametersCheck):
(JSValueToNative):
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalSequence):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalArray):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalArrayIsEmpty):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod7):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod9):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod10):
(WebCore::jsTestObjPrototypeFunctionMethodWithUnsignedLongSequence):
(WebCore::jsTestObjPrototypeFunctionStringArrayFunction):
(WebCore::jsTestObjPrototypeFunctionMethodWithAndWithoutNullableSequence):
(WebCore::jsTestObjPrototypeFunctionMethodWithAndWithoutNullableSequence2):
(WebCore::jsTestObjPrototypeFunctionStrictFunctionWithSequence):
(WebCore::jsTestObjPrototypeFunctionStrictFunctionWithArray):
(WebCore::jsTestObjPrototypeFunctionVariadicStringMethod):
(WebCore::jsTestObjPrototypeFunctionVariadicDoubleMethod):
* bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:
(WebCore::constructJSTestOverloadedConstructors5):
* bindings/scripts/test/JS/JSTestTypedefs.cpp:
(WebCore::jsTestTypedefsPrototypeFunctionFunc):
(WebCore::jsTestTypedefsPrototypeFunctionNullableArrayArg):
(WebCore::jsTestTypedefsPrototypeFunctionStringArrayFunction):
(WebCore::jsTestTypedefsPrototypeFunctionStringArrayFunction2):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorebindingsjsIDBBindingUtilitiescpp">trunk/Source/WebCore/bindings/js/IDBBindingUtilities.cpp</a></li>
<li><a href="#trunkSourceWebCorebindingsjsJSBlobCustomcpp">trunk/Source/WebCore/bindings/js/JSBlobCustom.cpp</a></li>
<li><a href="#trunkSourceWebCorebindingsjsJSDOMBindingh">trunk/Source/WebCore/bindings/js/JSDOMBinding.h</a></li>
<li><a href="#trunkSourceWebCorebindingsjsJSDOMConverth">trunk/Source/WebCore/bindings/js/JSDOMConvert.h</a></li>
<li><a href="#trunkSourceWebCorebindingsjsJSDictionarycpp">trunk/Source/WebCore/bindings/js/JSDictionary.cpp</a></li>
<li><a href="#trunkSourceWebCorebindingsjsJSFileCustomcpp">trunk/Source/WebCore/bindings/js/JSFileCustom.cpp</a></li>
<li><a href="#trunkSourceWebCorebindingsjsJSMessagePortCustomcpp">trunk/Source/WebCore/bindings/js/JSMessagePortCustom.cpp</a></li>
<li><a href="#trunkSourceWebCorebindingsscriptsCodeGeneratorJSpm">trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm</a></li>
<li><a href="#trunkSourceWebCorebindingsscriptstestJSJSTestObjcpp">trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp</a></li>
<li><a href="#trunkSourceWebCorebindingsscriptstestJSJSTestOverloadedConstructorscpp">trunk/Source/WebCore/bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp</a></li>
<li><a href="#trunkSourceWebCorebindingsscriptstestJSJSTestTypedefscpp">trunk/Source/WebCore/bindings/scripts/test/JS/JSTestTypedefs.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (203064 => 203065)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-07-11 16:01:04 UTC (rev 203064)
+++ trunk/Source/WebCore/ChangeLog 2016-07-11 16:26:00 UTC (rev 203065)
</span><span class="lines">@@ -1,3 +1,58 @@
</span><ins>+2016-07-11 Nael Ouedraogo <nael.ouedraogo@crf.canon.fr>
+
+ toNative functions in JSDOMBinding.h should take an ExecState reference instead of pointer
+ https://bugs.webkit.org/show_bug.cgi?id=159298
+
+ Reviewed by Youenn Fablet.
+
+ Pass ExecState by reference instead of pointer.
+
+ * bindings/js/IDBBindingUtilities.cpp:
+ (WebCore::idbKeyPathFromValue):
+ * bindings/js/JSBlobCustom.cpp:
+ (WebCore::constructJSBlob):
+ * bindings/js/JSDOMBinding.h: Pass ExecState by reference instead of pointer.
+ (WebCore::toJSSequence):
+ (WebCore::NativeValueTraits<String>::nativeValue):
+ (WebCore::NativeValueTraits<unsigned>::nativeValue):
+ (WebCore::NativeValueTraits<float>::nativeValue):
+ (WebCore::NativeValueTraits<double>::nativeValue):
+ (WebCore::toNativeArray):
+ (WebCore::toNativeArguments):
+ * bindings/js/JSDOMConvert.h:
+ (WebCore::Converter<Vector<T>>::convert):
+ * bindings/js/JSDictionary.cpp:
+ (WebCore::JSDictionary::convertValue):
+ * bindings/js/JSFileCustom.cpp:
+ (WebCore::constructJSFile):
+ * bindings/js/JSMessagePortCustom.cpp:
+ (WebCore::fillMessagePortArray):
+ * bindings/scripts/CodeGeneratorJS.pm:
+ (GenerateParametersCheck):
+ (JSValueToNative):
+ * bindings/scripts/test/JS/JSTestObj.cpp:
+ (WebCore::jsTestObjPrototypeFunctionMethodWithOptionalSequence):
+ (WebCore::jsTestObjPrototypeFunctionMethodWithOptionalArray):
+ (WebCore::jsTestObjPrototypeFunctionMethodWithOptionalArrayIsEmpty):
+ (WebCore::jsTestObjPrototypeFunctionOverloadedMethod7):
+ (WebCore::jsTestObjPrototypeFunctionOverloadedMethod9):
+ (WebCore::jsTestObjPrototypeFunctionOverloadedMethod10):
+ (WebCore::jsTestObjPrototypeFunctionMethodWithUnsignedLongSequence):
+ (WebCore::jsTestObjPrototypeFunctionStringArrayFunction):
+ (WebCore::jsTestObjPrototypeFunctionMethodWithAndWithoutNullableSequence):
+ (WebCore::jsTestObjPrototypeFunctionMethodWithAndWithoutNullableSequence2):
+ (WebCore::jsTestObjPrototypeFunctionStrictFunctionWithSequence):
+ (WebCore::jsTestObjPrototypeFunctionStrictFunctionWithArray):
+ (WebCore::jsTestObjPrototypeFunctionVariadicStringMethod):
+ (WebCore::jsTestObjPrototypeFunctionVariadicDoubleMethod):
+ * bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:
+ (WebCore::constructJSTestOverloadedConstructors5):
+ * bindings/scripts/test/JS/JSTestTypedefs.cpp:
+ (WebCore::jsTestTypedefsPrototypeFunctionFunc):
+ (WebCore::jsTestTypedefsPrototypeFunctionNullableArrayArg):
+ (WebCore::jsTestTypedefsPrototypeFunctionStringArrayFunction):
+ (WebCore::jsTestTypedefsPrototypeFunctionStringArrayFunction2):
+
</ins><span class="cx"> 2016-07-08 Alex Christensen <achristensen@webkit.org>
</span><span class="cx">
</span><span class="cx"> Use refs for ResourceLoaders
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsjsIDBBindingUtilitiescpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/js/IDBBindingUtilities.cpp (203064 => 203065)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/js/IDBBindingUtilities.cpp 2016-07-11 16:01:04 UTC (rev 203064)
+++ trunk/Source/WebCore/bindings/js/IDBBindingUtilities.cpp 2016-07-11 16:26:00 UTC (rev 203065)
</span><span class="lines">@@ -176,7 +176,7 @@
</span><span class="cx"> {
</span><span class="cx"> IDBKeyPath keyPath;
</span><span class="cx"> if (isJSArray(keyPathValue))
</span><del>- keyPath = IDBKeyPath(toNativeArray<String>(&exec, keyPathValue));
</del><ins>+ keyPath = IDBKeyPath(toNativeArray<String>(exec, keyPathValue));
</ins><span class="cx"> else
</span><span class="cx"> keyPath = IDBKeyPath(keyPathValue.toWTFString(&exec));
</span><span class="cx"> return keyPath;
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsjsJSBlobCustomcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/js/JSBlobCustom.cpp (203064 => 203065)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/js/JSBlobCustom.cpp 2016-07-11 16:01:04 UTC (rev 203064)
+++ trunk/Source/WebCore/bindings/js/JSBlobCustom.cpp 2016-07-11 16:26:00 UTC (rev 203065)
</span><span class="lines">@@ -72,7 +72,7 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> unsigned blobPartsLength = 0;
</span><del>- JSObject* blobParts = toJSSequence(&exec, exec.uncheckedArgument(0), blobPartsLength);
</del><ins>+ JSObject* blobParts = toJSSequence(exec, exec.uncheckedArgument(0), blobPartsLength);
</ins><span class="cx"> if (exec.hadException())
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><span class="cx"> ASSERT(blobParts);
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsjsJSDOMBindingh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/js/JSDOMBinding.h (203064 => 203065)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/js/JSDOMBinding.h 2016-07-11 16:01:04 UTC (rev 203064)
+++ trunk/Source/WebCore/bindings/js/JSDOMBinding.h 2016-07-11 16:26:00 UTC (rev 203065)
</span><span class="lines">@@ -247,7 +247,7 @@
</span><span class="cx"> double valueToDate(JSC::ExecState*, JSC::JSValue);
</span><span class="cx">
</span><span class="cx"> // Validates that the passed object is a sequence type per section 4.1.13 of the WebIDL spec.
</span><del>-JSC::JSObject* toJSSequence(JSC::ExecState*, JSC::JSValue, unsigned& length);
</del><ins>+JSC::JSObject* toJSSequence(JSC::ExecState&, JSC::JSValue, unsigned& length);
</ins><span class="cx">
</span><span class="cx"> JSC::JSValue toJS(JSC::ExecState*, JSDOMGlobalObject*, JSC::ArrayBuffer*);
</span><span class="cx"> JSC::JSValue toJS(JSC::ExecState*, JSDOMGlobalObject*, JSC::ArrayBufferView*);
</span><span class="lines">@@ -282,8 +282,8 @@
</span><span class="cx"> RefPtr<JSC::Float64Array> toFloat64Array(JSC::JSValue);
</span><span class="cx">
</span><span class="cx"> template<typename T, typename JSType> Vector<RefPtr<T>> toRefPtrNativeArray(JSC::ExecState*, JSC::JSValue, T* (*)(JSC::JSValue));
</span><del>-template<typename T> Vector<T> toNativeArray(JSC::ExecState*, JSC::JSValue);
-template<typename T> Vector<T> toNativeArguments(JSC::ExecState*, size_t startIndex = 0);
</del><ins>+template<typename T> Vector<T> toNativeArray(JSC::ExecState&, JSC::JSValue);
+template<typename T> Vector<T> toNativeArguments(JSC::ExecState&, size_t startIndex = 0);
</ins><span class="cx">
</span><span class="cx"> bool shouldAllowAccessToNode(JSC::ExecState*, Node*);
</span><span class="cx"> bool shouldAllowAccessToFrame(JSC::ExecState*, Frame*);
</span><span class="lines">@@ -477,25 +477,25 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> // Validates that the passed object is a sequence type per section 4.1.13 of the WebIDL spec.
</span><del>-inline JSC::JSObject* toJSSequence(JSC::ExecState* exec, JSC::JSValue value, unsigned& length)
</del><ins>+inline JSC::JSObject* toJSSequence(JSC::ExecState& exec, JSC::JSValue value, unsigned& length)
</ins><span class="cx"> {
</span><span class="cx"> JSC::JSObject* object = value.getObject();
</span><span class="cx"> if (!object) {
</span><del>- throwSequenceTypeError(*exec);
</del><ins>+ throwSequenceTypeError(exec);
</ins><span class="cx"> return nullptr;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- JSC::JSValue lengthValue = object->get(exec, exec->propertyNames().length);
- if (exec->hadException())
</del><ins>+ JSC::JSValue lengthValue = object->get(&exec, exec.propertyNames().length);
+ if (exec.hadException())
</ins><span class="cx"> return nullptr;
</span><span class="cx">
</span><span class="cx"> if (lengthValue.isUndefinedOrNull()) {
</span><del>- throwSequenceTypeError(*exec);
</del><ins>+ throwSequenceTypeError(exec);
</ins><span class="cx"> return nullptr;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- length = lengthValue.toUInt32(exec);
- if (exec->hadException())
</del><ins>+ length = lengthValue.toUInt32(&exec);
+ if (exec.hadException())
</ins><span class="cx"> return nullptr;
</span><span class="cx">
</span><span class="cx"> return object;
</span><span class="lines">@@ -660,21 +660,21 @@
</span><span class="cx"> template<typename T> struct NativeValueTraits;
</span><span class="cx">
</span><span class="cx"> template<> struct NativeValueTraits<String> {
</span><del>- static inline bool nativeValue(JSC::ExecState* exec, JSC::JSValue jsValue, String& indexedValue)
</del><ins>+ static inline bool nativeValue(JSC::ExecState& exec, JSC::JSValue jsValue, String& indexedValue)
</ins><span class="cx"> {
</span><del>- indexedValue = jsValue.toWTFString(exec);
</del><ins>+ indexedValue = jsValue.toWTFString(&exec);
</ins><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="cx"> };
</span><span class="cx">
</span><span class="cx"> template<> struct NativeValueTraits<unsigned> {
</span><del>- static inline bool nativeValue(JSC::ExecState* exec, JSC::JSValue jsValue, unsigned& indexedValue)
</del><ins>+ static inline bool nativeValue(JSC::ExecState& exec, JSC::JSValue jsValue, unsigned& indexedValue)
</ins><span class="cx"> {
</span><span class="cx"> if (!jsValue.isNumber())
</span><span class="cx"> return false;
</span><span class="cx">
</span><del>- indexedValue = jsValue.toUInt32(exec);
- if (exec->hadException())
</del><ins>+ indexedValue = jsValue.toUInt32(&exec);
+ if (exec.hadException())
</ins><span class="cx"> return false;
</span><span class="cx">
</span><span class="cx"> return true;
</span><span class="lines">@@ -682,18 +682,18 @@
</span><span class="cx"> };
</span><span class="cx">
</span><span class="cx"> template<> struct NativeValueTraits<float> {
</span><del>- static inline bool nativeValue(JSC::ExecState* exec, JSC::JSValue jsValue, float& indexedValue)
</del><ins>+ static inline bool nativeValue(JSC::ExecState& exec, JSC::JSValue jsValue, float& indexedValue)
</ins><span class="cx"> {
</span><del>- indexedValue = jsValue.toFloat(exec);
- return !exec->hadException();
</del><ins>+ indexedValue = jsValue.toFloat(&exec);
+ return !exec.hadException();
</ins><span class="cx"> }
</span><span class="cx"> };
</span><span class="cx">
</span><span class="cx"> template<> struct NativeValueTraits<double> {
</span><del>- static inline bool nativeValue(JSC::ExecState* exec, JSC::JSValue jsValue, double& indexedValue)
</del><ins>+ static inline bool nativeValue(JSC::ExecState& exec, JSC::JSValue jsValue, double& indexedValue)
</ins><span class="cx"> {
</span><del>- indexedValue = jsValue.toNumber(exec);
- return !exec->hadException();
</del><ins>+ indexedValue = jsValue.toNumber(&exec);
+ return !exec.hadException();
</ins><span class="cx"> }
</span><span class="cx"> };
</span><span class="cx">
</span><span class="lines">@@ -718,7 +718,7 @@
</span><span class="cx"> return result;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-template<typename T> Vector<T> toNativeArray(JSC::ExecState* exec, JSC::JSValue value)
</del><ins>+template<typename T> Vector<T> toNativeArray(JSC::ExecState& exec, JSC::JSValue value)
</ins><span class="cx"> {
</span><span class="cx"> JSC::JSObject* object = value.getObject();
</span><span class="cx"> if (!object)
</span><span class="lines">@@ -737,7 +737,7 @@
</span><span class="cx">
</span><span class="cx"> for (unsigned i = 0; i < length; ++i) {
</span><span class="cx"> T indexValue;
</span><del>- if (!TraitsType::nativeValue(exec, object->get(exec, i), indexValue))
</del><ins>+ if (!TraitsType::nativeValue(exec, object->get(&exec, i), indexValue))
</ins><span class="cx"> return Vector<T>();
</span><span class="cx"> result.uncheckedAppend(indexValue);
</span><span class="cx"> }
</span><span class="lines">@@ -744,9 +744,9 @@
</span><span class="cx"> return result;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-template<typename T> Vector<T> toNativeArguments(JSC::ExecState* exec, size_t startIndex)
</del><ins>+template<typename T> Vector<T> toNativeArguments(JSC::ExecState& exec, size_t startIndex)
</ins><span class="cx"> {
</span><del>- size_t length = exec->argumentCount();
</del><ins>+ size_t length = exec.argumentCount();
</ins><span class="cx"> ASSERT(startIndex <= length);
</span><span class="cx">
</span><span class="cx"> Vector<T> result;
</span><span class="lines">@@ -755,7 +755,7 @@
</span><span class="cx">
</span><span class="cx"> for (size_t i = startIndex; i < length; ++i) {
</span><span class="cx"> T indexValue;
</span><del>- if (!TraitsType::nativeValue(exec, exec->argument(i), indexValue))
</del><ins>+ if (!TraitsType::nativeValue(exec, exec.uncheckedArgument(i), indexValue))
</ins><span class="cx"> return Vector<T>();
</span><span class="cx"> result.uncheckedAppend(indexValue);
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsjsJSDOMConverth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/js/JSDOMConvert.h (203064 => 203065)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/js/JSDOMConvert.h 2016-07-11 16:01:04 UTC (rev 203064)
+++ trunk/Source/WebCore/bindings/js/JSDOMConvert.h 2016-07-11 16:26:00 UTC (rev 203065)
</span><span class="lines">@@ -122,7 +122,7 @@
</span><span class="cx"> static Vector<T> convert(JSC::ExecState& state, JSC::JSValue value)
</span><span class="cx"> {
</span><span class="cx"> // FIXME: The toNativeArray function doesn't throw a type error if the value is not an object. Is that OK?
</span><del>- return toNativeArray<T>(&state, value);
</del><ins>+ return toNativeArray<T>(state, value);
</ins><span class="cx"> }
</span><span class="cx"> };
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsjsJSDictionarycpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/js/JSDictionary.cpp (203064 => 203065)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/js/JSDictionary.cpp 2016-07-11 16:01:04 UTC (rev 203064)
+++ trunk/Source/WebCore/bindings/js/JSDictionary.cpp 2016-07-11 16:26:00 UTC (rev 203065)
</span><span class="lines">@@ -149,11 +149,12 @@
</span><span class="cx">
</span><span class="cx"> void JSDictionary::convertValue(ExecState* exec, JSValue value, Vector<String>& result)
</span><span class="cx"> {
</span><ins>+ ASSERT(exec);
</ins><span class="cx"> if (value.isUndefinedOrNull())
</span><span class="cx"> return;
</span><span class="cx">
</span><span class="cx"> unsigned length = 0;
</span><del>- JSObject* object = toJSSequence(exec, value, length);
</del><ins>+ JSObject* object = toJSSequence(*exec, value, length);
</ins><span class="cx"> if (exec->hadException())
</span><span class="cx"> return;
</span><span class="cx">
</span><span class="lines">@@ -210,6 +211,7 @@
</span><span class="cx">
</span><span class="cx"> void JSDictionary::convertValue(ExecState* exec, JSValue value, HashSet<AtomicString>& result)
</span><span class="cx"> {
</span><ins>+ ASSERT(exec);
</ins><span class="cx"> result.clear();
</span><span class="cx">
</span><span class="cx"> if (value.isUndefinedOrNull())
</span><span class="lines">@@ -216,7 +218,7 @@
</span><span class="cx"> return;
</span><span class="cx">
</span><span class="cx"> unsigned length = 0;
</span><del>- JSObject* object = toJSSequence(exec, value, length);
</del><ins>+ JSObject* object = toJSSequence(*exec, value, length);
</ins><span class="cx"> if (exec->hadException())
</span><span class="cx"> return;
</span><span class="cx">
</span><span class="lines">@@ -280,11 +282,12 @@
</span><span class="cx">
</span><span class="cx"> void JSDictionary::convertValue(ExecState* exec, JSValue value, Vector<RefPtr<MediaStream>>& result)
</span><span class="cx"> {
</span><ins>+ ASSERT(exec);
</ins><span class="cx"> if (value.isUndefinedOrNull())
</span><span class="cx"> return;
</span><span class="cx">
</span><span class="cx"> unsigned length = 0;
</span><del>- JSObject* object = toJSSequence(exec, value, length);
</del><ins>+ JSObject* object = toJSSequence(*exec, value, length);
</ins><span class="cx"> if (exec->hadException())
</span><span class="cx"> return;
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsjsJSFileCustomcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/js/JSFileCustom.cpp (203064 => 203065)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/js/JSFileCustom.cpp 2016-07-11 16:01:04 UTC (rev 203064)
+++ trunk/Source/WebCore/bindings/js/JSFileCustom.cpp 2016-07-11 16:26:00 UTC (rev 203065)
</span><span class="lines">@@ -52,7 +52,7 @@
</span><span class="cx"> return throwVMTypeError(&exec, ASCIILiteral("First argument to File constructor must be a valid sequence, was undefined or null"));
</span><span class="cx">
</span><span class="cx"> unsigned blobPartsLength = 0;
</span><del>- JSObject* blobParts = toJSSequence(&exec, arg, blobPartsLength);
</del><ins>+ JSObject* blobParts = toJSSequence(exec, arg, blobPartsLength);
</ins><span class="cx"> if (exec.hadException())
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><span class="cx"> ASSERT(blobParts);
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsjsJSMessagePortCustomcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/js/JSMessagePortCustom.cpp (203064 => 203065)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/js/JSMessagePortCustom.cpp 2016-07-11 16:01:04 UTC (rev 203064)
+++ trunk/Source/WebCore/bindings/js/JSMessagePortCustom.cpp 2016-07-11 16:26:00 UTC (rev 203065)
</span><span class="lines">@@ -69,7 +69,7 @@
</span><span class="cx">
</span><span class="cx"> // Validation of sequence types, per WebIDL spec 4.1.13.
</span><span class="cx"> unsigned length = 0;
</span><del>- JSObject* object = toJSSequence(&state, value, length);
</del><ins>+ JSObject* object = toJSSequence(state, value, length);
</ins><span class="cx"> if (state.hadException())
</span><span class="cx"> return;
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsscriptsCodeGeneratorJSpm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm (203064 => 203065)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm 2016-07-11 16:01:04 UTC (rev 203064)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm 2016-07-11 16:26:00 UTC (rev 203065)
</span><span class="lines">@@ -3717,7 +3717,7 @@
</span><span class="cx"> push(@$outputArray, " $name.uncheckedAppend(item);\n");
</span><span class="cx"> push(@$outputArray, " }\n")
</span><span class="cx"> } else {
</span><del>- push(@$outputArray, " Vector<$nativeElementType> $name = toNativeArguments<$nativeElementType>(state, $argumentIndex);\n");
</del><ins>+ push(@$outputArray, " Vector<$nativeElementType> $name = toNativeArguments<$nativeElementType>(*state, $argumentIndex);\n");
</ins><span class="cx"> push(@$outputArray, " if (UNLIKELY(state->hadException()))\n");
</span><span class="cx"> push(@$outputArray, " return JSValue::encode(jsUndefined());\n");
</span><span class="cx"> }
</span><span class="lines">@@ -4454,7 +4454,7 @@
</span><span class="cx"> AddToImplIncludes("JS${arrayOrSequenceType}.h");
</span><span class="cx"> return ("(toRefPtrNativeArray<${arrayOrSequenceType}, JS${arrayOrSequenceType}>(state, $value, &JS${arrayOrSequenceType}::toWrapped))", 1);
</span><span class="cx"> }
</span><del>- return ("toNativeArray<" . GetNativeVectorInnerType($arrayOrSequenceType) . ">(state, $value)", 1);
</del><ins>+ return ("toNativeArray<" . GetNativeVectorInnerType($arrayOrSequenceType) . ">(*state, $value)", 1);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> return ($value, 0) if $type eq "any";
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsscriptstestJSJSTestObjcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp (203064 => 203065)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp 2016-07-11 16:01:04 UTC (rev 203064)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp 2016-07-11 16:26:00 UTC (rev 203065)
</span><span class="lines">@@ -4904,7 +4904,7 @@
</span><span class="cx"> return throwThisTypeError(*state, "TestObj", "methodWithOptionalSequence");
</span><span class="cx"> ASSERT_GC_OBJECT_INHERITS(castedThis, JSTestObj::info());
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><del>- auto sequence = toNativeArray<String>(state, state->argument(0));
</del><ins>+ auto sequence = toNativeArray<String>(*state, state->argument(0));
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><span class="cx"> impl.methodWithOptionalSequence(WTFMove(sequence));
</span><span class="lines">@@ -4979,7 +4979,7 @@
</span><span class="cx"> return throwThisTypeError(*state, "TestObj", "methodWithOptionalArray");
</span><span class="cx"> ASSERT_GC_OBJECT_INHERITS(castedThis, JSTestObj::info());
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><del>- auto array = state->argument(0).isUndefined() ? Optional<Vector<String>>() : toNativeArray<String>(state, state->uncheckedArgument(0));
</del><ins>+ auto array = state->argument(0).isUndefined() ? Optional<Vector<String>>() : toNativeArray<String>(*state, state->uncheckedArgument(0));
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><span class="cx"> impl.methodWithOptionalArray(WTFMove(array));
</span><span class="lines">@@ -4994,7 +4994,7 @@
</span><span class="cx"> return throwThisTypeError(*state, "TestObj", "methodWithOptionalArrayIsEmpty");
</span><span class="cx"> ASSERT_GC_OBJECT_INHERITS(castedThis, JSTestObj::info());
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><del>- auto array = toNativeArray<String>(state, state->argument(0));
</del><ins>+ auto array = toNativeArray<String>(*state, state->argument(0));
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><span class="cx"> impl.methodWithOptionalArrayIsEmpty(WTFMove(array));
</span><span class="lines">@@ -5377,7 +5377,7 @@
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><span class="cx"> if (UNLIKELY(state->argumentCount() < 1))
</span><span class="cx"> return throwVMError(state, createNotEnoughArgumentsError(state));
</span><del>- auto arrayArg = toNativeArray<String>(state, state->argument(0));
</del><ins>+ auto arrayArg = toNativeArray<String>(*state, state->argument(0));
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><span class="cx"> impl.overloadedMethod(WTFMove(arrayArg));
</span><span class="lines">@@ -5411,7 +5411,7 @@
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><span class="cx"> if (UNLIKELY(state->argumentCount() < 1))
</span><span class="cx"> return throwVMError(state, createNotEnoughArgumentsError(state));
</span><del>- auto arrayArg = toNativeArray<String>(state, state->argument(0));
</del><ins>+ auto arrayArg = toNativeArray<String>(*state, state->argument(0));
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><span class="cx"> impl.overloadedMethod(WTFMove(arrayArg));
</span><span class="lines">@@ -5428,7 +5428,7 @@
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><span class="cx"> if (UNLIKELY(state->argumentCount() < 1))
</span><span class="cx"> return throwVMError(state, createNotEnoughArgumentsError(state));
</span><del>- auto arrayArg = toNativeArray<uint32_t>(state, state->argument(0));
</del><ins>+ auto arrayArg = toNativeArray<uint32_t>(*state, state->argument(0));
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><span class="cx"> impl.overloadedMethod(WTFMove(arrayArg));
</span><span class="lines">@@ -5674,7 +5674,7 @@
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><span class="cx"> if (UNLIKELY(state->argumentCount() < 1))
</span><span class="cx"> return throwVMError(state, createNotEnoughArgumentsError(state));
</span><del>- auto unsignedLongSequence = toNativeArray<uint32_t>(state, state->argument(0));
</del><ins>+ auto unsignedLongSequence = toNativeArray<uint32_t>(*state, state->argument(0));
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><span class="cx"> impl.methodWithUnsignedLongSequence(WTFMove(unsignedLongSequence));
</span><span class="lines">@@ -5692,7 +5692,7 @@
</span><span class="cx"> if (UNLIKELY(state->argumentCount() < 1))
</span><span class="cx"> return throwVMError(state, createNotEnoughArgumentsError(state));
</span><span class="cx"> ExceptionCode ec = 0;
</span><del>- auto values = toNativeArray<String>(state, state->argument(0));
</del><ins>+ auto values = toNativeArray<String>(*state, state->argument(0));
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><span class="cx"> JSValue result = jsArray(state, castedThis->globalObject(), impl.stringArrayFunction(WTFMove(values), ec));
</span><span class="lines">@@ -5733,10 +5733,10 @@
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><span class="cx"> if (UNLIKELY(state->argumentCount() < 2))
</span><span class="cx"> return throwVMError(state, createNotEnoughArgumentsError(state));
</span><del>- auto arrayArg = toNativeArray<uint32_t>(state, state->argument(0));
</del><ins>+ auto arrayArg = toNativeArray<uint32_t>(*state, state->argument(0));
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><del>- auto nullableArrayArg = toNativeArray<uint32_t>(state, state->argument(1));
</del><ins>+ auto nullableArrayArg = toNativeArray<uint32_t>(*state, state->argument(1));
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><span class="cx"> impl.methodWithAndWithoutNullableSequence(WTFMove(arrayArg), WTFMove(nullableArrayArg));
</span><span class="lines">@@ -5753,10 +5753,10 @@
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><span class="cx"> if (UNLIKELY(state->argumentCount() < 2))
</span><span class="cx"> return throwVMError(state, createNotEnoughArgumentsError(state));
</span><del>- auto arrayArg = toNativeArray<uint32_t>(state, state->argument(0));
</del><ins>+ auto arrayArg = toNativeArray<uint32_t>(*state, state->argument(0));
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><del>- auto nullableArrayArg = toNativeArray<uint32_t>(state, state->argument(1));
</del><ins>+ auto nullableArrayArg = toNativeArray<uint32_t>(*state, state->argument(1));
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><span class="cx"> impl.methodWithAndWithoutNullableSequence2(WTFMove(arrayArg), WTFMove(nullableArrayArg));
</span><span class="lines">@@ -5942,7 +5942,7 @@
</span><span class="cx"> if (UNLIKELY(!objArg))
</span><span class="cx"> return throwArgumentTypeError(*state, 0, "objArg", "TestObj", "strictFunctionWithSequence", "TestObj");
</span><span class="cx"> }
</span><del>- auto a = toNativeArray<uint32_t>(state, state->argument(1));
</del><ins>+ auto a = toNativeArray<uint32_t>(*state, state->argument(1));
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><span class="cx"> JSValue result = jsBoolean(impl.strictFunctionWithSequence(objArg, WTFMove(a), ec));
</span><span class="lines">@@ -5965,7 +5965,7 @@
</span><span class="cx"> auto objArg = JSTestObj::toWrapped(state->argument(0));
</span><span class="cx"> if (UNLIKELY(!objArg))
</span><span class="cx"> return throwArgumentTypeError(*state, 0, "objArg", "TestObj", "strictFunctionWithArray", "TestObj");
</span><del>- auto array = toNativeArray<int32_t>(state, state->argument(1));
</del><ins>+ auto array = toNativeArray<int32_t>(*state, state->argument(1));
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><span class="cx"> JSValue result = jsBoolean(impl.strictFunctionWithArray(*objArg, WTFMove(array), ec));
</span><span class="lines">@@ -5987,7 +5987,7 @@
</span><span class="cx"> auto head = state->argument(0).toWTFString(state);
</span><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><del>- Vector<String> tail = toNativeArguments<String>(state, 1);
</del><ins>+ Vector<String> tail = toNativeArguments<String>(*state, 1);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><span class="cx"> impl.variadicStringMethod(WTFMove(head), WTFMove(tail));
</span><span class="lines">@@ -6007,7 +6007,7 @@
</span><span class="cx"> auto head = convert<double>(*state, state->argument(0), ShouldAllowNonFinite::Yes);
</span><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><del>- Vector<double> tail = toNativeArguments<double>(state, 1);
</del><ins>+ Vector<double> tail = toNativeArguments<double>(*state, 1);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><span class="cx"> impl.variadicDoubleMethod(WTFMove(head), WTFMove(tail));
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsscriptstestJSJSTestOverloadedConstructorscpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp (203064 => 203065)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp 2016-07-11 16:01:04 UTC (rev 203064)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp 2016-07-11 16:26:00 UTC (rev 203065)
</span><span class="lines">@@ -120,7 +120,7 @@
</span><span class="cx"> static inline EncodedJSValue constructJSTestOverloadedConstructors5(ExecState* state)
</span><span class="cx"> {
</span><span class="cx"> auto* castedThis = jsCast<JSTestOverloadedConstructorsConstructor*>(state->callee());
</span><del>- Vector<int32_t> longArgs = toNativeArguments<int32_t>(state, 0);
</del><ins>+ Vector<int32_t> longArgs = toNativeArguments<int32_t>(*state, 0);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><span class="cx"> auto object = TestOverloadedConstructors::create(longArgs);
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsscriptstestJSJSTestTypedefscpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestTypedefs.cpp (203064 => 203065)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestTypedefs.cpp 2016-07-11 16:01:04 UTC (rev 203064)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestTypedefs.cpp 2016-07-11 16:26:00 UTC (rev 203065)
</span><span class="lines">@@ -455,7 +455,7 @@
</span><span class="cx"> return throwThisTypeError(*state, "TestTypedefs", "func");
</span><span class="cx"> ASSERT_GC_OBJECT_INHERITS(castedThis, JSTestTypedefs::info());
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><del>- auto x = toNativeArray<int32_t>(state, state->argument(0));
</del><ins>+ auto x = toNativeArray<int32_t>(*state, state->argument(0));
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><span class="cx"> impl.func(WTFMove(x));
</span><span class="lines">@@ -518,7 +518,7 @@
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><span class="cx"> if (UNLIKELY(state->argumentCount() < 1))
</span><span class="cx"> return throwVMError(state, createNotEnoughArgumentsError(state));
</span><del>- auto arrayArg = toNativeArray<String>(state, state->argument(0));
</del><ins>+ auto arrayArg = toNativeArray<String>(*state, state->argument(0));
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><span class="cx"> impl.nullableArrayArg(WTFMove(arrayArg));
</span><span class="lines">@@ -568,7 +568,7 @@
</span><span class="cx"> if (UNLIKELY(state->argumentCount() < 1))
</span><span class="cx"> return throwVMError(state, createNotEnoughArgumentsError(state));
</span><span class="cx"> ExceptionCode ec = 0;
</span><del>- auto values = toNativeArray<String>(state, state->argument(0));
</del><ins>+ auto values = toNativeArray<String>(*state, state->argument(0));
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><span class="cx"> JSValue result = jsArray(state, castedThis->globalObject(), impl.stringArrayFunction(WTFMove(values), ec));
</span><span class="lines">@@ -588,7 +588,7 @@
</span><span class="cx"> if (UNLIKELY(state->argumentCount() < 1))
</span><span class="cx"> return throwVMError(state, createNotEnoughArgumentsError(state));
</span><span class="cx"> ExceptionCode ec = 0;
</span><del>- auto values = toNativeArray<String>(state, state->argument(0));
</del><ins>+ auto values = toNativeArray<String>(*state, state->argument(0));
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><span class="cx"> JSValue result = jsArray(state, castedThis->globalObject(), impl.stringArrayFunction2(WTFMove(values), ec));
</span></span></pre>
</div>
</div>
</body>
</html>