<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[203018] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/203018">203018</a></dd>
<dt>Author</dt> <dd>cdumez@apple.com</dd>
<dt>Date</dt> <dd>2016-07-08 19:24:27 -0700 (Fri, 08 Jul 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>adoptNode() changes css class to lowercase for document loaded with XHR responseType = "document"
https://bugs.webkit.org/show_bug.cgi?id=159555
<rdar://problem/27252541>
Reviewed by Ryosuke Niwa.
Source/WebCore:
When adopting an Element from another document which has a different quirks mode,
case-sensitivity for id and class attributes differs and we need to correctly
update members such as ElementData::m_classNames or ElementData::m_idForStyleResolution.
To address the issue, have Element override didMoveToNewDocument() and call
attributeChanged() for id and class attributes.
Test: fast/dom/Document/adoptNode-quirks-mismatch.html
* dom/Element.cpp:
(WebCore::Element::didMoveToNewDocument):
* dom/Element.h:
LayoutTests:
Add test coverage for id and class attributes.
* fast/dom/Document/adoptNode-quirks-mismatch-expected.txt: Added.
* fast/dom/Document/adoptNode-quirks-mismatch.html: Added.
* fast/dom/Document/resources/document-quirks-class.html: Added.
* fast/dom/Document/resources/document-quirks-id.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoredomElementcpp">trunk/Source/WebCore/dom/Element.cpp</a></li>
<li><a href="#trunkSourceWebCoredomElementh">trunk/Source/WebCore/dom/Element.h</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsfastdomDocumentadoptNodequirksmismatchexpectedtxt">trunk/LayoutTests/fast/dom/Document/adoptNode-quirks-mismatch-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastdomDocumentadoptNodequirksmismatchhtml">trunk/LayoutTests/fast/dom/Document/adoptNode-quirks-mismatch.html</a></li>
<li><a href="#trunkLayoutTestsfastdomDocumentresourcesdocumentquirksclasshtml">trunk/LayoutTests/fast/dom/Document/resources/document-quirks-class.html</a></li>
<li><a href="#trunkLayoutTestsfastdomDocumentresourcesdocumentquirksidhtml">trunk/LayoutTests/fast/dom/Document/resources/document-quirks-id.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (203017 => 203018)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2016-07-09 02:24:23 UTC (rev 203017)
+++ trunk/LayoutTests/ChangeLog 2016-07-09 02:24:27 UTC (rev 203018)
</span><span class="lines">@@ -1,3 +1,18 @@
</span><ins>+2016-07-08 Chris Dumez <cdumez@apple.com>
+
+ adoptNode() changes css class to lowercase for document loaded with XHR responseType = "document"
+ https://bugs.webkit.org/show_bug.cgi?id=159555
+ <rdar://problem/27252541>
+
+ Reviewed by Ryosuke Niwa.
+
+ Add test coverage for id and class attributes.
+
+ * fast/dom/Document/adoptNode-quirks-mismatch-expected.txt: Added.
+ * fast/dom/Document/adoptNode-quirks-mismatch.html: Added.
+ * fast/dom/Document/resources/document-quirks-class.html: Added.
+ * fast/dom/Document/resources/document-quirks-id.html: Added.
+
</ins><span class="cx"> 2016-07-08 Daniel Bates <dabates@apple.com>
</span><span class="cx">
</span><span class="cx"> Setting table.tFoot or calling table.createTFoot() should append HTML tfont element to the end of the table
</span></span></pre></div>
<a id="trunkLayoutTestsfastdomDocumentadoptNodequirksmismatchexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/dom/Document/adoptNode-quirks-mismatch-expected.txt (0 => 203018)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/dom/Document/adoptNode-quirks-mismatch-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/dom/Document/adoptNode-quirks-mismatch-expected.txt 2016-07-09 02:24:27 UTC (rev 203018)
</span><span class="lines">@@ -0,0 +1,14 @@
</span><ins>+Tests that Document.adoptNode() properly deals with the documents having a different quirks mode
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+MyClass
+
+MyId
+
+PASS window.getComputedStyle(container.lastChild).color is "rgb(0, 128, 0)"
+PASS window.getComputedStyle(container.lastChild).color is "rgb(0, 128, 0)"
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
</ins></span></pre></div>
<a id="trunkLayoutTestsfastdomDocumentadoptNodequirksmismatchhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/dom/Document/adoptNode-quirks-mismatch.html (0 => 203018)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/dom/Document/adoptNode-quirks-mismatch.html (rev 0)
+++ trunk/LayoutTests/fast/dom/Document/adoptNode-quirks-mismatch.html 2016-07-09 02:24:27 UTC (rev 203018)
</span><span class="lines">@@ -0,0 +1,68 @@
</span><ins>+<!DOCTYPE html>
+<html>
+<head>
+<script src="../../../resources/js-test-pre.js"></script>
+<style>
+
+.myClass, #myId
+{
+ color: green;
+ font-weight: bold;
+}
+
+.myclass, #myid
+{
+ color: red;
+ font-weight: bold;
+}
+
+.myclass::after, #myid::after
+{
+ content: " (this should have been green!)";
+}
+</style>
+</head>
+<body>
+<div id="description"></div>
+<div id="container"></div>
+<div id="console"></div>
+<script>
+description("Tests that Document.adoptNode() properly deals with the documents having a different quirks mode");
+jsTestIsAsync = true;
+
+var tests = ["resources/document-quirks-class.html", "resources/document-quirks-id.html"];
+var currentTest = -1;
+
+function documentLoaded()
+{
+ var parsedBodyChild = this.response.body.children[0];
+
+ var container = document.getElementById("container");
+ container.appendChild(document.adoptNode(parsedBodyChild));
+
+ shouldBeEqualToString("window.getComputedStyle(container.lastChild).color", "rgb(0, 128, 0)");
+
+ runNextTest();
+}
+
+function runNextTest()
+{
+ currentTest++;
+ if (currentTest >= tests.length) {
+ finishJSTest();
+ return;
+ }
+
+ var xhr = new XMLHttpRequest();
+ xhr.responseType = "document";
+ xhr.addEventListener("load", documentLoaded);
+ xhr.open("GET", tests[currentTest], true);
+
+ xhr.send();
+}
+
+runNextTest();
+</script>
+<script src="../../../resources/js-test-post.js"></script>
+</body>
+</html>
</ins></span></pre></div>
<a id="trunkLayoutTestsfastdomDocumentresourcesdocumentquirksclasshtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/dom/Document/resources/document-quirks-class.html (0 => 203018)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/dom/Document/resources/document-quirks-class.html (rev 0)
+++ trunk/LayoutTests/fast/dom/Document/resources/document-quirks-class.html 2016-07-09 02:24:27 UTC (rev 203018)
</span><span class="lines">@@ -0,0 +1,7 @@
</span><ins>+<html>
+<body>
+<div class="myClass">
+<p>MyClass</p>
+</div>
+</body>
+</html>
</ins></span></pre></div>
<a id="trunkLayoutTestsfastdomDocumentresourcesdocumentquirksidhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/dom/Document/resources/document-quirks-id.html (0 => 203018)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/dom/Document/resources/document-quirks-id.html (rev 0)
+++ trunk/LayoutTests/fast/dom/Document/resources/document-quirks-id.html 2016-07-09 02:24:27 UTC (rev 203018)
</span><span class="lines">@@ -0,0 +1,7 @@
</span><ins>+<html>
+<body>
+<div id="myId">
+<p>MyId</p>
+</div>
+</body>
+</html>
</ins></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (203017 => 203018)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-07-09 02:24:23 UTC (rev 203017)
+++ trunk/Source/WebCore/ChangeLog 2016-07-09 02:24:27 UTC (rev 203018)
</span><span class="lines">@@ -1,3 +1,24 @@
</span><ins>+2016-07-08 Chris Dumez <cdumez@apple.com>
+
+ adoptNode() changes css class to lowercase for document loaded with XHR responseType = "document"
+ https://bugs.webkit.org/show_bug.cgi?id=159555
+ <rdar://problem/27252541>
+
+ Reviewed by Ryosuke Niwa.
+
+ When adopting an Element from another document which has a different quirks mode,
+ case-sensitivity for id and class attributes differs and we need to correctly
+ update members such as ElementData::m_classNames or ElementData::m_idForStyleResolution.
+
+ To address the issue, have Element override didMoveToNewDocument() and call
+ attributeChanged() for id and class attributes.
+
+ Test: fast/dom/Document/adoptNode-quirks-mismatch.html
+
+ * dom/Element.cpp:
+ (WebCore::Element::didMoveToNewDocument):
+ * dom/Element.h:
+
</ins><span class="cx"> 2016-07-08 Daniel Bates <dabates@apple.com>
</span><span class="cx">
</span><span class="cx"> Cleanup: Remove use of PassRefPtr from class HTMLTableElement
</span></span></pre></div>
<a id="trunkSourceWebCoredomElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Element.cpp (203017 => 203018)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Element.cpp 2016-07-09 02:24:23 UTC (rev 203017)
+++ trunk/Source/WebCore/dom/Element.cpp 2016-07-09 02:24:27 UTC (rev 203018)
</span><span class="lines">@@ -1454,6 +1454,19 @@
</span><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+void Element::didMoveToNewDocument(Document* oldDocument)
+{
+ Node::didMoveToNewDocument(oldDocument);
+
+ if (oldDocument->inQuirksMode() && !document().inQuirksMode()) {
+ // ElementData::m_classNames or ElementData::m_idForStyleResolution have folded case, we need to update them.
+ if (hasID())
+ attributeChanged(idAttr, nullAtom, getIdAttribute());
+ if (hasClass())
+ attributeChanged(classAttr, nullAtom, getAttribute(classAttr));
+ }
+}
+
</ins><span class="cx"> bool Element::hasAttributes() const
</span><span class="cx"> {
</span><span class="cx"> synchronizeAllAttributes();
</span></span></pre></div>
<a id="trunkSourceWebCoredomElementh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Element.h (203017 => 203018)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Element.h 2016-07-09 02:24:23 UTC (rev 203017)
+++ trunk/Source/WebCore/dom/Element.h 2016-07-09 02:24:27 UTC (rev 203018)
</span><span class="lines">@@ -537,6 +537,7 @@
</span><span class="cx"> void childrenChanged(const ChildChange&) override;
</span><span class="cx"> void removeAllEventListeners() final;
</span><span class="cx"> virtual void parserDidSetAttributes();
</span><ins>+ void didMoveToNewDocument(Document*) override;
</ins><span class="cx">
</span><span class="cx"> void clearTabIndexExplicitlyIfNeeded();
</span><span class="cx"> void setTabIndexExplicitly(int);
</span></span></pre>
</div>
</div>
</body>
</html>