<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[203009] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/203009">203009</a></dd>
<dt>Author</dt> <dd>dbates@webkit.org</dd>
<dt>Date</dt> <dd>2016-07-08 17:04:32 -0700 (Fri, 08 Jul 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Setting table.tFoot or calling table.createTFoot() should append HTML tfont element to the end of the table
https://bugs.webkit.org/show_bug.cgi?id=159583
<rdar://problem/27255292>
Reviewed by Chris Dumez.
LayoutTests/imported/w3c:
Update expected result now that we append the HTML tfoot element to the end of the table.
* web-platform-tests/html/semantics/tabular-data/the-table-element/tFoot-expected.txt:
Source/WebCore:
he HTML standard has long since been revised to describe that assignment to property table.tFoot
or invoking table.createTFoot() will append the HTML tfoot element to the end of the table. This
behavior is defined in <https://html.spec.whatwg.org/multipage/tables.html#dom-table-tfoot> (8 July 2016)
and <https://html.spec.whatwg.org/multipage/tables.html#dom-table-createtfoot> for the property
table.tFoot and table.createTFoot(), respectively. This change makes our behavior match the
behavior in Mozilla Firefox, Microsoft Edge, Microsoft Internet Explorer 8 and later.
* html/HTMLTableElement.cpp:
(WebCore::HTMLTableElement::setTFoot): Append <tfoot> to the end of the table. Use RefPtr<>&& instead of PassRefPtr.
(WebCore::HTMLTableElement::createTFoot): Use RefPtr<>&& instead of PassRefPtr.
* html/HTMLTableElement.h:
LayoutTests:
Update expected results now that we append the HTML tfoot element to the end of the table.
* platform/efl/tables/mozilla/bugs/bug30418-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug30418-expected.txt:
* platform/ios-simulator/tables/mozilla/bugs/bug30418-expected.txt:
* platform/mac/tables/mozilla/bugs/bug30418-expected.txt:
* platform/win/tables/mozilla/bugs/bug30418-expected.txt:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsimportedw3cChangeLog">trunk/LayoutTests/imported/w3c/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestshtmlsemanticstabulardatathetableelementtFootexpectedtxt">trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/tabular-data/the-table-element/tFoot-expected.txt</a></li>
<li><a href="#trunkLayoutTestsplatformefltablesmozillabugsbug30418expectedtxt">trunk/LayoutTests/platform/efl/tables/mozilla/bugs/bug30418-expected.txt</a></li>
<li><a href="#trunkLayoutTestsplatformgtktablesmozillabugsbug30418expectedtxt">trunk/LayoutTests/platform/gtk/tables/mozilla/bugs/bug30418-expected.txt</a></li>
<li><a href="#trunkLayoutTestsplatformiossimulatortablesmozillabugsbug30418expectedtxt">trunk/LayoutTests/platform/ios-simulator/tables/mozilla/bugs/bug30418-expected.txt</a></li>
<li><a href="#trunkLayoutTestsplatformmactablesmozillabugsbug30418expectedtxt">trunk/LayoutTests/platform/mac/tables/mozilla/bugs/bug30418-expected.txt</a></li>
<li><a href="#trunkLayoutTestsplatformwintablesmozillabugsbug30418expectedtxt">trunk/LayoutTests/platform/win/tables/mozilla/bugs/bug30418-expected.txt</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLTableElementcpp">trunk/Source/WebCore/html/HTMLTableElement.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLTableElementh">trunk/Source/WebCore/html/HTMLTableElement.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (203008 => 203009)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2016-07-08 23:49:15 UTC (rev 203008)
+++ trunk/LayoutTests/ChangeLog 2016-07-09 00:04:32 UTC (rev 203009)
</span><span class="lines">@@ -1,3 +1,19 @@
</span><ins>+2016-07-08 Daniel Bates <dabates@apple.com>
+
+ Setting table.tFoot or calling table.createTFoot() should append HTML tfont element to the end of the table
+ https://bugs.webkit.org/show_bug.cgi?id=159583
+ <rdar://problem/27255292>
+
+ Reviewed by Chris Dumez.
+
+ Update expected results now that we append the HTML tfoot element to the end of the table.
+
+ * platform/efl/tables/mozilla/bugs/bug30418-expected.txt:
+ * platform/gtk/tables/mozilla/bugs/bug30418-expected.txt:
+ * platform/ios-simulator/tables/mozilla/bugs/bug30418-expected.txt:
+ * platform/mac/tables/mozilla/bugs/bug30418-expected.txt:
+ * platform/win/tables/mozilla/bugs/bug30418-expected.txt:
+
</ins><span class="cx"> 2016-07-08 Chris Dumez <cdumez@apple.com>
</span><span class="cx">
</span><span class="cx"> Object.defineProperty() should maintain existing getter / setter if not overridden in the new descriptor
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/ChangeLog (203008 => 203009)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/ChangeLog 2016-07-08 23:49:15 UTC (rev 203008)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2016-07-09 00:04:32 UTC (rev 203009)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2016-07-08 Daniel Bates <dabates@apple.com>
+
+ Setting table.tFoot or calling table.createTFoot() should append HTML tfont element to the end of the table
+ https://bugs.webkit.org/show_bug.cgi?id=159583
+ <rdar://problem/27255292>
+
+ Reviewed by Chris Dumez.
+
+ Update expected result now that we append the HTML tfoot element to the end of the table.
+
+ * web-platform-tests/html/semantics/tabular-data/the-table-element/tFoot-expected.txt:
+
</ins><span class="cx"> 2016-07-07 Chris Dumez <cdumez@apple.com>
</span><span class="cx">
</span><span class="cx"> tdody.deleteRow(-1) and tr.deleteCell(-1) should not throw when there are no rows / cells
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestshtmlsemanticstabulardatathetableelementtFootexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/tabular-data/the-table-element/tFoot-expected.txt (203008 => 203009)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/tabular-data/the-table-element/tFoot-expected.txt 2016-07-08 23:49:15 UTC (rev 203008)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/tabular-data/the-table-element/tFoot-expected.txt 2016-07-09 00:04:32 UTC (rev 203009)
</span><span class="lines">@@ -1,3 +1,3 @@
</span><span class="cx">
</span><del>-FAIL tFoot tests assert_equals: expected Element node <tbody id="tbody2"></tbody> but got Element node <thead id="thead"></thead>
</del><ins>+PASS tFoot tests
</ins><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsplatformefltablesmozillabugsbug30418expectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/efl/tables/mozilla/bugs/bug30418-expected.txt (203008 => 203009)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/efl/tables/mozilla/bugs/bug30418-expected.txt 2016-07-08 23:49:15 UTC (rev 203008)
+++ trunk/LayoutTests/platform/efl/tables/mozilla/bugs/bug30418-expected.txt 2016-07-09 00:04:32 UTC (rev 203009)
</span><span class="lines">@@ -30,6 +30,32 @@
</span><span class="cx"> RenderTableCell {TD} at (240,2) size 32x22 [border: (1px inset #808080)] [r=0 c=7 rs=1 cs=1]
</span><span class="cx"> RenderText {#text} at (2,2) size 16x17
</span><span class="cx"> text run at (2,2) width 16: "h7"
</span><ins>+ RenderTableSection {TBODY} at (4,30) size 274x24
+ RenderTableRow {TR} at (0,0) size 274x22
+ RenderTableCell {TD} at (2,0) size 32x22 [border: (1px inset #808080)] [r=0 c=0 rs=1 cs=1]
+ RenderText {#text} at (2,2) size 28x17
+ text run at (2,2) width 28: "r0c0"
+ RenderTableCell {TD} at (36,0) size 32x22 [border: (1px inset #808080)] [r=0 c=1 rs=1 cs=1]
+ RenderText {#text} at (2,2) size 28x17
+ text run at (2,2) width 28: "r0c1"
+ RenderTableCell {TD} at (70,0) size 32x22 [border: (1px inset #808080)] [r=0 c=2 rs=1 cs=1]
+ RenderText {#text} at (2,2) size 28x17
+ text run at (2,2) width 28: "r0c2"
+ RenderTableCell {TD} at (104,0) size 32x22 [border: (1px inset #808080)] [r=0 c=3 rs=1 cs=1]
+ RenderText {#text} at (2,2) size 28x17
+ text run at (2,2) width 28: "r0c3"
+ RenderTableCell {TD} at (138,0) size 32x22 [border: (1px inset #808080)] [r=0 c=4 rs=1 cs=1]
+ RenderText {#text} at (2,2) size 28x17
+ text run at (2,2) width 28: "r0c4"
+ RenderTableCell {TD} at (172,0) size 32x22 [border: (1px inset #808080)] [r=0 c=5 rs=1 cs=1]
+ RenderText {#text} at (2,2) size 28x17
+ text run at (2,2) width 28: "r0c5"
+ RenderTableCell {TD} at (206,0) size 32x22 [border: (1px inset #808080)] [r=0 c=6 rs=1 cs=1]
+ RenderText {#text} at (2,2) size 28x17
+ text run at (2,2) width 28: "r0c6"
+ RenderTableCell {TD} at (240,0) size 32x22 [border: (1px inset #808080)] [r=0 c=7 rs=1 cs=1]
+ RenderText {#text} at (2,2) size 28x17
+ text run at (2,2) width 28: "r0c7"
</ins><span class="cx"> RenderTableSection {TFOOT} at (4,54) size 274x24
</span><span class="cx"> RenderTableRow {TR} at (0,0) size 274x22
</span><span class="cx"> RenderTableCell {TD} at (2,0) size 32x22 [border: (1px inset #808080)] [r=0 c=0 rs=1 cs=1]
</span><span class="lines">@@ -56,29 +82,3 @@
</span><span class="cx"> RenderTableCell {TD} at (240,0) size 32x22 [border: (1px inset #808080)] [r=0 c=7 rs=1 cs=1]
</span><span class="cx"> RenderText {#text} at (2,2) size 13x17
</span><span class="cx"> text run at (2,2) width 13: "f7"
</span><del>- RenderTableSection {TBODY} at (4,30) size 274x24
- RenderTableRow {TR} at (0,0) size 274x22
- RenderTableCell {TD} at (2,0) size 32x22 [border: (1px inset #808080)] [r=0 c=0 rs=1 cs=1]
- RenderText {#text} at (2,2) size 28x17
- text run at (2,2) width 28: "r0c0"
- RenderTableCell {TD} at (36,0) size 32x22 [border: (1px inset #808080)] [r=0 c=1 rs=1 cs=1]
- RenderText {#text} at (2,2) size 28x17
- text run at (2,2) width 28: "r0c1"
- RenderTableCell {TD} at (70,0) size 32x22 [border: (1px inset #808080)] [r=0 c=2 rs=1 cs=1]
- RenderText {#text} at (2,2) size 28x17
- text run at (2,2) width 28: "r0c2"
- RenderTableCell {TD} at (104,0) size 32x22 [border: (1px inset #808080)] [r=0 c=3 rs=1 cs=1]
- RenderText {#text} at (2,2) size 28x17
- text run at (2,2) width 28: "r0c3"
- RenderTableCell {TD} at (138,0) size 32x22 [border: (1px inset #808080)] [r=0 c=4 rs=1 cs=1]
- RenderText {#text} at (2,2) size 28x17
- text run at (2,2) width 28: "r0c4"
- RenderTableCell {TD} at (172,0) size 32x22 [border: (1px inset #808080)] [r=0 c=5 rs=1 cs=1]
- RenderText {#text} at (2,2) size 28x17
- text run at (2,2) width 28: "r0c5"
- RenderTableCell {TD} at (206,0) size 32x22 [border: (1px inset #808080)] [r=0 c=6 rs=1 cs=1]
- RenderText {#text} at (2,2) size 28x17
- text run at (2,2) width 28: "r0c6"
- RenderTableCell {TD} at (240,0) size 32x22 [border: (1px inset #808080)] [r=0 c=7 rs=1 cs=1]
- RenderText {#text} at (2,2) size 28x17
- text run at (2,2) width 28: "r0c7"
</del></span></pre></div>
<a id="trunkLayoutTestsplatformgtktablesmozillabugsbug30418expectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/gtk/tables/mozilla/bugs/bug30418-expected.txt (203008 => 203009)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/gtk/tables/mozilla/bugs/bug30418-expected.txt 2016-07-08 23:49:15 UTC (rev 203008)
+++ trunk/LayoutTests/platform/gtk/tables/mozilla/bugs/bug30418-expected.txt 2016-07-09 00:04:32 UTC (rev 203009)
</span><span class="lines">@@ -30,6 +30,32 @@
</span><span class="cx"> RenderTableCell {TD} at (240,2) size 32x21 [border: (1px inset #808080)] [r=0 c=7 rs=1 cs=1]
</span><span class="cx"> RenderText {#text} at (2,2) size 16x17
</span><span class="cx"> text run at (2,2) width 16: "h7"
</span><ins>+ RenderTableSection {TBODY} at (4,29) size 274x23
+ RenderTableRow {TR} at (0,0) size 274x21
+ RenderTableCell {TD} at (2,0) size 32x21 [border: (1px inset #808080)] [r=0 c=0 rs=1 cs=1]
+ RenderText {#text} at (2,2) size 28x17
+ text run at (2,2) width 28: "r0c0"
+ RenderTableCell {TD} at (36,0) size 32x21 [border: (1px inset #808080)] [r=0 c=1 rs=1 cs=1]
+ RenderText {#text} at (2,2) size 28x17
+ text run at (2,2) width 28: "r0c1"
+ RenderTableCell {TD} at (70,0) size 32x21 [border: (1px inset #808080)] [r=0 c=2 rs=1 cs=1]
+ RenderText {#text} at (2,2) size 28x17
+ text run at (2,2) width 28: "r0c2"
+ RenderTableCell {TD} at (104,0) size 32x21 [border: (1px inset #808080)] [r=0 c=3 rs=1 cs=1]
+ RenderText {#text} at (2,2) size 28x17
+ text run at (2,2) width 28: "r0c3"
+ RenderTableCell {TD} at (138,0) size 32x21 [border: (1px inset #808080)] [r=0 c=4 rs=1 cs=1]
+ RenderText {#text} at (2,2) size 28x17
+ text run at (2,2) width 28: "r0c4"
+ RenderTableCell {TD} at (172,0) size 32x21 [border: (1px inset #808080)] [r=0 c=5 rs=1 cs=1]
+ RenderText {#text} at (2,2) size 28x17
+ text run at (2,2) width 28: "r0c5"
+ RenderTableCell {TD} at (206,0) size 32x21 [border: (1px inset #808080)] [r=0 c=6 rs=1 cs=1]
+ RenderText {#text} at (2,2) size 28x17
+ text run at (2,2) width 28: "r0c6"
+ RenderTableCell {TD} at (240,0) size 32x21 [border: (1px inset #808080)] [r=0 c=7 rs=1 cs=1]
+ RenderText {#text} at (2,2) size 28x17
+ text run at (2,2) width 28: "r0c7"
</ins><span class="cx"> RenderTableSection {TFOOT} at (4,52) size 274x23
</span><span class="cx"> RenderTableRow {TR} at (0,0) size 274x21
</span><span class="cx"> RenderTableCell {TD} at (2,0) size 32x21 [border: (1px inset #808080)] [r=0 c=0 rs=1 cs=1]
</span><span class="lines">@@ -56,29 +82,3 @@
</span><span class="cx"> RenderTableCell {TD} at (240,0) size 32x21 [border: (1px inset #808080)] [r=0 c=7 rs=1 cs=1]
</span><span class="cx"> RenderText {#text} at (2,2) size 13x17
</span><span class="cx"> text run at (2,2) width 13: "f7"
</span><del>- RenderTableSection {TBODY} at (4,29) size 274x23
- RenderTableRow {TR} at (0,0) size 274x21
- RenderTableCell {TD} at (2,0) size 32x21 [border: (1px inset #808080)] [r=0 c=0 rs=1 cs=1]
- RenderText {#text} at (2,2) size 28x17
- text run at (2,2) width 28: "r0c0"
- RenderTableCell {TD} at (36,0) size 32x21 [border: (1px inset #808080)] [r=0 c=1 rs=1 cs=1]
- RenderText {#text} at (2,2) size 28x17
- text run at (2,2) width 28: "r0c1"
- RenderTableCell {TD} at (70,0) size 32x21 [border: (1px inset #808080)] [r=0 c=2 rs=1 cs=1]
- RenderText {#text} at (2,2) size 28x17
- text run at (2,2) width 28: "r0c2"
- RenderTableCell {TD} at (104,0) size 32x21 [border: (1px inset #808080)] [r=0 c=3 rs=1 cs=1]
- RenderText {#text} at (2,2) size 28x17
- text run at (2,2) width 28: "r0c3"
- RenderTableCell {TD} at (138,0) size 32x21 [border: (1px inset #808080)] [r=0 c=4 rs=1 cs=1]
- RenderText {#text} at (2,2) size 28x17
- text run at (2,2) width 28: "r0c4"
- RenderTableCell {TD} at (172,0) size 32x21 [border: (1px inset #808080)] [r=0 c=5 rs=1 cs=1]
- RenderText {#text} at (2,2) size 28x17
- text run at (2,2) width 28: "r0c5"
- RenderTableCell {TD} at (206,0) size 32x21 [border: (1px inset #808080)] [r=0 c=6 rs=1 cs=1]
- RenderText {#text} at (2,2) size 28x17
- text run at (2,2) width 28: "r0c6"
- RenderTableCell {TD} at (240,0) size 32x21 [border: (1px inset #808080)] [r=0 c=7 rs=1 cs=1]
- RenderText {#text} at (2,2) size 28x17
- text run at (2,2) width 28: "r0c7"
</del></span></pre></div>
<a id="trunkLayoutTestsplatformiossimulatortablesmozillabugsbug30418expectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/ios-simulator/tables/mozilla/bugs/bug30418-expected.txt (203008 => 203009)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/ios-simulator/tables/mozilla/bugs/bug30418-expected.txt 2016-07-08 23:49:15 UTC (rev 203008)
+++ trunk/LayoutTests/platform/ios-simulator/tables/mozilla/bugs/bug30418-expected.txt 2016-07-09 00:04:32 UTC (rev 203009)
</span><span class="lines">@@ -30,6 +30,32 @@
</span><span class="cx"> RenderTableCell {TD} at (243,2) size 33x24 [border: (1px inset #808080)] [r=0 c=7 rs=1 cs=1]
</span><span class="cx"> RenderText {#text} at (2,2) size 16x19
</span><span class="cx"> text run at (2,2) width 16: "h7"
</span><ins>+ RenderTableSection {TBODY} at (4,32) size 278x26
+ RenderTableRow {TR} at (0,0) size 278x24
+ RenderTableCell {TD} at (2,0) size 33x24 [border: (1px inset #808080)] [r=0 c=0 rs=1 cs=1]
+ RenderText {#text} at (2,2) size 29x19
+ text run at (2,2) width 29: "r0c0"
+ RenderTableCell {TD} at (36,0) size 33x24 [border: (1px inset #808080)] [r=0 c=1 rs=1 cs=1]
+ RenderText {#text} at (2,2) size 29x19
+ text run at (2,2) width 29: "r0c1"
+ RenderTableCell {TD} at (70,0) size 34x24 [border: (1px inset #808080)] [r=0 c=2 rs=1 cs=1]
+ RenderText {#text} at (2,2) size 29x19
+ text run at (2,2) width 29: "r0c2"
+ RenderTableCell {TD} at (105,0) size 33x24 [border: (1px inset #808080)] [r=0 c=3 rs=1 cs=1]
+ RenderText {#text} at (2,2) size 29x19
+ text run at (2,2) width 29: "r0c3"
+ RenderTableCell {TD} at (139,0) size 34x24 [border: (1px inset #808080)] [r=0 c=4 rs=1 cs=1]
+ RenderText {#text} at (2,2) size 29x19
+ text run at (2,2) width 29: "r0c4"
+ RenderTableCell {TD} at (174,0) size 33x24 [border: (1px inset #808080)] [r=0 c=5 rs=1 cs=1]
+ RenderText {#text} at (2,2) size 29x19
+ text run at (2,2) width 29: "r0c5"
+ RenderTableCell {TD} at (208,0) size 34x24 [border: (1px inset #808080)] [r=0 c=6 rs=1 cs=1]
+ RenderText {#text} at (2,2) size 29x19
+ text run at (2,2) width 29: "r0c6"
+ RenderTableCell {TD} at (243,0) size 33x24 [border: (1px inset #808080)] [r=0 c=7 rs=1 cs=1]
+ RenderText {#text} at (2,2) size 29x19
+ text run at (2,2) width 29: "r0c7"
</ins><span class="cx"> RenderTableSection {TFOOT} at (4,58) size 278x26
</span><span class="cx"> RenderTableRow {TR} at (0,0) size 278x24
</span><span class="cx"> RenderTableCell {TD} at (2,0) size 33x24 [border: (1px inset #808080)] [r=0 c=0 rs=1 cs=1]
</span><span class="lines">@@ -56,29 +82,3 @@
</span><span class="cx"> RenderTableCell {TD} at (243,0) size 33x24 [border: (1px inset #808080)] [r=0 c=7 rs=1 cs=1]
</span><span class="cx"> RenderText {#text} at (2,2) size 14x19
</span><span class="cx"> text run at (2,2) width 14: "f7"
</span><del>- RenderTableSection {TBODY} at (4,32) size 278x26
- RenderTableRow {TR} at (0,0) size 278x24
- RenderTableCell {TD} at (2,0) size 33x24 [border: (1px inset #808080)] [r=0 c=0 rs=1 cs=1]
- RenderText {#text} at (2,2) size 29x19
- text run at (2,2) width 29: "r0c0"
- RenderTableCell {TD} at (36,0) size 33x24 [border: (1px inset #808080)] [r=0 c=1 rs=1 cs=1]
- RenderText {#text} at (2,2) size 29x19
- text run at (2,2) width 29: "r0c1"
- RenderTableCell {TD} at (70,0) size 34x24 [border: (1px inset #808080)] [r=0 c=2 rs=1 cs=1]
- RenderText {#text} at (2,2) size 29x19
- text run at (2,2) width 29: "r0c2"
- RenderTableCell {TD} at (105,0) size 33x24 [border: (1px inset #808080)] [r=0 c=3 rs=1 cs=1]
- RenderText {#text} at (2,2) size 29x19
- text run at (2,2) width 29: "r0c3"
- RenderTableCell {TD} at (139,0) size 34x24 [border: (1px inset #808080)] [r=0 c=4 rs=1 cs=1]
- RenderText {#text} at (2,2) size 29x19
- text run at (2,2) width 29: "r0c4"
- RenderTableCell {TD} at (174,0) size 33x24 [border: (1px inset #808080)] [r=0 c=5 rs=1 cs=1]
- RenderText {#text} at (2,2) size 29x19
- text run at (2,2) width 29: "r0c5"
- RenderTableCell {TD} at (208,0) size 34x24 [border: (1px inset #808080)] [r=0 c=6 rs=1 cs=1]
- RenderText {#text} at (2,2) size 29x19
- text run at (2,2) width 29: "r0c6"
- RenderTableCell {TD} at (243,0) size 33x24 [border: (1px inset #808080)] [r=0 c=7 rs=1 cs=1]
- RenderText {#text} at (2,2) size 29x19
- text run at (2,2) width 29: "r0c7"
</del></span></pre></div>
<a id="trunkLayoutTestsplatformmactablesmozillabugsbug30418expectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/mac/tables/mozilla/bugs/bug30418-expected.txt (203008 => 203009)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/mac/tables/mozilla/bugs/bug30418-expected.txt 2016-07-08 23:49:15 UTC (rev 203008)
+++ trunk/LayoutTests/platform/mac/tables/mozilla/bugs/bug30418-expected.txt 2016-07-09 00:04:32 UTC (rev 203009)
</span><span class="lines">@@ -30,6 +30,32 @@
</span><span class="cx"> RenderTableCell {TD} at (243,2) size 33x22 [border: (1px inset #808080)] [r=0 c=7 rs=1 cs=1]
</span><span class="cx"> RenderText {#text} at (2,2) size 16x18
</span><span class="cx"> text run at (2,2) width 16: "h7"
</span><ins>+ RenderTableSection {TBODY} at (4,30) size 278x24
+ RenderTableRow {TR} at (0,0) size 278x22
+ RenderTableCell {TD} at (2,0) size 33x22 [border: (1px inset #808080)] [r=0 c=0 rs=1 cs=1]
+ RenderText {#text} at (2,2) size 29x18
+ text run at (2,2) width 29: "r0c0"
+ RenderTableCell {TD} at (36,0) size 33x22 [border: (1px inset #808080)] [r=0 c=1 rs=1 cs=1]
+ RenderText {#text} at (2,2) size 29x18
+ text run at (2,2) width 29: "r0c1"
+ RenderTableCell {TD} at (70,0) size 34x22 [border: (1px inset #808080)] [r=0 c=2 rs=1 cs=1]
+ RenderText {#text} at (2,2) size 29x18
+ text run at (2,2) width 29: "r0c2"
+ RenderTableCell {TD} at (105,0) size 33x22 [border: (1px inset #808080)] [r=0 c=3 rs=1 cs=1]
+ RenderText {#text} at (2,2) size 29x18
+ text run at (2,2) width 29: "r0c3"
+ RenderTableCell {TD} at (139,0) size 34x22 [border: (1px inset #808080)] [r=0 c=4 rs=1 cs=1]
+ RenderText {#text} at (2,2) size 29x18
+ text run at (2,2) width 29: "r0c4"
+ RenderTableCell {TD} at (174,0) size 33x22 [border: (1px inset #808080)] [r=0 c=5 rs=1 cs=1]
+ RenderText {#text} at (2,2) size 29x18
+ text run at (2,2) width 29: "r0c5"
+ RenderTableCell {TD} at (208,0) size 34x22 [border: (1px inset #808080)] [r=0 c=6 rs=1 cs=1]
+ RenderText {#text} at (2,2) size 29x18
+ text run at (2,2) width 29: "r0c6"
+ RenderTableCell {TD} at (243,0) size 33x22 [border: (1px inset #808080)] [r=0 c=7 rs=1 cs=1]
+ RenderText {#text} at (2,2) size 29x18
+ text run at (2,2) width 29: "r0c7"
</ins><span class="cx"> RenderTableSection {TFOOT} at (4,54) size 278x24
</span><span class="cx"> RenderTableRow {TR} at (0,0) size 278x22
</span><span class="cx"> RenderTableCell {TD} at (2,0) size 33x22 [border: (1px inset #808080)] [r=0 c=0 rs=1 cs=1]
</span><span class="lines">@@ -56,29 +82,3 @@
</span><span class="cx"> RenderTableCell {TD} at (243,0) size 33x22 [border: (1px inset #808080)] [r=0 c=7 rs=1 cs=1]
</span><span class="cx"> RenderText {#text} at (2,2) size 14x18
</span><span class="cx"> text run at (2,2) width 14: "f7"
</span><del>- RenderTableSection {TBODY} at (4,30) size 278x24
- RenderTableRow {TR} at (0,0) size 278x22
- RenderTableCell {TD} at (2,0) size 33x22 [border: (1px inset #808080)] [r=0 c=0 rs=1 cs=1]
- RenderText {#text} at (2,2) size 29x18
- text run at (2,2) width 29: "r0c0"
- RenderTableCell {TD} at (36,0) size 33x22 [border: (1px inset #808080)] [r=0 c=1 rs=1 cs=1]
- RenderText {#text} at (2,2) size 29x18
- text run at (2,2) width 29: "r0c1"
- RenderTableCell {TD} at (70,0) size 34x22 [border: (1px inset #808080)] [r=0 c=2 rs=1 cs=1]
- RenderText {#text} at (2,2) size 29x18
- text run at (2,2) width 29: "r0c2"
- RenderTableCell {TD} at (105,0) size 33x22 [border: (1px inset #808080)] [r=0 c=3 rs=1 cs=1]
- RenderText {#text} at (2,2) size 29x18
- text run at (2,2) width 29: "r0c3"
- RenderTableCell {TD} at (139,0) size 34x22 [border: (1px inset #808080)] [r=0 c=4 rs=1 cs=1]
- RenderText {#text} at (2,2) size 29x18
- text run at (2,2) width 29: "r0c4"
- RenderTableCell {TD} at (174,0) size 33x22 [border: (1px inset #808080)] [r=0 c=5 rs=1 cs=1]
- RenderText {#text} at (2,2) size 29x18
- text run at (2,2) width 29: "r0c5"
- RenderTableCell {TD} at (208,0) size 34x22 [border: (1px inset #808080)] [r=0 c=6 rs=1 cs=1]
- RenderText {#text} at (2,2) size 29x18
- text run at (2,2) width 29: "r0c6"
- RenderTableCell {TD} at (243,0) size 33x22 [border: (1px inset #808080)] [r=0 c=7 rs=1 cs=1]
- RenderText {#text} at (2,2) size 29x18
- text run at (2,2) width 29: "r0c7"
</del></span></pre></div>
<a id="trunkLayoutTestsplatformwintablesmozillabugsbug30418expectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/win/tables/mozilla/bugs/bug30418-expected.txt (203008 => 203009)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/win/tables/mozilla/bugs/bug30418-expected.txt 2016-07-08 23:49:15 UTC (rev 203008)
+++ trunk/LayoutTests/platform/win/tables/mozilla/bugs/bug30418-expected.txt 2016-07-09 00:04:32 UTC (rev 203009)
</span><span class="lines">@@ -30,6 +30,32 @@
</span><span class="cx"> RenderTableCell {TD} at (240,2) size 32x22 [border: (1px inset #808080)] [r=0 c=7 rs=1 cs=1]
</span><span class="cx"> RenderText {#text} at (2,2) size 16x18
</span><span class="cx"> text run at (2,2) width 16: "h7"
</span><ins>+ RenderTableSection {TBODY} at (4,30) size 274x24
+ RenderTableRow {TR} at (0,0) size 274x22
+ RenderTableCell {TD} at (2,0) size 32x22 [border: (1px inset #808080)] [r=0 c=0 rs=1 cs=1]
+ RenderText {#text} at (2,2) size 28x18
+ text run at (2,2) width 28: "r0c0"
+ RenderTableCell {TD} at (36,0) size 32x22 [border: (1px inset #808080)] [r=0 c=1 rs=1 cs=1]
+ RenderText {#text} at (2,2) size 28x18
+ text run at (2,2) width 28: "r0c1"
+ RenderTableCell {TD} at (70,0) size 32x22 [border: (1px inset #808080)] [r=0 c=2 rs=1 cs=1]
+ RenderText {#text} at (2,2) size 28x18
+ text run at (2,2) width 28: "r0c2"
+ RenderTableCell {TD} at (104,0) size 32x22 [border: (1px inset #808080)] [r=0 c=3 rs=1 cs=1]
+ RenderText {#text} at (2,2) size 28x18
+ text run at (2,2) width 28: "r0c3"
+ RenderTableCell {TD} at (138,0) size 32x22 [border: (1px inset #808080)] [r=0 c=4 rs=1 cs=1]
+ RenderText {#text} at (2,2) size 28x18
+ text run at (2,2) width 28: "r0c4"
+ RenderTableCell {TD} at (172,0) size 32x22 [border: (1px inset #808080)] [r=0 c=5 rs=1 cs=1]
+ RenderText {#text} at (2,2) size 28x18
+ text run at (2,2) width 28: "r0c5"
+ RenderTableCell {TD} at (206,0) size 32x22 [border: (1px inset #808080)] [r=0 c=6 rs=1 cs=1]
+ RenderText {#text} at (2,2) size 28x18
+ text run at (2,2) width 28: "r0c6"
+ RenderTableCell {TD} at (240,0) size 32x22 [border: (1px inset #808080)] [r=0 c=7 rs=1 cs=1]
+ RenderText {#text} at (2,2) size 28x18
+ text run at (2,2) width 28: "r0c7"
</ins><span class="cx"> RenderTableSection {TFOOT} at (4,54) size 274x24
</span><span class="cx"> RenderTableRow {TR} at (0,0) size 274x22
</span><span class="cx"> RenderTableCell {TD} at (2,0) size 32x22 [border: (1px inset #808080)] [r=0 c=0 rs=1 cs=1]
</span><span class="lines">@@ -56,29 +82,3 @@
</span><span class="cx"> RenderTableCell {TD} at (240,0) size 32x22 [border: (1px inset #808080)] [r=0 c=7 rs=1 cs=1]
</span><span class="cx"> RenderText {#text} at (2,2) size 13x18
</span><span class="cx"> text run at (2,2) width 13: "f7"
</span><del>- RenderTableSection {TBODY} at (4,30) size 274x24
- RenderTableRow {TR} at (0,0) size 274x22
- RenderTableCell {TD} at (2,0) size 32x22 [border: (1px inset #808080)] [r=0 c=0 rs=1 cs=1]
- RenderText {#text} at (2,2) size 28x18
- text run at (2,2) width 28: "r0c0"
- RenderTableCell {TD} at (36,0) size 32x22 [border: (1px inset #808080)] [r=0 c=1 rs=1 cs=1]
- RenderText {#text} at (2,2) size 28x18
- text run at (2,2) width 28: "r0c1"
- RenderTableCell {TD} at (70,0) size 32x22 [border: (1px inset #808080)] [r=0 c=2 rs=1 cs=1]
- RenderText {#text} at (2,2) size 28x18
- text run at (2,2) width 28: "r0c2"
- RenderTableCell {TD} at (104,0) size 32x22 [border: (1px inset #808080)] [r=0 c=3 rs=1 cs=1]
- RenderText {#text} at (2,2) size 28x18
- text run at (2,2) width 28: "r0c3"
- RenderTableCell {TD} at (138,0) size 32x22 [border: (1px inset #808080)] [r=0 c=4 rs=1 cs=1]
- RenderText {#text} at (2,2) size 28x18
- text run at (2,2) width 28: "r0c4"
- RenderTableCell {TD} at (172,0) size 32x22 [border: (1px inset #808080)] [r=0 c=5 rs=1 cs=1]
- RenderText {#text} at (2,2) size 28x18
- text run at (2,2) width 28: "r0c5"
- RenderTableCell {TD} at (206,0) size 32x22 [border: (1px inset #808080)] [r=0 c=6 rs=1 cs=1]
- RenderText {#text} at (2,2) size 28x18
- text run at (2,2) width 28: "r0c6"
- RenderTableCell {TD} at (240,0) size 32x22 [border: (1px inset #808080)] [r=0 c=7 rs=1 cs=1]
- RenderText {#text} at (2,2) size 28x18
- text run at (2,2) width 28: "r0c7"
</del></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (203008 => 203009)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-07-08 23:49:15 UTC (rev 203008)
+++ trunk/Source/WebCore/ChangeLog 2016-07-09 00:04:32 UTC (rev 203009)
</span><span class="lines">@@ -1,3 +1,23 @@
</span><ins>+2016-07-08 Daniel Bates <dabates@apple.com>
+
+ Setting table.tFoot or calling table.createTFoot() should append HTML tfont element to the end of the table
+ https://bugs.webkit.org/show_bug.cgi?id=159583
+ <rdar://problem/27255292>
+
+ Reviewed by Chris Dumez.
+
+ he HTML standard has long since been revised to describe that assignment to property table.tFoot
+ or invoking table.createTFoot() will append the HTML tfoot element to the end of the table. This
+ behavior is defined in <https://html.spec.whatwg.org/multipage/tables.html#dom-table-tfoot> (8 July 2016)
+ and <https://html.spec.whatwg.org/multipage/tables.html#dom-table-createtfoot> for the property
+ table.tFoot and table.createTFoot(), respectively. This change makes our behavior match the
+ behavior in Mozilla Firefox, Microsoft Edge, Microsoft Internet Explorer 8 and later.
+
+ * html/HTMLTableElement.cpp:
+ (WebCore::HTMLTableElement::setTFoot): Append <tfoot> to the end of the table. Use RefPtr<>&& instead of PassRefPtr.
+ (WebCore::HTMLTableElement::createTFoot): Use RefPtr<>&& instead of PassRefPtr.
+ * html/HTMLTableElement.h:
+
</ins><span class="cx"> 2016-07-08 Jer Noble <jer.noble@apple.com>
</span><span class="cx">
</span><span class="cx"> Crash in layout test /media/video-buffered-range-contains-currentTime.html
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLTableElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLTableElement.cpp (203008 => 203009)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLTableElement.cpp 2016-07-08 23:49:15 UTC (rev 203008)
+++ trunk/Source/WebCore/html/HTMLTableElement.cpp 2016-07-09 00:04:32 UTC (rev 203009)
</span><span class="lines">@@ -122,7 +122,7 @@
</span><span class="cx"> return nullptr;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void HTMLTableElement::setTFoot(PassRefPtr<HTMLTableSectionElement> newFoot, ExceptionCode& ec)
</del><ins>+void HTMLTableElement::setTFoot(RefPtr<HTMLTableSectionElement>&& newFoot, ExceptionCode& ec)
</ins><span class="cx"> {
</span><span class="cx"> if (UNLIKELY(newFoot && !newFoot->hasTagName(tfootTag))) {
</span><span class="cx"> ec = HIERARCHY_REQUEST_ERR;
</span><span class="lines">@@ -134,12 +134,7 @@
</span><span class="cx"> if (!newFoot)
</span><span class="cx"> return;
</span><span class="cx">
</span><del>- Node* child;
- for (child = firstChild(); child; child = child->nextSibling())
- if (child->isElementNode() && !child->hasTagName(captionTag) && !child->hasTagName(colgroupTag) && !child->hasTagName(theadTag))
- break;
-
- insertBefore(*newFoot, child, ec);
</del><ins>+ appendChild(*newFoot, ec);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> Ref<HTMLTableSectionElement> HTMLTableElement::createTHead()
</span><span class="lines">@@ -162,7 +157,7 @@
</span><span class="cx"> if (HTMLTableSectionElement* existingFoot = tFoot())
</span><span class="cx"> return *existingFoot;
</span><span class="cx"> Ref<HTMLTableSectionElement> foot = HTMLTableSectionElement::create(tfootTag, document());
</span><del>- setTFoot(foot.ptr(), IGNORE_EXCEPTION);
</del><ins>+ setTFoot(WTFMove(foot), IGNORE_EXCEPTION);
</ins><span class="cx"> return foot;
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLTableElementh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLTableElement.h (203008 => 203009)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLTableElement.h 2016-07-08 23:49:15 UTC (rev 203008)
+++ trunk/Source/WebCore/html/HTMLTableElement.h 2016-07-09 00:04:32 UTC (rev 203009)
</span><span class="lines">@@ -47,7 +47,7 @@
</span><span class="cx"> void setTHead(PassRefPtr<HTMLTableSectionElement>, ExceptionCode&);
</span><span class="cx">
</span><span class="cx"> HTMLTableSectionElement* tFoot() const;
</span><del>- void setTFoot(PassRefPtr<HTMLTableSectionElement>, ExceptionCode&);
</del><ins>+ void setTFoot(RefPtr<HTMLTableSectionElement>&&, ExceptionCode&);
</ins><span class="cx">
</span><span class="cx"> Ref<HTMLTableSectionElement> createTHead();
</span><span class="cx"> void deleteTHead();
</span></span></pre>
</div>
</div>
</body>
</html>