<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[202956] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/202956">202956</a></dd>
<dt>Author</dt> <dd>benjamin@webkit.org</dd>
<dt>Date</dt> <dd>2016-07-07 21:10:00 -0700 (Thu, 07 Jul 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>[JSC] String.prototype[Symbol.iterator] needs a name
https://bugs.webkit.org/show_bug.cgi?id=159541
Reviewed by Yusuke Suzuki.
Source/JavaScriptCore:
A man needs a name.
Spec: https://tc39.github.io/ecma262/#sec-string.prototype-@@iterator
* runtime/StringPrototype.cpp:
(JSC::StringPrototype::finishCreation):
LayoutTests:
* js/script-tests/string-iterator.js: Added.
* js/string-iterator-expected.txt: Added.
* js/string-iterator.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkSourceJavaScriptCoreChangeLog">trunk/Source/JavaScriptCore/ChangeLog</a></li>
<li><a href="#trunkSourceJavaScriptCoreruntimeStringPrototypecpp">trunk/Source/JavaScriptCore/runtime/StringPrototype.cpp</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsjsscripttestsstringiteratorjs">trunk/LayoutTests/js/script-tests/string-iterator.js</a></li>
<li><a href="#trunkLayoutTestsjsstringiteratorexpectedtxt">trunk/LayoutTests/js/string-iterator-expected.txt</a></li>
<li><a href="#trunkLayoutTestsjsstringiteratorhtml">trunk/LayoutTests/js/string-iterator.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (202955 => 202956)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2016-07-08 03:47:59 UTC (rev 202955)
+++ trunk/LayoutTests/ChangeLog 2016-07-08 04:10:00 UTC (rev 202956)
</span><span class="lines">@@ -1,3 +1,14 @@
</span><ins>+2016-07-07 Benjamin Poulain <benjamin@webkit.org>
+
+ [JSC] String.prototype[Symbol.iterator] needs a name
+ https://bugs.webkit.org/show_bug.cgi?id=159541
+
+ Reviewed by Yusuke Suzuki.
+
+ * js/script-tests/string-iterator.js: Added.
+ * js/string-iterator-expected.txt: Added.
+ * js/string-iterator.html: Added.
+
</ins><span class="cx"> 2016-07-07 Joseph Pecoraro <pecoraro@apple.com>
</span><span class="cx">
</span><span class="cx"> Unexpected "Out of memory" error for "x".repeat(-1)
</span></span></pre></div>
<a id="trunkLayoutTestsjsscripttestsstringiteratorjs"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/js/script-tests/string-iterator.js (0 => 202956)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/js/script-tests/string-iterator.js (rev 0)
+++ trunk/LayoutTests/js/script-tests/string-iterator.js 2016-07-08 04:10:00 UTC (rev 202956)
</span><span class="lines">@@ -0,0 +1,41 @@
</span><ins>+"use strict"
+
+description("Verify the various properties of String.prototype[Symbol.iterator]");
+
+
+debug("Iterator object properties");
+shouldBeEqualToString("typeof String.prototype[Symbol.iterator]", "function");
+shouldBeEqualToString("String.prototype[Symbol.iterator].name", "[Symbol.iterator]");
+shouldBe("String.prototype[Symbol.iterator].length", "0");
+shouldBeTrue("Object.getOwnPropertyDescriptor(String.prototype, Symbol.iterator).configurable");
+shouldBeFalse("Object.getOwnPropertyDescriptor(String.prototype, Symbol.iterator).enumerable");
+shouldBeTrue("Object.getOwnPropertyDescriptor(String.prototype, Symbol.iterator).writable");
+shouldBeFalse("String.prototype[Symbol.iterator]() === String.prototype[Symbol.iterator]()");
+
+debug("Iterating a simple string.");
+let iterator = "WebKit"[Symbol.iterator]();
+
+let next = iterator.next();
+shouldBeEqualToString("next.value", "W");
+shouldBeFalse("next.done");
+next = iterator.next();
+shouldBeEqualToString("next.value", "e");
+shouldBeFalse("next.done");
+next = iterator.next();
+shouldBeEqualToString("next.value", "b");
+shouldBeFalse("next.done");
+next = iterator.next();
+shouldBeEqualToString("next.value", "K");
+shouldBeFalse("next.done");
+next = iterator.next();
+shouldBeEqualToString("next.value", "i");
+shouldBeFalse("next.done");
+next = iterator.next();
+shouldBeEqualToString("next.value", "t");
+shouldBeFalse("next.done");
+next = iterator.next();
+shouldBe("next.value", "undefined");
+shouldBeTrue("next.done");
+next = iterator.next();
+shouldBe("next.value", "undefined");
+shouldBeTrue("next.done");
</ins></span></pre></div>
<a id="trunkLayoutTestsjsstringiteratorexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/js/string-iterator-expected.txt (0 => 202956)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/js/string-iterator-expected.txt (rev 0)
+++ trunk/LayoutTests/js/string-iterator-expected.txt 2016-07-08 04:10:00 UTC (rev 202956)
</span><span class="lines">@@ -0,0 +1,34 @@
</span><ins>+Verify the various properties of String.prototype[Symbol.iterator]
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+Iterator object properties
+PASS typeof String.prototype[Symbol.iterator] is "function"
+PASS String.prototype[Symbol.iterator].name is "[Symbol.iterator]"
+PASS String.prototype[Symbol.iterator].length is 0
+PASS Object.getOwnPropertyDescriptor(String.prototype, Symbol.iterator).configurable is true
+PASS Object.getOwnPropertyDescriptor(String.prototype, Symbol.iterator).enumerable is false
+PASS Object.getOwnPropertyDescriptor(String.prototype, Symbol.iterator).writable is true
+PASS String.prototype[Symbol.iterator]() === String.prototype[Symbol.iterator]() is false
+Iterating a simple string.
+PASS next.value is "W"
+PASS next.done is false
+PASS next.value is "e"
+PASS next.done is false
+PASS next.value is "b"
+PASS next.done is false
+PASS next.value is "K"
+PASS next.done is false
+PASS next.value is "i"
+PASS next.done is false
+PASS next.value is "t"
+PASS next.done is false
+PASS next.value is undefined
+PASS next.done is true
+PASS next.value is undefined
+PASS next.done is true
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
</ins></span></pre></div>
<a id="trunkLayoutTestsjsstringiteratorhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/js/string-iterator.html (0 => 202956)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/js/string-iterator.html (rev 0)
+++ trunk/LayoutTests/js/string-iterator.html 2016-07-08 04:10:00 UTC (rev 202956)
</span><span class="lines">@@ -0,0 +1,10 @@
</span><ins>+<!DOCTYPE html>
+<html>
+<head>
+<script src="../resources/js-test-pre.js"></script>
+</head>
+<body>
+<script src="script-tests/string-iterator.js"></script>
+<script src="../resources/js-test-post.js"></script>
+</body>
+</html>
</ins></span></pre></div>
<a id="trunkSourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/ChangeLog (202955 => 202956)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/ChangeLog 2016-07-08 03:47:59 UTC (rev 202955)
+++ trunk/Source/JavaScriptCore/ChangeLog 2016-07-08 04:10:00 UTC (rev 202956)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2016-07-07 Benjamin Poulain <benjamin@webkit.org>
+
+ [JSC] String.prototype[Symbol.iterator] needs a name
+ https://bugs.webkit.org/show_bug.cgi?id=159541
+
+ Reviewed by Yusuke Suzuki.
+
+ A man needs a name.
+ Spec: https://tc39.github.io/ecma262/#sec-string.prototype-@@iterator
+
+ * runtime/StringPrototype.cpp:
+ (JSC::StringPrototype::finishCreation):
+
</ins><span class="cx"> 2016-07-07 Michael Saboff <msaboff@apple.com>
</span><span class="cx">
</span><span class="cx"> REGRESSION(184445): Need to insert a StoreBarrier when we don't know child's epoch
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreruntimeStringPrototypecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/runtime/StringPrototype.cpp (202955 => 202956)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/runtime/StringPrototype.cpp 2016-07-08 03:47:59 UTC (rev 202955)
+++ trunk/Source/JavaScriptCore/runtime/StringPrototype.cpp 2016-07-08 04:10:00 UTC (rev 202956)
</span><span class="lines">@@ -174,10 +174,11 @@
</span><span class="cx"> JSC_NATIVE_FUNCTION_WITHOUT_TRANSITION("endsWith", stringProtoFuncEndsWith, DontEnum, 1);
</span><span class="cx"> JSC_NATIVE_FUNCTION_WITHOUT_TRANSITION("includes", stringProtoFuncIncludes, DontEnum, 1);
</span><span class="cx"> JSC_NATIVE_FUNCTION_WITHOUT_TRANSITION("normalize", stringProtoFuncNormalize, DontEnum, 0);
</span><del>- JSC_NATIVE_FUNCTION_WITHOUT_TRANSITION(vm.propertyNames->iteratorSymbol, stringProtoFuncIterator, DontEnum, 0);
-
</del><span class="cx"> JSC_NATIVE_INTRINSIC_FUNCTION_WITHOUT_TRANSITION(vm.propertyNames->builtinNames().charCodeAtPrivateName(), stringProtoFuncCharCodeAt, DontEnum, 1, CharCodeAtIntrinsic);
</span><span class="cx">
</span><ins>+ JSFunction* iteratorFunction = JSFunction::create(vm, globalObject, 0, ASCIILiteral("[Symbol.iterator]"), stringProtoFuncIterator, NoIntrinsic);
+ putDirectWithoutTransition(vm, vm.propertyNames->iteratorSymbol, iteratorFunction, DontEnum);
+
</ins><span class="cx"> // The constructor will be added later, after StringConstructor has been built
</span><span class="cx"> putDirectWithoutTransition(vm, vm.propertyNames->length, jsNumber(0), DontDelete | ReadOnly | DontEnum);
</span><span class="cx"> }
</span></span></pre>
</div>
</div>
</body>
</html>