<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[202770] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/202770">202770</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2016-07-01 19:20:39 -0700 (Fri, 01 Jul 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>[JSC] RegExp.compile is not returning the regexp when it succeed
https://bugs.webkit.org/show_bug.cgi?id=159381
Patch by Benjamin Poulain <bpoulain@apple.com> on 2016-07-01
Reviewed by Mark Lam.
Source/JavaScriptCore:
Spec:
-https://tc39.github.io/ecma262/#sec-regexp.prototype.compile
-https://tc39.github.io/ecma262/#sec-regexpinitialize
* runtime/RegExpPrototype.cpp:
(JSC::regExpProtoFuncCompile):
LayoutTests:
* js/regexp-compile-expected.txt:
* js/script-tests/regexp-compile.js:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsjsregexpcompileexpectedtxt">trunk/LayoutTests/js/regexp-compile-expected.txt</a></li>
<li><a href="#trunkLayoutTestsjsscripttestsregexpcompilejs">trunk/LayoutTests/js/script-tests/regexp-compile.js</a></li>
<li><a href="#trunkSourceJavaScriptCoreChangeLog">trunk/Source/JavaScriptCore/ChangeLog</a></li>
<li><a href="#trunkSourceJavaScriptCoreruntimeRegExpPrototypecpp">trunk/Source/JavaScriptCore/runtime/RegExpPrototype.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (202769 => 202770)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2016-07-02 01:15:44 UTC (rev 202769)
+++ trunk/LayoutTests/ChangeLog 2016-07-02 02:20:39 UTC (rev 202770)
</span><span class="lines">@@ -1,3 +1,13 @@
</span><ins>+2016-07-01 Benjamin Poulain <bpoulain@apple.com>
+
+ [JSC] RegExp.compile is not returning the regexp when it succeed
+ https://bugs.webkit.org/show_bug.cgi?id=159381
+
+ Reviewed by Mark Lam.
+
+ * js/regexp-compile-expected.txt:
+ * js/script-tests/regexp-compile.js:
+
</ins><span class="cx"> 2016-07-01 Zalan Bujtas <zalan@apple.com>
</span><span class="cx">
</span><span class="cx"> prepareForDestruction() always needs to be called before destroying the Document object.
</span></span></pre></div>
<a id="trunkLayoutTestsjsregexpcompileexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/js/regexp-compile-expected.txt (202769 => 202770)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/js/regexp-compile-expected.txt 2016-07-02 01:15:44 UTC (rev 202769)
+++ trunk/LayoutTests/js/regexp-compile-expected.txt 2016-07-02 02:20:39 UTC (rev 202770)
</span><span class="lines">@@ -23,6 +23,9 @@
</span><span class="cx"> PASS re.toString() is '/z/'
</span><span class="cx"> PASS re.lastIndex is 0
</span><span class="cx"> PASS re.lastIndex is 1
</span><ins>+PASS regexpWithUndefinedCompiledToValid = new RegExp(undefined), regexpWithUndefinedCompiledToValid.compile('abc') is regexpWithUndefinedCompiledToValid
+PASS regexpValidPatternCompiledToValid = new RegExp('zyx'), regexpValidPatternCompiledToValid.compile('abc') is regexpValidPatternCompiledToValid
+PASS regexpWithValidCompiledToUndefined = new RegExp('abc'), regexpWithValidCompiledToUndefined.compile(undefined) is regexpWithValidCompiledToUndefined
</ins><span class="cx"> PASS successfullyParsed is true
</span><span class="cx">
</span><span class="cx"> TEST COMPLETE
</span></span></pre></div>
<a id="trunkLayoutTestsjsscripttestsregexpcompilejs"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/js/script-tests/regexp-compile.js (202769 => 202770)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/js/script-tests/regexp-compile.js 2016-07-02 01:15:44 UTC (rev 202769)
+++ trunk/LayoutTests/js/script-tests/regexp-compile.js 2016-07-02 02:20:39 UTC (rev 202770)
</span><span class="lines">@@ -49,3 +49,8 @@
</span><span class="cx"> shouldBe("re.lastIndex", "0");
</span><span class="cx"> re.exec("aaa");
</span><span class="cx"> shouldBe("re.lastIndex", "1");
</span><ins>+
+// Compile returns the regexp itself.
+shouldBe("regexpWithUndefinedCompiledToValid = new RegExp(undefined), regexpWithUndefinedCompiledToValid.compile('abc')", "regexpWithUndefinedCompiledToValid");
+shouldBe("regexpValidPatternCompiledToValid = new RegExp('zyx'), regexpValidPatternCompiledToValid.compile('abc')", "regexpValidPatternCompiledToValid");
+shouldBe("regexpWithValidCompiledToUndefined = new RegExp('abc'), regexpWithValidCompiledToUndefined.compile(undefined)", "regexpWithValidCompiledToUndefined");
</ins></span></pre></div>
<a id="trunkSourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/ChangeLog (202769 => 202770)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/ChangeLog 2016-07-02 01:15:44 UTC (rev 202769)
+++ trunk/Source/JavaScriptCore/ChangeLog 2016-07-02 02:20:39 UTC (rev 202770)
</span><span class="lines">@@ -1,3 +1,17 @@
</span><ins>+2016-07-01 Benjamin Poulain <bpoulain@apple.com>
+
+ [JSC] RegExp.compile is not returning the regexp when it succeed
+ https://bugs.webkit.org/show_bug.cgi?id=159381
+
+ Reviewed by Mark Lam.
+
+ Spec:
+ -https://tc39.github.io/ecma262/#sec-regexp.prototype.compile
+ -https://tc39.github.io/ecma262/#sec-regexpinitialize
+
+ * runtime/RegExpPrototype.cpp:
+ (JSC::regExpProtoFuncCompile):
+
</ins><span class="cx"> 2016-07-01 Saam Barati <sbarati@apple.com>
</span><span class="cx">
</span><span class="cx"> fix "ASSERTION FAILED: currentOffset() >= currentLineStartOffset()"
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreruntimeRegExpPrototypecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/runtime/RegExpPrototype.cpp (202769 => 202770)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/runtime/RegExpPrototype.cpp 2016-07-02 01:15:44 UTC (rev 202769)
+++ trunk/Source/JavaScriptCore/runtime/RegExpPrototype.cpp 2016-07-02 02:20:39 UTC (rev 202770)
</span><span class="lines">@@ -166,7 +166,7 @@
</span><span class="cx">
</span><span class="cx"> asRegExpObject(thisValue)->setRegExp(exec->vm(), regExp);
</span><span class="cx"> asRegExpObject(thisValue)->setLastIndex(exec, 0);
</span><del>- return JSValue::encode(jsUndefined());
</del><ins>+ return JSValue::encode(thisValue);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> typedef std::array<char, 5 + 1> FlagsString; // 5 different flags and a null character terminator.
</span></span></pre>
</div>
</div>
</body>
</html>