<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[202752] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/202752">202752</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2016-07-01 13:49:31 -0700 (Fri, 01 Jul 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>[JSC] Date.toGMTString should be the Date.toUTCString function
https://bugs.webkit.org/show_bug.cgi?id=159318
Patch by Benjamin Poulain <bpoulain@apple.com> on 2016-07-01
Reviewed by Mark Lam.
Source/JavaScriptCore:
See https://tc39.github.io/ecma262/#sec-date.prototype.togmtstring
* runtime/DatePrototype.cpp:
(JSC::DatePrototype::finishCreation):
(JSC::dateProtoFuncToGMTString): Deleted.
LayoutTests:
* js/date-prototype-expected.txt: Added.
* js/date-prototype.html: Added.
* js/script-tests/date-prototype.js: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsjskdeinbuilt_function_tostringexpectedtxt">trunk/LayoutTests/js/kde/inbuilt_function_tostring-expected.txt</a></li>
<li><a href="#trunkLayoutTestsjskdescripttestsinbuilt_function_tostringjs">trunk/LayoutTests/js/kde/script-tests/inbuilt_function_tostring.js</a></li>
<li><a href="#trunkSourceJavaScriptCoreChangeLog">trunk/Source/JavaScriptCore/ChangeLog</a></li>
<li><a href="#trunkSourceJavaScriptCoreruntimeDatePrototypecpp">trunk/Source/JavaScriptCore/runtime/DatePrototype.cpp</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsjsdateprototypeexpectedtxt">trunk/LayoutTests/js/date-prototype-expected.txt</a></li>
<li><a href="#trunkLayoutTestsjsdateprototypehtml">trunk/LayoutTests/js/date-prototype.html</a></li>
<li><a href="#trunkLayoutTestsjsscripttestsdateprototypejs">trunk/LayoutTests/js/script-tests/date-prototype.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (202751 => 202752)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2016-07-01 20:46:14 UTC (rev 202751)
+++ trunk/LayoutTests/ChangeLog 2016-07-01 20:49:31 UTC (rev 202752)
</span><span class="lines">@@ -1,3 +1,14 @@
</span><ins>+2016-07-01 Benjamin Poulain <bpoulain@apple.com>
+
+ [JSC] Date.toGMTString should be the Date.toUTCString function
+ https://bugs.webkit.org/show_bug.cgi?id=159318
+
+ Reviewed by Mark Lam.
+
+ * js/date-prototype-expected.txt: Added.
+ * js/date-prototype.html: Added.
+ * js/script-tests/date-prototype.js: Added.
+
</ins><span class="cx"> 2016-07-01 Frederic Wang <fwang@igalia.com>
</span><span class="cx">
</span><span class="cx"> Rebaseline some MathML tests.
</span></span></pre></div>
<a id="trunkLayoutTestsjsdateprototypeexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/js/date-prototype-expected.txt (0 => 202752)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/js/date-prototype-expected.txt (rev 0)
+++ trunk/LayoutTests/js/date-prototype-expected.txt 2016-07-01 20:49:31 UTC (rev 202752)
</span><span class="lines">@@ -0,0 +1,16 @@
</span><ins>+Check the Date's prototype properties.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS Date.prototype.toGMTString is Date.prototype.toUTCString
+PASS Date.prototype.toUTCString.name is "toUTCString"
+PASS Date.prototype.toUTCString.length is 0
+PASS typeof Date.prototype.toUTCString is "function"
+PASS Object.getOwnPropertyDescriptor(Date.prototype, "toUTCString").configurable is true
+PASS Object.getOwnPropertyDescriptor(Date.prototype, "toUTCString").enumerable is false
+PASS Object.getOwnPropertyDescriptor(Date.prototype, "toUTCString").writable is true
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
</ins></span></pre></div>
<a id="trunkLayoutTestsjsdateprototypehtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/js/date-prototype.html (0 => 202752)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/js/date-prototype.html (rev 0)
+++ trunk/LayoutTests/js/date-prototype.html 2016-07-01 20:49:31 UTC (rev 202752)
</span><span class="lines">@@ -0,0 +1,10 @@
</span><ins>+<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">
+<html>
+<head>
+<script src="../resources/js-test-pre.js"></script>
+</head>
+<body>
+<script src="script-tests/date-prototype.js"></script>
+<script src="../resources/js-test-post.js"></script>
+</body>
+</html>
</ins></span></pre></div>
<a id="trunkLayoutTestsjskdeinbuilt_function_tostringexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/js/kde/inbuilt_function_tostring-expected.txt (202751 => 202752)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/js/kde/inbuilt_function_tostring-expected.txt 2016-07-01 20:46:14 UTC (rev 202751)
+++ trunk/LayoutTests/js/kde/inbuilt_function_tostring-expected.txt 2016-07-01 20:49:31 UTC (rev 202752)
</span><span class="lines">@@ -97,7 +97,7 @@
</span><span class="cx"> PASS StripSpaces(Date.prototype.getTime.toString()) is "functiongetTime(){[nativecode]}"
</span><span class="cx"> PASS StripSpaces(Date.prototype.getFullYear.toString()) is "functiongetFullYear(){[nativecode]}"
</span><span class="cx"> PASS StripSpaces(Date.prototype.getUTCFullYear.toString()) is "functiongetUTCFullYear(){[nativecode]}"
</span><del>-PASS StripSpaces(Date.prototype.toGMTString.toString()) is "functiontoGMTString(){[nativecode]}"
</del><ins>+PASS StripSpaces(Date.prototype.toGMTString.toString()) is "functiontoUTCString(){[nativecode]}"
</ins><span class="cx"> PASS StripSpaces(Date.prototype.getMonth.toString()) is "functiongetMonth(){[nativecode]}"
</span><span class="cx"> PASS StripSpaces(Date.prototype.getUTCMonth.toString()) is "functiongetUTCMonth(){[nativecode]}"
</span><span class="cx"> PASS StripSpaces(Date.prototype.getDate.toString()) is "functiongetDate(){[nativecode]}"
</span><span class="lines">@@ -130,7 +130,7 @@
</span><span class="cx"> PASS StripSpaces(Date.prototype.setUTCFullYear.toString()) is "functionsetUTCFullYear(){[nativecode]}"
</span><span class="cx"> PASS StripSpaces(Date.prototype.setYear.toString()) is "functionsetYear(){[nativecode]}"
</span><span class="cx"> PASS StripSpaces(Date.prototype.getYear.toString()) is "functiongetYear(){[nativecode]}"
</span><del>-PASS StripSpaces(Date.prototype.toGMTString.toString()) is "functiontoGMTString(){[nativecode]}"
</del><ins>+PASS StripSpaces(Date.prototype.toGMTString.toString()) is "functiontoUTCString(){[nativecode]}"
</ins><span class="cx"> PASS StripSpaces(RegExp.prototype.exec.toString()) is "functionexec(){[nativecode]}"
</span><span class="cx"> PASS StripSpaces(RegExp.prototype.test.toString()) is "functiontest(){[nativecode]}"
</span><span class="cx"> PASS StripSpaces(RegExp.prototype.toString.toString()) is "functiontoString(){[nativecode]}"
</span></span></pre></div>
<a id="trunkLayoutTestsjskdescripttestsinbuilt_function_tostringjs"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/js/kde/script-tests/inbuilt_function_tostring.js (202751 => 202752)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/js/kde/script-tests/inbuilt_function_tostring.js 2016-07-01 20:46:14 UTC (rev 202751)
+++ trunk/LayoutTests/js/kde/script-tests/inbuilt_function_tostring.js 2016-07-01 20:49:31 UTC (rev 202752)
</span><span class="lines">@@ -129,7 +129,7 @@
</span><span class="cx"> shouldBe("StripSpaces(Date.prototype.getTime.toString())","\"functiongetTime(){[nativecode]}\"");
</span><span class="cx"> shouldBe("StripSpaces(Date.prototype.getFullYear.toString())","\"functiongetFullYear(){[nativecode]}\"");
</span><span class="cx"> shouldBe("StripSpaces(Date.prototype.getUTCFullYear.toString())","\"functiongetUTCFullYear(){[nativecode]}\"");
</span><del>-shouldBe("StripSpaces(Date.prototype.toGMTString.toString())","\"functiontoGMTString(){[nativecode]}\"");
</del><ins>+shouldBe("StripSpaces(Date.prototype.toGMTString.toString())","\"functiontoUTCString(){[nativecode]}\"");
</ins><span class="cx"> shouldBe("StripSpaces(Date.prototype.getMonth.toString())","\"functiongetMonth(){[nativecode]}\"");
</span><span class="cx"> shouldBe("StripSpaces(Date.prototype.getUTCMonth.toString())","\"functiongetUTCMonth(){[nativecode]}\"");
</span><span class="cx"> shouldBe("StripSpaces(Date.prototype.getDate.toString())","\"functiongetDate(){[nativecode]}\"");
</span><span class="lines">@@ -162,7 +162,7 @@
</span><span class="cx"> shouldBe("StripSpaces(Date.prototype.setUTCFullYear.toString())","\"functionsetUTCFullYear(){[nativecode]}\"");
</span><span class="cx"> shouldBe("StripSpaces(Date.prototype.setYear.toString())","\"functionsetYear(){[nativecode]}\"");
</span><span class="cx"> shouldBe("StripSpaces(Date.prototype.getYear.toString())","\"functiongetYear(){[nativecode]}\"");
</span><del>-shouldBe("StripSpaces(Date.prototype.toGMTString.toString())","\"functiontoGMTString(){[nativecode]}\"");
</del><ins>+shouldBe("StripSpaces(Date.prototype.toGMTString.toString())","\"functiontoUTCString(){[nativecode]}\"");
</ins><span class="cx">
</span><span class="cx"> shouldBe("StripSpaces(RegExp.prototype.exec.toString())","\"functionexec(){[nativecode]}\"");
</span><span class="cx"> shouldBe("StripSpaces(RegExp.prototype.test.toString())","\"functiontest(){[nativecode]}\"");
</span></span></pre></div>
<a id="trunkLayoutTestsjsscripttestsdateprototypejs"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/js/script-tests/date-prototype.js (0 => 202752)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/js/script-tests/date-prototype.js (rev 0)
+++ trunk/LayoutTests/js/script-tests/date-prototype.js 2016-07-01 20:49:31 UTC (rev 202752)
</span><span class="lines">@@ -0,0 +1,12 @@
</span><ins>+description("Check the Date's prototype properties.");
+
+// toGMTString.
+shouldBe('Date.prototype.toGMTString', 'Date.prototype.toUTCString');
+
+// toUTCString.
+shouldBeEqualToString('Date.prototype.toUTCString.name', 'toUTCString');
+shouldBe('Date.prototype.toUTCString.length', '0');
+shouldBeEqualToString('typeof Date.prototype.toUTCString', 'function');
+shouldBeTrue('Object.getOwnPropertyDescriptor(Date.prototype, "toUTCString").configurable');
+shouldBeFalse('Object.getOwnPropertyDescriptor(Date.prototype, "toUTCString").enumerable');
+shouldBeTrue('Object.getOwnPropertyDescriptor(Date.prototype, "toUTCString").writable');
</ins></span></pre></div>
<a id="trunkSourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/ChangeLog (202751 => 202752)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/ChangeLog 2016-07-01 20:46:14 UTC (rev 202751)
+++ trunk/Source/JavaScriptCore/ChangeLog 2016-07-01 20:49:31 UTC (rev 202752)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2016-07-01 Benjamin Poulain <bpoulain@apple.com>
+
+ [JSC] Date.toGMTString should be the Date.toUTCString function
+ https://bugs.webkit.org/show_bug.cgi?id=159318
+
+ Reviewed by Mark Lam.
+
+ See https://tc39.github.io/ecma262/#sec-date.prototype.togmtstring
+
+ * runtime/DatePrototype.cpp:
+ (JSC::DatePrototype::finishCreation):
+ (JSC::dateProtoFuncToGMTString): Deleted.
+
</ins><span class="cx"> 2016-07-01 Mark Lam <mark.lam@apple.com>
</span><span class="cx">
</span><span class="cx"> Update JSC_functionOverrides to handle the new SourceCode strings that have params.
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreruntimeDatePrototypecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/runtime/DatePrototype.cpp (202751 => 202752)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/runtime/DatePrototype.cpp 2016-07-01 20:46:14 UTC (rev 202751)
+++ trunk/Source/JavaScriptCore/runtime/DatePrototype.cpp 2016-07-01 20:49:31 UTC (rev 202752)
</span><span class="lines">@@ -107,7 +107,6 @@
</span><span class="cx"> EncodedJSValue JSC_HOST_CALL dateProtoFuncSetUTCSeconds(ExecState*);
</span><span class="cx"> EncodedJSValue JSC_HOST_CALL dateProtoFuncSetYear(ExecState*);
</span><span class="cx"> EncodedJSValue JSC_HOST_CALL dateProtoFuncToDateString(ExecState*);
</span><del>-EncodedJSValue JSC_HOST_CALL dateProtoFuncToGMTString(ExecState*);
</del><span class="cx"> EncodedJSValue JSC_HOST_CALL dateProtoFuncToLocaleDateString(ExecState*);
</span><span class="cx"> EncodedJSValue JSC_HOST_CALL dateProtoFuncToLocaleString(ExecState*);
</span><span class="cx"> EncodedJSValue JSC_HOST_CALL dateProtoFuncToLocaleTimeString(ExecState*);
</span><span class="lines">@@ -433,7 +432,6 @@
</span><span class="cx"> @begin dateTable
</span><span class="cx"> toString dateProtoFuncToString DontEnum|Function 0
</span><span class="cx"> toISOString dateProtoFuncToISOString DontEnum|Function 0
</span><del>- toUTCString dateProtoFuncToUTCString DontEnum|Function 0
</del><span class="cx"> toDateString dateProtoFuncToDateString DontEnum|Function 0
</span><span class="cx"> toTimeString dateProtoFuncToTimeString DontEnum|Function 0
</span><span class="cx"> toLocaleString dateProtoFuncToLocaleString DontEnum|Function 0
</span><span class="lines">@@ -443,7 +441,6 @@
</span><span class="cx"> getTime dateProtoFuncGetTime DontEnum|Function 0
</span><span class="cx"> getFullYear dateProtoFuncGetFullYear DontEnum|Function 0
</span><span class="cx"> getUTCFullYear dateProtoFuncGetUTCFullYear DontEnum|Function 0
</span><del>- toGMTString dateProtoFuncToGMTString DontEnum|Function 0
</del><span class="cx"> getMonth dateProtoFuncGetMonth DontEnum|Function 0
</span><span class="cx"> getUTCMonth dateProtoFuncGetUTCMonth DontEnum|Function 0
</span><span class="cx"> getDate dateProtoFuncGetDate DontEnum|Function 0
</span><span class="lines">@@ -492,6 +489,11 @@
</span><span class="cx"> Base::finishCreation(vm);
</span><span class="cx"> ASSERT(inherits(info()));
</span><span class="cx">
</span><ins>+ Identifier toUTCStringName = Identifier::fromString(&vm, ASCIILiteral("toUTCString"));
+ JSFunction* toUTCStringFunction = JSFunction::create(vm, globalObject, 0, toUTCStringName.string(), dateProtoFuncToUTCString);
+ putDirectWithoutTransition(vm, toUTCStringName, toUTCStringFunction, DontEnum);
+ putDirectWithoutTransition(vm, Identifier::fromString(&vm, ASCIILiteral("toGMTString")), toUTCStringFunction, DontEnum);
+
</ins><span class="cx"> #if ENABLE(INTL)
</span><span class="cx"> JSC_BUILTIN_FUNCTION_WITHOUT_TRANSITION("toLocaleString", datePrototypeToLocaleStringCodeGenerator, DontEnum);
</span><span class="cx"> JSC_BUILTIN_FUNCTION_WITHOUT_TRANSITION("toLocaleDateString", datePrototypeToLocaleDateStringCodeGenerator, DontEnum);
</span><span class="lines">@@ -652,12 +654,6 @@
</span><span class="cx"> return JSValue::encode(jsNumber(gregorianDateTime->year()));
</span><span class="cx"> }
</span><span class="cx">
</span><del>-EncodedJSValue JSC_HOST_CALL dateProtoFuncToGMTString(ExecState* exec)
-{
- const bool asUTCVariant = true;
- return formateDateInstance(exec, DateTimeFormatDateAndTime, asUTCVariant);
-}
-
</del><span class="cx"> EncodedJSValue JSC_HOST_CALL dateProtoFuncGetMonth(ExecState* exec)
</span><span class="cx"> {
</span><span class="cx"> JSValue thisValue = exec->thisValue();
</span></span></pre>
</div>
</div>
</body>
</html>