<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[202728] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/202728">202728</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2016-07-01 00:47:14 -0700 (Fri, 01 Jul 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Add a runtime flag for DOM iterators
https://bugs.webkit.org/show_bug.cgi?id=159300
Patch by Youenn Fablet <youennf@gmail.com> on 2016-07-01
Reviewed by Alex Christensen.
Source/JavaScriptCore:
* runtime/CommonIdentifiers.h:
Source/WebCore:
* Modules/fetch/FetchHeaders.idl: Making iterator runtime-enabled.
* bindings/generic/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::setDOMIteratorEnabled):
(WebCore::RuntimeEnabledFeatures::domIteratorEnabled):
* bindings/scripts/CodeGeneratorJS.pm:
(ToMethodName): Fixing dOM -> dom casing issue.
(GenerateImplementation): Using addIterableProperties new method.
(addIterableProperties): Activating property addition according runtime flag if iterator is rnutime flagged.
* bindings/scripts/IDLParser.pm:
(parseOptionalIterableInterface): Adding extendedAttributes to iterable.
* bindings/scripts/test/JS/JSTestNode.cpp:
(WebCore::JSTestNodePrototype::finishCreation):
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::JSTestObjPrototype::finishCreation):
* bindings/scripts/test/TestNode.idl: Making iterator runtime-enabled.
* bindings/scripts/test/TestObj.idl: Ditto.
* css/FontFaceSet.idl: Ditto.
* dom/NodeList.idl: Ditto.
Source/WebKit/mac:
* WebView/WebPreferenceKeysPrivate.h:
* WebView/WebPreferences.mm:
(-[WebPreferences DOMIteratorEnabled]):
(-[WebPreferences setDOMIteratorEnabled:]):
* WebView/WebPreferencesPrivate.h:
* WebView/WebView.mm:
(-[WebView _preferencesChanged:]):
Source/WebKit/win:
* WebPreferenceKeysPrivate.h:
* WebPreferences.cpp:
(WebPreferences::domIteratorEnabled):
(WebPreferences::setDOMIteratorEnabled):
(WebView::notifyPreferencesChanged):
* WebPreferencesreferences.h:
* WebView.cpp:
(WebView::notifyPreferencesChanged):
Source/WebKit2:
* Shared/WebPreferencesDefinitions.h:
* WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
Tools:
* DumpRenderTree/mac/DumpRenderTree.mm:
(resetWebPreferencesToConsistentValues):
* DumpRenderTree/win/DumpRenderTree.cpp:
(resetWebPreferencesToConsistentValues):
* Scripts/webkitperl/FeatureList.pm:
* WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::beginTesting):
* WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::TestRunner::setDOMIteratorEnabled):
* WebKitTestRunner/InjectedBundle/TestRunner.h:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceJavaScriptCoreChangeLog">trunk/Source/JavaScriptCore/ChangeLog</a></li>
<li><a href="#trunkSourceJavaScriptCoreruntimeCommonIdentifiersh">trunk/Source/JavaScriptCore/runtime/CommonIdentifiers.h</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreModulesfetchFetchHeadersidl">trunk/Source/WebCore/Modules/fetch/FetchHeaders.idl</a></li>
<li><a href="#trunkSourceWebCorebindingsgenericRuntimeEnabledFeaturesh">trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.h</a></li>
<li><a href="#trunkSourceWebCorebindingsscriptsCodeGeneratorJSpm">trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm</a></li>
<li><a href="#trunkSourceWebCorebindingsscriptsIDLParserpm">trunk/Source/WebCore/bindings/scripts/IDLParser.pm</a></li>
<li><a href="#trunkSourceWebCorebindingsscriptstestJSJSTestNodecpp">trunk/Source/WebCore/bindings/scripts/test/JS/JSTestNode.cpp</a></li>
<li><a href="#trunkSourceWebCorebindingsscriptstestJSJSTestObjcpp">trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp</a></li>
<li><a href="#trunkSourceWebCorebindingsscriptstestTestNodeidl">trunk/Source/WebCore/bindings/scripts/test/TestNode.idl</a></li>
<li><a href="#trunkSourceWebCorebindingsscriptstestTestObjidl">trunk/Source/WebCore/bindings/scripts/test/TestObj.idl</a></li>
<li><a href="#trunkSourceWebCorecssFontFaceSetidl">trunk/Source/WebCore/css/FontFaceSet.idl</a></li>
<li><a href="#trunkSourceWebCoredomNodeListidl">trunk/Source/WebCore/dom/NodeList.idl</a></li>
<li><a href="#trunkSourceWebKitmacChangeLog">trunk/Source/WebKit/mac/ChangeLog</a></li>
<li><a href="#trunkSourceWebKitmacWebViewWebPreferenceKeysPrivateh">trunk/Source/WebKit/mac/WebView/WebPreferenceKeysPrivate.h</a></li>
<li><a href="#trunkSourceWebKitmacWebViewWebPreferencesmm">trunk/Source/WebKit/mac/WebView/WebPreferences.mm</a></li>
<li><a href="#trunkSourceWebKitmacWebViewWebPreferencesPrivateh">trunk/Source/WebKit/mac/WebView/WebPreferencesPrivate.h</a></li>
<li><a href="#trunkSourceWebKitmacWebViewWebViewmm">trunk/Source/WebKit/mac/WebView/WebView.mm</a></li>
<li><a href="#trunkSourceWebKitwinChangeLog">trunk/Source/WebKit/win/ChangeLog</a></li>
<li><a href="#trunkSourceWebKitwinInterfacesIWebPreferencesPrivateidl">trunk/Source/WebKit/win/Interfaces/IWebPreferencesPrivate.idl</a></li>
<li><a href="#trunkSourceWebKitwinWebPreferenceKeysPrivateh">trunk/Source/WebKit/win/WebPreferenceKeysPrivate.h</a></li>
<li><a href="#trunkSourceWebKitwinWebPreferencescpp">trunk/Source/WebKit/win/WebPreferences.cpp</a></li>
<li><a href="#trunkSourceWebKitwinWebPreferencesh">trunk/Source/WebKit/win/WebPreferences.h</a></li>
<li><a href="#trunkSourceWebKitwinWebViewcpp">trunk/Source/WebKit/win/WebView.cpp</a></li>
<li><a href="#trunkSourceWebKit2ChangeLog">trunk/Source/WebKit2/ChangeLog</a></li>
<li><a href="#trunkSourceWebKit2SharedWebPreferencesDefinitionsh">trunk/Source/WebKit2/Shared/WebPreferencesDefinitions.h</a></li>
<li><a href="#trunkSourceWebKit2WebProcessInjectedBundleInjectedBundlecpp">trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp</a></li>
<li><a href="#trunkSourceWebKit2WebProcessWebPageWebPagecpp">trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp</a></li>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
<li><a href="#trunkToolsDumpRenderTreemacDumpRenderTreemm">trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm</a></li>
<li><a href="#trunkToolsDumpRenderTreewinDumpRenderTreecpp">trunk/Tools/DumpRenderTree/win/DumpRenderTree.cpp</a></li>
<li><a href="#trunkToolsScriptswebkitperlFeatureListpm">trunk/Tools/Scripts/webkitperl/FeatureList.pm</a></li>
<li><a href="#trunkToolsWebKitTestRunnerInjectedBundleInjectedBundlecpp">trunk/Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp</a></li>
<li><a href="#trunkToolsWebKitTestRunnerInjectedBundleTestRunnercpp">trunk/Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp</a></li>
<li><a href="#trunkToolsWebKitTestRunnerInjectedBundleTestRunnerh">trunk/Tools/WebKitTestRunner/InjectedBundle/TestRunner.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/ChangeLog (202727 => 202728)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/ChangeLog 2016-07-01 07:29:53 UTC (rev 202727)
+++ trunk/Source/JavaScriptCore/ChangeLog 2016-07-01 07:47:14 UTC (rev 202728)
</span><span class="lines">@@ -1,3 +1,12 @@
</span><ins>+2016-07-01 Youenn Fablet <youennf@gmail.com>
+
+ Add a runtime flag for DOM iterators
+ https://bugs.webkit.org/show_bug.cgi?id=159300
+
+ Reviewed by Alex Christensen.
+
+ * runtime/CommonIdentifiers.h:
+
</ins><span class="cx"> 2016-06-30 Joseph Pecoraro <pecoraro@apple.com>
</span><span class="cx">
</span><span class="cx"> Web Inspector: Wrong function name next to scope
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreruntimeCommonIdentifiersh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/runtime/CommonIdentifiers.h (202727 => 202728)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/runtime/CommonIdentifiers.h 2016-07-01 07:29:53 UTC (rev 202727)
+++ trunk/Source/JavaScriptCore/runtime/CommonIdentifiers.h 2016-07-01 07:47:14 UTC (rev 202728)
</span><span class="lines">@@ -38,6 +38,7 @@
</span><span class="cx"> macro(Date) \
</span><span class="cx"> macro(DateTimeFormat) \
</span><span class="cx"> macro(DocumentTimeline) \
</span><ins>+ macro(DOMIterator) \
</ins><span class="cx"> macro(Error) \
</span><span class="cx"> macro(EvalError) \
</span><span class="cx"> macro(Function) \
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (202727 => 202728)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-07-01 07:29:53 UTC (rev 202727)
+++ trunk/Source/WebCore/ChangeLog 2016-07-01 07:47:14 UTC (rev 202728)
</span><span class="lines">@@ -1,3 +1,29 @@
</span><ins>+2016-07-01 Youenn Fablet <youennf@gmail.com>
+
+ Add a runtime flag for DOM iterators
+ https://bugs.webkit.org/show_bug.cgi?id=159300
+
+ Reviewed by Alex Christensen.
+
+ * Modules/fetch/FetchHeaders.idl: Making iterator runtime-enabled.
+ * bindings/generic/RuntimeEnabledFeatures.h:
+ (WebCore::RuntimeEnabledFeatures::setDOMIteratorEnabled):
+ (WebCore::RuntimeEnabledFeatures::domIteratorEnabled):
+ * bindings/scripts/CodeGeneratorJS.pm:
+ (ToMethodName): Fixing dOM -> dom casing issue.
+ (GenerateImplementation): Using addIterableProperties new method.
+ (addIterableProperties): Activating property addition according runtime flag if iterator is rnutime flagged.
+ * bindings/scripts/IDLParser.pm:
+ (parseOptionalIterableInterface): Adding extendedAttributes to iterable.
+ * bindings/scripts/test/JS/JSTestNode.cpp:
+ (WebCore::JSTestNodePrototype::finishCreation):
+ * bindings/scripts/test/JS/JSTestObj.cpp:
+ (WebCore::JSTestObjPrototype::finishCreation):
+ * bindings/scripts/test/TestNode.idl: Making iterator runtime-enabled.
+ * bindings/scripts/test/TestObj.idl: Ditto.
+ * css/FontFaceSet.idl: Ditto.
+ * dom/NodeList.idl: Ditto.
+
</ins><span class="cx"> 2016-07-01 Frederic Wang <fwang.igalia.com>
</span><span class="cx">
</span><span class="cx"> Eliminate trailing whitespace in MathML code
</span></span></pre></div>
<a id="trunkSourceWebCoreModulesfetchFetchHeadersidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/fetch/FetchHeaders.idl (202727 => 202728)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/fetch/FetchHeaders.idl 2016-07-01 07:29:53 UTC (rev 202727)
+++ trunk/Source/WebCore/Modules/fetch/FetchHeaders.idl 2016-07-01 07:47:14 UTC (rev 202728)
</span><span class="lines">@@ -41,7 +41,7 @@
</span><span class="cx"> [RaisesException] boolean has(DOMString name);
</span><span class="cx"> [RaisesException] void set(DOMString name, DOMString value);
</span><span class="cx">
</span><del>- iterable<DOMString, DOMString>;
</del><ins>+ [EnabledAtRuntime=DOMIterator] iterable<DOMString, DOMString>;
</ins><span class="cx">
</span><span class="cx"> [PrivateIdentifier, RaisesException, ImplementedAs=append] void appendFromJS(DOMString name, DOMString value);
</span><span class="cx"> [PrivateIdentifier, ImplementedAs=fill] void fillFromJS(FetchHeaders? headers);
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsgenericRuntimeEnabledFeaturesh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.h (202727 => 202728)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.h 2016-07-01 07:29:53 UTC (rev 202727)
+++ trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.h 2016-07-01 07:47:14 UTC (rev 202728)
</span><span class="lines">@@ -58,6 +58,9 @@
</span><span class="cx"> void setDataTransferItemsEnabled(bool isEnabled) { m_isDataTransferItemsEnabled = isEnabled; }
</span><span class="cx"> bool dataTransferItemsEnabled() const { return m_isDataTransferItemsEnabled; }
</span><span class="cx">
</span><ins>+ void setDOMIteratorEnabled(bool isEnabled) { m_isDOMIteratorEnabled = isEnabled; }
+ bool domIteratorEnabled() const { return m_isDOMIteratorEnabled; }
+
</ins><span class="cx"> void setGeolocationEnabled(bool isEnabled) { m_isGeolocationEnabled = isEnabled; }
</span><span class="cx"> bool geolocationEnabled() const { return m_isGeolocationEnabled; }
</span><span class="cx">
</span><span class="lines">@@ -234,6 +237,7 @@
</span><span class="cx"> bool m_isWebkitNotificationsEnabled;
</span><span class="cx"> bool m_isApplicationCacheEnabled;
</span><span class="cx"> bool m_isDataTransferItemsEnabled;
</span><ins>+ bool m_isDOMIteratorEnabled { true };
</ins><span class="cx"> bool m_isGeolocationEnabled;
</span><span class="cx"> bool m_isTouchEnabled;
</span><span class="cx"> bool m_isDeviceMotionEnabled;
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsscriptsCodeGeneratorJSpm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm (202727 => 202728)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm 2016-07-01 07:29:53 UTC (rev 202727)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm 2016-07-01 07:47:14 UTC (rev 202728)
</span><span class="lines">@@ -1956,12 +1956,13 @@
</span><span class="cx"> {
</span><span class="cx"> my $param = shift;
</span><span class="cx"> my $ret = lcfirst($param);
</span><ins>+ $ret =~ s/cSS/css/ if $ret =~ /^cSS/;
+ $ret =~ s/dOM/dom/ if $ret =~ /^dOM/;
</ins><span class="cx"> $ret =~ s/hTML/html/ if $ret =~ /^hTML/;
</span><ins>+ $ret =~ s/jS/js/ if $ret =~ /^jS/;
</ins><span class="cx"> $ret =~ s/uRL/url/ if $ret =~ /^uRL/;
</span><del>- $ret =~ s/jS/js/ if $ret =~ /^jS/;
</del><span class="cx"> $ret =~ s/xML/xml/ if $ret =~ /^xML/;
</span><span class="cx"> $ret =~ s/xSLT/xslt/ if $ret =~ /^xSLT/;
</span><del>- $ret =~ s/cSS/css/ if $ret =~ /^cSS/;
</del><span class="cx">
</span><span class="cx"> # For HTML5 FileSystem API Flags attributes.
</span><span class="cx"> # (create is widely used to instantiate an object and must be avoided.)
</span><span class="lines">@@ -2309,8 +2310,7 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> if ($interface->iterable) {
</span><del>- my $functionName = GetFunctionName($interface, $className, @{$interface->iterable->functions}[0]);
- push(@implContent, " putDirect(vm, vm.propertyNames->iteratorSymbol, JSFunction::create(vm, globalObject(), 0, ASCIILiteral(\"[Symbol.Iterator]\"), $functionName), DontEnum);\n");
</del><ins>+ addIterableProperties($interface, $className);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> push(@implContent, "}\n\n");
</span><span class="lines">@@ -4247,6 +4247,26 @@
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+sub addIterableProperties()
+{
+ my $interface = shift;
+ my $className = shift;
+
+ if ($interface->iterable->extendedAttributes->{"EnabledAtRuntime"}) {
+ AddToImplIncludes("RuntimeEnabledFeatures.h");
+ my $enable_function = GetRuntimeEnableFunctionName($interface->iterable);
+ push(@implContent, " if (${enable_function}()) {\n ");
+ }
+
+ my $functionName = GetFunctionName($interface, $className, @{$interface->iterable->functions}[0]);
+ push(@implContent, " putDirect(vm, vm.propertyNames->iteratorSymbol, JSFunction::create(vm, globalObject(), 0, ASCIILiteral(\"[Symbol.Iterator]\"), $functionName), DontEnum);\n");
+
+ if ($interface->iterable->extendedAttributes->{"EnabledAtRuntime"}) {
+ push(@implContent, " }\n");
+ }
+
+}
+
</ins><span class="cx"> sub GetNativeTypeFromSignature
</span><span class="cx"> {
</span><span class="cx"> my ($interface, $signature) = @_;
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsscriptsIDLParserpm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/scripts/IDLParser.pm (202727 => 202728)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/scripts/IDLParser.pm 2016-07-01 07:29:53 UTC (rev 202727)
+++ trunk/Source/WebCore/bindings/scripts/IDLParser.pm 2016-07-01 07:47:14 UTC (rev 202728)
</span><span class="lines">@@ -93,6 +93,7 @@
</span><span class="cx"> keyType => '$', # Key type for map iterables
</span><span class="cx"> valueType => '$', # Value type for map or set iterables
</span><span class="cx"> functions => '@', # Iterable functions (entries, keys, values, [Symbol.Iterator], forEach)
</span><ins>+ extendedAttributes => '$', # Extended attributes
</ins><span class="cx"> });
</span><span class="cx">
</span><span class="cx">
</span><span class="lines">@@ -1408,6 +1409,7 @@
</span><span class="cx"> push(@{$forEachFunction->parameters}, ($forEachArgument));
</span><span class="cx">
</span><span class="cx"> my $newDataNode = domIterable->new();
</span><ins>+ $newDataNode->extendedAttributes($extendedAttributeList);
</ins><span class="cx"> push(@{$newDataNode->functions}, $symbolIteratorFunction);
</span><span class="cx"> push(@{$newDataNode->functions}, $entriesFunction);
</span><span class="cx"> push(@{$newDataNode->functions}, $keysFunction);
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsscriptstestJSJSTestNodecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestNode.cpp (202727 => 202728)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestNode.cpp 2016-07-01 07:29:53 UTC (rev 202727)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestNode.cpp 2016-07-01 07:47:14 UTC (rev 202728)
</span><span class="lines">@@ -25,6 +25,7 @@
</span><span class="cx"> #include "JSDOMBinding.h"
</span><span class="cx"> #include "JSDOMConstructor.h"
</span><span class="cx"> #include "JSDOMIterator.h"
</span><ins>+#include "RuntimeEnabledFeatures.h"
</ins><span class="cx"> #include "URL.h"
</span><span class="cx"> #include <runtime/Error.h>
</span><span class="cx"> #include <runtime/JSString.h>
</span><span class="lines">@@ -115,7 +116,29 @@
</span><span class="cx"> {
</span><span class="cx"> Base::finishCreation(vm);
</span><span class="cx"> reifyStaticProperties(vm, JSTestNodePrototypeTableValues, *this);
</span><del>- putDirect(vm, vm.propertyNames->iteratorSymbol, JSFunction::create(vm, globalObject(), 0, ASCIILiteral("[Symbol.Iterator]"), jsTestNodePrototypeFunctionSymbolIterator), DontEnum);
</del><ins>+ if (!RuntimeEnabledFeatures::sharedFeatures().domIteratorEnabled()) {
+ Identifier propertyName = Identifier::fromString(&vm, reinterpret_cast<const LChar*>("entries"), strlen("entries"));
+ VM::DeletePropertyModeScope scope(vm, VM::DeletePropertyMode::IgnoreConfigurable);
+ JSObject::deleteProperty(this, globalObject()->globalExec(), propertyName);
+ }
+ if (!RuntimeEnabledFeatures::sharedFeatures().domIteratorEnabled()) {
+ Identifier propertyName = Identifier::fromString(&vm, reinterpret_cast<const LChar*>("keys"), strlen("keys"));
+ VM::DeletePropertyModeScope scope(vm, VM::DeletePropertyMode::IgnoreConfigurable);
+ JSObject::deleteProperty(this, globalObject()->globalExec(), propertyName);
+ }
+ if (!RuntimeEnabledFeatures::sharedFeatures().domIteratorEnabled()) {
+ Identifier propertyName = Identifier::fromString(&vm, reinterpret_cast<const LChar*>("values"), strlen("values"));
+ VM::DeletePropertyModeScope scope(vm, VM::DeletePropertyMode::IgnoreConfigurable);
+ JSObject::deleteProperty(this, globalObject()->globalExec(), propertyName);
+ }
+ if (!RuntimeEnabledFeatures::sharedFeatures().domIteratorEnabled()) {
+ Identifier propertyName = Identifier::fromString(&vm, reinterpret_cast<const LChar*>("forEach"), strlen("forEach"));
+ VM::DeletePropertyModeScope scope(vm, VM::DeletePropertyMode::IgnoreConfigurable);
+ JSObject::deleteProperty(this, globalObject()->globalExec(), propertyName);
+ }
+ if (RuntimeEnabledFeatures::sharedFeatures().domIteratorEnabled()) {
+ putDirect(vm, vm.propertyNames->iteratorSymbol, JSFunction::create(vm, globalObject(), 0, ASCIILiteral("[Symbol.Iterator]"), jsTestNodePrototypeFunctionSymbolIterator), DontEnum);
+ }
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> const ClassInfo JSTestNode::s_info = { "TestNode", &Base::s_info, 0, CREATE_METHOD_TABLE(JSTestNode) };
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsscriptstestJSJSTestObjcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp (202727 => 202728)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp 2016-07-01 07:29:53 UTC (rev 202727)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp 2016-07-01 07:47:14 UTC (rev 202728)
</span><span class="lines">@@ -1317,6 +1317,26 @@
</span><span class="cx"> JSObject::deleteProperty(this, globalObject()->globalExec(), propertyName);
</span><span class="cx"> }
</span><span class="cx"> #endif
</span><ins>+ if (!RuntimeEnabledFeatures::sharedFeatures().domIteratorEnabled()) {
+ Identifier propertyName = Identifier::fromString(&vm, reinterpret_cast<const LChar*>("entries"), strlen("entries"));
+ VM::DeletePropertyModeScope scope(vm, VM::DeletePropertyMode::IgnoreConfigurable);
+ JSObject::deleteProperty(this, globalObject()->globalExec(), propertyName);
+ }
+ if (!RuntimeEnabledFeatures::sharedFeatures().domIteratorEnabled()) {
+ Identifier propertyName = Identifier::fromString(&vm, reinterpret_cast<const LChar*>("keys"), strlen("keys"));
+ VM::DeletePropertyModeScope scope(vm, VM::DeletePropertyMode::IgnoreConfigurable);
+ JSObject::deleteProperty(this, globalObject()->globalExec(), propertyName);
+ }
+ if (!RuntimeEnabledFeatures::sharedFeatures().domIteratorEnabled()) {
+ Identifier propertyName = Identifier::fromString(&vm, reinterpret_cast<const LChar*>("values"), strlen("values"));
+ VM::DeletePropertyModeScope scope(vm, VM::DeletePropertyMode::IgnoreConfigurable);
+ JSObject::deleteProperty(this, globalObject()->globalExec(), propertyName);
+ }
+ if (!RuntimeEnabledFeatures::sharedFeatures().domIteratorEnabled()) {
+ Identifier propertyName = Identifier::fromString(&vm, reinterpret_cast<const LChar*>("forEach"), strlen("forEach"));
+ VM::DeletePropertyModeScope scope(vm, VM::DeletePropertyMode::IgnoreConfigurable);
+ JSObject::deleteProperty(this, globalObject()->globalExec(), propertyName);
+ }
</ins><span class="cx"> #if ENABLE(TEST_FEATURE)
</span><span class="cx"> if (!RuntimeEnabledFeatures::sharedFeatures().testFeatureEnabled()) {
</span><span class="cx"> Identifier propertyName = Identifier::fromString(&vm, reinterpret_cast<const LChar*>("enabledAtRuntimeAttribute"), strlen("enabledAtRuntimeAttribute"));
</span><span class="lines">@@ -1327,7 +1347,9 @@
</span><span class="cx"> JSVMClientData& clientData = *static_cast<JSVMClientData*>(vm.clientData);
</span><span class="cx"> putDirect(vm, clientData.builtinNames().privateMethodPrivateName(), JSFunction::create(vm, globalObject(), 0, String(), jsTestObjPrototypeFunctionPrivateMethod), ReadOnly | DontEnum);
</span><span class="cx"> putDirect(vm, clientData.builtinNames().publicAndPrivateMethodPrivateName(), JSFunction::create(vm, globalObject(), 0, String(), jsTestObjPrototypeFunctionPublicAndPrivateMethod), ReadOnly | DontEnum);
</span><del>- putDirect(vm, vm.propertyNames->iteratorSymbol, JSFunction::create(vm, globalObject(), 0, ASCIILiteral("[Symbol.Iterator]"), jsTestObjPrototypeFunctionSymbolIterator), DontEnum);
</del><ins>+ if (RuntimeEnabledFeatures::sharedFeatures().domIteratorEnabled()) {
+ putDirect(vm, vm.propertyNames->iteratorSymbol, JSFunction::create(vm, globalObject(), 0, ASCIILiteral("[Symbol.Iterator]"), jsTestObjPrototypeFunctionSymbolIterator), DontEnum);
+ }
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> const ClassInfo JSTestObj::s_info = { "TestObject", &Base::s_info, &JSTestObjTable, CREATE_METHOD_TABLE(JSTestObj) };
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsscriptstestTestNodeidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/scripts/test/TestNode.idl (202727 => 202728)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/scripts/test/TestNode.idl 2016-07-01 07:29:53 UTC (rev 202727)
+++ trunk/Source/WebCore/bindings/scripts/test/TestNode.idl 2016-07-01 07:47:14 UTC (rev 202728)
</span><span class="lines">@@ -24,6 +24,6 @@
</span><span class="cx"> ] interface TestNode : Node {
</span><span class="cx"> attribute DOMString name;
</span><span class="cx">
</span><del>- iterable<TestNode>;
</del><ins>+ [EnabledAtRuntime=DOMIterator] iterable<TestNode>;
</ins><span class="cx"> };
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsscriptstestTestObjidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/scripts/test/TestObj.idl (202727 => 202728)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/scripts/test/TestObj.idl 2016-07-01 07:29:53 UTC (rev 202727)
+++ trunk/Source/WebCore/bindings/scripts/test/TestObj.idl 2016-07-01 07:47:14 UTC (rev 202728)
</span><span class="lines">@@ -95,7 +95,7 @@
</span><span class="cx"> // TypedArray attribute
</span><span class="cx"> attribute Float32Array typedArrayAttr;
</span><span class="cx">
</span><del>- iterable<DOMString, TestObj>;
</del><ins>+ [EnabledAtRuntime=DOMIterator] iterable<DOMString, TestObj>;
</ins><span class="cx">
</span><span class="cx"> // Methods
</span><span class="cx"> void voidMethod();
</span></span></pre></div>
<a id="trunkSourceWebCorecssFontFaceSetidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/FontFaceSet.idl (202727 => 202728)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/FontFaceSet.idl 2016-07-01 07:29:53 UTC (rev 202727)
+++ trunk/Source/WebCore/css/FontFaceSet.idl 2016-07-01 07:47:14 UTC (rev 202728)
</span><span class="lines">@@ -35,7 +35,7 @@
</span><span class="cx"> boolean has(FontFace font);
</span><span class="cx">
</span><span class="cx"> // FIXME: We should add support for the setlike declaration.
</span><del>- iterable<FontFace>;
</del><ins>+ [EnabledAtRuntime=DOMIterator] iterable<FontFace>;
</ins><span class="cx">
</span><span class="cx"> readonly attribute long size;
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoredomNodeListidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/NodeList.idl (202727 => 202728)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/NodeList.idl 2016-07-01 07:29:53 UTC (rev 202727)
+++ trunk/Source/WebCore/dom/NodeList.idl 2016-07-01 07:47:14 UTC (rev 202728)
</span><span class="lines">@@ -27,6 +27,6 @@
</span><span class="cx"> ] interface NodeList {
</span><span class="cx"> getter Node item(unsigned long index);
</span><span class="cx"> readonly attribute unsigned long length;
</span><del>- iterable<Node>;
</del><ins>+ [EnabledAtRuntime=DOMIterator] iterable<Node>;
</ins><span class="cx"> };
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebKitmacChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/ChangeLog (202727 => 202728)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/ChangeLog 2016-07-01 07:29:53 UTC (rev 202727)
+++ trunk/Source/WebKit/mac/ChangeLog 2016-07-01 07:47:14 UTC (rev 202728)
</span><span class="lines">@@ -1,3 +1,18 @@
</span><ins>+2016-07-01 Youenn Fablet <youennf@gmail.com>
+
+ Add a runtime flag for DOM iterators
+ https://bugs.webkit.org/show_bug.cgi?id=159300
+
+ Reviewed by Alex Christensen.
+
+ * WebView/WebPreferenceKeysPrivate.h:
+ * WebView/WebPreferences.mm:
+ (-[WebPreferences DOMIteratorEnabled]):
+ (-[WebPreferences setDOMIteratorEnabled:]):
+ * WebView/WebPreferencesPrivate.h:
+ * WebView/WebView.mm:
+ (-[WebView _preferencesChanged:]):
+
</ins><span class="cx"> 2016-06-30 Jiewen Tan <jiewen_tan@apple.com>
</span><span class="cx">
</span><span class="cx"> Create a generic "linked-on-or-after" check for new CSP Rules
</span></span></pre></div>
<a id="trunkSourceWebKitmacWebViewWebPreferenceKeysPrivateh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/WebView/WebPreferenceKeysPrivate.h (202727 => 202728)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/WebView/WebPreferenceKeysPrivate.h 2016-07-01 07:29:53 UTC (rev 202727)
+++ trunk/Source/WebKit/mac/WebView/WebPreferenceKeysPrivate.h 2016-07-01 07:47:14 UTC (rev 202728)
</span><span class="lines">@@ -161,6 +161,7 @@
</span><span class="cx"> #define WebKitMediaKeysStorageDirectoryKey @"WebKitMediaKeysStorageDirectory"
</span><span class="cx"> #define WebKitShadowDOMEnabledPreferenceKey @"WebKitShadowDOMEnabled"
</span><span class="cx"> #define WebKitCustomElementsEnabledPreferenceKey @"WebKitCustomElementsEnabled"
</span><ins>+#define WebKitDOMIteratorEnabledPreferenceKey @"WebKitDOMIteratorEnabled"
</ins><span class="cx"> #define WebKitFetchAPIEnabledPreferenceKey @"WebKitFetchAPIEnabled"
</span><span class="cx"> #define WebKitDownloadAttributeEnabledPreferenceKey @"WebKitDownloadAttributeEnabled"
</span><span class="cx"> #define WebKitCSSGridLayoutEnabledPreferenceKey @"WebKitCSSGridLayoutEnabled"
</span></span></pre></div>
<a id="trunkSourceWebKitmacWebViewWebPreferencesmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/WebView/WebPreferences.mm (202727 => 202728)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/WebView/WebPreferences.mm 2016-07-01 07:29:53 UTC (rev 202727)
+++ trunk/Source/WebKit/mac/WebView/WebPreferences.mm 2016-07-01 07:47:14 UTC (rev 202728)
</span><span class="lines">@@ -2722,6 +2722,16 @@
</span><span class="cx"> [self _setBoolValue:flag forKey:WebKitCustomElementsEnabledPreferenceKey];
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+- (BOOL)DOMIteratorEnabled
+{
+ return [self _boolValueForKey:WebKitDOMIteratorEnabledPreferenceKey];
+}
+
+- (void)setDOMIteratorEnabled:(BOOL)flag
+{
+ [self _setBoolValue:flag forKey:WebKitDOMIteratorEnabledPreferenceKey];
+}
+
</ins><span class="cx"> - (BOOL)fetchAPIEnabled
</span><span class="cx"> {
</span><span class="cx"> return [self _boolValueForKey:WebKitFetchAPIEnabledPreferenceKey];
</span></span></pre></div>
<a id="trunkSourceWebKitmacWebViewWebPreferencesPrivateh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/WebView/WebPreferencesPrivate.h (202727 => 202728)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/WebView/WebPreferencesPrivate.h 2016-07-01 07:29:53 UTC (rev 202727)
+++ trunk/Source/WebKit/mac/WebView/WebPreferencesPrivate.h 2016-07-01 07:47:14 UTC (rev 202728)
</span><span class="lines">@@ -481,6 +481,9 @@
</span><span class="cx"> - (void)setCustomElementsEnabled:(BOOL)flag;
</span><span class="cx"> - (BOOL)customElementsEnabled;
</span><span class="cx">
</span><ins>+- (void)setDOMIteratorEnabled:(BOOL)flag;
+- (BOOL)DOMIteratorEnabled;
+
</ins><span class="cx"> - (void)setFetchAPIEnabled:(BOOL)flag;
</span><span class="cx"> - (BOOL)fetchAPIEnabled;
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebKitmacWebViewWebViewmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/WebView/WebView.mm (202727 => 202728)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/WebView/WebView.mm 2016-07-01 07:29:53 UTC (rev 202727)
+++ trunk/Source/WebKit/mac/WebView/WebView.mm 2016-07-01 07:47:14 UTC (rev 202728)
</span><span class="lines">@@ -2498,6 +2498,8 @@
</span><span class="cx">
</span><span class="cx"> RuntimeEnabledFeatures::sharedFeatures().setShadowDOMEnabled([preferences shadowDOMEnabled]);
</span><span class="cx">
</span><ins>+ RuntimeEnabledFeatures::sharedFeatures().setDOMIteratorEnabled([preferences DOMIteratorEnabled]);
+
</ins><span class="cx"> #if ENABLE(CUSTOM_ELEMENTS)
</span><span class="cx"> RuntimeEnabledFeatures::sharedFeatures().setCustomElementsEnabled([preferences customElementsEnabled]);
</span><span class="cx"> #endif
</span></span></pre></div>
<a id="trunkSourceWebKitwinChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/win/ChangeLog (202727 => 202728)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/win/ChangeLog 2016-07-01 07:29:53 UTC (rev 202727)
+++ trunk/Source/WebKit/win/ChangeLog 2016-07-01 07:47:14 UTC (rev 202728)
</span><span class="lines">@@ -1,3 +1,19 @@
</span><ins>+2016-07-01 Youenn Fablet <youennf@gmail.com>
+
+ Add a runtime flag for DOM iterators
+ https://bugs.webkit.org/show_bug.cgi?id=159300
+
+ Reviewed by Alex Christensen.
+
+ * WebPreferenceKeysPrivate.h:
+ * WebPreferences.cpp:
+ (WebPreferences::domIteratorEnabled):
+ (WebPreferences::setDOMIteratorEnabled):
+ (WebView::notifyPreferencesChanged):
+ * WebPreferencesreferences.h:
+ * WebView.cpp:
+ (WebView::notifyPreferencesChanged):
+
</ins><span class="cx"> 2016-06-28 Per Arne Vollan <pvollan@apple.com>
</span><span class="cx">
</span><span class="cx"> [Win] Custom elements tests are failing.
</span></span></pre></div>
<a id="trunkSourceWebKitwinInterfacesIWebPreferencesPrivateidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/win/Interfaces/IWebPreferencesPrivate.idl (202727 => 202728)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/win/Interfaces/IWebPreferencesPrivate.idl 2016-07-01 07:29:53 UTC (rev 202727)
+++ trunk/Source/WebKit/win/Interfaces/IWebPreferencesPrivate.idl 2016-07-01 07:47:14 UTC (rev 202728)
</span><span class="lines">@@ -175,6 +175,8 @@
</span><span class="cx"> {
</span><span class="cx"> HRESULT showTiledScrollingIndicator([out, retval] BOOL* enabled);
</span><span class="cx"> HRESULT setShowTiledScrollingIndicator([in] BOOL enabled);
</span><ins>+ HRESULT domIteratorEnabled([out, retval] BOOL* enabled);
+ HRESULT setDOMIteratorEnabled([in] BOOL enabled);
</ins><span class="cx"> HRESULT fetchAPIEnabled([out, retval] BOOL* enabled);
</span><span class="cx"> HRESULT setFetchAPIEnabled([in] BOOL enabled);
</span><span class="cx"> HRESULT shadowDOMEnabled([out, retval] BOOL* enabled);
</span></span></pre></div>
<a id="trunkSourceWebKitwinWebPreferenceKeysPrivateh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/win/WebPreferenceKeysPrivate.h (202727 => 202728)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/win/WebPreferenceKeysPrivate.h 2016-07-01 07:29:53 UTC (rev 202727)
+++ trunk/Source/WebKit/win/WebPreferenceKeysPrivate.h 2016-07-01 07:47:14 UTC (rev 202728)
</span><span class="lines">@@ -168,6 +168,8 @@
</span><span class="cx">
</span><span class="cx"> #define WebKitShowTiledScrollingIndicatorPreferenceKey "WebKitShowTiledScrollingIndicator"
</span><span class="cx">
</span><ins>+#define WebKitDOMIteratorEnabledPreferenceKey "WebKitDOMIteratorEnabled"
+
</ins><span class="cx"> #define WebKitFetchAPIEnabledPreferenceKey "WebKitFetchAPIEnabled"
</span><span class="cx">
</span><span class="cx"> #define WebKitShadowDOMEnabledPreferenceKey "WebKitShadowDOMEnabled"
</span></span></pre></div>
<a id="trunkSourceWebKitwinWebPreferencescpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/win/WebPreferences.cpp (202727 => 202728)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/win/WebPreferences.cpp 2016-07-01 07:29:53 UTC (rev 202727)
+++ trunk/Source/WebKit/win/WebPreferences.cpp 2016-07-01 07:47:14 UTC (rev 202728)
</span><span class="lines">@@ -1938,6 +1938,20 @@
</span><span class="cx"> return S_OK;
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+HRESULT WebPreferences::setDOMIteratorEnabled(BOOL enabled)
+{
+ setBoolValue(WebKitDOMIteratorEnabledPreferenceKey, enabled);
+ return S_OK;
+}
+
+HRESULT WebPreferences::domIteratorEnabled(_Out_ BOOL* enabled)
+{
+ if (!enabled)
+ return E_POINTER;
+ *enabled = boolValueForKey(WebKitDOMIteratorEnabledPreferenceKey);
+ return S_OK;
+}
+
</ins><span class="cx"> HRESULT WebPreferences::shadowDOMEnabled(_Out_ BOOL* enabled)
</span><span class="cx"> {
</span><span class="cx"> if (!enabled)
</span></span></pre></div>
<a id="trunkSourceWebKitwinWebPreferencesh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/win/WebPreferences.h (202727 => 202728)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/win/WebPreferences.h 2016-07-01 07:29:53 UTC (rev 202727)
+++ trunk/Source/WebKit/win/WebPreferences.h 2016-07-01 07:47:14 UTC (rev 202728)
</span><span class="lines">@@ -235,6 +235,8 @@
</span><span class="cx"> virtual HRESULT STDMETHODCALLTYPE setShowTiledScrollingIndicator(BOOL);
</span><span class="cx"> virtual HRESULT STDMETHODCALLTYPE fetchAPIEnabled(_Out_ BOOL*);
</span><span class="cx"> virtual HRESULT STDMETHODCALLTYPE setFetchAPIEnabled(BOOL);
</span><ins>+ virtual HRESULT STDMETHODCALLTYPE domIteratorEnabled(_Out_ BOOL*);
+ virtual HRESULT STDMETHODCALLTYPE setDOMIteratorEnabled(BOOL);
</ins><span class="cx"> virtual HRESULT STDMETHODCALLTYPE shadowDOMEnabled(_Out_ BOOL*);
</span><span class="cx"> virtual HRESULT STDMETHODCALLTYPE setShadowDOMEnabled(BOOL);
</span><span class="cx"> virtual HRESULT STDMETHODCALLTYPE customElementsEnabled(_Out_ BOOL*);
</span></span></pre></div>
<a id="trunkSourceWebKitwinWebViewcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/win/WebView.cpp (202727 => 202728)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/win/WebView.cpp 2016-07-01 07:29:53 UTC (rev 202727)
+++ trunk/Source/WebKit/win/WebView.cpp 2016-07-01 07:47:14 UTC (rev 202728)
</span><span class="lines">@@ -5040,6 +5040,11 @@
</span><span class="cx"> RuntimeEnabledFeatures::sharedFeatures().setWebkitIndexedDBEnabled(true);
</span><span class="cx"> #endif
</span><span class="cx">
</span><ins>+ hr = prefsPrivate->domIteratorEnabled(&enabled);
+ if (FAILED(hr))
+ return hr;
+ RuntimeEnabledFeatures::sharedFeatures().setDOMIteratorEnabled(!!enabled);
+
</ins><span class="cx"> #if ENABLE(FETCH_API)
</span><span class="cx"> hr = prefsPrivate->fetchAPIEnabled(&enabled);
</span><span class="cx"> if (FAILED(hr))
</span></span></pre></div>
<a id="trunkSourceWebKit2ChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/ChangeLog (202727 => 202728)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/ChangeLog 2016-07-01 07:29:53 UTC (rev 202727)
+++ trunk/Source/WebKit2/ChangeLog 2016-07-01 07:47:14 UTC (rev 202728)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2016-07-01 Youenn Fablet <youennf@gmail.com>
+
+ Add a runtime flag for DOM iterators
+ https://bugs.webkit.org/show_bug.cgi?id=159300
+
+ Reviewed by Alex Christensen.
+
+ * Shared/WebPreferencesDefinitions.h:
+ * WebProcess/InjectedBundle/InjectedBundle.cpp:
+ (WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):
+ * WebProcess/WebPage/WebPage.cpp:
+ (WebKit::WebPage::updatePreferences):
+
</ins><span class="cx"> 2016-07-01 Andreas Kling <akling@apple.com>
</span><span class="cx">
</span><span class="cx"> [Mac] Get rid of the old timey rubber-banding linen pattern.
</span></span></pre></div>
<a id="trunkSourceWebKit2SharedWebPreferencesDefinitionsh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/Shared/WebPreferencesDefinitions.h (202727 => 202728)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/Shared/WebPreferencesDefinitions.h 2016-07-01 07:29:53 UTC (rev 202727)
+++ trunk/Source/WebKit2/Shared/WebPreferencesDefinitions.h 2016-07-01 07:47:14 UTC (rev 202728)
</span><span class="lines">@@ -225,6 +225,7 @@
</span><span class="cx"> macro(HTTPEquivEnabled, httpEquivEnabled, Bool, bool, true, "", "") \
</span><span class="cx"> macro(MockCaptureDevicesEnabled, mockCaptureDevicesEnabled, Bool, bool, false, "", "") \
</span><span class="cx"> macro(ShadowDOMEnabled, shadowDOMEnabled, Bool, bool, true, "Shadow DOM", "HTML Shadow DOM prototype") \
</span><ins>+ macro(DOMIteratorEnabled, domIteratorEnabled, Bool, bool, true, "", "") \
</ins><span class="cx"> macro(FetchAPIEnabled, fetchAPIEnabled, Bool, bool, false, "", "") \
</span><span class="cx"> macro(DownloadAttributeEnabled, downloadAttributeEnabled, Bool, bool, false, "", "") \
</span><span class="cx"> macro(SelectionPaintingWithoutSelectionGapsEnabled, selectionPaintingWithoutSelectionGapsEnabled, Bool, bool, DEFAULT_SELECTION_PAINTING_WITHOUT_SELECTION_GAPS_ENABLED, "", "") \
</span></span></pre></div>
<a id="trunkSourceWebKit2WebProcessInjectedBundleInjectedBundlecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp (202727 => 202728)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp 2016-07-01 07:29:53 UTC (rev 202727)
+++ trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp 2016-07-01 07:47:14 UTC (rev 202728)
</span><span class="lines">@@ -196,6 +196,9 @@
</span><span class="cx"> if (preference == "WebKitShadowDOMEnabled")
</span><span class="cx"> RuntimeEnabledFeatures::sharedFeatures().setShadowDOMEnabled(enabled);
</span><span class="cx">
</span><ins>+ if (preference == "WebKitDOMIteratorEnabled")
+ RuntimeEnabledFeatures::sharedFeatures().setDOMIteratorEnabled(enabled);
+
</ins><span class="cx"> #if ENABLE(CSS_GRID_LAYOUT)
</span><span class="cx"> if (preference == "WebKitCSSGridLayoutEnabled")
</span><span class="cx"> RuntimeEnabledFeatures::sharedFeatures().setCSSGridLayoutEnabled(enabled);
</span></span></pre></div>
<a id="trunkSourceWebKit2WebProcessWebPageWebPagecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp (202727 => 202728)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp 2016-07-01 07:29:53 UTC (rev 202727)
+++ trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp 2016-07-01 07:47:14 UTC (rev 202728)
</span><span class="lines">@@ -3149,6 +3149,8 @@
</span><span class="cx">
</span><span class="cx"> RuntimeEnabledFeatures::sharedFeatures().setShadowDOMEnabled(store.getBoolValueForKey(WebPreferencesKey::shadowDOMEnabledKey()));
</span><span class="cx">
</span><ins>+ RuntimeEnabledFeatures::sharedFeatures().setDOMIteratorEnabled(store.getBoolValueForKey(WebPreferencesKey::domIteratorEnabledKey()));
+
</ins><span class="cx"> // Experimental Features.
</span><span class="cx">
</span><span class="cx"> #if ENABLE(CSS_GRID_LAYOUT)
</span></span></pre></div>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (202727 => 202728)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog 2016-07-01 07:29:53 UTC (rev 202727)
+++ trunk/Tools/ChangeLog 2016-07-01 07:47:14 UTC (rev 202728)
</span><span class="lines">@@ -1,3 +1,21 @@
</span><ins>+2016-07-01 Youenn Fablet <youennf@gmail.com>
+
+ Add a runtime flag for DOM iterators
+ https://bugs.webkit.org/show_bug.cgi?id=159300
+
+ Reviewed by Alex Christensen.
+
+ * DumpRenderTree/mac/DumpRenderTree.mm:
+ (resetWebPreferencesToConsistentValues):
+ * DumpRenderTree/win/DumpRenderTree.cpp:
+ (resetWebPreferencesToConsistentValues):
+ * Scripts/webkitperl/FeatureList.pm:
+ * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
+ (WTR::InjectedBundle::beginTesting):
+ * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
+ (WTR::TestRunner::setDOMIteratorEnabled):
+ * WebKitTestRunner/InjectedBundle/TestRunner.h:
+
</ins><span class="cx"> 2016-06-30 Tina Liu <iting_liu@apple.com>
</span><span class="cx">
</span><span class="cx"> Add an API test for WKPageRestoreFromSessionStateWithoutNavigation.
</span></span></pre></div>
<a id="trunkToolsDumpRenderTreemacDumpRenderTreemm"></a>
<div class="modfile"><h4>Modified: trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm (202727 => 202728)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm 2016-07-01 07:29:53 UTC (rev 202727)
+++ trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm 2016-07-01 07:47:14 UTC (rev 202728)
</span><span class="lines">@@ -979,6 +979,8 @@
</span><span class="cx"> [preferences setShadowDOMEnabled:YES];
</span><span class="cx"> [preferences setCustomElementsEnabled:YES];
</span><span class="cx">
</span><ins>+ [preferences setDOMIteratorEnabled:YES];
+
</ins><span class="cx"> [preferences setWebGL2Enabled:YES];
</span><span class="cx">
</span><span class="cx"> [preferences setFetchAPIEnabled:YES];
</span></span></pre></div>
<a id="trunkToolsDumpRenderTreewinDumpRenderTreecpp"></a>
<div class="modfile"><h4>Modified: trunk/Tools/DumpRenderTree/win/DumpRenderTree.cpp (202727 => 202728)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/DumpRenderTree/win/DumpRenderTree.cpp 2016-07-01 07:29:53 UTC (rev 202727)
+++ trunk/Tools/DumpRenderTree/win/DumpRenderTree.cpp 2016-07-01 07:47:14 UTC (rev 202728)
</span><span class="lines">@@ -853,6 +853,8 @@
</span><span class="cx"> prefsPrivate3->setShadowDOMEnabled(TRUE);
</span><span class="cx"> prefsPrivate3->setCustomElementsEnabled(TRUE);
</span><span class="cx">
</span><ins>+ prefsPrivate3->setDOMIteratorEnabled(TRUE);
+
</ins><span class="cx"> setAlwaysAcceptCookies(false);
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkToolsScriptswebkitperlFeatureListpm"></a>
<div class="modfile"><h4>Modified: trunk/Tools/Scripts/webkitperl/FeatureList.pm (202727 => 202728)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/Scripts/webkitperl/FeatureList.pm 2016-07-01 07:29:53 UTC (rev 202727)
+++ trunk/Tools/Scripts/webkitperl/FeatureList.pm 2016-07-01 07:47:14 UTC (rev 202728)
</span><span class="lines">@@ -80,6 +80,7 @@
</span><span class="cx"> $deviceOrientationSupport,
</span><span class="cx"> $directoryUploadSupport,
</span><span class="cx"> $dom4EventsConstructor,
</span><ins>+ $domIterator,
</ins><span class="cx"> $downloadAttributeSupport,
</span><span class="cx"> $fetchAPISupport,
</span><span class="cx"> $fontLoadEventsSupport,
</span></span></pre></div>
<a id="trunkToolsWebKitTestRunnerInjectedBundleInjectedBundlecpp"></a>
<div class="modfile"><h4>Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp (202727 => 202728)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp 2016-07-01 07:29:53 UTC (rev 202727)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp 2016-07-01 07:47:14 UTC (rev 202728)
</span><span class="lines">@@ -314,6 +314,8 @@
</span><span class="cx"> m_testRunner->setShadowDOMEnabled(true);
</span><span class="cx"> m_testRunner->setCustomElementsEnabled(true);
</span><span class="cx">
</span><ins>+ m_testRunner->setDOMIteratorEnabled(true);
+
</ins><span class="cx"> m_testRunner->setWebGL2Enabled(true);
</span><span class="cx">
</span><span class="cx"> m_testRunner->setFetchAPIEnabled(true);
</span></span></pre></div>
<a id="trunkToolsWebKitTestRunnerInjectedBundleTestRunnercpp"></a>
<div class="modfile"><h4>Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp (202727 => 202728)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp 2016-07-01 07:29:53 UTC (rev 202727)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp 2016-07-01 07:47:14 UTC (rev 202728)
</span><span class="lines">@@ -348,6 +348,13 @@
</span><span class="cx"> WKBundleOverrideBoolPreferenceForTestRunner(injectedBundle.bundle(), injectedBundle.pageGroup(), key.get(), enabled);
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+void TestRunner::setDOMIteratorEnabled(bool enabled)
+{
+ WKRetainPtr<WKStringRef> key(AdoptWK, WKStringCreateWithUTF8CString("WebKitDOMIteratorEnabled"));
+ auto& injectedBundle = InjectedBundle::singleton();
+ WKBundleOverrideBoolPreferenceForTestRunner(injectedBundle.bundle(), injectedBundle.pageGroup(), key.get(), enabled);
+}
+
</ins><span class="cx"> void TestRunner::setWebGL2Enabled(bool enabled)
</span><span class="cx"> {
</span><span class="cx"> WKRetainPtr<WKStringRef> key(AdoptWK, WKStringCreateWithUTF8CString("WebKitWebGL2Enabled"));
</span></span></pre></div>
<a id="trunkToolsWebKitTestRunnerInjectedBundleTestRunnerh"></a>
<div class="modfile"><h4>Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/TestRunner.h (202727 => 202728)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/WebKitTestRunner/InjectedBundle/TestRunner.h 2016-07-01 07:29:53 UTC (rev 202727)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/TestRunner.h 2016-07-01 07:47:14 UTC (rev 202728)
</span><span class="lines">@@ -102,6 +102,7 @@
</span><span class="cx"> void setXSSAuditorEnabled(bool);
</span><span class="cx"> void setShadowDOMEnabled(bool);
</span><span class="cx"> void setCustomElementsEnabled(bool);
</span><ins>+ void setDOMIteratorEnabled(bool);
</ins><span class="cx"> void setWebGL2Enabled(bool);
</span><span class="cx"> void setFetchAPIEnabled(bool);
</span><span class="cx"> void setAllowUniversalAccessFromFileURLs(bool);
</span></span></pre>
</div>
</div>
</body>
</html>