<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[202631] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/202631">202631</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2016-06-29 11:16:33 -0700 (Wed, 29 Jun 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>[JSC] Fix small issues of TypedArray prototype
https://bugs.webkit.org/show_bug.cgi?id=159248
Patch by Benjamin Poulain <bpoulain@apple.com> on 2016-06-29
Reviewed by Saam Barati.
Source/JavaScriptCore:
First, TypedArray's toString and Array's toString
should be the same function.
I moved the function to GlobalObject and each array type
gets it as needed.
Then TypedArray length was supposed to be configurable.
I removed the "DontDelete" flag accordingly.
* runtime/ArrayPrototype.cpp:
(JSC::ArrayPrototype::finishCreation):
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::init):
(JSC::JSGlobalObject::visitChildren):
* runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::arrayProtoToStringFunction):
* runtime/JSTypedArrayViewPrototype.cpp:
(JSC::JSTypedArrayViewPrototype::finishCreation):
LayoutTests:
* js/script-tests/typedarray-prototype.js: Added.
* js/typedarray-prototype-expected.txt: Added.
* js/typedarray-prototype.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkSourceJavaScriptCoreChangeLog">trunk/Source/JavaScriptCore/ChangeLog</a></li>
<li><a href="#trunkSourceJavaScriptCoreruntimeArrayPrototypecpp">trunk/Source/JavaScriptCore/runtime/ArrayPrototype.cpp</a></li>
<li><a href="#trunkSourceJavaScriptCoreruntimeJSGlobalObjectcpp">trunk/Source/JavaScriptCore/runtime/JSGlobalObject.cpp</a></li>
<li><a href="#trunkSourceJavaScriptCoreruntimeJSGlobalObjecth">trunk/Source/JavaScriptCore/runtime/JSGlobalObject.h</a></li>
<li><a href="#trunkSourceJavaScriptCoreruntimeJSTypedArrayViewPrototypecpp">trunk/Source/JavaScriptCore/runtime/JSTypedArrayViewPrototype.cpp</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsjsscriptteststypedarrayprototypejs">trunk/LayoutTests/js/script-tests/typedarray-prototype.js</a></li>
<li><a href="#trunkLayoutTestsjstypedarrayprototypeexpectedtxt">trunk/LayoutTests/js/typedarray-prototype-expected.txt</a></li>
<li><a href="#trunkLayoutTestsjstypedarrayprototypehtml">trunk/LayoutTests/js/typedarray-prototype.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (202630 => 202631)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2016-06-29 18:11:35 UTC (rev 202630)
+++ trunk/LayoutTests/ChangeLog 2016-06-29 18:16:33 UTC (rev 202631)
</span><span class="lines">@@ -1,3 +1,14 @@
</span><ins>+2016-06-29 Benjamin Poulain <bpoulain@apple.com>
+
+ [JSC] Fix small issues of TypedArray prototype
+ https://bugs.webkit.org/show_bug.cgi?id=159248
+
+ Reviewed by Saam Barati.
+
+ * js/script-tests/typedarray-prototype.js: Added.
+ * js/typedarray-prototype-expected.txt: Added.
+ * js/typedarray-prototype.html: Added.
+
</ins><span class="cx"> 2016-06-29 Alejandro G. Castro <alex@igalia.com>
</span><span class="cx">
</span><span class="cx"> WebRTC: ice-char can not contain '=' characters for credentials
</span></span></pre></div>
<a id="trunkLayoutTestsjsscriptteststypedarrayprototypejs"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/js/script-tests/typedarray-prototype.js (0 => 202631)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/js/script-tests/typedarray-prototype.js (rev 0)
+++ trunk/LayoutTests/js/script-tests/typedarray-prototype.js 2016-06-29 18:16:33 UTC (rev 202631)
</span><span class="lines">@@ -0,0 +1,44 @@
</span><ins>+"use strict"
+
+description('This tests basic properties of the TypedArray prototype');
+
+let arrayTypes = [
+ Int8Array,
+ Int16Array,
+ Int32Array,
+ Uint8Array,
+ Uint16Array,
+ Uint32Array,
+ Float32Array,
+ Float64Array,
+];
+
+// The prototype should be the same for every type of view.
+for (let i = 0; i < arrayTypes.length; ++i) {
+ for (let j = i; j < arrayTypes.length; ++j) {
+ shouldBeTrue("Object.getPrototypeOf(" + arrayTypes[i].name + ") === Object.getPrototypeOf(" + arrayTypes[j].name + ")");
+ }
+}
+
+let TypedArray = Object.getPrototypeOf(Int8Array);
+
+// length.
+shouldBeFalse('"writable" in Object.getOwnPropertyDescriptor(TypedArray.prototype, "length")');
+shouldBeFalse('Object.getOwnPropertyDescriptor(TypedArray.prototype, "length").enumerable');
+shouldBeTrue('Object.getOwnPropertyDescriptor(TypedArray.prototype, "length").configurable');
+shouldBe('Object.getOwnPropertyDescriptor(TypedArray.prototype, "length").get.length', '0');
+shouldBeEqualToString('typeof Object.getOwnPropertyDescriptor(TypedArray.prototype, "length").get', 'function');
+shouldBe('Object.getOwnPropertyDescriptor(TypedArray.prototype, "length").set', 'undefined');
+
+// toString.
+shouldBe('TypedArray.prototype.toString', 'Array.prototype.toString');
+shouldBeTrue('Object.getOwnPropertyDescriptor(TypedArray.prototype, "toString").writable');
+shouldBeFalse('Object.getOwnPropertyDescriptor(TypedArray.prototype, "toString").enumerable');
+shouldBeTrue('Object.getOwnPropertyDescriptor(TypedArray.prototype, "toString").configurable');
+shouldBeEqualToString('typeof Object.getOwnPropertyDescriptor(TypedArray.prototype, "toString").value', 'function');
+
+// toLocaleString.
+shouldBeTrue('Object.getOwnPropertyDescriptor(TypedArray.prototype, "toLocaleString").writable');
+shouldBeFalse('Object.getOwnPropertyDescriptor(TypedArray.prototype, "toLocaleString").enumerable');
+shouldBeTrue('Object.getOwnPropertyDescriptor(TypedArray.prototype, "toLocaleString").configurable');
+shouldBeEqualToString('typeof Object.getOwnPropertyDescriptor(TypedArray.prototype, "toString").value', 'function');
</ins></span></pre></div>
<a id="trunkLayoutTestsjstypedarrayprototypeexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/js/typedarray-prototype-expected.txt (0 => 202631)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/js/typedarray-prototype-expected.txt (rev 0)
+++ trunk/LayoutTests/js/typedarray-prototype-expected.txt 2016-06-29 18:16:33 UTC (rev 202631)
</span><span class="lines">@@ -0,0 +1,60 @@
</span><ins>+This tests basic properties of the TypedArray prototype
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS Object.getPrototypeOf(Int8Array) === Object.getPrototypeOf(Int8Array) is true
+PASS Object.getPrototypeOf(Int8Array) === Object.getPrototypeOf(Int16Array) is true
+PASS Object.getPrototypeOf(Int8Array) === Object.getPrototypeOf(Int32Array) is true
+PASS Object.getPrototypeOf(Int8Array) === Object.getPrototypeOf(Uint8Array) is true
+PASS Object.getPrototypeOf(Int8Array) === Object.getPrototypeOf(Uint16Array) is true
+PASS Object.getPrototypeOf(Int8Array) === Object.getPrototypeOf(Uint32Array) is true
+PASS Object.getPrototypeOf(Int8Array) === Object.getPrototypeOf(Float32Array) is true
+PASS Object.getPrototypeOf(Int8Array) === Object.getPrototypeOf(Float64Array) is true
+PASS Object.getPrototypeOf(Int16Array) === Object.getPrototypeOf(Int16Array) is true
+PASS Object.getPrototypeOf(Int16Array) === Object.getPrototypeOf(Int32Array) is true
+PASS Object.getPrototypeOf(Int16Array) === Object.getPrototypeOf(Uint8Array) is true
+PASS Object.getPrototypeOf(Int16Array) === Object.getPrototypeOf(Uint16Array) is true
+PASS Object.getPrototypeOf(Int16Array) === Object.getPrototypeOf(Uint32Array) is true
+PASS Object.getPrototypeOf(Int16Array) === Object.getPrototypeOf(Float32Array) is true
+PASS Object.getPrototypeOf(Int16Array) === Object.getPrototypeOf(Float64Array) is true
+PASS Object.getPrototypeOf(Int32Array) === Object.getPrototypeOf(Int32Array) is true
+PASS Object.getPrototypeOf(Int32Array) === Object.getPrototypeOf(Uint8Array) is true
+PASS Object.getPrototypeOf(Int32Array) === Object.getPrototypeOf(Uint16Array) is true
+PASS Object.getPrototypeOf(Int32Array) === Object.getPrototypeOf(Uint32Array) is true
+PASS Object.getPrototypeOf(Int32Array) === Object.getPrototypeOf(Float32Array) is true
+PASS Object.getPrototypeOf(Int32Array) === Object.getPrototypeOf(Float64Array) is true
+PASS Object.getPrototypeOf(Uint8Array) === Object.getPrototypeOf(Uint8Array) is true
+PASS Object.getPrototypeOf(Uint8Array) === Object.getPrototypeOf(Uint16Array) is true
+PASS Object.getPrototypeOf(Uint8Array) === Object.getPrototypeOf(Uint32Array) is true
+PASS Object.getPrototypeOf(Uint8Array) === Object.getPrototypeOf(Float32Array) is true
+PASS Object.getPrototypeOf(Uint8Array) === Object.getPrototypeOf(Float64Array) is true
+PASS Object.getPrototypeOf(Uint16Array) === Object.getPrototypeOf(Uint16Array) is true
+PASS Object.getPrototypeOf(Uint16Array) === Object.getPrototypeOf(Uint32Array) is true
+PASS Object.getPrototypeOf(Uint16Array) === Object.getPrototypeOf(Float32Array) is true
+PASS Object.getPrototypeOf(Uint16Array) === Object.getPrototypeOf(Float64Array) is true
+PASS Object.getPrototypeOf(Uint32Array) === Object.getPrototypeOf(Uint32Array) is true
+PASS Object.getPrototypeOf(Uint32Array) === Object.getPrototypeOf(Float32Array) is true
+PASS Object.getPrototypeOf(Uint32Array) === Object.getPrototypeOf(Float64Array) is true
+PASS Object.getPrototypeOf(Float32Array) === Object.getPrototypeOf(Float32Array) is true
+PASS Object.getPrototypeOf(Float32Array) === Object.getPrototypeOf(Float64Array) is true
+PASS Object.getPrototypeOf(Float64Array) === Object.getPrototypeOf(Float64Array) is true
+PASS "writable" in Object.getOwnPropertyDescriptor(TypedArray.prototype, "length") is false
+PASS Object.getOwnPropertyDescriptor(TypedArray.prototype, "length").enumerable is false
+PASS Object.getOwnPropertyDescriptor(TypedArray.prototype, "length").configurable is true
+PASS Object.getOwnPropertyDescriptor(TypedArray.prototype, "length").get.length is 0
+PASS typeof Object.getOwnPropertyDescriptor(TypedArray.prototype, "length").get is "function"
+PASS Object.getOwnPropertyDescriptor(TypedArray.prototype, "length").set is undefined
+PASS TypedArray.prototype.toString is Array.prototype.toString
+PASS Object.getOwnPropertyDescriptor(TypedArray.prototype, "toString").writable is true
+PASS Object.getOwnPropertyDescriptor(TypedArray.prototype, "toString").enumerable is false
+PASS Object.getOwnPropertyDescriptor(TypedArray.prototype, "toString").configurable is true
+PASS typeof Object.getOwnPropertyDescriptor(TypedArray.prototype, "toString").value is "function"
+PASS Object.getOwnPropertyDescriptor(TypedArray.prototype, "toLocaleString").writable is true
+PASS Object.getOwnPropertyDescriptor(TypedArray.prototype, "toLocaleString").enumerable is false
+PASS Object.getOwnPropertyDescriptor(TypedArray.prototype, "toLocaleString").configurable is true
+PASS typeof Object.getOwnPropertyDescriptor(TypedArray.prototype, "toString").value is "function"
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
</ins></span></pre></div>
<a id="trunkLayoutTestsjstypedarrayprototypehtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/js/typedarray-prototype.html (0 => 202631)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/js/typedarray-prototype.html (rev 0)
+++ trunk/LayoutTests/js/typedarray-prototype.html 2016-06-29 18:16:33 UTC (rev 202631)
</span><span class="lines">@@ -0,0 +1,10 @@
</span><ins>+<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">
+<html>
+<head>
+<script src="../resources/js-test-pre.js"></script>
+</head>
+<body>
+<script src="script-tests/typedarray-prototype.js"></script>
+<script src="../resources/js-test-post.js"></script>
+</body>
+</html>
</ins></span></pre></div>
<a id="trunkSourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/ChangeLog (202630 => 202631)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/ChangeLog 2016-06-29 18:11:35 UTC (rev 202630)
+++ trunk/Source/JavaScriptCore/ChangeLog 2016-06-29 18:16:33 UTC (rev 202631)
</span><span class="lines">@@ -1,3 +1,28 @@
</span><ins>+2016-06-29 Benjamin Poulain <bpoulain@apple.com>
+
+ [JSC] Fix small issues of TypedArray prototype
+ https://bugs.webkit.org/show_bug.cgi?id=159248
+
+ Reviewed by Saam Barati.
+
+ First, TypedArray's toString and Array's toString
+ should be the same function.
+ I moved the function to GlobalObject and each array type
+ gets it as needed.
+
+ Then TypedArray length was supposed to be configurable.
+ I removed the "DontDelete" flag accordingly.
+
+ * runtime/ArrayPrototype.cpp:
+ (JSC::ArrayPrototype::finishCreation):
+ * runtime/JSGlobalObject.cpp:
+ (JSC::JSGlobalObject::init):
+ (JSC::JSGlobalObject::visitChildren):
+ * runtime/JSGlobalObject.h:
+ (JSC::JSGlobalObject::arrayProtoToStringFunction):
+ * runtime/JSTypedArrayViewPrototype.cpp:
+ (JSC::JSTypedArrayViewPrototype::finishCreation):
+
</ins><span class="cx"> 2016-06-29 Caio Lima <ticaiolima@gmail.com>
</span><span class="cx">
</span><span class="cx"> LLInt should support other types of prototype GetById caching.
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreruntimeArrayPrototypecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/runtime/ArrayPrototype.cpp (202630 => 202631)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/runtime/ArrayPrototype.cpp 2016-06-29 18:11:35 UTC (rev 202630)
+++ trunk/Source/JavaScriptCore/runtime/ArrayPrototype.cpp 2016-06-29 18:16:33 UTC (rev 202631)
</span><span class="lines">@@ -86,10 +86,10 @@
</span><span class="cx"> ASSERT(inherits(info()));
</span><span class="cx"> vm.prototypeMap.addPrototype(this);
</span><span class="cx">
</span><ins>+ putDirectWithoutTransition(vm, vm.propertyNames->toString, globalObject->arrayProtoToStringFunction(), DontEnum);
</ins><span class="cx"> putDirectWithoutTransition(vm, vm.propertyNames->builtinNames().valuesPublicName(), globalObject->arrayProtoValuesFunction(), DontEnum);
</span><span class="cx"> putDirectWithoutTransition(vm, vm.propertyNames->iteratorSymbol, globalObject->arrayProtoValuesFunction(), DontEnum);
</span><del>-
- JSC_NATIVE_FUNCTION_WITHOUT_TRANSITION(vm.propertyNames->toString, arrayProtoFuncToString, DontEnum, 0);
</del><ins>+
</ins><span class="cx"> JSC_NATIVE_FUNCTION_WITHOUT_TRANSITION(vm.propertyNames->toLocaleString, arrayProtoFuncToLocaleString, DontEnum, 0);
</span><span class="cx"> JSC_BUILTIN_FUNCTION_WITHOUT_TRANSITION("concat", arrayPrototypeConcatCodeGenerator, DontEnum);
</span><span class="cx"> JSC_BUILTIN_FUNCTION_WITHOUT_TRANSITION("fill", arrayPrototypeFillCodeGenerator, DontEnum);
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreruntimeJSGlobalObjectcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/runtime/JSGlobalObject.cpp (202630 => 202631)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/runtime/JSGlobalObject.cpp 2016-06-29 18:11:35 UTC (rev 202630)
+++ trunk/Source/JavaScriptCore/runtime/JSGlobalObject.cpp 2016-06-29 18:16:33 UTC (rev 202631)
</span><span class="lines">@@ -365,6 +365,10 @@
</span><span class="cx"> m_functionPrototype->addFunctionProperties(exec, this, &callFunction, &applyFunction, &hasInstanceSymbolFunction);
</span><span class="cx"> m_callFunction.set(vm, this, callFunction);
</span><span class="cx"> m_applyFunction.set(vm, this, applyFunction);
</span><ins>+ m_arrayProtoToStringFunction.initLater(
+ [] (const Initializer<JSFunction>& init) {
+ init.set(JSFunction::create(init.vm, init.owner, 0, init.vm.propertyNames->toString.string(), arrayProtoFuncToString, NoIntrinsic));
+ });
</ins><span class="cx"> m_arrayProtoValuesFunction.initLater(
</span><span class="cx"> [] (const Initializer<JSFunction>& init) {
</span><span class="cx"> init.set(JSFunction::createBuiltinFunction(init.vm, arrayPrototypeValuesCodeGenerator(init.vm), init.owner));
</span><span class="lines">@@ -1036,6 +1040,7 @@
</span><span class="cx"> visitor.append(&thisObject->m_callFunction);
</span><span class="cx"> visitor.append(&thisObject->m_applyFunction);
</span><span class="cx"> visitor.append(&thisObject->m_definePropertyFunction);
</span><ins>+ thisObject->m_arrayProtoToStringFunction.visit(visitor);
</ins><span class="cx"> thisObject->m_arrayProtoValuesFunction.visit(visitor);
</span><span class="cx"> thisObject->m_initializePromiseFunction.visit(visitor);
</span><span class="cx"> visitor.append(&thisObject->m_newPromiseCapabilityFunction);
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreruntimeJSGlobalObjecth"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/runtime/JSGlobalObject.h (202630 => 202631)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/runtime/JSGlobalObject.h 2016-06-29 18:11:35 UTC (rev 202630)
+++ trunk/Source/JavaScriptCore/runtime/JSGlobalObject.h 2016-06-29 18:16:33 UTC (rev 202631)
</span><span class="lines">@@ -240,6 +240,7 @@
</span><span class="cx"> WriteBarrier<JSFunction> m_callFunction;
</span><span class="cx"> WriteBarrier<JSFunction> m_applyFunction;
</span><span class="cx"> WriteBarrier<JSFunction> m_definePropertyFunction;
</span><ins>+ LazyProperty<JSGlobalObject, JSFunction> m_arrayProtoToStringFunction;
</ins><span class="cx"> LazyProperty<JSGlobalObject, JSFunction> m_arrayProtoValuesFunction;
</span><span class="cx"> LazyProperty<JSGlobalObject, JSFunction> m_initializePromiseFunction;
</span><span class="cx"> WriteBarrier<JSFunction> m_newPromiseCapabilityFunction;
</span><span class="lines">@@ -485,6 +486,7 @@
</span><span class="cx"> JSFunction* callFunction() const { return m_callFunction.get(); }
</span><span class="cx"> JSFunction* applyFunction() const { return m_applyFunction.get(); }
</span><span class="cx"> JSFunction* definePropertyFunction() const { return m_definePropertyFunction.get(); }
</span><ins>+ JSFunction* arrayProtoToStringFunction() const { return m_arrayProtoToStringFunction.get(this); }
</ins><span class="cx"> JSFunction* arrayProtoValuesFunction() const { return m_arrayProtoValuesFunction.get(this); }
</span><span class="cx"> JSFunction* initializePromiseFunction() const { return m_initializePromiseFunction.get(this); }
</span><span class="cx"> JSFunction* newPromiseCapabilityFunction() const { return m_newPromiseCapabilityFunction.get(); }
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreruntimeJSTypedArrayViewPrototypecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/runtime/JSTypedArrayViewPrototype.cpp (202630 => 202631)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/runtime/JSTypedArrayViewPrototype.cpp 2016-06-29 18:11:35 UTC (rev 202630)
+++ trunk/Source/JavaScriptCore/runtime/JSTypedArrayViewPrototype.cpp 2016-06-29 18:16:33 UTC (rev 202631)
</span><span class="lines">@@ -246,6 +246,8 @@
</span><span class="cx">
</span><span class="cx"> ASSERT(inherits(info()));
</span><span class="cx">
</span><ins>+ putDirectWithoutTransition(vm, vm.propertyNames->toString, globalObject->arrayProtoToStringFunction(), DontEnum);
+
</ins><span class="cx"> JSC_NATIVE_GETTER(vm.propertyNames->buffer, typedArrayViewProtoGetterFuncBuffer, DontEnum | ReadOnly | DontDelete);
</span><span class="cx"> JSC_NATIVE_INTRINSIC_GETTER(vm.propertyNames->byteLength, typedArrayViewProtoGetterFuncByteLength, DontEnum | ReadOnly | DontDelete, TypedArrayByteLengthIntrinsic);
</span><span class="cx"> JSC_NATIVE_INTRINSIC_GETTER(vm.propertyNames->byteOffset, typedArrayViewProtoGetterFuncByteOffset, DontEnum | ReadOnly | DontDelete, TypedArrayByteOffsetIntrinsic);
</span><span class="lines">@@ -262,7 +264,7 @@
</span><span class="cx"> JSC_NATIVE_FUNCTION_WITHOUT_TRANSITION(vm.propertyNames->join, typedArrayViewProtoFuncJoin, DontEnum, 1);
</span><span class="cx"> JSC_BUILTIN_FUNCTION_WITHOUT_TRANSITION(vm.propertyNames->builtinNames().keysPublicName(), typedArrayPrototypeKeysCodeGenerator, DontEnum);
</span><span class="cx"> JSC_NATIVE_FUNCTION_WITHOUT_TRANSITION("lastIndexOf", typedArrayViewProtoFuncLastIndexOf, DontEnum, 1);
</span><del>- JSC_NATIVE_INTRINSIC_GETTER(vm.propertyNames->length, typedArrayViewProtoGetterFuncLength, DontEnum | ReadOnly | DontDelete, TypedArrayLengthIntrinsic);
</del><ins>+ JSC_NATIVE_INTRINSIC_GETTER(vm.propertyNames->length, typedArrayViewProtoGetterFuncLength, DontEnum | ReadOnly, TypedArrayLengthIntrinsic);
</ins><span class="cx"> JSC_BUILTIN_FUNCTION_WITHOUT_TRANSITION("map", typedArrayPrototypeMapCodeGenerator, DontEnum);
</span><span class="cx"> JSC_BUILTIN_FUNCTION_WITHOUT_TRANSITION("reduce", typedArrayPrototypeReduceCodeGenerator, DontEnum);
</span><span class="cx"> JSC_BUILTIN_FUNCTION_WITHOUT_TRANSITION("reduceRight", typedArrayPrototypeReduceRightCodeGenerator, DontEnum);
</span><span class="lines">@@ -272,7 +274,6 @@
</span><span class="cx"> JSC_BUILTIN_FUNCTION_WITHOUT_TRANSITION("some", typedArrayPrototypeSomeCodeGenerator, DontEnum);
</span><span class="cx"> JSC_NATIVE_FUNCTION_WITHOUT_TRANSITION(vm.propertyNames->subarray, typedArrayViewProtoFuncSubarray, DontEnum, 2);
</span><span class="cx"> JSC_BUILTIN_FUNCTION_WITHOUT_TRANSITION(vm.propertyNames->toLocaleString, typedArrayPrototypeToLocaleStringCodeGenerator, DontEnum);
</span><del>- JSC_NATIVE_FUNCTION_WITHOUT_TRANSITION(vm.propertyNames->toString, arrayProtoFuncToString, DontEnum, 0);
</del><span class="cx"> JSC_NATIVE_GETTER(vm.propertyNames->toStringTagSymbol, typedArrayViewProtoGetterFuncToStringTag, DontEnum | ReadOnly);
</span><span class="cx">
</span><span class="cx"> JSFunction* valuesFunction = JSFunction::createBuiltinFunction(vm, typedArrayPrototypeValuesCodeGenerator(vm), globalObject);
</span></span></pre>
</div>
</div>
</body>
</html>