<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[202577] trunk/Websites/webkit.org</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/202577">202577</a></dd>
<dt>Author</dt> <dd>jond@apple.com</dd>
<dt>Date</dt> <dd>2016-06-28 11:12:23 -0700 (Tue, 28 Jun 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Fixed Open Graph meta data and image entries.
https://bugs.webkit.org/show_bug.cgi?id=159167.
Reviewed by Timothy Hatcher.
This patch addresses Open Graph meta data issues:
- Added a high-resolution PNG of the WebKit logo because Facebook doesn't support SVG images
- Uses the first image of a page or post if not featured image is set
- Article date/time information should not be given for the homepage
- Added Facebook admins as per the Facebook Open Graph debugger
* wp-content/plugins/social-meta.php:
* wp-content/themes/webkit/images/ogimage.png: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkWebsiteswebkitorgChangeLog">trunk/Websites/webkit.org/ChangeLog</a></li>
<li><a href="#trunkWebsiteswebkitorgwpcontentpluginssocialmetaphp">trunk/Websites/webkit.org/wp-content/plugins/social-meta.php</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkWebsiteswebkitorgwpcontentthemeswebkitimagesogimagepng">trunk/Websites/webkit.org/wp-content/themes/webkit/images/ogimage.png</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkWebsiteswebkitorgChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Websites/webkit.org/ChangeLog (202576 => 202577)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/webkit.org/ChangeLog 2016-06-28 18:08:59 UTC (rev 202576)
+++ trunk/Websites/webkit.org/ChangeLog 2016-06-28 18:12:23 UTC (rev 202577)
</span><span class="lines">@@ -1,3 +1,20 @@
</span><ins>+2016-06-28 Jon Davis <jond@apple.com>
+
+ Fixed Open Graph meta data and image entries.
+ https://bugs.webkit.org/show_bug.cgi?id=159167.
+
+ Reviewed by Timothy Hatcher.
+
+ This patch addresses Open Graph meta data issues:
+
+ - Added a high-resolution PNG of the WebKit logo because Facebook doesn't support SVG images
+ - Uses the first image of a page or post if not featured image is set
+ - Article date/time information should not be given for the homepage
+ - Added Facebook admins as per the Facebook Open Graph debugger
+
+ * wp-content/plugins/social-meta.php:
+ * wp-content/themes/webkit/images/ogimage.png: Added.
+
</ins><span class="cx"> 2016-06-27 Dean Jackson <dino@apple.com>
</span><span class="cx">
</span><span class="cx"> Updated content for the color blog post.
</span></span></pre></div>
<a id="trunkWebsiteswebkitorgwpcontentpluginssocialmetaphp"></a>
<div class="modfile"><h4>Modified: trunk/Websites/webkit.org/wp-content/plugins/social-meta.php (202576 => 202577)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/webkit.org/wp-content/plugins/social-meta.php 2016-06-28 18:08:59 UTC (rev 202576)
+++ trunk/Websites/webkit.org/wp-content/plugins/social-meta.php 2016-06-28 18:12:23 UTC (rev 202577)
</span><span class="lines">@@ -8,34 +8,50 @@
</span><span class="cx"> */
</span><span class="cx">
</span><span class="cx"> add_action('wp_head', function() {
</span><del>-
</del><ins>+
</ins><span class="cx"> $title = get_the_title();
</span><span class="cx"> $description = get_the_excerpt();
</span><span class="cx"> $type = 'article';
</span><del>-
</del><ins>+
</ins><span class="cx"> $categories = array();
</span><span class="cx"> $tags = array();
</span><del>- $image_url = get_stylesheet_directory_uri() . '/images/webkit.svg';
</del><ins>+ $image_url = get_stylesheet_directory_uri() . '/images/ogimage.png';
</ins><span class="cx"> $twitter_handle = '';
</span><del>-
</del><ins>+ $published_time = '';
+ $modified_time = '';
+
+ $fb_admins = array(
+ 'Jon Davis' => '1085088865',
+ 'Tim Hatcher' => '854565306'
+ );
+
</ins><span class="cx"> if (is_front_page() || is_home()) {
</span><span class="cx"> $title = get_bloginfo('name');
</span><span class="cx"> $description = get_bloginfo('description');
</span><del>- $type = 'website';
</del><ins>+ $type = 'website';
</ins><span class="cx"> }
</span><del>-
</del><ins>+
</ins><span class="cx"> if (is_single()) {
</span><del>- $image_src = wp_get_attachment_image_src( get_post_thumbnail_id($post_id), 'large' );
- $image_url = $image_src[0];
-
</del><ins>+
+ $post = get_post();
+
+ if ( has_post_thumbnail() ) {
+ $image_src = wp_get_attachment_image_src( get_post_thumbnail_id($post_id), 'large' );
+ $image_url = $image_src[0];
+ } else {
+ preg_match_all('/<img.+src=[\'"]([^\'"]+)[\'"].*>/i', $post->post_content, $matches);
+ if ($matches[1][0]) $image_url = $matches[1][0];
+ }
+
</ins><span class="cx"> $categories = wp_get_object_terms(get_the_ID(), 'category', array('fields' => 'names'));
</span><span class="cx"> $tags = wp_get_object_terms(get_the_ID(), 'post_tag', array('fields' => 'names'));
</span><span class="cx">
</span><span class="cx"> // Post author data is not available in wp_head filter context
</span><del>- $post = get_post();
</del><span class="cx"> $twitter_handle = get_the_author_meta('twitter', $post->post_author);
</span><ins>+ $published_time = get_the_time('c');
+ $modified_time = get_the_modified_date('c');
</ins><span class="cx"> }
</span><del>-
</del><ins>+
</ins><span class="cx"> ?>
</span><span class="cx">
</span><span class="cx"> <!-- Schema.org markup -->
</span><span class="lines">@@ -62,24 +78,28 @@
</span><span class="cx"> <?php endif; ?>
</span><span class="cx">
</span><span class="cx"> <!-- Open Graph data -->
</span><del>- <meta property="og:title" content="<?php echo esc_attr($title); ?>" />
- <meta property="og:type" content="<?php echo esc_attr($type); ?>" />
- <meta property="og:url" content="<?php the_permalink(); ?>" />
</del><ins>+ <meta property="og:title" content="<?php echo esc_attr($title); ?>">
+ <meta property="og:type" content="<?php echo esc_attr($type); ?>">
+ <meta property="og:url" content="<?php the_permalink(); ?>">
</ins><span class="cx"> <?php if ($image_url): ?>
</span><span class="cx"> <meta itemprop="og:image" content="<?php echo esc_url($image_url); ?>">
</span><span class="cx"> <?php endif; ?>
</span><span class="cx"> <?php if ($description): ?>
</span><del>- <meta property="og:description" content="<?php echo esc_attr($description); ?>" />
</del><ins>+ <meta property="og:description" content="<?php echo esc_attr($description); ?>">
</ins><span class="cx"> <?php endif; ?>
</span><del>- <meta property="og:site_name" content="<?php bloginfo('title'); ?>" />
- <meta property="article:published_time" content="<?php the_time('c'); ?>" />
- <meta property="article:modified_time" content="<?php the_modified_date('c'); ?>" />
</del><ins>+ <meta property="og:site_name" content="<?php bloginfo('title'); ?>">
+<?php if ($published_time): ?>
+ <meta property="article:published_time" content="<?php echo $published_time; ?>">
+<?php endif; ?>
+<?php if ($modified_time): ?>
+ <meta property="article:modified_time" content="<?php echo $modified_time; ?>">
+<?php endif; ?>
</ins><span class="cx"> <?php
</span><span class="cx"> if (!empty($categories)):
</span><span class="cx"> $section = array_shift($categories); // The first category is used as the section
</span><span class="cx"> $tags = array_merge($categories, $tags); // The rest are prepended to the tag list
</span><span class="cx"> ?>
</span><del>- <meta property="article:section" content="<?php echo esc_attr($section); ?>" />
</del><ins>+ <meta property="article:section" content="<?php echo esc_attr($section); ?>">
</ins><span class="cx"> <?php
</span><span class="cx"> endif;
</span><span class="cx">
</span><span class="lines">@@ -86,11 +106,16 @@
</span><span class="cx"> if (!empty($tags)):
</span><span class="cx"> foreach($tags as $tag):
</span><span class="cx"> ?>
</span><del>- <meta property="article:tag" content="<?php echo esc_attr($tag); ?>" />
-<?php
- endforeach;
</del><ins>+ <meta property="article:tag" content="<?php echo esc_attr($tag); ?>">
+<?php
+ endforeach;
</ins><span class="cx"> endif;
</span><ins>+
+ if (!empty($fb_admins)):
+ foreach($fb_admins as $id):
</ins><span class="cx"> ?>
</span><del>-
</del><ins>+ <meta property="fb:admins" content="<?php echo esc_attr($id); ?>">
</ins><span class="cx"> <?php
</span><ins>+ endforeach;
+ endif;
</ins><span class="cx"> });
</span><span class="cx">\ No newline at end of file
</span></span></pre></div>
<a id="trunkWebsiteswebkitorgwpcontentthemeswebkitimagesogimagepng"></a>
<div class="binary"><h4>Added: trunk/Websites/webkit.org/wp-content/themes/webkit/images/ogimage.png</h4>
<pre class="diff"><span>
<span class="cx">(Binary files differ)
</span></span></pre></div>
<span class="cx">Index: trunk/Websites/webkit.org/wp-content/themes/webkit/images/ogimage.png
</span><span class="cx">===================================================================
</span><del>--- trunk/Websites/webkit.org/wp-content/themes/webkit/images/ogimage.png 2016-06-28 18:08:59 UTC (rev 202576)
</del><ins>+++ trunk/Websites/webkit.org/wp-content/themes/webkit/images/ogimage.png 2016-06-28 18:12:23 UTC (rev 202577)
</ins><span class="cx">Property changes on: trunk/Websites/webkit.org/wp-content/themes/webkit/images/ogimage.png
</span><span class="cx">___________________________________________________________________
</span><a id="svnmimetype"></a>
<div class="addfile"><h4>Added: svn:mime-type</h4></div>
<ins>+image/png
</ins><span class="cx">\ No newline at end of property
</span></div>
</body>
</html>