<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[202592] trunk/Source/WebCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/202592">202592</a></dd>
<dt>Author</dt> <dd>dino@apple.com</dd>
<dt>Date</dt> <dd>2016-06-28 15:11:45 -0700 (Tue, 28 Jun 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Remove incorrect comments in HTMLCanvasElement
https://bugs.webkit.org/show_bug.cgi?id=159229
Reviewed by Sam Weinig.
These comments are wrong.
* html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::probablySupportsContext):
(WebCore::HTMLCanvasElement::getContext): Deleted.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLCanvasElementcpp">trunk/Source/WebCore/html/HTMLCanvasElement.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (202591 => 202592)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-06-28 22:09:06 UTC (rev 202591)
+++ trunk/Source/WebCore/ChangeLog 2016-06-28 22:11:45 UTC (rev 202592)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2016-06-28 Dean Jackson <dino@apple.com>
+
+ Remove incorrect comments in HTMLCanvasElement
+ https://bugs.webkit.org/show_bug.cgi?id=159229
+
+ Reviewed by Sam Weinig.
+
+ These comments are wrong.
+
+ * html/HTMLCanvasElement.cpp:
+ (WebCore::HTMLCanvasElement::probablySupportsContext):
+ (WebCore::HTMLCanvasElement::getContext): Deleted.
+
</ins><span class="cx"> 2016-06-28 Geoffrey Garen <ggaren@apple.com>
</span><span class="cx">
</span><span class="cx"> CrashTracer beneath JSC::MarkedBlock::specializedSweep
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLCanvasElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLCanvasElement.cpp (202591 => 202592)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLCanvasElement.cpp 2016-06-28 22:09:06 UTC (rev 202591)
+++ trunk/Source/WebCore/html/HTMLCanvasElement.cpp 2016-06-28 22:11:45 UTC (rev 202592)
</span><span class="lines">@@ -206,14 +206,6 @@
</span><span class="cx">
</span><span class="cx"> CanvasRenderingContext* HTMLCanvasElement::getContext(const String& type, CanvasContextAttributes* attrs)
</span><span class="cx"> {
</span><del>- // A Canvas can either be "2D" or "webgl" but never both. If you request a 2D canvas and the existing
- // context is already 2D, just return that. If the existing context is WebGL, then destroy it
- // before creating a new 2D context. Vice versa when requesting a WebGL canvas. Requesting a
- // context with any other type string will destroy any existing context.
-
- // FIXME: The code depends on the context not going away once created, to prevent JS from
- // seeing a dangling pointer. So for now we will disallow the context from being changed
- // once it is created. https://bugs.webkit.org/show_bug.cgi?id=117095
</del><span class="cx"> if (is2dType(type)) {
</span><span class="cx"> if (m_context && !m_context->is2d())
</span><span class="cx"> return nullptr;
</span><span class="lines">@@ -271,11 +263,8 @@
</span><span class="cx">
</span><span class="cx"> bool HTMLCanvasElement::probablySupportsContext(const String& type, CanvasContextAttributes*)
</span><span class="cx"> {
</span><del>- // FIXME: Provide implementation that accounts for attributes. Bugzilla bug 117093
</del><ins>+ // FIXME: Provide implementation that accounts for attributes.
</ins><span class="cx"> // https://bugs.webkit.org/show_bug.cgi?id=117093
</span><del>-
- // FIXME: The code depends on the context not going away once created (as getContext
- // is implemented under this assumption) https://bugs.webkit.org/show_bug.cgi?id=117095
</del><span class="cx"> if (is2dType(type))
</span><span class="cx"> return !m_context || m_context->is2d();
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>