<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[202380] trunk/Source</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/202380">202380</a></dd>
<dt>Author</dt> <dd>wilander@apple.com</dd>
<dt>Date</dt> <dd>2016-06-23 09:35:17 -0700 (Thu, 23 Jun 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Source/WebCore:
Enable window.open() for existing versions of Secret Society
https://bugs.webkit.org/show_bug.cgi?id=159049
<rdar://problem/26528349>
Reviewed by Andy Estes.
The Secret Society Hidden Mystery app has a broken version check treating iOS 10
as iOS 1 on iPads. Therefore it believes it can use window.open() in a tap
handler. We should allow the existing versions of the app to do this to not break
them.
No new tests. Tested manually in the app.
* page/DOMWindow.cpp:
(WebCore::DOMWindow::allowPopUp):
Now checks with Settings whether it should allow a popup even though it is
not processing a user gesture.
* page/Settings.in:
Added setting allowWindowOpenWithoutUserGesture.
* platform/RuntimeApplicationChecks.h:
* platform/RuntimeApplicationChecks.mm:
(WebCore::IOSApplication::isTheSecretSocietyHiddenMystery):
Added.
Source/WebKit/mac:
Enable window.open() for existing versions of Secret Society app
https://bugs.webkit.org/show_bug.cgi?id=159049
<rdar://problem/26528349>
Reviewed by Andy Estes.
The Secret Society Hidden Mystery app has a broken version check treating iOS 10
as iOS 1 on iPads. Therefore it believes it can use window.open() in a tap
handler. We should allow the existing versions of the app to do this to not break
them.
* WebView/WebView.mm:
(shouldAllowWindowOpenWithoutUserGesture):
Added.
(shouldConvertInvalidURLsToBlank):
Changed hex number to constant DYLD_IOS_VERSION_10_0.
Source/WTF:
Enable window.open() for existing versions of Secret Society
https://bugs.webkit.org/show_bug.cgi?id=159049
<rdar://problem/26528349>
Reviewed by Andy Estes.
The Secret Society Hidden Mystery app has a broken version check treating iOS 10
as iOS 1 on iPads. Therefore it believes it can use window.open() in a tap
handler. We should allow the existing versions of the app to do this to not break
them.
* wtf/spi/darwin/dyldSPI.h:
Added DYLD_IOS_VERSION_10_0.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWTFChangeLog">trunk/Source/WTF/ChangeLog</a></li>
<li><a href="#trunkSourceWTFwtfspidarwindyldSPIh">trunk/Source/WTF/wtf/spi/darwin/dyldSPI.h</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorepageDOMWindowcpp">trunk/Source/WebCore/page/DOMWindow.cpp</a></li>
<li><a href="#trunkSourceWebCorepageSettingsin">trunk/Source/WebCore/page/Settings.in</a></li>
<li><a href="#trunkSourceWebCoreplatformRuntimeApplicationChecksh">trunk/Source/WebCore/platform/RuntimeApplicationChecks.h</a></li>
<li><a href="#trunkSourceWebCoreplatformRuntimeApplicationChecksmm">trunk/Source/WebCore/platform/RuntimeApplicationChecks.mm</a></li>
<li><a href="#trunkSourceWebKitmacChangeLog">trunk/Source/WebKit/mac/ChangeLog</a></li>
<li><a href="#trunkSourceWebKitmacWebViewWebViewmm">trunk/Source/WebKit/mac/WebView/WebView.mm</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWTFChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WTF/ChangeLog (202379 => 202380)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WTF/ChangeLog 2016-06-23 16:03:18 UTC (rev 202379)
+++ trunk/Source/WTF/ChangeLog 2016-06-23 16:35:17 UTC (rev 202380)
</span><span class="lines">@@ -1,3 +1,19 @@
</span><ins>+2016-06-23 John Wilander <wilander@apple.com>
+
+ Enable window.open() for existing versions of Secret Society
+ https://bugs.webkit.org/show_bug.cgi?id=159049
+ <rdar://problem/26528349>
+
+ Reviewed by Andy Estes.
+
+ The Secret Society Hidden Mystery app has a broken version check treating iOS 10
+ as iOS 1 on iPads. Therefore it believes it can use window.open() in a tap
+ handler. We should allow the existing versions of the app to do this to not break
+ them.
+
+ * wtf/spi/darwin/dyldSPI.h:
+ Added DYLD_IOS_VERSION_10_0.
+
</ins><span class="cx"> 2016-06-21 Said Abou-Hallawa <sabouhallawa@apple,com>
</span><span class="cx">
</span><span class="cx"> Add system tracing points for requestAnimationFrame() workflow
</span></span></pre></div>
<a id="trunkSourceWTFwtfspidarwindyldSPIh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WTF/wtf/spi/darwin/dyldSPI.h (202379 => 202380)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WTF/wtf/spi/darwin/dyldSPI.h 2016-06-23 16:03:18 UTC (rev 202379)
+++ trunk/Source/WTF/wtf/spi/darwin/dyldSPI.h 2016-06-23 16:35:17 UTC (rev 202380)
</span><span class="lines">@@ -37,6 +37,7 @@
</span><span class="cx"> #define DYLD_IOS_VERSION_6_0 0x00060000
</span><span class="cx"> #define DYLD_IOS_VERSION_7_0 0x00070000
</span><span class="cx"> #define DYLD_IOS_VERSION_9_0 0x00090000
</span><ins>+#define DYLD_IOS_VERSION_10_0 0x000A0000
</ins><span class="cx">
</span><span class="cx"> #endif
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (202379 => 202380)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-06-23 16:03:18 UTC (rev 202379)
+++ trunk/Source/WebCore/ChangeLog 2016-06-23 16:35:17 UTC (rev 202380)
</span><span class="lines">@@ -1,3 +1,29 @@
</span><ins>+2016-06-23 John Wilander <wilander@apple.com>
+
+ Enable window.open() for existing versions of Secret Society
+ https://bugs.webkit.org/show_bug.cgi?id=159049
+ <rdar://problem/26528349>
+
+ Reviewed by Andy Estes.
+
+ The Secret Society Hidden Mystery app has a broken version check treating iOS 10
+ as iOS 1 on iPads. Therefore it believes it can use window.open() in a tap
+ handler. We should allow the existing versions of the app to do this to not break
+ them.
+
+ No new tests. Tested manually in the app.
+
+ * page/DOMWindow.cpp:
+ (WebCore::DOMWindow::allowPopUp):
+ Now checks with Settings whether it should allow a popup even though it is
+ not processing a user gesture.
+ * page/Settings.in:
+ Added setting allowWindowOpenWithoutUserGesture.
+ * platform/RuntimeApplicationChecks.h:
+ * platform/RuntimeApplicationChecks.mm:
+ (WebCore::IOSApplication::isTheSecretSocietyHiddenMystery):
+ Added.
+
</ins><span class="cx"> 2016-06-23 Chris Dumez <cdumez@apple.com>
</span><span class="cx">
</span><span class="cx"> Only call sqlite3_initialize() when a SQLite database is actually being opened
</span></span></pre></div>
<a id="trunkSourceWebCorepageDOMWindowcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/DOMWindow.cpp (202379 => 202380)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/DOMWindow.cpp 2016-06-23 16:03:18 UTC (rev 202379)
+++ trunk/Source/WebCore/page/DOMWindow.cpp 2016-06-23 16:35:17 UTC (rev 202380)
</span><span class="lines">@@ -358,11 +358,13 @@
</span><span class="cx"> bool DOMWindow::allowPopUp(Frame* firstFrame)
</span><span class="cx"> {
</span><span class="cx"> ASSERT(firstFrame);
</span><ins>+
+ auto& settings = firstFrame->settings();
</ins><span class="cx">
</span><del>- if (ScriptController::processingUserGesture())
</del><ins>+ if (ScriptController::processingUserGesture() || settings.allowWindowOpenWithoutUserGesture())
</ins><span class="cx"> return true;
</span><span class="cx">
</span><del>- return firstFrame->settings().javaScriptCanOpenWindowsAutomatically();
</del><ins>+ return settings.javaScriptCanOpenWindowsAutomatically();
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> bool DOMWindow::allowPopUp()
</span></span></pre></div>
<a id="trunkSourceWebCorepageSettingsin"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/Settings.in (202379 => 202380)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/Settings.in 2016-06-23 16:03:18 UTC (rev 202379)
+++ trunk/Source/WebCore/page/Settings.in 2016-06-23 16:35:17 UTC (rev 202380)
</span><span class="lines">@@ -264,6 +264,8 @@
</span><span class="cx">
</span><span class="cx"> allowContentSecurityPolicySourceStarToMatchAnyProtocol initial=false
</span><span class="cx">
</span><ins>+allowWindowOpenWithoutUserGesture initial=false
+
</ins><span class="cx"> selectionPaintingWithoutSelectionGapsEnabled initial=false
</span><span class="cx">
</span><span class="cx"> shouldConvertInvalidURLsToBlank initial=true
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformRuntimeApplicationChecksh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/RuntimeApplicationChecks.h (202379 => 202380)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/RuntimeApplicationChecks.h 2016-06-23 16:03:18 UTC (rev 202379)
+++ trunk/Source/WebCore/platform/RuntimeApplicationChecks.h 2016-06-23 16:35:17 UTC (rev 202380)
</span><span class="lines">@@ -75,6 +75,7 @@
</span><span class="cx"> WEBCORE_EXPORT bool isEcobee();
</span><span class="cx"> WEBCORE_EXPORT bool isQuora();
</span><span class="cx"> WEBCORE_EXPORT bool isXtraMath();
</span><ins>+WEBCORE_EXPORT bool isTheSecretSocietyHiddenMystery();
</ins><span class="cx">
</span><span class="cx"> } // IOSApplication
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformRuntimeApplicationChecksmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/RuntimeApplicationChecks.mm (202379 => 202380)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/RuntimeApplicationChecks.mm 2016-06-23 16:03:18 UTC (rev 202379)
+++ trunk/Source/WebCore/platform/RuntimeApplicationChecks.mm 2016-06-23 16:35:17 UTC (rev 202380)
</span><span class="lines">@@ -253,6 +253,12 @@
</span><span class="cx"> return isXtraMath;
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+bool IOSApplication::isTheSecretSocietyHiddenMystery()
+{
+ static bool isTheSecretSocietyHiddenMystery = applicationBundleIsEqualTo("com.g5e.secretsociety");
+ return isTheSecretSocietyHiddenMystery;
+}
+
</ins><span class="cx"> #endif
</span><span class="cx">
</span><span class="cx"> } // namespace WebCore
</span></span></pre></div>
<a id="trunkSourceWebKitmacChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/ChangeLog (202379 => 202380)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/ChangeLog 2016-06-23 16:03:18 UTC (rev 202379)
+++ trunk/Source/WebKit/mac/ChangeLog 2016-06-23 16:35:17 UTC (rev 202380)
</span><span class="lines">@@ -1,3 +1,22 @@
</span><ins>+2016-06-23 John Wilander <wilander@apple.com>
+
+ Enable window.open() for existing versions of Secret Society app
+ https://bugs.webkit.org/show_bug.cgi?id=159049
+ <rdar://problem/26528349>
+
+ Reviewed by Andy Estes.
+
+ The Secret Society Hidden Mystery app has a broken version check treating iOS 10
+ as iOS 1 on iPads. Therefore it believes it can use window.open() in a tap
+ handler. We should allow the existing versions of the app to do this to not break
+ them.
+
+ * WebView/WebView.mm:
+ (shouldAllowWindowOpenWithoutUserGesture):
+ Added.
+ (shouldConvertInvalidURLsToBlank):
+ Changed hex number to constant DYLD_IOS_VERSION_10_0.
+
</ins><span class="cx"> 2016-06-22 Anders Carlsson <andersca@apple.com>
</span><span class="cx">
</span><span class="cx"> Move the WebKitLegacy Apple Pay code to the open source repository
</span></span></pre></div>
<a id="trunkSourceWebKitmacWebViewWebViewmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/WebView/WebView.mm (202379 => 202380)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/WebView/WebView.mm 2016-06-23 16:03:18 UTC (rev 202379)
+++ trunk/Source/WebKit/mac/WebView/WebView.mm 2016-06-23 16:35:17 UTC (rev 202380)
</span><span class="lines">@@ -876,10 +876,20 @@
</span><span class="cx"> #endif
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+static bool shouldAllowWindowOpenWithoutUserGesture()
+{
+#if PLATFORM(IOS)
+ static bool shouldAllowWindowOpenWithoutUserGesture = IOSApplication::isTheSecretSocietyHiddenMystery() && dyld_get_program_sdk_version() < DYLD_IOS_VERSION_10_0;
+ return shouldAllowWindowOpenWithoutUserGesture;
+#else
+ return false;
+#endif
+}
+
</ins><span class="cx"> static bool shouldConvertInvalidURLsToBlank()
</span><span class="cx"> {
</span><span class="cx"> #if PLATFORM(IOS)
</span><del>- static bool shouldConvertInvalidURLsToBlank = dyld_get_program_sdk_version() >= 0x000A0000;
</del><ins>+ static bool shouldConvertInvalidURLsToBlank = dyld_get_program_sdk_version() >= DYLD_IOS_VERSION_10_0;
</ins><span class="cx"> #elif PLATFORM(MAC)
</span><span class="cx"> static bool shouldConvertInvalidURLsToBlank = dyld_get_program_sdk_version() >= 0x000A0C00;
</span><span class="cx"> #else
</span><span class="lines">@@ -2542,6 +2552,8 @@
</span><span class="cx">
</span><span class="cx"> settings.setAllowContentSecurityPolicySourceStarToMatchAnyProtocol(shouldAllowContentSecurityPolicySourceStarToMatchAnyProtocol());
</span><span class="cx">
</span><ins>+ settings.setAllowWindowOpenWithoutUserGesture(shouldAllowWindowOpenWithoutUserGesture());
+
</ins><span class="cx"> settings.setShouldConvertInvalidURLsToBlank(shouldConvertInvalidURLsToBlank());
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>