<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[202401] trunk/Source/WebCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/202401">202401</a></dd>
<dt>Author</dt> <dd>bburg@apple.com</dd>
<dt>Date</dt> <dd>2016-06-23 16:22:21 -0700 (Thu, 23 Jun 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Web Inspector: add assertions to catch dangling frontends that persist between tests
https://bugs.webkit.org/show_bug.cgi?id=159073
Reviewed by Joseph Pecoraro.
Based on the analysis in https://webkit.org/b/159070, we suspect that some test
flakiness might be caused by dangling frontends from previous test cases. Add an
assertion that should catch any frontends that are attached to the inspected page's
backend. There should never be any frontends connected when a test first starts.
* inspector/InspectorController.cpp:
(WebCore::InspectorController::setIsUnderTest):
* inspector/InspectorController.h:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorControllercpp">trunk/Source/WebCore/inspector/InspectorController.cpp</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorControllerh">trunk/Source/WebCore/inspector/InspectorController.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (202400 => 202401)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-06-23 22:52:00 UTC (rev 202400)
+++ trunk/Source/WebCore/ChangeLog 2016-06-23 23:22:21 UTC (rev 202401)
</span><span class="lines">@@ -1,3 +1,19 @@
</span><ins>+2016-06-23 Brian Burg <bburg@apple.com>
+
+ Web Inspector: add assertions to catch dangling frontends that persist between tests
+ https://bugs.webkit.org/show_bug.cgi?id=159073
+
+ Reviewed by Joseph Pecoraro.
+
+ Based on the analysis in https://webkit.org/b/159070, we suspect that some test
+ flakiness might be caused by dangling frontends from previous test cases. Add an
+ assertion that should catch any frontends that are attached to the inspected page's
+ backend. There should never be any frontends connected when a test first starts.
+
+ * inspector/InspectorController.cpp:
+ (WebCore::InspectorController::setIsUnderTest):
+ * inspector/InspectorController.h:
+
</ins><span class="cx"> 2016-06-23 Said Abou-Hallawa <sabouhallawa@apple.com>
</span><span class="cx">
</span><span class="cx"> requestFrameAnimation() callback timestamp should be very close to Performance.now()
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorControllercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorController.cpp (202400 => 202401)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorController.cpp 2016-06-23 22:52:00 UTC (rev 202400)
+++ trunk/Source/WebCore/inspector/InspectorController.cpp 2016-06-23 23:22:21 UTC (rev 202401)
</span><span class="lines">@@ -341,6 +341,17 @@
</span><span class="cx"> IdentifiersFactory::setProcessId(processId);
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+void InspectorController::setIsUnderTest(bool value)
+{
+ if (value == m_isUnderTest)
+ return;
+
+ m_isUnderTest = value;
+
+ // <rdar://problem/26768628> Try to catch suspicious scenarios where we may have a dangling frontend while running tests.
+ RELEASE_ASSERT(!m_isUnderTest || !m_frontendRouter->hasFrontends());
+}
+
</ins><span class="cx"> void InspectorController::evaluateForTestInFrontend(const String& script)
</span><span class="cx"> {
</span><span class="cx"> m_inspectorAgent->evaluateForTestInFrontend(script);
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorControllerh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorController.h (202400 => 202401)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorController.h 2016-06-23 22:52:00 UTC (rev 202400)
+++ trunk/Source/WebCore/inspector/InspectorController.h 2016-06-23 23:22:21 UTC (rev 202401)
</span><span class="lines">@@ -107,7 +107,7 @@
</span><span class="cx"> WEBCORE_EXPORT Ref<Inspector::Protocol::Array<Inspector::Protocol::OverlayTypes::NodeHighlightData>> buildObjectForHighlightedNodes() const;
</span><span class="cx">
</span><span class="cx"> bool isUnderTest() const { return m_isUnderTest; }
</span><del>- void setIsUnderTest(bool isUnderTest) { m_isUnderTest = isUnderTest; }
</del><ins>+ WEBCORE_EXPORT void setIsUnderTest(bool);
</ins><span class="cx"> WEBCORE_EXPORT void evaluateForTestInFrontend(const String& script);
</span><span class="cx">
</span><span class="cx"> InspectorClient* inspectorClient() const { return m_inspectorClient; }
</span></span></pre>
</div>
</div>
</body>
</html>