<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[202326] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/202326">202326</a></dd>
<dt>Author</dt> <dd>pvollan@apple.com</dd>
<dt>Date</dt> <dd>2016-06-22 00:48:15 -0700 (Wed, 22 Jun 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>window.showModalDialog doesn't work in DumpRenderTree on Windows
https://bugs.webkit.org/show_bug.cgi?id=53675
Reviewed by Brent Fulgham.
Tools:
Implement modal dialog support in DumpRenderTree.
* DumpRenderTree/win/UIDelegate.cpp:
(UIDelegate::canRunModal):
(getHandleFromWebView):
(UIDelegate::createModalDialog):
(findTopLevelParent):
(UIDelegate::runModal):
(UIDelegate::webViewClose):
* DumpRenderTree/win/UIDelegate.h:
LayoutTests:
Update test expectations for modal dialog tests.
* platform/win/TestExpectations:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsplatformwinTestExpectations">trunk/LayoutTests/platform/win/TestExpectations</a></li>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
<li><a href="#trunkToolsDumpRenderTreewinUIDelegatecpp">trunk/Tools/DumpRenderTree/win/UIDelegate.cpp</a></li>
<li><a href="#trunkToolsDumpRenderTreewinUIDelegateh">trunk/Tools/DumpRenderTree/win/UIDelegate.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (202325 => 202326)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2016-06-22 05:52:52 UTC (rev 202325)
+++ trunk/LayoutTests/ChangeLog 2016-06-22 07:48:15 UTC (rev 202326)
</span><span class="lines">@@ -1,3 +1,14 @@
</span><ins>+2016-06-22 Per Arne Vollan <pvollan@apple.com>
+
+ window.showModalDialog doesn't work in DumpRenderTree on Windows
+ https://bugs.webkit.org/show_bug.cgi?id=53675
+
+ Reviewed by Brent Fulgham.
+
+ Update test expectations for modal dialog tests.
+
+ * platform/win/TestExpectations:
+
</ins><span class="cx"> 2016-06-21 Alexey Proskuryakov <ap@apple.com>
</span><span class="cx">
</span><span class="cx"> Land test expectations for rdar://problem/26422051.
</span></span></pre></div>
<a id="trunkLayoutTestsplatformwinTestExpectations"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/win/TestExpectations (202325 => 202326)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/win/TestExpectations 2016-06-22 05:52:52 UTC (rev 202325)
+++ trunk/LayoutTests/platform/win/TestExpectations 2016-06-22 07:48:15 UTC (rev 202326)
</span><span class="lines">@@ -308,12 +308,7 @@
</span><span class="cx"> webkit.org/b/140234 fast/text/midword-break-before-surrogate-pair-2.html [ Failure ]
</span><span class="cx"> webkit.org/b/140234 fast/text/narrow-non-breaking-space.html [ ImageOnlyFailure ]
</span><span class="cx">
</span><del>-# TODO DRT doesn't support showModalDialog
-webkit.org/b/53675 fast/events/show-modal-dialog-onblur-onfocus.html [ Skip ]
-webkit.org/b/53675 fast/harness/show-modal-dialog.html [ Skip ]
-webkit.org/b/53675 fast/events/scroll-event-during-modal-dialog.html [ Skip ]
-webkit.org/b/53675 fast/dom/Window/open-window-min-size.html [ Skip ]
-webkit.org/b/53675 js/dom/function-length.html [ Skip ]
</del><ins>+fast/events/scroll-event-during-modal-dialog.html [ Failure ]
</ins><span class="cx">
</span><span class="cx"> webkit.org/b/151506 fast/events/beforeunload-showModalDialog.html [ Skip ]
</span><span class="cx"> webkit.org/b/151506 fast/events/pagehide-showModalDialog.html [ Skip ]
</span></span></pre></div>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (202325 => 202326)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog 2016-06-22 05:52:52 UTC (rev 202325)
+++ trunk/Tools/ChangeLog 2016-06-22 07:48:15 UTC (rev 202326)
</span><span class="lines">@@ -1,3 +1,21 @@
</span><ins>+2016-06-22 Per Arne Vollan <pvollan@apple.com>
+
+ window.showModalDialog doesn't work in DumpRenderTree on Windows
+ https://bugs.webkit.org/show_bug.cgi?id=53675
+
+ Reviewed by Brent Fulgham.
+
+ Implement modal dialog support in DumpRenderTree.
+
+ * DumpRenderTree/win/UIDelegate.cpp:
+ (UIDelegate::canRunModal):
+ (getHandleFromWebView):
+ (UIDelegate::createModalDialog):
+ (findTopLevelParent):
+ (UIDelegate::runModal):
+ (UIDelegate::webViewClose):
+ * DumpRenderTree/win/UIDelegate.h:
+
</ins><span class="cx"> 2016-06-21 Aakash Jain <aakash_jain@apple.com>
</span><span class="cx">
</span><span class="cx"> Fix formatting issues reported by check-webkit-style
</span></span></pre></div>
<a id="trunkToolsDumpRenderTreewinUIDelegatecpp"></a>
<div class="modfile"><h4>Modified: trunk/Tools/DumpRenderTree/win/UIDelegate.cpp (202325 => 202326)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/DumpRenderTree/win/UIDelegate.cpp 2016-06-22 05:52:52 UTC (rev 202325)
+++ trunk/Tools/DumpRenderTree/win/UIDelegate.cpp 2016-06-22 07:48:15 UTC (rev 202326)
</span><span class="lines">@@ -313,24 +313,112 @@
</span><span class="cx"> return E_NOTIMPL;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-HRESULT UIDelegate::canRunModal(_In_opt_ IWebView*, _Out_ BOOL* /*canRunBoolean*/)
</del><ins>+HRESULT UIDelegate::canRunModal(_In_opt_ IWebView*, _Out_ BOOL* canRunBoolean)
</ins><span class="cx"> {
</span><del>- return E_NOTIMPL;
</del><ins>+ if (!canRunBoolean)
+ return E_POINTER;
+ *canRunBoolean = TRUE;
+ return S_OK;
</ins><span class="cx"> }
</span><span class="cx">
</span><del>-HRESULT UIDelegate::createModalDialog(_In_opt_ IWebView* /*sender*/, _In_opt_ IWebURLRequest* /*request*/, _COM_Outptr_opt_ IWebView** newWebView)
</del><ins>+static HWND getHandleFromWebView(IWebView* webView)
</ins><span class="cx"> {
</span><ins>+ COMPtr<IWebViewPrivate2> webViewPrivate;
+ HRESULT hr = webView->QueryInterface(&webViewPrivate);
+ if (FAILED(hr))
+ return nullptr;
+
+ HWND webViewWindow = nullptr;
+ hr = webViewPrivate->viewWindow(&webViewWindow);
+ if (FAILED(hr))
+ return nullptr;
+
+ return webViewWindow;
+}
+
+HRESULT UIDelegate::createModalDialog(_In_opt_ IWebView* sender, _In_opt_ IWebURLRequest*, _COM_Outptr_opt_ IWebView** newWebView)
+{
</ins><span class="cx"> if (!newWebView)
</span><span class="cx"> return E_POINTER;
</span><del>- *newWebView = nullptr;
- return E_NOTIMPL;
</del><ins>+
+ COMPtr<IWebView> webView;
+ HRESULT hr = WebKitCreateInstance(CLSID_WebView, 0, IID_IWebView, (void**)&webView);
+ if (FAILED(hr))
+ return hr;
+
+ m_modalDialogParent = ::CreateWindow(L"STATIC", L"ModalDialog", WS_OVERLAPPED | WS_VISIBLE, 0, 0, 0, 0, getHandleFromWebView(sender), nullptr, nullptr, nullptr);
+
+ hr = webView->setHostWindow(m_modalDialogParent);
+ if (FAILED(hr))
+ return hr;
+
+ RECT clientRect = { 0, 0, 0, 0 };
+ hr = webView->initWithFrame(clientRect, 0, _bstr_t(L""));
+ if (FAILED(hr))
+ return hr;
+
+ COMPtr<IWebUIDelegate> uiDelegate;
+ hr = sender->uiDelegate(&uiDelegate);
+ if (FAILED(hr))
+ return hr;
+
+ hr = webView->setUIDelegate(uiDelegate.get());
+ if (FAILED(hr))
+ return hr;
+
+ COMPtr<IWebFrameLoadDelegate> frameLoadDelegate;
+ hr = sender->frameLoadDelegate(&frameLoadDelegate);
+ if (FAILED(hr))
+ return hr;
+
+ hr = webView.get()->setFrameLoadDelegate(frameLoadDelegate.get());
+ if (FAILED(hr))
+ return hr;
+
+ *newWebView = webView.leakRef();
+
+ return S_OK;
</ins><span class="cx"> }
</span><span class="cx">
</span><del>-HRESULT UIDelegate::runModal(_In_opt_ IWebView*)
</del><ins>+static HWND findTopLevelParent(HWND window)
</ins><span class="cx"> {
</span><del>- return E_NOTIMPL;
</del><ins>+ if (!window)
+ return nullptr;
+
+ HWND current = window;
+ for (HWND parent = GetParent(current); current; current = parent, parent = GetParent(parent)) {
+ if (!parent)
+ return current;
+ }
+ ASSERT_NOT_REACHED();
+ return nullptr;
</ins><span class="cx"> }
</span><span class="cx">
</span><ins>+HRESULT UIDelegate::runModal(_In_opt_ IWebView* webView)
+{
+ COMPtr<IWebView> protector(webView);
+
+ auto topLevelParent = findTopLevelParent(::GetWindow(m_modalDialogParent, GW_OWNER));
+
+ ::EnableWindow(topLevelParent, FALSE);
+
+ while (::IsWindow(getHandleFromWebView(webView))) {
+#if USE(CF)
+ CFRunLoopRunInMode(kCFRunLoopDefaultMode, 0, true);
+#endif
+ MSG msg;
+ if (!::GetMessage(&msg, 0, 0, 0))
+ break;
+
+ ::TranslateMessage(&msg);
+ ::DispatchMessage(&msg);
+ }
+
+ ::EnableWindow(topLevelParent, TRUE);
+
+ return S_OK;
+}
+
</ins><span class="cx"> HRESULT UIDelegate::isMenuBarVisible(_In_opt_ IWebView*, _Out_ BOOL* visible)
</span><span class="cx"> {
</span><span class="cx"> if (!visible)
</span><span class="lines">@@ -483,6 +571,8 @@
</span><span class="cx"> HWND hostWindow;
</span><span class="cx"> sender->hostWindow(&hostWindow);
</span><span class="cx"> DestroyWindow(hostWindow);
</span><ins>+ if (hostWindow == m_modalDialogParent)
+ m_modalDialogParent = nullptr;
</ins><span class="cx"> return S_OK;
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkToolsDumpRenderTreewinUIDelegateh"></a>
<div class="modfile"><h4>Modified: trunk/Tools/DumpRenderTree/win/UIDelegate.h (202325 => 202326)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/DumpRenderTree/win/UIDelegate.h 2016-06-22 05:52:52 UTC (rev 202325)
+++ trunk/Tools/DumpRenderTree/win/UIDelegate.h 2016-06-22 07:48:15 UTC (rev 202326)
</span><span class="lines">@@ -144,6 +144,7 @@
</span><span class="cx"> std::unique_ptr<DRTUndoManager> m_undoManager;
</span><span class="cx">
</span><span class="cx"> COMPtr<IWebDesktopNotificationsDelegate> m_desktopNotifications;
</span><ins>+ HWND m_modalDialogParent { nullptr };
</ins><span class="cx"> };
</span><span class="cx">
</span><span class="cx"> #endif
</span></span></pre>
</div>
</div>
</body>
</html>