<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[202297] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/202297">202297</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2016-06-21 15:29:57 -0700 (Tue, 21 Jun 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Add system tracing points for requestAnimationFrame() workflow
https://bugs.webkit.org/show_bug.cgi?id=158723
Patch by Said Abou-Hallawa <sabouhallawa@apple,com> on 2016-06-21
Reviewed by Simon Fraser.
Source/WebCore:
Add trace points for requestAnimationFrame().
* dom/ScriptedAnimationController.cpp:
(WebCore::ScriptedAnimationController::requestAnimationFrameEnabled):
(WebCore::ScriptedAnimationController::serviceScriptedAnimations):
(WebCore::ScriptedAnimationController::windowScreenDidChange):
(WebCore::ScriptedAnimationController::scheduleAnimation):
* dom/ScriptedAnimationController.h:
* platform/graphics/ios/DisplayRefreshMonitorIOS.mm:
(WebCore::DisplayRefreshMonitorIOS::requestRefreshCallback):
(WebCore::DisplayRefreshMonitorIOS::displayLinkFired):
Source/WebKit2:
Add trace points for requestAnimationFrame().
* UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm:
(WebKit::RemoteLayerTreeDrawingAreaProxy::commitLayerTree):
(WebKit::RemoteLayerTreeDrawingAreaProxy::didRefreshDisplay):
* WebProcess/WebPage/mac/RemoteLayerTreeContext.mm:
(WebKit::RemoteLayerTreeContext::buildTransaction):
* WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:
(WebKit::RemoteLayerTreeDrawingArea::didUpdate):
(WebKit::RemoteLayerTreeDrawingArea::BackingStoreFlusher::flush):
Source/WTF:
Define new trace score codes for requestAnimationFrame().
* wtf/SystemTracing.h:
(WTF::TracePoint):
(WTF::TraceScope::TraceScope):
(WTF::TraceScope::~TraceScope):
Tools:
Add new plist entries to be used by kdebug_trace() viewing tools.
* Tracing/SystemTracePoints.plist:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWTFChangeLog">trunk/Source/WTF/ChangeLog</a></li>
<li><a href="#trunkSourceWTFwtfSystemTracingh">trunk/Source/WTF/wtf/SystemTracing.h</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoredomScriptedAnimationControllercpp">trunk/Source/WebCore/dom/ScriptedAnimationController.cpp</a></li>
<li><a href="#trunkSourceWebCoredomScriptedAnimationControllerh">trunk/Source/WebCore/dom/ScriptedAnimationController.h</a></li>
<li><a href="#trunkSourceWebCoreplatformgraphicsiosDisplayRefreshMonitorIOSmm">trunk/Source/WebCore/platform/graphics/ios/DisplayRefreshMonitorIOS.mm</a></li>
<li><a href="#trunkSourceWebKit2ChangeLog">trunk/Source/WebKit2/ChangeLog</a></li>
<li><a href="#trunkSourceWebKit2UIProcessmacRemoteLayerTreeDrawingAreaProxymm">trunk/Source/WebKit2/UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm</a></li>
<li><a href="#trunkSourceWebKit2WebProcessWebPagemacRemoteLayerTreeContextmm">trunk/Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerTreeContext.mm</a></li>
<li><a href="#trunkSourceWebKit2WebProcessWebPagemacRemoteLayerTreeDrawingAreamm">trunk/Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm</a></li>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
<li><a href="#trunkToolsTracingSystemTracePointsplist">trunk/Tools/Tracing/SystemTracePoints.plist</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWTFChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WTF/ChangeLog (202296 => 202297)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WTF/ChangeLog 2016-06-21 22:26:57 UTC (rev 202296)
+++ trunk/Source/WTF/ChangeLog 2016-06-21 22:29:57 UTC (rev 202297)
</span><span class="lines">@@ -1,3 +1,17 @@
</span><ins>+2016-06-21 Said Abou-Hallawa <sabouhallawa@apple,com>
+
+ Add system tracing points for requestAnimationFrame() workflow
+ https://bugs.webkit.org/show_bug.cgi?id=158723
+
+ Reviewed by Simon Fraser.
+
+ Define new trace score codes for requestAnimationFrame().
+
+ * wtf/SystemTracing.h:
+ (WTF::TracePoint):
+ (WTF::TraceScope::TraceScope):
+ (WTF::TraceScope::~TraceScope):
+
</ins><span class="cx"> 2016-06-20 Commit Queue <commit-queue@webkit.org>
</span><span class="cx">
</span><span class="cx"> Unreviewed, rolling out r202136.
</span></span></pre></div>
<a id="trunkSourceWTFwtfSystemTracingh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WTF/wtf/SystemTracing.h (202296 => 202297)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WTF/wtf/SystemTracing.h 2016-06-21 22:26:57 UTC (rev 202296)
+++ trunk/Source/WTF/wtf/SystemTracing.h 2016-06-21 22:29:57 UTC (rev 202297)
</span><span class="lines">@@ -52,9 +52,27 @@
</span><span class="cx"> PaintViewEnd,
</span><span class="cx"> PaintLayerStart,
</span><span class="cx"> PaintLayerEnd,
</span><ins>+ RAFDisplayLinkScheduled,
+ RAFDisplayLinkFired,
+ RAFCallbackStart,
+ RAFCallbackEnd,
</ins><span class="cx">
</span><span class="cx"> WebKitRange = 10000,
</span><span class="cx"> WebKit2Range = 12000,
</span><ins>+
+ RAFDidUpdateStart,
+ RAFDidUpdateEnd,
+ RAFBackingStoreFlushStart,
+ RAFBackingStoreFlushEnd,
+ RAFBuildTransactionStart,
+ RAFBuildTransactionEnd,
+
+ UIProcessRange = 14000,
+
+ RAFCommitLayerTreeStart,
+ RAFCommitLayerTreeEnd,
+ RAFDidRefreshDisplayStart,
+ RAFDidRefreshDisplayEnd,
</ins><span class="cx"> };
</span><span class="cx">
</span><span class="cx"> #ifdef __cplusplus
</span><span class="lines">@@ -61,37 +79,37 @@
</span><span class="cx">
</span><span class="cx"> namespace WTF {
</span><span class="cx">
</span><ins>+inline void TracePoint(TracePointCode code)
+{
+#if HAVE(KDEBUG_H)
+ kdebug_trace(ARIADNEDBG_CODE(WEBKIT_COMPONENT, code), 0, 0, 0, 0);
+#else
+ UNUSED_PARAM(code);
+#endif
+}
+
</ins><span class="cx"> class TraceScope {
</span><span class="cx"> public:
</span><span class="cx">
</span><del>-#if HAVE(KDEBUG_H)
</del><span class="cx"> TraceScope(TracePointCode entryCode, TracePointCode exitCode)
</span><span class="cx"> : m_exitCode(exitCode)
</span><span class="cx"> {
</span><del>- kdebug_trace(ARIADNEDBG_CODE(WEBKIT_COMPONENT, entryCode), 0, 0, 0, 0);
</del><ins>+ TracePoint(entryCode);
</ins><span class="cx"> }
</span><del>-#else
- TraceScope(TracePointCode, TracePointCode)
- {
- }
-#endif
-
</del><ins>+
</ins><span class="cx"> ~TraceScope()
</span><span class="cx"> {
</span><del>-#if HAVE(KDEBUG_H)
- kdebug_trace(ARIADNEDBG_CODE(WEBKIT_COMPONENT, m_exitCode), 0, 0, 0, 0);
-#endif
</del><ins>+ TracePoint(m_exitCode);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> private:
</span><del>-#if HAVE(KDEBUG_H)
</del><span class="cx"> TracePointCode m_exitCode;
</span><del>-#endif
</del><span class="cx"> };
</span><span class="cx">
</span><span class="cx"> } // namespace WTF
</span><span class="cx">
</span><span class="cx"> using WTF::TraceScope;
</span><ins>+using WTF::TracePoint;
</ins><span class="cx">
</span><span class="cx"> #endif // __cplusplus
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (202296 => 202297)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-06-21 22:26:57 UTC (rev 202296)
+++ trunk/Source/WebCore/ChangeLog 2016-06-21 22:29:57 UTC (rev 202297)
</span><span class="lines">@@ -1,3 +1,22 @@
</span><ins>+2016-06-21 Said Abou-Hallawa <sabouhallawa@apple,com>
+
+ Add system tracing points for requestAnimationFrame() workflow
+ https://bugs.webkit.org/show_bug.cgi?id=158723
+
+ Reviewed by Simon Fraser.
+
+ Add trace points for requestAnimationFrame().
+
+ * dom/ScriptedAnimationController.cpp:
+ (WebCore::ScriptedAnimationController::requestAnimationFrameEnabled):
+ (WebCore::ScriptedAnimationController::serviceScriptedAnimations):
+ (WebCore::ScriptedAnimationController::windowScreenDidChange):
+ (WebCore::ScriptedAnimationController::scheduleAnimation):
+ * dom/ScriptedAnimationController.h:
+ * platform/graphics/ios/DisplayRefreshMonitorIOS.mm:
+ (WebCore::DisplayRefreshMonitorIOS::requestRefreshCallback):
+ (WebCore::DisplayRefreshMonitorIOS::displayLinkFired):
+
</ins><span class="cx"> 2016-06-20 Simon Fraser <simon.fraser@apple.com>
</span><span class="cx">
</span><span class="cx"> [iOS] Typing text into a text field or text area causes screen to scroll down (hiding text entry)
</span></span></pre></div>
<a id="trunkSourceWebCoredomScriptedAnimationControllercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/ScriptedAnimationController.cpp (202296 => 202297)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/ScriptedAnimationController.cpp 2016-06-21 22:26:57 UTC (rev 202296)
+++ trunk/Source/WebCore/dom/ScriptedAnimationController.cpp 2016-06-21 22:29:57 UTC (rev 202297)
</span><span class="lines">@@ -40,6 +40,7 @@
</span><span class="cx"> #include "RequestAnimationFrameCallback.h"
</span><span class="cx"> #include "Settings.h"
</span><span class="cx"> #include <wtf/Ref.h>
</span><ins>+#include <wtf/SystemTracing.h>
</ins><span class="cx">
</span><span class="cx"> #if USE(REQUEST_ANIMATION_FRAME_TIMER)
</span><span class="cx"> #include <algorithm>
</span><span class="lines">@@ -65,6 +66,11 @@
</span><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+bool ScriptedAnimationController::requestAnimationFrameEnabled() const
+{
+ return m_document && (!m_document->settings() || m_document->settings()->requestAnimationFrameEnabled());
+}
+
</ins><span class="cx"> void ScriptedAnimationController::suspend()
</span><span class="cx"> {
</span><span class="cx"> ++m_suspendCount;
</span><span class="lines">@@ -136,9 +142,11 @@
</span><span class="cx">
</span><span class="cx"> void ScriptedAnimationController::serviceScriptedAnimations(double monotonicTimeNow)
</span><span class="cx"> {
</span><del>- if (!m_callbacks.size() || m_suspendCount || (m_document->settings() && !m_document->settings()->requestAnimationFrameEnabled()))
</del><ins>+ if (!m_callbacks.size() || m_suspendCount || !requestAnimationFrameEnabled())
</ins><span class="cx"> return;
</span><span class="cx">
</span><ins>+ TraceScope tracingScope(RAFCallbackStart, RAFCallbackEnd);
+
</ins><span class="cx"> double highResNowMs = 1000.0 * m_document->loader()->timing().monotonicTimeToZeroBasedDocumentTime(monotonicTimeNow);
</span><span class="cx"> double legacyHighResNowMs = 1000.0 * m_document->loader()->timing().monotonicTimeToPseudoWallTime(monotonicTimeNow);
</span><span class="cx">
</span><span class="lines">@@ -176,7 +184,7 @@
</span><span class="cx">
</span><span class="cx"> void ScriptedAnimationController::windowScreenDidChange(PlatformDisplayID displayID)
</span><span class="cx"> {
</span><del>- if (m_document->settings() && !m_document->settings()->requestAnimationFrameEnabled())
</del><ins>+ if (!requestAnimationFrameEnabled())
</ins><span class="cx"> return;
</span><span class="cx"> #if USE(REQUEST_ANIMATION_FRAME_DISPLAY_MONITOR)
</span><span class="cx"> DisplayRefreshMonitorManager::sharedManager().windowScreenDidChange(displayID, *this);
</span><span class="lines">@@ -187,7 +195,7 @@
</span><span class="cx">
</span><span class="cx"> void ScriptedAnimationController::scheduleAnimation()
</span><span class="cx"> {
</span><del>- if (!m_document || (m_document->settings() && !m_document->settings()->requestAnimationFrameEnabled()))
</del><ins>+ if (!requestAnimationFrameEnabled())
</ins><span class="cx"> return;
</span><span class="cx">
</span><span class="cx"> #if USE(REQUEST_ANIMATION_FRAME_TIMER)
</span></span></pre></div>
<a id="trunkSourceWebCoredomScriptedAnimationControllerh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/ScriptedAnimationController.h (202296 => 202297)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/ScriptedAnimationController.h 2016-06-21 22:26:57 UTC (rev 202296)
+++ trunk/Source/WebCore/dom/ScriptedAnimationController.h 2016-06-21 22:29:57 UTC (rev 202297)
</span><span class="lines">@@ -58,6 +58,7 @@
</span><span class="cx"> }
</span><span class="cx"> ~ScriptedAnimationController();
</span><span class="cx"> void clearDocumentPointer() { m_document = nullptr; }
</span><ins>+ bool requestAnimationFrameEnabled() const;
</ins><span class="cx">
</span><span class="cx"> typedef int CallbackId;
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformgraphicsiosDisplayRefreshMonitorIOSmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/graphics/ios/DisplayRefreshMonitorIOS.mm (202296 => 202297)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/graphics/ios/DisplayRefreshMonitorIOS.mm 2016-06-21 22:26:57 UTC (rev 202296)
+++ trunk/Source/WebCore/platform/graphics/ios/DisplayRefreshMonitorIOS.mm 2016-06-21 22:29:57 UTC (rev 202297)
</span><span class="lines">@@ -32,6 +32,7 @@
</span><span class="cx"> #import <QuartzCore/QuartzCore.h>
</span><span class="cx"> #import <wtf/CurrentTime.h>
</span><span class="cx"> #import <wtf/MainThread.h>
</span><ins>+#import <wtf/SystemTracing.h>
</ins><span class="cx">
</span><span class="cx"> using namespace WebCore;
</span><span class="cx">
</span><span class="lines">@@ -97,6 +98,8 @@
</span><span class="cx"> if (!isActive())
</span><span class="cx"> return false;
</span><span class="cx">
</span><ins>+ TracePoint(RAFDisplayLinkScheduled);
+
</ins><span class="cx"> if (!m_handler) {
</span><span class="cx"> m_handler = adoptNS([[WebDisplayLinkHandler alloc] initWithMonitor:this]);
</span><span class="cx"> setIsActive(true);
</span><span class="lines">@@ -121,6 +124,8 @@
</span><span class="cx"> setMonotonicAnimationStartTime(mediaTimeToCurrentTime(nowSeconds));
</span><span class="cx">
</span><span class="cx"> handleDisplayRefreshedNotificationOnMainThread(this);
</span><ins>+
+ TracePoint(RAFDisplayLinkFired);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebKit2ChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/ChangeLog (202296 => 202297)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/ChangeLog 2016-06-21 22:26:57 UTC (rev 202296)
+++ trunk/Source/WebKit2/ChangeLog 2016-06-21 22:29:57 UTC (rev 202297)
</span><span class="lines">@@ -1,3 +1,21 @@
</span><ins>+2016-06-21 Said Abou-Hallawa <sabouhallawa@apple,com>
+
+ Add system tracing points for requestAnimationFrame() workflow
+ https://bugs.webkit.org/show_bug.cgi?id=158723
+
+ Reviewed by Simon Fraser.
+
+ Add trace points for requestAnimationFrame().
+
+ * UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm:
+ (WebKit::RemoteLayerTreeDrawingAreaProxy::commitLayerTree):
+ (WebKit::RemoteLayerTreeDrawingAreaProxy::didRefreshDisplay):
+ * WebProcess/WebPage/mac/RemoteLayerTreeContext.mm:
+ (WebKit::RemoteLayerTreeContext::buildTransaction):
+ * WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:
+ (WebKit::RemoteLayerTreeDrawingArea::didUpdate):
+ (WebKit::RemoteLayerTreeDrawingArea::BackingStoreFlusher::flush):
+
</ins><span class="cx"> 2016-06-21 Sam Weinig <sam@webkit.org>
</span><span class="cx">
</span><span class="cx"> WKWebView with no WKNavigationDelegate does not follow universal links
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessmacRemoteLayerTreeDrawingAreaProxymm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm (202296 => 202297)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm 2016-06-21 22:26:57 UTC (rev 202296)
+++ trunk/Source/WebKit2/UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm 2016-06-21 22:29:57 UTC (rev 202297)
</span><span class="lines">@@ -38,6 +38,7 @@
</span><span class="cx"> #import <WebCore/IOSurfacePool.h>
</span><span class="cx"> #import <WebCore/MachSendRight.h>
</span><span class="cx"> #import <WebCore/WebActionDisablingCALayerDelegate.h>
</span><ins>+#import <wtf/SystemTracing.h>
</ins><span class="cx">
</span><span class="cx"> using namespace IPC;
</span><span class="cx"> using namespace WebCore;
</span><span class="lines">@@ -175,6 +176,8 @@
</span><span class="cx">
</span><span class="cx"> void RemoteLayerTreeDrawingAreaProxy::commitLayerTree(const RemoteLayerTreeTransaction& layerTreeTransaction, const RemoteScrollingCoordinatorTransaction& scrollingTreeTransaction)
</span><span class="cx"> {
</span><ins>+ TraceScope tracingScope(RAFCommitLayerTreeStart, RAFCommitLayerTreeEnd);
+
</ins><span class="cx"> LOG(RemoteLayerTree, "%s", layerTreeTransaction.description().data());
</span><span class="cx"> LOG(RemoteLayerTree, "%s", scrollingTreeTransaction.description().data());
</span><span class="cx">
</span><span class="lines">@@ -406,6 +409,8 @@
</span><span class="cx">
</span><span class="cx"> m_didUpdateMessageState = Sent;
</span><span class="cx">
</span><ins>+ TraceScope tracingScope(RAFDidRefreshDisplayStart, RAFDidRefreshDisplayEnd);
+
</ins><span class="cx"> // Waiting for CA to commit is insufficient, because the render server can still be
</span><span class="cx"> // using our backing store. We can improve this by waiting for the render server to commit
</span><span class="cx"> // if we find API to do so, but for now we will make extra buffers if need be.
</span></span></pre></div>
<a id="trunkSourceWebKit2WebProcessWebPagemacRemoteLayerTreeContextmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerTreeContext.mm (202296 => 202297)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerTreeContext.mm 2016-06-21 22:26:57 UTC (rev 202296)
+++ trunk/Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerTreeContext.mm 2016-06-21 22:29:57 UTC (rev 202297)
</span><span class="lines">@@ -35,6 +35,7 @@
</span><span class="cx"> #import <WebCore/FrameView.h>
</span><span class="cx"> #import <WebCore/MainFrame.h>
</span><span class="cx"> #import <WebCore/Page.h>
</span><ins>+#import <wtf/SystemTracing.h>
</ins><span class="cx"> #import <wtf/TemporaryChange.h>
</span><span class="cx">
</span><span class="cx"> using namespace WebCore;
</span><span class="lines">@@ -106,6 +107,8 @@
</span><span class="cx">
</span><span class="cx"> void RemoteLayerTreeContext::buildTransaction(RemoteLayerTreeTransaction& transaction, PlatformCALayer& rootLayer)
</span><span class="cx"> {
</span><ins>+ TraceScope tracingScope(RAFBuildTransactionStart, RAFBuildTransactionEnd);
+
</ins><span class="cx"> PlatformCALayerRemote& rootLayerRemote = downcast<PlatformCALayerRemote>(rootLayer);
</span><span class="cx"> transaction.setRootLayerID(rootLayerRemote.layerID());
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebKit2WebProcessWebPagemacRemoteLayerTreeDrawingAreamm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm (202296 => 202297)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm 2016-06-21 22:26:57 UTC (rev 202296)
+++ trunk/Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm 2016-06-21 22:29:57 UTC (rev 202297)
</span><span class="lines">@@ -37,6 +37,7 @@
</span><span class="cx"> #import "RemoteScrollingCoordinatorTransaction.h"
</span><span class="cx"> #import "WebPage.h"
</span><span class="cx"> #import "WebProcess.h"
</span><ins>+#import <QuartzCore/QuartzCore.h>
</ins><span class="cx"> #import <WebCore/DebugPageOverlays.h>
</span><span class="cx"> #import <WebCore/Frame.h>
</span><span class="cx"> #import <WebCore/FrameView.h>
</span><span class="lines">@@ -48,7 +49,7 @@
</span><span class="cx"> #import <WebCore/RenderView.h>
</span><span class="cx"> #import <WebCore/Settings.h>
</span><span class="cx"> #import <WebCore/TiledBacking.h>
</span><del>-#import <QuartzCore/QuartzCore.h>
</del><ins>+#import <wtf/SystemTracing.h>
</ins><span class="cx">
</span><span class="cx"> using namespace WebCore;
</span><span class="cx">
</span><span class="lines">@@ -436,6 +437,8 @@
</span><span class="cx">
</span><span class="cx"> void RemoteLayerTreeDrawingArea::didUpdate()
</span><span class="cx"> {
</span><ins>+ TraceScope tracingScope(RAFDidUpdateStart, RAFDidUpdateEnd);
+
</ins><span class="cx"> // FIXME: This should use a counted replacement for setLayerTreeStateIsFrozen, but
</span><span class="cx"> // the callers of that function are not strictly paired.
</span><span class="cx">
</span><span class="lines">@@ -485,6 +488,8 @@
</span><span class="cx"> {
</span><span class="cx"> ASSERT(!m_hasFlushed);
</span><span class="cx">
</span><ins>+ TraceScope tracingScope(RAFBackingStoreFlushStart, RAFBackingStoreFlushEnd);
+
</ins><span class="cx"> for (auto& context : m_contextsToFlush)
</span><span class="cx"> CGContextFlush(context.get());
</span><span class="cx"> m_hasFlushed = true;
</span></span></pre></div>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (202296 => 202297)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog 2016-06-21 22:26:57 UTC (rev 202296)
+++ trunk/Tools/ChangeLog 2016-06-21 22:29:57 UTC (rev 202297)
</span><span class="lines">@@ -1,3 +1,14 @@
</span><ins>+2016-06-21 Said Abou-Hallawa <sabouhallawa@apple,com>
+
+ Add system tracing points for requestAnimationFrame() workflow
+ https://bugs.webkit.org/show_bug.cgi?id=158723
+
+ Reviewed by Simon Fraser.
+
+ Add new plist entries to be used by kdebug_trace() viewing tools.
+
+ * Tracing/SystemTracePoints.plist:
+
</ins><span class="cx"> 2016-06-21 Sam Weinig <sam@webkit.org>
</span><span class="cx">
</span><span class="cx"> WKWebView with no WKNavigationDelegate does not follow universal links
</span></span></pre></div>
<a id="trunkToolsTracingSystemTracePointsplist"></a>
<div class="modfile"><h4>Modified: trunk/Tools/Tracing/SystemTracePoints.plist (202296 => 202297)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/Tracing/SystemTracePoints.plist 2016-06-21 22:26:57 UTC (rev 202296)
+++ trunk/Tools/Tracing/SystemTracePoints.plist 2016-06-21 22:29:57 UTC (rev 202297)
</span><span class="lines">@@ -55,6 +55,90 @@
</span><span class="cx"> <key>CodeEnd</key>
</span><span class="cx"> <string>5008</string>
</span><span class="cx"> </dict>
</span><ins>+ <dict>
+ <key>Name</key>
+ <string>DisplayRefreshMonitor</string>
+ <key>Type</key>
+ <string>Interval</string>
+ <key>Component</key>
+ <string>47</string>
+ <key>CodeBegin</key>
+ <string>5009</string>
+ <key>CodeEnd</key>
+ <string>5010</string>
+ </dict>
+ <dict>
+ <key>Name</key>
+ <string>ScriptedAnimationController::serviceScriptedAnimations()</string>
+ <key>Type</key>
+ <string>Interval</string>
+ <key>Component</key>
+ <string>47</string>
+ <key>CodeBegin</key>
+ <string>5011</string>
+ <key>CodeEnd</key>
+ <string>5012</string>
+ </dict>
+ <dict>
+ <key>Name</key>
+ <string>RemoteLayerTreeDrawingArea::didUpdate()</string>
+ <key>Type</key>
+ <string>Interval</string>
+ <key>Component</key>
+ <string>47</string>
+ <key>CodeBegin</key>
+ <string>12001</string>
+ <key>CodeEnd</key>
+ <string>12002</string>
+ </dict>
+ <dict>
+ <key>Name</key>
+ <string>RemoteLayerTreeDrawingArea::BackingStoreFlusher::flush()</string>
+ <key>Type</key>
+ <string>Interval</string>
+ <key>Component</key>
+ <string>47</string>
+ <key>CodeBegin</key>
+ <string>12003</string>
+ <key>CodeEnd</key>
+ <string>12004</string>
+ </dict>
+ <dict>
+ <key>Name</key>
+ <string>RemoteLayerTreeContext::buildTransaction()</string>
+ <key>Type</key>
+ <string>Interval</string>
+ <key>Component</key>
+ <string>47</string>
+ <key>CodeBegin</key>
+ <string>12005</string>
+ <key>CodeEnd</key>
+ <string>12006</string>
+ </dict>
+ <dict>
+ <key>Name</key>
+ <string>RemoteLayerTreeDrawingAreaProxy::commitLayerTree()</string>
+ <key>Type</key>
+ <string>Interval</string>
+ <key>Component</key>
+ <string>47</string>
+ <key>CodeBegin</key>
+ <string>14001</string>
+ <key>CodeEnd</key>
+ <string>14002</string>
+ </dict>
+ <dict>
+ <key>Name</key>
+ <string>RemoteLayerTreeDrawingAreaProxy::didRefreshDisplay()</string>
+ <key>Type</key>
+ <string>Interval</string>
+ <key>Component</key>
+ <string>47</string>
+ <key>CodeBegin</key>
+ <string>14003</string>
+ <key>CodeEnd</key>
+ <string>14004</string>
+ </dict>
</ins><span class="cx"> </array>
</span><span class="cx"> </dict>
</span><span class="cx"> </array>
</span></span></pre>
</div>
</div>
</body>
</html>