<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[202318] trunk/PerformanceTests</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/202318">202318</a></dd>
<dt>Author</dt> <dd>jonlee@apple.com</dd>
<dt>Date</dt> <dd>2016-06-21 20:26:57 -0700 (Tue, 21 Jun 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Update canvas size when benchmark begins
https://bugs.webkit.org/show_bug.cgi?id=159010
Reviewed by Dean Jackson.
Previously we would evaluate the media queries and assign the canvas size to the test
on body.onload. Instead, do it once the user starts the benchmark.
* Animometer/resources/debug-runner/animometer.js: Move benchmarkController.determineCanvasSize()
to benchmarkController._startBenchmark.
* Animometer/resources/runner/animometer.js: Ditto.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkPerformanceTestsAnimometerresourcesdebugrunneranimometerjs">trunk/PerformanceTests/Animometer/resources/debug-runner/animometer.js</a></li>
<li><a href="#trunkPerformanceTestsAnimometerresourcesrunneranimometerjs">trunk/PerformanceTests/Animometer/resources/runner/animometer.js</a></li>
<li><a href="#trunkPerformanceTestsChangeLog">trunk/PerformanceTests/ChangeLog</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkPerformanceTestsAnimometerresourcesdebugrunneranimometerjs"></a>
<div class="modfile"><h4>Modified: trunk/PerformanceTests/Animometer/resources/debug-runner/animometer.js (202317 => 202318)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/PerformanceTests/Animometer/resources/debug-runner/animometer.js 2016-06-22 03:26:24 UTC (rev 202317)
+++ trunk/PerformanceTests/Animometer/resources/debug-runner/animometer.js 2016-06-22 03:26:57 UTC (rev 202318)
</span><span class="lines">@@ -507,7 +507,6 @@
</span><span class="cx"> if (benchmarkController.startBenchmarkImmediatelyIfEncoded())
</span><span class="cx"> return;
</span><span class="cx">
</span><del>- benchmarkController.determineCanvasSize();
</del><span class="cx"> benchmarkController.addOrientationListenerIfNecessary();
</span><span class="cx"> suitesManager.createElements();
</span><span class="cx"> suitesManager.updateUIFromLocalStorage();
</span><span class="lines">@@ -568,6 +567,7 @@
</span><span class="cx">
</span><span class="cx"> startBenchmark: function()
</span><span class="cx"> {
</span><ins>+ benchmarkController.determineCanvasSize();
</ins><span class="cx"> benchmarkController.options = optionsManager.updateLocalStorageFromUI();
</span><span class="cx"> benchmarkController.suites = suitesManager.updateLocalStorageFromUI();
</span><span class="cx"> this._startBenchmark(benchmarkController.suites, benchmarkController.options, "running-test");
</span></span></pre></div>
<a id="trunkPerformanceTestsAnimometerresourcesrunneranimometerjs"></a>
<div class="modfile"><h4>Modified: trunk/PerformanceTests/Animometer/resources/runner/animometer.js (202317 => 202318)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/PerformanceTests/Animometer/resources/runner/animometer.js 2016-06-22 03:26:24 UTC (rev 202317)
+++ trunk/PerformanceTests/Animometer/resources/runner/animometer.js 2016-06-22 03:26:57 UTC (rev 202318)
</span><span class="lines">@@ -436,7 +436,6 @@
</span><span class="cx"> window.benchmarkController = {
</span><span class="cx"> initialize: function()
</span><span class="cx"> {
</span><del>- benchmarkController.determineCanvasSize();
</del><span class="cx"> benchmarkController.addOrientationListenerIfNecessary();
</span><span class="cx"> },
</span><span class="cx">
</span><span class="lines">@@ -488,6 +487,8 @@
</span><span class="cx">
</span><span class="cx"> _startBenchmark: function(suites, options, frameContainerID)
</span><span class="cx"> {
</span><ins>+ benchmarkController.determineCanvasSize();
+
</ins><span class="cx"> var configuration = document.body.className.match(/small|medium|large/);
</span><span class="cx"> if (configuration)
</span><span class="cx"> options[Strings.json.configuration] = configuration[0];
</span></span></pre></div>
<a id="trunkPerformanceTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/PerformanceTests/ChangeLog (202317 => 202318)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/PerformanceTests/ChangeLog 2016-06-22 03:26:24 UTC (rev 202317)
+++ trunk/PerformanceTests/ChangeLog 2016-06-22 03:26:57 UTC (rev 202318)
</span><span class="lines">@@ -1,5 +1,19 @@
</span><span class="cx"> 2016-06-21 Jon Lee <jonlee@apple.com>
</span><span class="cx">
</span><ins>+ Update canvas size when benchmark begins
+ https://bugs.webkit.org/show_bug.cgi?id=159010
+
+ Reviewed by Dean Jackson.
+
+ Previously we would evaluate the media queries and assign the canvas size to the test
+ on body.onload. Instead, do it once the user starts the benchmark.
+
+ * Animometer/resources/debug-runner/animometer.js: Move benchmarkController.determineCanvasSize()
+ to benchmarkController._startBenchmark.
+ * Animometer/resources/runner/animometer.js: Ditto.
+
+2016-06-21 Jon Lee <jonlee@apple.com>
+
</ins><span class="cx"> Add new timestamp option
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=159006
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>