<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[202283] trunk/Tools</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/202283">202283</a></dd>
<dt>Author</dt> <dd>aakash_jain@apple.com</dd>
<dt>Date</dt> <dd>2016-06-21 11:26:53 -0700 (Tue, 21 Jun 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>run-javascriptcore-tests should have flag to skip mozilla tests
https://bugs.webkit.org/show_bug.cgi?id=158963
rdar://problem/25838924
Reviewed by Alexey Proskuryakov.
* Scripts/run-javascriptcore-tests:
(runJSCStressTests): Added flag to skip mozilla tests.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
<li><a href="#trunkToolsScriptsrunjavascriptcoretests">trunk/Tools/Scripts/run-javascriptcore-tests</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (202282 => 202283)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog 2016-06-21 18:15:48 UTC (rev 202282)
+++ trunk/Tools/ChangeLog 2016-06-21 18:26:53 UTC (rev 202283)
</span><span class="lines">@@ -1,3 +1,14 @@
</span><ins>+2016-06-21 Aakash Jain <aakash_jain@apple.com>
+
+ run-javascriptcore-tests should have flag to skip mozilla tests
+ https://bugs.webkit.org/show_bug.cgi?id=158963
+ rdar://problem/25838924
+
+ Reviewed by Alexey Proskuryakov.
+
+ * Scripts/run-javascriptcore-tests:
+ (runJSCStressTests): Added flag to skip mozilla tests.
+
</ins><span class="cx"> 2016-06-20 Commit Queue <commit-queue@webkit.org>
</span><span class="cx">
</span><span class="cx"> Unreviewed, rolling out r202136.
</span></span></pre></div>
<a id="trunkToolsScriptsrunjavascriptcoretests"></a>
<div class="modfile"><h4>Modified: trunk/Tools/Scripts/run-javascriptcore-tests (202282 => 202283)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/Scripts/run-javascriptcore-tests 2016-06-21 18:15:48 UTC (rev 202282)
+++ trunk/Tools/Scripts/run-javascriptcore-tests 2016-06-21 18:26:53 UTC (rev 202283)
</span><span class="lines">@@ -59,6 +59,7 @@
</span><span class="cx">
</span><span class="cx"> my $runJSCStress = 1;
</span><span class="cx"> my $runJITStressTests = 1;
</span><ins>+my $runMozillaTests = 1;
</ins><span class="cx"> my $runQuickMode = 0;
</span><span class="cx"> my $envVars = "";
</span><span class="cx"> my $gmallocPath = undef;
</span><span class="lines">@@ -77,6 +78,7 @@
</span><span class="cx"> my $testapiDefault = $runTestAPI ? "will run" : "will not run";
</span><span class="cx"> my $jscStressDefault = $runJSCStress ? "will run" : " will not run";
</span><span class="cx"> my $jitStressTestsDefault = $runJITStressTests ? "will run" : " will not run";
</span><ins>+my $mozillaTestsDefault = $runMozillaTests ? "will run" : " will not run";
</ins><span class="cx"> my $quickModeDefault = $runQuickMode ? "some" : "all";
</span><span class="cx"> my $failFastDefault = $failFast ? "fail fast" : "don't fail fast";
</span><span class="cx"> my $filter;
</span><span class="lines">@@ -89,6 +91,7 @@
</span><span class="cx"> --[no-]testapi Run (or don't run) testapi (default: $testapiDefault)
</span><span class="cx"> --[no-]jsc-stress Run (or don't run) the JSC stress tests (default: $jscStressDefault)
</span><span class="cx"> --[no-]jit-stress-tests Run (or don't run) the JIT stress tests (default: $jitStressTestsDefault)
</span><ins>+ --[no-]mozilla-tests Run (or don't run) the Mozilla tests (default: $mozillaTestsDefault)
</ins><span class="cx"> --[no-]quick Run some (or all) of the regular testing modes (default: $quickModeDefault)
</span><span class="cx"> If the runner only runs some it will run the default and no-cjit-validate modes.
</span><span class="cx"> Note, this will not change the behavior of tests that specify their own modes.
</span><span class="lines">@@ -119,6 +122,7 @@
</span><span class="cx"> 'testapi!' => \$runTestAPI,
</span><span class="cx"> 'jsc-stress!' => \$runJSCStress,
</span><span class="cx"> 'jit-stress-tests!' => \$runJITStressTests,
</span><ins>+ 'mozilla-tests!' => \$runMozillaTests,
</ins><span class="cx"> 'quick!' => \$runQuickMode,
</span><span class="cx"> 'fail-fast!' => \$failFast,
</span><span class="cx"> 'json-output=s' => \$jsonFileName,
</span><span class="lines">@@ -240,7 +244,6 @@
</span><span class="cx"> "PerformanceTests/SunSpider/no-architecture-specific-optimizations.yaml",
</span><span class="cx"> "PerformanceTests/SunSpider/shadow-chicken.yaml",
</span><span class="cx"> "PerformanceTests/SunSpider/tests/v8-v6",
</span><del>- "Source/JavaScriptCore/tests/mozilla/mozilla-tests.yaml",
</del><span class="cx"> "Source/JavaScriptCore/tests/stress",
</span><span class="cx"> "LayoutTests/js/regress/script-tests",
</span><span class="cx"> "PerformanceTests/SunSpider/profiler-test.yaml",
</span><span class="lines">@@ -249,10 +252,11 @@
</span><span class="cx"> "Source/JavaScriptCore/tests/controlFlowProfiler.yaml",
</span><span class="cx"> "Source/JavaScriptCore/tests/es6.yaml",
</span><span class="cx"> "Source/JavaScriptCore/tests/modules.yaml");
</span><del>- } else {
- @testList = ("Source/JavaScriptCore/tests/mozilla/mozilla-tests.yaml");
</del><span class="cx"> }
</span><span class="cx">
</span><ins>+ if ($runMozillaTests) {
+ push(@testList, "Source/JavaScriptCore/tests/mozilla/mozilla-tests.yaml");
+ }
</ins><span class="cx">
</span><span class="cx"> # Set LANG environment variable so the stress tests will work with newer ruby (<rdar://problem/15010705>)
</span><span class="cx"> $ENV{LANG}="en_US.UTF-8";
</span></span></pre>
</div>
</div>
</body>
</html>