<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[202313] trunk/Source/WebCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/202313">202313</a></dd>
<dt>Author</dt> <dd>cdumez@apple.com</dd>
<dt>Date</dt> <dd>2016-06-21 20:06:36 -0700 (Tue, 21 Jun 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Pass ScriptExecutionContext::Task as rvalue reference
https://bugs.webkit.org/show_bug.cgi?id=159007
Reviewed by Anders Carlsson.
Pass ScriptExecutionContext::Task as rvalue reference since its non-copyable
and has to be moved in.
* workers/WorkerLoaderProxy.h:
* workers/WorkerMessagingProxy.cpp:
(WebCore::WorkerMessagingProxy::postTaskToLoader):
(WebCore::WorkerMessagingProxy::postTaskForModeToWorkerGlobalScope):
* workers/WorkerMessagingProxy.h:
* workers/WorkerRunLoop.cpp:
(WebCore::WorkerRunLoop::postTask):
(WebCore::WorkerRunLoop::postTaskAndTerminate):
(WebCore::WorkerRunLoop::postTaskForMode):
(WebCore::WorkerRunLoop::Task::Task):
* workers/WorkerRunLoop.h:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreworkersWorkerLoaderProxyh">trunk/Source/WebCore/workers/WorkerLoaderProxy.h</a></li>
<li><a href="#trunkSourceWebCoreworkersWorkerMessagingProxycpp">trunk/Source/WebCore/workers/WorkerMessagingProxy.cpp</a></li>
<li><a href="#trunkSourceWebCoreworkersWorkerMessagingProxyh">trunk/Source/WebCore/workers/WorkerMessagingProxy.h</a></li>
<li><a href="#trunkSourceWebCoreworkersWorkerRunLoopcpp">trunk/Source/WebCore/workers/WorkerRunLoop.cpp</a></li>
<li><a href="#trunkSourceWebCoreworkersWorkerRunLooph">trunk/Source/WebCore/workers/WorkerRunLoop.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (202312 => 202313)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-06-22 02:52:46 UTC (rev 202312)
+++ trunk/Source/WebCore/ChangeLog 2016-06-22 03:06:36 UTC (rev 202313)
</span><span class="lines">@@ -1,3 +1,25 @@
</span><ins>+2016-06-21 Chris Dumez <cdumez@apple.com>
+
+ Pass ScriptExecutionContext::Task as rvalue reference
+ https://bugs.webkit.org/show_bug.cgi?id=159007
+
+ Reviewed by Anders Carlsson.
+
+ Pass ScriptExecutionContext::Task as rvalue reference since its non-copyable
+ and has to be moved in.
+
+ * workers/WorkerLoaderProxy.h:
+ * workers/WorkerMessagingProxy.cpp:
+ (WebCore::WorkerMessagingProxy::postTaskToLoader):
+ (WebCore::WorkerMessagingProxy::postTaskForModeToWorkerGlobalScope):
+ * workers/WorkerMessagingProxy.h:
+ * workers/WorkerRunLoop.cpp:
+ (WebCore::WorkerRunLoop::postTask):
+ (WebCore::WorkerRunLoop::postTaskAndTerminate):
+ (WebCore::WorkerRunLoop::postTaskForMode):
+ (WebCore::WorkerRunLoop::Task::Task):
+ * workers/WorkerRunLoop.h:
+
</ins><span class="cx"> 2016-06-21 Anders Carlsson <andersca@apple.com>
</span><span class="cx">
</span><span class="cx"> Include IdentifierInlines.h.
</span></span></pre></div>
<a id="trunkSourceWebCoreworkersWorkerLoaderProxyh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/workers/WorkerLoaderProxy.h (202312 => 202313)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/workers/WorkerLoaderProxy.h 2016-06-22 02:52:46 UTC (rev 202312)
+++ trunk/Source/WebCore/workers/WorkerLoaderProxy.h 2016-06-22 03:06:36 UTC (rev 202313)
</span><span class="lines">@@ -46,12 +46,12 @@
</span><span class="cx"> virtual ~WorkerLoaderProxy() { }
</span><span class="cx">
</span><span class="cx"> // Posts a task to the thread which runs the loading code (normally, the main thread).
</span><del>- virtual void postTaskToLoader(ScriptExecutionContext::Task) = 0;
</del><ins>+ virtual void postTaskToLoader(ScriptExecutionContext::Task&&) = 0;
</ins><span class="cx">
</span><span class="cx"> // Posts callbacks from loading code to the WorkerGlobalScope. The 'mode' is used to differentiate
</span><span class="cx"> // specific synchronous loading requests so they can be 'nested', per spec.
</span><span class="cx"> // Returns true if the task was posted successfully.
</span><del>- virtual bool postTaskForModeToWorkerGlobalScope(ScriptExecutionContext::Task, const String& mode) = 0;
</del><ins>+ virtual bool postTaskForModeToWorkerGlobalScope(ScriptExecutionContext::Task&&, const String& mode) = 0;
</ins><span class="cx"> };
</span><span class="cx">
</span><span class="cx"> } // namespace WebCore
</span></span></pre></div>
<a id="trunkSourceWebCoreworkersWorkerMessagingProxycpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/workers/WorkerMessagingProxy.cpp (202312 => 202313)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/workers/WorkerMessagingProxy.cpp 2016-06-22 02:52:46 UTC (rev 202312)
+++ trunk/Source/WebCore/workers/WorkerMessagingProxy.cpp 2016-06-22 03:06:36 UTC (rev 202313)
</span><span class="lines">@@ -120,7 +120,7 @@
</span><span class="cx"> m_queuedEarlyTasks.append(std::make_unique<ScriptExecutionContext::Task>(WTFMove(task)));
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void WorkerMessagingProxy::postTaskToLoader(ScriptExecutionContext::Task task)
</del><ins>+void WorkerMessagingProxy::postTaskToLoader(ScriptExecutionContext::Task&& task)
</ins><span class="cx"> {
</span><span class="cx"> // FIXME: In case of nested workers, this should go directly to the root Document context.
</span><span class="cx"> ASSERT(m_scriptExecutionContext->isDocument());
</span><span class="lines">@@ -127,7 +127,7 @@
</span><span class="cx"> m_scriptExecutionContext->postTask(WTFMove(task));
</span><span class="cx"> }
</span><span class="cx">
</span><del>-bool WorkerMessagingProxy::postTaskForModeToWorkerGlobalScope(ScriptExecutionContext::Task task, const String& mode)
</del><ins>+bool WorkerMessagingProxy::postTaskForModeToWorkerGlobalScope(ScriptExecutionContext::Task&& task, const String& mode)
</ins><span class="cx"> {
</span><span class="cx"> if (m_askedToTerminate)
</span><span class="cx"> return false;
</span></span></pre></div>
<a id="trunkSourceWebCoreworkersWorkerMessagingProxyh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/workers/WorkerMessagingProxy.h (202312 => 202313)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/workers/WorkerMessagingProxy.h 2016-06-22 02:52:46 UTC (rev 202312)
+++ trunk/Source/WebCore/workers/WorkerMessagingProxy.h 2016-06-22 03:06:36 UTC (rev 202313)
</span><span class="lines">@@ -72,8 +72,8 @@
</span><span class="cx"> // Implementation of WorkerLoaderProxy.
</span><span class="cx"> // These methods are called on different threads to schedule loading
</span><span class="cx"> // requests and to send callbacks back to WorkerGlobalScope.
</span><del>- void postTaskToLoader(ScriptExecutionContext::Task) override;
- bool postTaskForModeToWorkerGlobalScope(ScriptExecutionContext::Task, const String& mode) override;
</del><ins>+ void postTaskToLoader(ScriptExecutionContext::Task&&) override;
+ bool postTaskForModeToWorkerGlobalScope(ScriptExecutionContext::Task&&, const String& mode) override;
</ins><span class="cx">
</span><span class="cx"> void workerThreadCreated(PassRefPtr<DedicatedWorkerThread>);
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreworkersWorkerRunLoopcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/workers/WorkerRunLoop.cpp (202312 => 202313)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/workers/WorkerRunLoop.cpp 2016-06-22 02:52:46 UTC (rev 202312)
+++ trunk/Source/WebCore/workers/WorkerRunLoop.cpp 2016-06-22 03:06:36 UTC (rev 202313)
</span><span class="lines">@@ -212,17 +212,17 @@
</span><span class="cx"> m_messageQueue.kill();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void WorkerRunLoop::postTask(ScriptExecutionContext::Task task)
</del><ins>+void WorkerRunLoop::postTask(ScriptExecutionContext::Task&& task)
</ins><span class="cx"> {
</span><span class="cx"> postTaskForMode(WTFMove(task), defaultMode());
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void WorkerRunLoop::postTaskAndTerminate(ScriptExecutionContext::Task task)
</del><ins>+void WorkerRunLoop::postTaskAndTerminate(ScriptExecutionContext::Task&& task)
</ins><span class="cx"> {
</span><span class="cx"> m_messageQueue.appendAndKill(std::make_unique<Task>(WTFMove(task), defaultMode()));
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void WorkerRunLoop::postTaskForMode(ScriptExecutionContext::Task task, const String& mode)
</del><ins>+void WorkerRunLoop::postTaskForMode(ScriptExecutionContext::Task&& task, const String& mode)
</ins><span class="cx"> {
</span><span class="cx"> m_messageQueue.append(std::make_unique<Task>(WTFMove(task), mode));
</span><span class="cx"> }
</span><span class="lines">@@ -233,7 +233,7 @@
</span><span class="cx"> m_task.performTask(*context);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-WorkerRunLoop::Task::Task(ScriptExecutionContext::Task task, const String& mode)
</del><ins>+WorkerRunLoop::Task::Task(ScriptExecutionContext::Task&& task, const String& mode)
</ins><span class="cx"> : m_task(WTFMove(task))
</span><span class="cx"> , m_mode(mode.isolatedCopy())
</span><span class="cx"> {
</span></span></pre></div>
<a id="trunkSourceWebCoreworkersWorkerRunLooph"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/workers/WorkerRunLoop.h (202312 => 202313)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/workers/WorkerRunLoop.h 2016-06-22 02:52:46 UTC (rev 202312)
+++ trunk/Source/WebCore/workers/WorkerRunLoop.h 2016-06-22 03:06:36 UTC (rev 202313)
</span><span class="lines">@@ -57,9 +57,9 @@
</span><span class="cx"> void terminate();
</span><span class="cx"> bool terminated() const { return m_messageQueue.killed(); }
</span><span class="cx">
</span><del>- void postTask(ScriptExecutionContext::Task);
- void postTaskAndTerminate(ScriptExecutionContext::Task);
- void postTaskForMode(ScriptExecutionContext::Task, const String& mode);
</del><ins>+ void postTask(ScriptExecutionContext::Task&&);
+ void postTaskAndTerminate(ScriptExecutionContext::Task&&);
+ void postTaskForMode(ScriptExecutionContext::Task&&, const String& mode);
</ins><span class="cx">
</span><span class="cx"> unsigned long createUniqueId() { return ++m_uniqueId; }
</span><span class="cx">
</span><span class="lines">@@ -68,7 +68,7 @@
</span><span class="cx"> class Task {
</span><span class="cx"> WTF_MAKE_NONCOPYABLE(Task); WTF_MAKE_FAST_ALLOCATED;
</span><span class="cx"> public:
</span><del>- Task(ScriptExecutionContext::Task, const String& mode);
</del><ins>+ Task(ScriptExecutionContext::Task&&, const String& mode);
</ins><span class="cx"> const String& mode() const { return m_mode; }
</span><span class="cx"> void performTask(const WorkerRunLoop&, WorkerGlobalScope*);
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>