<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[202164] trunk/LayoutTests</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/202164">202164</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2016-06-17 04:46:14 -0700 (Fri, 17 Jun 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Update test-expected file for failing fullscreen test
https://bugs.webkit.org/show_bug.cgi?id=158838
Patch by Romain Bellessort <romain.bellessort@crf.canon.fr> on 2016-06-17
Reviewed by Carlos Garcia Campos.
Used MAC version of the test as the default version since only MAC and
GTK do not skip this test and expect the same result. Removed
test-expected files specific to each port when there was one. Prior to
this patch, GTK test was failing unexpectedly.
* fullscreen/video-controls-override-expected.txt:
* platform/efl/fullscreen/video-controls-override-expected.txt: Removed.
* platform/gtk/fullscreen/video-controls-override-expected.txt: Removed.
* platform/mac/fullscreen/video-controls-override-expected.txt: Removed.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsfullscreenvideocontrolsoverrideexpectedtxt">trunk/LayoutTests/fullscreen/video-controls-override-expected.txt</a></li>
</ul>
<h3>Removed Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsplatformeflfullscreenvideocontrolsoverrideexpectedtxt">trunk/LayoutTests/platform/efl/fullscreen/video-controls-override-expected.txt</a></li>
<li><a href="#trunkLayoutTestsplatformgtkfullscreenvideocontrolsoverrideexpectedtxt">trunk/LayoutTests/platform/gtk/fullscreen/video-controls-override-expected.txt</a></li>
<li><a href="#trunkLayoutTestsplatformmacfullscreenvideocontrolsoverrideexpectedtxt">trunk/LayoutTests/platform/mac/fullscreen/video-controls-override-expected.txt</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (202163 => 202164)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2016-06-17 11:19:32 UTC (rev 202163)
+++ trunk/LayoutTests/ChangeLog 2016-06-17 11:46:14 UTC (rev 202164)
</span><span class="lines">@@ -1,3 +1,20 @@
</span><ins>+2016-06-17 Romain Bellessort <romain.bellessort@crf.canon.fr>
+
+ Update test-expected file for failing fullscreen test
+ https://bugs.webkit.org/show_bug.cgi?id=158838
+
+ Reviewed by Carlos Garcia Campos.
+
+ Used MAC version of the test as the default version since only MAC and
+ GTK do not skip this test and expect the same result. Removed
+ test-expected files specific to each port when there was one. Prior to
+ this patch, GTK test was failing unexpectedly.
+
+ * fullscreen/video-controls-override-expected.txt:
+ * platform/efl/fullscreen/video-controls-override-expected.txt: Removed.
+ * platform/gtk/fullscreen/video-controls-override-expected.txt: Removed.
+ * platform/mac/fullscreen/video-controls-override-expected.txt: Removed.
+
</ins><span class="cx"> 2016-06-17 Youenn Fablet <youenn.fablet@crf.canon.fr>
</span><span class="cx">
</span><span class="cx"> CORS preflight with a non-200 response should be a preflight failure
</span></span></pre></div>
<a id="trunkLayoutTestsfullscreenvideocontrolsoverrideexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fullscreen/video-controls-override-expected.txt (202163 => 202164)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fullscreen/video-controls-override-expected.txt 2016-06-17 11:19:32 UTC (rev 202163)
+++ trunk/LayoutTests/fullscreen/video-controls-override-expected.txt 2016-06-17 11:46:14 UTC (rev 202164)
</span><span class="lines">@@ -6,8 +6,8 @@
</span><span class="cx"> EXPECTED (panel = mediaControlsElement(shadowRoot.firstChild, '-webkit-media-controls-panel') != 'null') OK
</span><span class="cx"> EXPECTED (internals.shadowPseudoId(panel) == '-webkit-media-controls-panel') OK
</span><span class="cx"> EXPECTED (document.defaultView.getComputedStyle(panel)['display'] != 'none') OK
</span><del>-EXPECTED (document.defaultView.getComputedStyle(panel)['height'] >= '20px') OK
</del><ins>+EXPECTED (parseInt(document.defaultView.getComputedStyle(panel)['height']) >= '20') OK
</ins><span class="cx"> EVENT(webkitfullscreenchange)
</span><del>-EXPECTED (document.defaultView.getComputedStyle(panel)['display'] == 'none') OK
</del><ins>+EXPECTED (document.defaultView.getComputedStyle(panel)['display'] == 'none'), OBSERVED '' FAIL
</ins><span class="cx"> END OF TEST
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsplatformeflfullscreenvideocontrolsoverrideexpectedtxt"></a>
<div class="delfile"><h4>Deleted: trunk/LayoutTests/platform/efl/fullscreen/video-controls-override-expected.txt (202163 => 202164)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/efl/fullscreen/video-controls-override-expected.txt 2016-06-17 11:19:32 UTC (rev 202163)
+++ trunk/LayoutTests/platform/efl/fullscreen/video-controls-override-expected.txt 2016-06-17 11:46:14 UTC (rev 202164)
</span><span class="lines">@@ -1,13 +0,0 @@
</span><del>-This tests that the video element's "controls" attribute is overridden in full screen mode, and that the controls are correctly hidden upon exiting full screen. Press any key to continue.
-
-
-EVENT(webkitfullscreenchange)
-EXPECTED (shadowRoot = internals.shadowRoot(video) != 'null') OK
-EXPECTED (panel = mediaControlsElement(shadowRoot.firstChild, '-webkit-media-controls-panel') != 'null') OK
-EXPECTED (internals.shadowPseudoId(panel) == '-webkit-media-controls-panel') OK
-EXPECTED (document.defaultView.getComputedStyle(panel)['display'] != 'none') OK
-EXPECTED (document.defaultView.getComputedStyle(panel)['height'] >= '20px') OK
-EVENT(webkitfullscreenchange)
-EXPECTED (document.defaultView.getComputedStyle(panel)['display'] == 'none'), OBSERVED '' FAIL
-END OF TEST
-
</del></span></pre></div>
<a id="trunkLayoutTestsplatformgtkfullscreenvideocontrolsoverrideexpectedtxt"></a>
<div class="delfile"><h4>Deleted: trunk/LayoutTests/platform/gtk/fullscreen/video-controls-override-expected.txt (202163 => 202164)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/gtk/fullscreen/video-controls-override-expected.txt 2016-06-17 11:19:32 UTC (rev 202163)
+++ trunk/LayoutTests/platform/gtk/fullscreen/video-controls-override-expected.txt 2016-06-17 11:46:14 UTC (rev 202164)
</span><span class="lines">@@ -1,13 +0,0 @@
</span><del>-This tests that the video element's "controls" attribute is overridden in full screen mode, and that the controls are correctly hidden upon exiting full screen. Press any key to continue.
-
-
-EVENT(webkitfullscreenchange)
-EXPECTED (shadowRoot = internals.shadowRoot(video) != 'null') OK
-EXPECTED (panel = mediaControlsElement(shadowRoot.firstChild, '-webkit-media-controls-panel') != 'null') OK
-EXPECTED (internals.shadowPseudoId(panel) == '-webkit-media-controls-panel') OK
-EXPECTED (document.defaultView.getComputedStyle(panel)['display'] != 'none') OK
-EXPECTED (document.defaultView.getComputedStyle(panel)['height'] >= '20px') OK
-EVENT(webkitfullscreenchange)
-EXPECTED (document.defaultView.getComputedStyle(panel)['display'] == 'none'), OBSERVED '' FAIL
-END OF TEST
-
</del></span></pre></div>
<a id="trunkLayoutTestsplatformmacfullscreenvideocontrolsoverrideexpectedtxt"></a>
<div class="delfile"><h4>Deleted: trunk/LayoutTests/platform/mac/fullscreen/video-controls-override-expected.txt (202163 => 202164)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/mac/fullscreen/video-controls-override-expected.txt 2016-06-17 11:19:32 UTC (rev 202163)
+++ trunk/LayoutTests/platform/mac/fullscreen/video-controls-override-expected.txt 2016-06-17 11:46:14 UTC (rev 202164)
</span><span class="lines">@@ -1,13 +0,0 @@
</span><del>-This tests that the video element's "controls" attribute is overridden in full screen mode, and that the controls are correctly hidden upon exiting full screen. Press any key to continue.
-
-
-EVENT(webkitfullscreenchange)
-EXPECTED (shadowRoot = internals.shadowRoot(video) != 'null') OK
-EXPECTED (panel = mediaControlsElement(shadowRoot.firstChild, '-webkit-media-controls-panel') != 'null') OK
-EXPECTED (internals.shadowPseudoId(panel) == '-webkit-media-controls-panel') OK
-EXPECTED (document.defaultView.getComputedStyle(panel)['display'] != 'none') OK
-EXPECTED (parseInt(document.defaultView.getComputedStyle(panel)['height']) >= '20') OK
-EVENT(webkitfullscreenchange)
-EXPECTED (document.defaultView.getComputedStyle(panel)['display'] == 'none'), OBSERVED '' FAIL
-END OF TEST
-
</del></span></pre>
</div>
</div>
</body>
</html>