<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[201876] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/201876">201876</a></dd>
<dt>Author</dt> <dd>cdumez@apple.com</dd>
<dt>Date</dt> <dd>2016-06-09 11:47:21 -0700 (Thu, 09 Jun 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>WorkerGlobalScope attributes / operations should be on the prototype
https://bugs.webkit.org/show_bug.cgi?id=158568
<rdar://problem/26720079>
Reviewed by Geoffrey Garen.
Source/WebCore:
WorkerGlobalScope attributes / operations should be on the prototype
because WorkerGlobalScope is not marked as [Global] / [PrimaryGlobal]:
- https://html.spec.whatwg.org/multipage/workers.html#the-workerglobalscope-common-interface
- http://heycam.github.io/webidl/#es-attributes
- http://heycam.github.io/webidl/#es-operations
DedicatedWorkerGlobalScope is the interface that is marked as [Global]
and whose attributes / operations should be on the instance.
This brings the number of failures on http://w3c-test.org/workers/interfaces.worker
from 65 to 34. It also aligns our behavior with Firefox and Chrome.
Test: fast/workers/WorkerGlobalScope-properties-prototype.html
* bindings/scripts/CodeGeneratorJS.pm:
(InterfaceRequiresAttributesOnInstance):
(OperationShouldBeOnInstance):
LayoutTests:
* fast/workers/WorkerGlobalScope-properties-prototype-expected.txt: Added.
* fast/workers/WorkerGlobalScope-properties-prototype.html: Added.
Add layout test coverage.
* fast/workers/self-hasOwnProperty-expected.txt:
* fast/workers/self-hasOwnProperty.html:
Update test I added a couple of days ago because it wrongly expected
the 'navigator' property to be on the instance. This check was failing
in other browsers (Firefox and Chrome).</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsfastworkersselfhasOwnPropertyexpectedtxt">trunk/LayoutTests/fast/workers/self-hasOwnProperty-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastworkersselfhasOwnPropertyhtml">trunk/LayoutTests/fast/workers/self-hasOwnProperty.html</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorebindingsscriptsCodeGeneratorJSpm">trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsfastworkersWorkerGlobalScopepropertiesprototypeexpectedtxt">trunk/LayoutTests/fast/workers/WorkerGlobalScope-properties-prototype-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastworkersWorkerGlobalScopepropertiesprototypehtml">trunk/LayoutTests/fast/workers/WorkerGlobalScope-properties-prototype.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (201875 => 201876)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog        2016-06-09 18:33:02 UTC (rev 201875)
+++ trunk/LayoutTests/ChangeLog        2016-06-09 18:47:21 UTC (rev 201876)
</span><span class="lines">@@ -1,3 +1,21 @@
</span><ins>+2016-06-09 Chris Dumez <cdumez@apple.com>
+
+ WorkerGlobalScope attributes / operations should be on the prototype
+ https://bugs.webkit.org/show_bug.cgi?id=158568
+ <rdar://problem/26720079>
+
+ Reviewed by Geoffrey Garen.
+
+ * fast/workers/WorkerGlobalScope-properties-prototype-expected.txt: Added.
+ * fast/workers/WorkerGlobalScope-properties-prototype.html: Added.
+ Add layout test coverage.
+
+ * fast/workers/self-hasOwnProperty-expected.txt:
+ * fast/workers/self-hasOwnProperty.html:
+ Update test I added a couple of days ago because it wrongly expected
+ the 'navigator' property to be on the instance. This check was failing
+ in other browsers (Firefox and Chrome).
+
</ins><span class="cx"> 2016-06-09 Tim Horton <timothy_horton@apple.com>
</span><span class="cx">
</span><span class="cx"> Writing-mode-dependent properties don't apply if their value is a variable
</span></span></pre></div>
<a id="trunkLayoutTestsfastworkersWorkerGlobalScopepropertiesprototypeexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/workers/WorkerGlobalScope-properties-prototype-expected.txt (0 => 201876)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/workers/WorkerGlobalScope-properties-prototype-expected.txt         (rev 0)
+++ trunk/LayoutTests/fast/workers/WorkerGlobalScope-properties-prototype-expected.txt        2016-06-09 18:47:21 UTC (rev 201876)
</span><span class="lines">@@ -0,0 +1,20 @@
</span><ins>+Tests that WorkerGlobalScope's properties are on the prototype.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+self.__proto__.__proto__ === WorkerGlobalScope.prototype: true
+self.__proto__.__proto__.hasOwnProperty('navigator') === true: true
+self.__proto__.__proto__.hasOwnProperty('self') === true: true
+self.__proto__.__proto__.hasOwnProperty('location') === true: true
+self.__proto__.__proto__.hasOwnProperty('close') === true: true
+self.__proto__.__proto__.hasOwnProperty('importScripts') === true: true
+self.hasOwnProperty('navigator') === false: true
+self.hasOwnProperty('location') === false: true
+self.hasOwnProperty('close') === false: true
+self.hasOwnProperty('postMessage') === true: true
+self.hasOwnProperty('onmessage') === true: true
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
</ins></span></pre></div>
<a id="trunkLayoutTestsfastworkersWorkerGlobalScopepropertiesprototypehtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/workers/WorkerGlobalScope-properties-prototype.html (0 => 201876)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/workers/WorkerGlobalScope-properties-prototype.html         (rev 0)
+++ trunk/LayoutTests/fast/workers/WorkerGlobalScope-properties-prototype.html        2016-06-09 18:47:21 UTC (rev 201876)
</span><span class="lines">@@ -0,0 +1,34 @@
</span><ins>+<!DOCTYPE html>
+<script src="../../resources/js-test-pre.js"></script>
+<script src="resources/worker-create-common.js"></script>
+<script>
+
+var jsTestIsAsync = true;
+
+description("Tests that WorkerGlobalScope's properties are on the prototype.");
+
+var worker = createWorker();
+worker.postMessage("eval self.__proto__.__proto__ === WorkerGlobalScope.prototype");
+worker.postMessage("eval self.__proto__.__proto__.hasOwnProperty('navigator') === true");
+worker.postMessage("eval self.__proto__.__proto__.hasOwnProperty('self') === true");
+worker.postMessage("eval self.__proto__.__proto__.hasOwnProperty('location') === true");
+worker.postMessage("eval self.__proto__.__proto__.hasOwnProperty('close') === true");
+worker.postMessage("eval self.__proto__.__proto__.hasOwnProperty('importScripts') === true");
+worker.postMessage("eval self.hasOwnProperty('navigator') === false");
+worker.postMessage("eval self.hasOwnProperty('location') === false");
+worker.postMessage("eval self.hasOwnProperty('close') === false");
+
+// DedicatedWorkerGlobalScope properties should be on the instance.
+worker.postMessage("eval self.hasOwnProperty('postMessage') === true");
+worker.postMessage("eval self.hasOwnProperty('onmessage') === true");
+worker.postMessage("eval DONE");
+
+worker.onmessage = function(evt) {
+ if (!/DONE/.test(evt.data))
+ debug(evt.data.replace(new RegExp("/.*LayoutTests"), "<...>"));
+ else
+ finishJSTest();
+};
+
+</script>
+<script src="../../resources/js-test-post.js"></script>
</ins></span></pre></div>
<a id="trunkLayoutTestsfastworkersselfhasOwnPropertyexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/workers/self-hasOwnProperty-expected.txt (201875 => 201876)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/workers/self-hasOwnProperty-expected.txt        2016-06-09 18:33:02 UTC (rev 201875)
+++ trunk/LayoutTests/fast/workers/self-hasOwnProperty-expected.txt        2016-06-09 18:47:21 UTC (rev 201876)
</span><span class="lines">@@ -5,7 +5,7 @@
</span><span class="cx">
</span><span class="cx"> self.hasOwnProperty('DedicatedWorkerGlobalScope'): true
</span><span class="cx"> self.hasOwnProperty('WorkerGlobalScope'): true
</span><del>-self.hasOwnProperty('navigator'): true
</del><ins>+self.hasOwnProperty('postMessage'): true
</ins><span class="cx"> PASS successfullyParsed is true
</span><span class="cx">
</span><span class="cx"> TEST COMPLETE
</span></span></pre></div>
<a id="trunkLayoutTestsfastworkersselfhasOwnPropertyhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/workers/self-hasOwnProperty.html (201875 => 201876)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/workers/self-hasOwnProperty.html        2016-06-09 18:33:02 UTC (rev 201875)
+++ trunk/LayoutTests/fast/workers/self-hasOwnProperty.html        2016-06-09 18:47:21 UTC (rev 201876)
</span><span class="lines">@@ -10,7 +10,7 @@
</span><span class="cx"> var worker = createWorker();
</span><span class="cx"> worker.postMessage("eval self.hasOwnProperty('DedicatedWorkerGlobalScope')");
</span><span class="cx"> worker.postMessage("eval self.hasOwnProperty('WorkerGlobalScope')");
</span><del>-worker.postMessage("eval self.hasOwnProperty('navigator')");
</del><ins>+worker.postMessage("eval self.hasOwnProperty('postMessage')");
</ins><span class="cx"> worker.postMessage("eval DONE");
</span><span class="cx">
</span><span class="cx"> worker.onmessage = function(evt) {
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (201875 => 201876)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog        2016-06-09 18:33:02 UTC (rev 201875)
+++ trunk/Source/WebCore/ChangeLog        2016-06-09 18:47:21 UTC (rev 201876)
</span><span class="lines">@@ -1,3 +1,29 @@
</span><ins>+2016-06-09 Chris Dumez <cdumez@apple.com>
+
+ WorkerGlobalScope attributes / operations should be on the prototype
+ https://bugs.webkit.org/show_bug.cgi?id=158568
+ <rdar://problem/26720079>
+
+ Reviewed by Geoffrey Garen.
+
+ WorkerGlobalScope attributes / operations should be on the prototype
+ because WorkerGlobalScope is not marked as [Global] / [PrimaryGlobal]:
+ - https://html.spec.whatwg.org/multipage/workers.html#the-workerglobalscope-common-interface
+ - http://heycam.github.io/webidl/#es-attributes
+ - http://heycam.github.io/webidl/#es-operations
+
+ DedicatedWorkerGlobalScope is the interface that is marked as [Global]
+ and whose attributes / operations should be on the instance.
+
+ This brings the number of failures on http://w3c-test.org/workers/interfaces.worker
+ from 65 to 34. It also aligns our behavior with Firefox and Chrome.
+
+ Test: fast/workers/WorkerGlobalScope-properties-prototype.html
+
+ * bindings/scripts/CodeGeneratorJS.pm:
+ (InterfaceRequiresAttributesOnInstance):
+ (OperationShouldBeOnInstance):
+
</ins><span class="cx"> 2016-06-09 Tim Horton <timothy_horton@apple.com>
</span><span class="cx">
</span><span class="cx"> Writing-mode-dependent properties don't apply if their value is a variable
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsscriptsCodeGeneratorJSpm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm (201875 => 201876)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm        2016-06-09 18:33:02 UTC (rev 201875)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm        2016-06-09 18:47:21 UTC (rev 201876)
</span><span class="lines">@@ -558,7 +558,8 @@
</span><span class="cx"> # FIXME: We should be able to drop this once <rdar://problem/24466097> is fixed.
</span><span class="cx"> return 1 if $interface->isException;
</span><span class="cx">
</span><del>- return 1 if IsDOMGlobalObject($interface);
</del><ins>+ # FIXME: Add support for [PrimaryGlobal] / [Global].
+ return 1 if IsDOMGlobalObject($interface) && $interface->name ne "WorkerGlobalScope";
</ins><span class="cx">
</span><span class="cx"> return 1 if InterfaceRequiresAttributesOnInstanceForCompatibility($interface);
</span><span class="cx">
</span><span class="lines">@@ -596,7 +597,8 @@
</span><span class="cx"> my $interface = shift;
</span><span class="cx"> my $function = shift;
</span><span class="cx">
</span><del>- return 1 if IsDOMGlobalObject($interface);
</del><ins>+ # FIXME: Add support for [PrimaryGlobal] / [Global].
+ return 1 if IsDOMGlobalObject($interface) && $interface->name ne "WorkerGlobalScope";
</ins><span class="cx">
</span><span class="cx"> # FIXME: The bindings generator does not support putting runtime-enabled operations on the instance yet (except for global objects).
</span><span class="cx"> return 0 if $function->signature->extendedAttributes->{"EnabledAtRuntime"};
</span></span></pre>
</div>
</div>
</body>
</html>