<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[201704] trunk/Source/WebCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/201704">201704</a></dd>
<dt>Author</dt> <dd>zalan@apple.com</dd>
<dt>Date</dt> <dd>2016-06-05 20:19:21 -0700 (Sun, 05 Jun 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Addressing post-review comments on <a href="http://trac.webkit.org/projects/webkit/changeset/201635">r201635</a>.
Reviewed by Chris Dumez.
* rendering/RenderInline.h:
(WebCore::RenderInline::computeRectForRepaint):
* rendering/RenderObject.h:
(WebCore::RenderObject::RepaintContext::RepaintContext):
(WebCore::RenderObject::computeRectForRepaint):
* rendering/RenderTableCell.h:
* rendering/RenderView.h:
* rendering/svg/RenderSVGForeignObject.h:
* rendering/svg/RenderSVGText.h:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderInlineh">trunk/Source/WebCore/rendering/RenderInline.h</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderObjecth">trunk/Source/WebCore/rendering/RenderObject.h</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderTableCellh">trunk/Source/WebCore/rendering/RenderTableCell.h</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderViewh">trunk/Source/WebCore/rendering/RenderView.h</a></li>
<li><a href="#trunkSourceWebCorerenderingsvgRenderSVGForeignObjecth">trunk/Source/WebCore/rendering/svg/RenderSVGForeignObject.h</a></li>
<li><a href="#trunkSourceWebCorerenderingsvgRenderSVGTexth">trunk/Source/WebCore/rendering/svg/RenderSVGText.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (201703 => 201704)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-06-06 01:56:11 UTC (rev 201703)
+++ trunk/Source/WebCore/ChangeLog 2016-06-06 03:19:21 UTC (rev 201704)
</span><span class="lines">@@ -1,3 +1,19 @@
</span><ins>+2016-06-05 Zalan Bujtas <zalan@apple.com>
+
+ Addressing post-review comments on r201635.
+
+ Reviewed by Chris Dumez.
+
+ * rendering/RenderInline.h:
+ (WebCore::RenderInline::computeRectForRepaint):
+ * rendering/RenderObject.h:
+ (WebCore::RenderObject::RepaintContext::RepaintContext):
+ (WebCore::RenderObject::computeRectForRepaint):
+ * rendering/RenderTableCell.h:
+ * rendering/RenderView.h:
+ * rendering/svg/RenderSVGForeignObject.h:
+ * rendering/svg/RenderSVGText.h:
+
</ins><span class="cx"> 2016-06-05 Yusuke Suzuki <utatane.tea@gmail.com>
</span><span class="cx">
</span><span class="cx"> Change ProxyObject.[[Get]] not to use custom accessor
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderInlineh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderInline.h (201703 => 201704)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderInline.h 2016-06-06 01:56:11 UTC (rev 201703)
+++ trunk/Source/WebCore/rendering/RenderInline.h 2016-06-06 03:19:21 UTC (rev 201704)
</span><span class="lines">@@ -145,7 +145,7 @@
</span><span class="cx">
</span><span class="cx"> LayoutRect clippedOverflowRectForRepaint(const RenderLayerModelObject* repaintContainer) const override;
</span><span class="cx"> LayoutRect rectWithOutlineForRepaint(const RenderLayerModelObject* repaintContainer, LayoutUnit outlineWidth) const final;
</span><del>- LayoutRect computeRectForRepaint(const LayoutRect&, const RenderLayerModelObject* repaintContainer, RepaintContext = { false, false }) const final;
</del><ins>+ LayoutRect computeRectForRepaint(const LayoutRect&, const RenderLayerModelObject* repaintContainer, RepaintContext = { }) const final;
</ins><span class="cx">
</span><span class="cx"> void mapLocalToContainer(const RenderLayerModelObject* repaintContainer, TransformState&, MapCoordinatesFlags, bool* wasFixed) const override;
</span><span class="cx"> const RenderObject* pushMappingToContainer(const RenderLayerModelObject* ancestorToStopAt, RenderGeometryMap&) const override;
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderObjecth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderObject.h (201703 => 201704)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderObject.h 2016-06-06 01:56:11 UTC (rev 201703)
+++ trunk/Source/WebCore/rendering/RenderObject.h 2016-06-06 03:19:21 UTC (rev 201704)
</span><span class="lines">@@ -747,15 +747,15 @@
</span><span class="cx"> // Given a rect in the object's coordinate space, compute a rect suitable for repainting
</span><span class="cx"> // that rect in the coordinate space of repaintContainer.
</span><span class="cx"> struct RepaintContext {
</span><del>- RepaintContext(bool hasPositionFixedDescendant, bool dirtyRectIsFlipped)
</del><ins>+ RepaintContext(bool hasPositionFixedDescendant = false, bool dirtyRectIsFlipped = false)
</ins><span class="cx"> : m_hasPositionFixedDescendant(hasPositionFixedDescendant)
</span><span class="cx"> , m_dirtyRectIsFlipped(dirtyRectIsFlipped)
</span><span class="cx"> {
</span><span class="cx"> }
</span><del>- bool m_hasPositionFixedDescendant { false };
- bool m_dirtyRectIsFlipped { false };
</del><ins>+ bool m_hasPositionFixedDescendant;
+ bool m_dirtyRectIsFlipped;
</ins><span class="cx"> };
</span><del>- virtual LayoutRect computeRectForRepaint(const LayoutRect&, const RenderLayerModelObject* repaintContainer, RepaintContext = { false, false }) const;
</del><ins>+ virtual LayoutRect computeRectForRepaint(const LayoutRect&, const RenderLayerModelObject* repaintContainer, RepaintContext = { }) const;
</ins><span class="cx"> virtual FloatRect computeFloatRectForRepaint(const FloatRect&, const RenderLayerModelObject* repaintContainer, bool fixed = false) const;
</span><span class="cx">
</span><span class="cx"> virtual unsigned int length() const { return 1; }
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderTableCellh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderTableCell.h (201703 => 201704)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderTableCell.h 2016-06-06 01:56:11 UTC (rev 201703)
+++ trunk/Source/WebCore/rendering/RenderTableCell.h 2016-06-06 03:19:21 UTC (rev 201704)
</span><span class="lines">@@ -153,7 +153,7 @@
</span><span class="cx"> bool boxShadowShouldBeAppliedToBackground(const LayoutPoint& paintOffset, BackgroundBleedAvoidance, InlineFlowBox*) const override;
</span><span class="cx">
</span><span class="cx"> LayoutSize offsetFromContainer(RenderElement&, const LayoutPoint&, bool* offsetDependsOnPoint = 0) const override;
</span><del>- LayoutRect computeRectForRepaint(const LayoutRect&, const RenderLayerModelObject* repaintContainer, RepaintContext = { false, false }) const override;
</del><ins>+ LayoutRect computeRectForRepaint(const LayoutRect&, const RenderLayerModelObject* repaintContainer, RepaintContext = { }) const override;
</ins><span class="cx">
</span><span class="cx"> LayoutUnit borderHalfLeft(bool outer) const;
</span><span class="cx"> LayoutUnit borderHalfRight(bool outer) const;
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderViewh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderView.h (201703 => 201704)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderView.h 2016-06-06 01:56:11 UTC (rev 201703)
+++ trunk/Source/WebCore/rendering/RenderView.h 2016-06-06 03:19:21 UTC (rev 201704)
</span><span class="lines">@@ -76,7 +76,7 @@
</span><span class="cx"> FrameView& frameView() const { return m_frameView; }
</span><span class="cx">
</span><span class="cx"> LayoutRect visualOverflowRect() const override;
</span><del>- LayoutRect computeRectForRepaint(const LayoutRect&, const RenderLayerModelObject* repaintContainer, RepaintContext = { false, false }) const override;
</del><ins>+ LayoutRect computeRectForRepaint(const LayoutRect&, const RenderLayerModelObject* repaintContainer, RepaintContext = { }) const override;
</ins><span class="cx"> void repaintRootContents();
</span><span class="cx"> void repaintViewRectangle(const LayoutRect&) const;
</span><span class="cx"> void repaintViewAndCompositedLayers();
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingsvgRenderSVGForeignObjecth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/svg/RenderSVGForeignObject.h (201703 => 201704)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/svg/RenderSVGForeignObject.h 2016-06-06 01:56:11 UTC (rev 201703)
+++ trunk/Source/WebCore/rendering/svg/RenderSVGForeignObject.h 2016-06-06 03:19:21 UTC (rev 201704)
</span><span class="lines">@@ -41,7 +41,7 @@
</span><span class="cx">
</span><span class="cx"> LayoutRect clippedOverflowRectForRepaint(const RenderLayerModelObject* repaintContainer) const override;
</span><span class="cx"> FloatRect computeFloatRectForRepaint(const FloatRect&, const RenderLayerModelObject* repaintContainer, bool fixed = false) const override;
</span><del>- LayoutRect computeRectForRepaint(const LayoutRect&, const RenderLayerModelObject* repaintContainer, RepaintContext = { false, false }) const override;
</del><ins>+ LayoutRect computeRectForRepaint(const LayoutRect&, const RenderLayerModelObject* repaintContainer, RepaintContext = { }) const override;
</ins><span class="cx">
</span><span class="cx"> bool requiresLayer() const override { return false; }
</span><span class="cx"> void layout() override;
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingsvgRenderSVGTexth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/svg/RenderSVGText.h (201703 => 201704)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/svg/RenderSVGText.h 2016-06-06 01:56:11 UTC (rev 201703)
+++ trunk/Source/WebCore/rendering/svg/RenderSVGText.h 2016-06-06 03:19:21 UTC (rev 201704)
</span><span class="lines">@@ -78,7 +78,7 @@
</span><span class="cx"> void absoluteQuads(Vector<FloatQuad>&, bool* wasFixed) const override;
</span><span class="cx">
</span><span class="cx"> LayoutRect clippedOverflowRectForRepaint(const RenderLayerModelObject* repaintContainer) const override;
</span><del>- LayoutRect computeRectForRepaint(const LayoutRect&, const RenderLayerModelObject* repaintContainer, RepaintContext = { false, false }) const override;
</del><ins>+ LayoutRect computeRectForRepaint(const LayoutRect&, const RenderLayerModelObject* repaintContainer, RepaintContext = { }) const override;
</ins><span class="cx"> FloatRect computeFloatRectForRepaint(const FloatRect&, const RenderLayerModelObject* repaintContainer, bool fixed = false) const override;
</span><span class="cx">
</span><span class="cx"> void mapLocalToContainer(const RenderLayerModelObject* repaintContainer, TransformState&, MapCoordinatesFlags, bool* wasFixed) const override;
</span></span></pre>
</div>
</div>
</body>
</html>