<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[201656] trunk/Source/JavaScriptCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/201656">201656</a></dd>
<dt>Author</dt> <dd>benjamin@webkit.org</dd>
<dt>Date</dt> <dd>2016-06-03 14:13:34 -0700 (Fri, 03 Jun 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Fix some more INFINITI->INFINITY typos
Unreviewed.
The tests were not covering the edge cases they were supposed to test.
Patch by Benjamin Poulain <bpoulain@apple.com> on 2016-06-03
* tests/stress/math-ceil-basics.js:
(testMathCeilOnConstants):
* tests/stress/math-clz32-basics.js:
(testMathClz32OnDoubles):
(testMathClz32OnConstants):
* tests/stress/math-floor-basics.js:
(testMathFloorOnConstants):
* tests/stress/math-round-basics.js:
(testMathRoundOnConstants):
* tests/stress/math-trunc-basics.js:
(testMathTruncOnConstants):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceJavaScriptCoreChangeLog">trunk/Source/JavaScriptCore/ChangeLog</a></li>
<li><a href="#trunkSourceJavaScriptCoretestsstressmathceilbasicsjs">trunk/Source/JavaScriptCore/tests/stress/math-ceil-basics.js</a></li>
<li><a href="#trunkSourceJavaScriptCoretestsstressmathclz32basicsjs">trunk/Source/JavaScriptCore/tests/stress/math-clz32-basics.js</a></li>
<li><a href="#trunkSourceJavaScriptCoretestsstressmathfloorbasicsjs">trunk/Source/JavaScriptCore/tests/stress/math-floor-basics.js</a></li>
<li><a href="#trunkSourceJavaScriptCoretestsstressmathroundbasicsjs">trunk/Source/JavaScriptCore/tests/stress/math-round-basics.js</a></li>
<li><a href="#trunkSourceJavaScriptCoretestsstressmathtruncbasicsjs">trunk/Source/JavaScriptCore/tests/stress/math-trunc-basics.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/ChangeLog (201655 => 201656)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/ChangeLog 2016-06-03 20:59:49 UTC (rev 201655)
+++ trunk/Source/JavaScriptCore/ChangeLog 2016-06-03 21:13:34 UTC (rev 201656)
</span><span class="lines">@@ -1,3 +1,23 @@
</span><ins>+2016-06-03 Benjamin Poulain <bpoulain@apple.com>
+
+ Fix some more INFINITI->INFINITY typos
+
+ Unreviewed.
+
+ The tests were not covering the edge cases they were supposed to test.
+
+ * tests/stress/math-ceil-basics.js:
+ (testMathCeilOnConstants):
+ * tests/stress/math-clz32-basics.js:
+ (testMathClz32OnDoubles):
+ (testMathClz32OnConstants):
+ * tests/stress/math-floor-basics.js:
+ (testMathFloorOnConstants):
+ * tests/stress/math-round-basics.js:
+ (testMathRoundOnConstants):
+ * tests/stress/math-trunc-basics.js:
+ (testMathTruncOnConstants):
+
</ins><span class="cx"> 2016-06-02 Gavin & Ellie Barraclough <barraclough@apple.com>
</span><span class="cx">
</span><span class="cx"> JSGlobalObject::addFunction should call deleteProperty rather than removeDirect
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoretestsstressmathceilbasicsjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/tests/stress/math-ceil-basics.js (201655 => 201656)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/tests/stress/math-ceil-basics.js 2016-06-03 20:59:49 UTC (rev 201655)
+++ trunk/Source/JavaScriptCore/tests/stress/math-ceil-basics.js 2016-06-03 21:13:34 UTC (rev 201656)
</span><span class="lines">@@ -220,12 +220,12 @@
</span><span class="cx"> var value = Math.ceil(NaN);
</span><span class="cx"> if (value === value)
</span><span class="cx"> throw new Error("Math.ceil(NaN) = " + value);
</span><del>- var value = Math.ceil(Number.POSITIVE_INFINITI);
- if (value === value)
- throw new Error("Math.ceil(Number.POSITIVE_INFINITI) = " + value);
- var value = Math.ceil(Number.NEGATIVE_INFINITI);
- if (value === value)
- throw new Error("Math.ceil(Number.NEGATIVE_INFINITI) = " + value);
</del><ins>+ var value = Math.ceil(Number.POSITIVE_INFINITY);
+ if (value !== Infinity)
+ throw new Error("Math.ceil(Number.POSITIVE_INFINITY) = " + value);
+ var value = Math.ceil(Number.NEGATIVE_INFINITY);
+ if (value !== -Infinity)
+ throw new Error("Math.ceil(Number.NEGATIVE_INFINITY) = " + value);
</ins><span class="cx"> var value = Math.ceil(Math.E);
</span><span class="cx"> if (value !== 3)
</span><span class="cx"> throw new Error("Math.ceil(Math.E) = " + value);
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoretestsstressmathclz32basicsjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/tests/stress/math-clz32-basics.js (201655 => 201656)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/tests/stress/math-clz32-basics.js 2016-06-03 20:59:49 UTC (rev 201655)
+++ trunk/Source/JavaScriptCore/tests/stress/math-clz32-basics.js 2016-06-03 21:13:34 UTC (rev 201656)
</span><span class="lines">@@ -95,13 +95,13 @@
</span><span class="cx"> if (value != 32)
</span><span class="cx"> throw "mathClz32OnDouble(NaN) = " + value;
</span><span class="cx">
</span><del>- var value = mathClz32OnDouble(Number.POSITIVE_INFINITI);
</del><ins>+ var value = mathClz32OnDouble(Number.POSITIVE_INFINITY);
</ins><span class="cx"> if (value != 32)
</span><del>- throw "mathClz32OnDouble(Number.POSITIVE_INFINITI) = " + value;
</del><ins>+ throw "mathClz32OnDouble(Number.POSITIVE_INFINITY) = " + value;
</ins><span class="cx">
</span><del>- var value = mathClz32OnDouble(Number.NEGATIVE_INFINITI);
</del><ins>+ var value = mathClz32OnDouble(Number.NEGATIVE_INFINITY);
</ins><span class="cx"> if (value != 32)
</span><del>- throw "mathClz32OnDouble(Number.NEGATIVE_INFINITI) = " + value;
</del><ins>+ throw "mathClz32OnDouble(Number.NEGATIVE_INFINITY) = " + value;
</ins><span class="cx"> }
</span><span class="cx"> noInline(testMathClz32OnDoubles);
</span><span class="cx">
</span><span class="lines">@@ -185,12 +185,12 @@
</span><span class="cx"> var value = Math.clz32(NaN);
</span><span class="cx"> if (value !== 32)
</span><span class="cx"> throw "Math.clz32(NaN) = " + value;
</span><del>- var value = Math.clz32(Number.POSITIVE_INFINITI);
</del><ins>+ var value = Math.clz32(Number.POSITIVE_INFINITY);
</ins><span class="cx"> if (value !== 32)
</span><del>- throw "Math.clz32(Number.POSITIVE_INFINITI) = " + value;
- var value = Math.clz32(Number.NEGATIVE_INFINITI);
</del><ins>+ throw "Math.clz32(Number.POSITIVE_INFINITY) = " + value;
+ var value = Math.clz32(Number.NEGATIVE_INFINITY);
</ins><span class="cx"> if (value !== 32)
</span><del>- throw "Math.clz32(Number.NEGATIVE_INFINITI) = " + value;
</del><ins>+ throw "Math.clz32(Number.NEGATIVE_INFINITY) = " + value;
</ins><span class="cx"> var value = Math.clz32(Math.E);
</span><span class="cx"> if (value !== 30)
</span><span class="cx"> throw "Math.clz32(Math.E) = " + value;
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoretestsstressmathfloorbasicsjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/tests/stress/math-floor-basics.js (201655 => 201656)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/tests/stress/math-floor-basics.js 2016-06-03 20:59:49 UTC (rev 201655)
+++ trunk/Source/JavaScriptCore/tests/stress/math-floor-basics.js 2016-06-03 21:13:34 UTC (rev 201656)
</span><span class="lines">@@ -220,12 +220,12 @@
</span><span class="cx"> var value = Math.floor(NaN);
</span><span class="cx"> if (value === value)
</span><span class="cx"> throw new Error("Math.floor(NaN) = " + value);
</span><del>- var value = Math.floor(Number.POSITIVE_INFINITI);
- if (value === value)
- throw new Error("Math.floor(Number.POSITIVE_INFINITI) = " + value);
- var value = Math.floor(Number.NEGATIVE_INFINITI);
- if (value === value)
- throw new Error("Math.floor(Number.NEGATIVE_INFINITI) = " + value);
</del><ins>+ var value = Math.floor(Number.POSITIVE_INFINITY);
+ if (value !== Infinity)
+ throw new Error("Math.floor(Number.POSITIVE_INFINITY) = " + value);
+ var value = Math.floor(Number.NEGATIVE_INFINITY);
+ if (value !== -Infinity)
+ throw new Error("Math.floor(Number.NEGATIVE_INFINITY) = " + value);
</ins><span class="cx"> var value = Math.floor(Math.E);
</span><span class="cx"> if (value !== 2)
</span><span class="cx"> throw new Error("Math.floor(Math.E) = " + value);
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoretestsstressmathroundbasicsjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/tests/stress/math-round-basics.js (201655 => 201656)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/tests/stress/math-round-basics.js 2016-06-03 20:59:49 UTC (rev 201655)
+++ trunk/Source/JavaScriptCore/tests/stress/math-round-basics.js 2016-06-03 21:13:34 UTC (rev 201656)
</span><span class="lines">@@ -220,12 +220,12 @@
</span><span class="cx"> var value = Math.round(NaN);
</span><span class="cx"> if (value === value)
</span><span class="cx"> throw "Math.round(NaN) = " + value;
</span><del>- var value = Math.round(Number.POSITIVE_INFINITI);
- if (value === value)
- throw "Math.round(Number.POSITIVE_INFINITI) = " + value;
- var value = Math.round(Number.NEGATIVE_INFINITI);
- if (value === value)
- throw "Math.round(Number.NEGATIVE_INFINITI) = " + value;
</del><ins>+ var value = Math.round(Number.POSITIVE_INFINITY);
+ if (value !== Infinity)
+ throw "Math.round(Number.POSITIVE_INFINITY) = " + value;
+ var value = Math.round(Number.NEGATIVE_INFINITY);
+ if (value !== -Infinity)
+ throw "Math.round(Number.NEGATIVE_INFINITY) = " + value;
</ins><span class="cx"> var value = Math.round(Math.E);
</span><span class="cx"> if (value !== 3)
</span><span class="cx"> throw "Math.round(Math.E) = " + value;
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoretestsstressmathtruncbasicsjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/tests/stress/math-trunc-basics.js (201655 => 201656)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/tests/stress/math-trunc-basics.js 2016-06-03 20:59:49 UTC (rev 201655)
+++ trunk/Source/JavaScriptCore/tests/stress/math-trunc-basics.js 2016-06-03 21:13:34 UTC (rev 201656)
</span><span class="lines">@@ -219,12 +219,12 @@
</span><span class="cx"> var value = Math.trunc(NaN);
</span><span class="cx"> if (value === value)
</span><span class="cx"> throw new Error("Math.trunc(NaN) = " + value);
</span><del>- var value = Math.trunc(Number.POSITIVE_INFINITI);
- if (value === value)
- throw new Error("Math.trunc(Number.POSITIVE_INFINITI) = " + value);
- var value = Math.trunc(Number.NEGATIVE_INFINITI);
- if (value === value)
- throw new Error("Math.trunc(Number.NEGATIVE_INFINITI) = " + value);
</del><ins>+ var value = Math.trunc(Number.POSITIVE_INFINITY);
+ if (value !== Infinity)
+ throw new Error("Math.trunc(Number.POSITIVE_INFINITY) = " + value);
+ var value = Math.trunc(Number.NEGATIVE_INFINITY);
+ if (value !== -Infinity)
+ throw new Error("Math.trunc(Number.NEGATIVE_INFINITY) = " + value);
</ins><span class="cx"> var value = Math.trunc(Math.E);
</span><span class="cx"> if (value !== 2)
</span><span class="cx"> throw new Error("Math.trunc(Math.E) = " + value);
</span></span></pre>
</div>
</div>
</body>
</html>